summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT_test.py
Commit message (Collapse)AuthorAgeFilesLines
* Do per-file OWNERS check for per-file DEPS changes.joi@chromium.org2014-01-081-7/+8
| | | | | | | | | | Before this, an OWNER of the entire directory that a new DEPS rule was pointing to would be required, even when the DEPS rule specified an individual file for which there are per-file OWNERS in the OWNERS file. BUG=290401 Review URL: https://codereview.chromium.org/116443011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243459 0039d316-1c4b-4281-b951-d872f2087c98
* Include order check should work better for files containing uncheckable includesb.kelemen@samsung.com2014-01-071-8/+8
| | | | | | | | | | Currently as soon as we see an uncheckable include (like ipc/*macros.h or windows.h) we stop checking the file. Instead we should just skip that line and continue checking. Review URL: https://codereview.chromium.org/105633012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243427 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 'using base::string16;' from base/strings/string16.h and remove temporarydbeam@chromium.org2013-12-301-40/+0
| | | | | | | | | | | | PRESUBMIT.py _CheckForString16(). R=brettw@chromium.org, maruel@chromium.org TBR=sky@chromium.org, tsepez@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/93903011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242733 0039d316-1c4b-4281-b951-d872f2087c98
* Adds PRESUBMIT.py check to look for unprefixed string16.dbeam@chromium.org2013-12-181-0/+40
| | | | | | | | | | | R=maruel@chromium.org BUG=329295 TEST=PRESUBMIT_test.py NOTRY=true Review URL: https://codereview.chromium.org/98143005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241485 0039d316-1c4b-4281-b951-d872f2087c98
* Implement presubmit support for _unittest_win includes, etc.erikwright@chromium.org2013-10-091-0/+10
| | | | | | | | | | Without this change, xxx_unittest_win.cc would cause an erroneous presubmit error by including xxx_win.h as its first 'special' include. BUG=None Review URL: https://codereview.chromium.org/26486003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227823 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude more files from the PRESUBMIT #include check.marja@chromium.org2013-09-201-1/+15
| | | | | | | | | | | These files need to be included out-of-order. BUG=NONE NOTRY=true Review URL: https://chromiumcodereview.appspot.com/24177004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224367 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore +grit entries in DEPS files.tony@chromium.org2013-07-261-0/+37
| | | | | | | | | | | | Sometimes the trailing slash doesn't exist on the DEPS on grit, but we were expecting it. BUG=None R=maruel@chromium.org Review URL: https://codereview.chromium.org/20770002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213989 0039d316-1c4b-4281-b951-d872f2087c98
* Update PRESUBMIT scripts to use PresubmitPromptOrNotify helper.wez@chromium.org2013-04-021-13/+6
| | | | | | | | NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13093006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191863 0039d316-1c4b-4281-b951-d872f2087c98
* Adding _Check* function for invalid OS_MACROs in src/PRESUBMIT.pydbeam@chromium.org2013-03-261-1/+21
| | | | | | | | | | | | R=maruel@chromium.org BUG=none CONTEXT=http://goo.gl/hrlj1 TEST=PRESUBMIT_test.py and less OS_MAXOSX! NOTRY=true Review URL: https://chromiumcodereview.appspot.com/12845013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190693 0039d316-1c4b-4281-b951-d872f2087c98
* Don't issue try jobs for OWNERS-only changes.dbeam@chromium.org2013-01-101-0/+16
| | | | | | | | | | | BUG=None R=maruel@chromium.org TEST=PRESUBMIT_test.py, less needless try jobs. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11830057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176192 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT #include check: exclude known cases which need a non-standard order.marja@chromium.org2012-12-181-0/+34
| | | | | | | | | | BUG=NONE NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11607019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173773 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT #include check: don't add a warning if we're committing.marja@chromium.org2012-12-101-0/+17
| | | | | | | | | | | | | This enables the commit queue to commit patches where the #include order is "wrong" according to the check. NOTRY=true BUG= Review URL: https://chromiumcodereview.appspot.com/11496010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172084 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT #include check enhancements.marja@chromium.org2012-12-061-9/+38
| | | | | | | | | | | | | | | | | 1) Handle #define and #undef the same way as #if etc. See e.g., https://codereview.chromium.org/11363222/diff/10015/chrome/browser/history/history_unittest.cc line 545. 2) Also headers can have the special first include, not only sources. See e.g., net/disk_cache/storage_block-inl.h. NOTRY=true BUG=NONE Review URL: https://chromiumcodereview.appspot.com/11441035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171511 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check to prevent committing .rej/.orig patch filesenne@chromium.org2012-12-051-0/+59
| | | | | | | | | | | | | This is a follow-up to me having to remove some of these by hand in r171143. R=maruel@chromium.org NOTRY=true BUG=none Review URL: https://chromiumcodereview.appspot.com/11448014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171287 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT #include check enhancement: <sys/..> includes can be in any order.marja@chromium.org2012-11-221-0/+10
| | | | | | | | | | | E.g., need to be in this order, since the latter uses definitions from the former. BUG=NONE Review URL: https://codereview.chromium.org/11418128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169290 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a presubmit that looks for version control conflicts.dbeam@chromium.org2012-11-201-0/+19
| | | | | | | | | | R=maruel@chromium.org,thakis@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/11417044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168715 0039d316-1c4b-4281-b951-d872f2087c98
* Fix include order PRESUBMIT check: #if-#elif-#elsemarja@chromium.org2012-11-161-0/+16
| | | | | | | | BUG=161390 Review URL: https://codereview.chromium.org/11413036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168191 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the PRESUBMIT include check some more.marja@chromium.org2012-11-151-0/+160
The previous version didn't take into account that source files can have a platform specific suffix. BUG=NONE TBR=ben@chromium.org Review URL: https://codereview.chromium.org/11413012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167996 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 00:57:46 +0000