summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT_test.py
Commit message (Collapse)AuthorAgeFilesLines
* Include isolate.py in data for Android unit testsagrieve2016-03-241-4/+96
| | | | | | | | | | | This is required for any test that uses an .isolate to push files to the device (e.g. base_unittests). BUG=589318 Review URL: https://codereview.chromium.org/1784373002 Cr-Commit-Position: refs/heads/master@{#383127}
* Add presubmit warning about deprecated compiled_resources.gypdbeam2016-02-101-0/+14
| | | | | | | | | | | Just use v2 instead ;) (compiled_resources2.gyp) R=maruel@chromium.org,cpu@chromium.org BUG=585553 Review URL: https://codereview.chromium.org/1686663002 Cr-Commit-Position: refs/heads/master@{#374762}
* Rename MOVE_ONLY_TYPE_WITH_MOVE_CONSTRUCTOR_FOR_CPP_03danakj2015-12-081-39/+0
| | | | | | | | | | | | | | | | This renames the macro to be more standard and express its intent and relationship to DISALLOW_COPY_AND_ASSIGN. It renames the macro to DISALLOW_COPY_AND_ASSIGN_WITH_MOVE_FOR_BIND, as it does what the old DISALLOW_COPY_AND_ASSIGN does, but also whitelists the type for Bind/Callback to try move it. R=Nico TBR=sky BUG=561749 Review URL: https://codereview.chromium.org/1501793003 Cr-Commit-Position: refs/heads/master@{#363712}
* Add additional hosts to hard-coded service URL presubmit checkreillyi2015-11-161-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | | This adds additional domains to the root PRESUBMIT check, "_CheckHardcodedGoogleHostsInLowerLayers", based on hostnames currently used in Chromium. Previously, this check only validated that "google.com" was not hard-coded, but did not catch other common hostnames: - gstatic.com - googleapis.com - googlezip.net - googledrive.com - appspot.com Note that this check is non-blocking, only prompting the user with a warning before continuing the submit operation. BUG=164568 TEST=PRESUBMIT_test.py Review URL: https://codereview.chromium.org/1403673003 Cr-Commit-Position: refs/heads/master@{#359869}
* Changed the CheckBaseMacrosInHeaders presubmit to pass over C++ commentsoysteine2015-10-221-3/+8
| | | | | | | | | R=dbeam@chromium.org,maruel@chromium.org BUG=545272 Review URL: https://codereview.chromium.org/1413263002 Cr-Commit-Position: refs/heads/master@{#355639}
* PRESUBMIT: Bark about DISALLOW_* macros without #include "base/macros.h"dbeam2015-10-161-0/+37
| | | | | | | | | | | | | I'm sick of enforcing this in like every code review. R=cpu@chromium.org,maruel@chromium.org TBR=phajdan.jr@chromium.org BUG=none TEST=PRESUBMIT_test.py Review URL: https://codereview.chromium.org/1411553003 Cr-Commit-Position: refs/heads/master@{#354607}
* [android] Change the recommended log tag format to "cr_foo"dgn2015-09-181-16/+37
| | | | | | | | | | | | | | | | | This is to ensure that log tags are not elided when retrieving logcat output from crash reports. The log function has been modified to make the transition easier and avoid specifying the prefix everywhere. This patch also moves some eliding testing from instrumentation tests to junit tests, and adds a test to ensure that the new tag format is not elided. BUG=533072 Review URL: https://codereview.chromium.org/1354723004 Cr-Commit-Position: refs/heads/master@{#349733}
* Turn components/crash into a layered component.sdefresne2015-09-181-1/+1
| | | | | | | | | | | | | | | The crash component cannot be used on iOS (as it depends on //content). Turn it into a layered component so that it is possible to put shared code related to crash there (components/crash_keys and objc_zombie.{h,mm}). BUG=522955 TBR=sky@chromium.org TBR=jschuh@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1315303004 Cr-Commit-Position: refs/heads/master@{#349643}
* Revert of Turn components/crash into a layered component. (patchset #6 ↵sdefresne2015-09-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:100001 of https://codereview.chromium.org/1315303004/ ) Reason for revert: This breaks Webkit layout tests. Original issue's description: > Turn components/crash into a layered component. > > The crash component cannot be used on iOS (as it depends on //content). > Turn it into a layered component so that it is possible to put shared > code related to crash there (components/crash_keys and objc_zombie.{h,mm}). > > BUG=522955 > TBR=sky@chromium.org > TBR=jschuh@chromium.org > NOPRESUBMIT=true > > Committed: https://crrev.com/4e483c64be5136b785e92c5baa971baca7eea2bc > Cr-Commit-Position: refs/heads/master@{#349384} TBR=blundell@chromium.org,jam@chromium.org,jschuh@chromium.org,mark@chromium.org,rsesek@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=522955 Review URL: https://codereview.chromium.org/1351923002 Cr-Commit-Position: refs/heads/master@{#349417}
* Turn components/crash into a layered component.sdefresne2015-09-171-1/+1
| | | | | | | | | | | | | | | The crash component cannot be used on iOS (as it depends on //content). Turn it into a layered component so that it is possible to put shared code related to crash there (components/crash_keys and objc_zombie.{h,mm}). BUG=522955 TBR=sky@chromium.org TBR=jschuh@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1315303004 Cr-Commit-Position: refs/heads/master@{#349384}
* Move Singleton and related structs to namespace baseolli.raula2015-09-101-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Public APIs from base should live inside base:: so moved Singleton class and structs to base{} and fixed consumers. also fixed: ** Presubmit ERRORS ** Found Singleton<T> in the following header files. Please move them to an appropriate source file so that the template gets instantiated in a single compilation unit. chrome/browser/plugins/plugin_finder.h \ chromecast/media/base/media_message_loop.h \ content/browser/media/android/media_drm_credential_manager.h Presubmit warnings: src/chrome/browser/extensions/warning_badge_service_factory.h:5: #ifndef header guard has wrong style, please use: CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_ [build/header_guard] [5] src/chrome/browser/extensions/warning_badge_service_factory.h:39: #endif line should be "#endif // CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_" [build/header_guard] [5] TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1308823002 Cr-Commit-Position: refs/heads/master@{#348136}
* [Android log] Fix presubmit check reports in base packagedgn2015-06-121-27/+20
| | | | | | | | | | | | | The presubmit check stop warning about Log calls from classes in the org.chromium.base package. Also does some refactoring to simplify logging related checks BUG=498171 Review URL: https://codereview.chromium.org/1183493002 Cr-Commit-Position: refs/heads/master@{#334135}
* [Android log] Promote using hardcoded string tagsdgn2015-06-101-0/+71
| | | | | | | | | | | | | | | This is to avoid static initializers that would make the code slower. See the linked bug for discussion. This patch deprecates Log#makeTag(String) and adds presubmit checks to enforce at submit time what makeTag was trying to do: length and naming rules BUG=485772 Review URL: https://codereview.chromium.org/1131903007 Cr-Commit-Position: refs/heads/master@{#333710}
* Exclude .md files from version control conflict detection.dbeam2015-06-021-0/+10
| | | | | | | | | | | | Turns out top-level headers basically look exactly like a merge conflict marker. R=jlklein@chromium.org BUG=495338 Review URL: https://codereview.chromium.org/1153013005 Cr-Commit-Position: refs/heads/master@{#332313}
* [android log] Add documentation and presubmit checks for log usage.dgn2015-04-291-0/+41
| | | | | | | | | | | | The new check warns for new log usages that don't use base.Log The documentation is added in-tree as a markdown file BUG=472152 Review URL: https://codereview.chromium.org/1114593002 Cr-Commit-Position: refs/heads/master@{#327504}
* Add PRESUBMIT tests for _CheckUserActionUpdate function.davileen2015-03-021-0/+34
| | | | | | | | | | | | | Presubmit does not contain any tests for the _CheckUserActionUpdate function. This commit adds a test to check against an action in actions.xml and one that is not found there. To do this we have to improve the MockInputApi and MockFile classes. BUG=462814 Review URL: https://codereview.chromium.org/966703003 Cr-Commit-Position: refs/heads/master@{#318759}
* Make `git cl try` to the same as hitting cq (except for presubmit).thakis2015-02-231-8/+0
| | | | | | | | | | | | | | | | | | | PRESUBMIT.py used to contain a handwritten list of bots to trigger on `git cl try`. It was always out of sync with what the cq did. https://codereview.chromium.org/823823002 awesomely made `git cl try` do the same thing as the commit queue, but it kept a few special-case rules around. It's better to not have these special cases: Once the developer hits cq, all the "intelligently" skipped bots need to be run anyways. More importantly, there should be only one system to decide what to run and it should be identical for cq and `git cl try`. Currently, we think this system is the `analyze` step, and it does a decent job of that already. BUG=none (but made possible by 443613) Review URL: https://codereview.chromium.org/921323003 Cr-Commit-Position: refs/heads/master@{#317597}
* Removed references to win_gpu, which has been removedsergiyb2015-02-181-4/+0
| | | | | | | | | BUG=426897 R=kbr@chromium.org,phajdan.jr@chromium.org,zmo@chromium.org,darin@chromium.org,brettw@chromium.org,cpu@chromium.org Review URL: https://codereview.chromium.org/794303004 Cr-Commit-Position: refs/heads/master@{#316870}
* Reland https://codereview.chromium.org/929043002/: Add a presubmit check ↵glider2015-02-181-1/+28
| | | | | | | | | | | | | | | | that warns about declaring Singleton<T> in header files Add a presubmit check that warns about declaring Singleton<T> in header files (except for base/memory/singleton.h) This check is copied from presubmit_canned_checks.py in depot_tools/ with an added exception for base/memory/singleton.h. The corresponding code will be removed from presubmit_canned_checks.py afterwards. BUG=349861 Review URL: https://codereview.chromium.org/933253002 Cr-Commit-Position: refs/heads/master@{#316852}
* Revert of Add a presubmit check that warns about declaring Singleton<T> in ↵glider2015-02-171-27/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | header files (patchset #2 id:20001 of https://codereview.chromium.org/929043002/) Reason for revert: Reverting because of presubmit crashes: Traceback (most recent call last): File "/usr/local/google/ssd/depot_tools/git_cl.py", line 2983, in <module> sys.exit(main(sys.argv[1:])) File "/usr/local/google/ssd/depot_tools/git_cl.py", line 2969, in main return dispatcher.execute(OptionParser(), argv) File "/usr/local/google/ssd/depot_tools/subcommand.py", line 245, in execute return command(parser, args[1:]) File "/usr/local/google/ssd/depot_tools/git_cl.py", line 1614, in CMDpresubmit change=cl.GetChange(base_branch, None)) File "/usr/local/google/ssd/depot_tools/git_cl.py", line 936, in RunHook rietveld_obj=self.RpcServer()) File "/usr/local/google/ssd/depot_tools/presubmit_support.py", line 1396, in DoPresubmitChecks results += executer.ExecPresubmitScript(presubmit_script, filename) File "/usr/local/google/ssd/depot_tools/presubmit_support.py", line 1313, in ExecPresubmitScript result = eval(function_name + '(*__args)', context) File "<string>", line 1, in <module> File "<string>", line 1727, in CheckChangeOnCommit File "<string>", line 1455, in _CommonChecks File "<string>", line 1322, in _CheckSingletonInHeaders File "/usr/local/google/ssd/depot_tools/presubmit_support.py", line 472, in ReadFile raise IOError('Access outside the repository root is denied.') IOError: Access outside the repository root is denied. Original issue's description: > Add a presubmit check that warns about declaring Singleton<T> in header files > (except for base/memory/singleton.h) > This check is copied from presubmit_canned_checks.py in depot_tools/ with an > added exception for base/memory/singleton.h. > The corresponding code will be removed from presubmit_canned_checks.py afterwards. > > BUG=349861 > R=phajdan.jr@chromium.org, > > Committed: https://crrev.com/9b73d0393037452d13358f4e2766cb62adbdede8 > Cr-Commit-Position: refs/heads/master@{#316546} TBR=phajdan.jr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=349861 Review URL: https://codereview.chromium.org/934723003 Cr-Commit-Position: refs/heads/master@{#316559}
* Add a presubmit check that warns about declaring Singleton<T> in header filesglider2015-02-171-0/+27
| | | | | | | | | | | | | | (except for base/memory/singleton.h) This check is copied from presubmit_canned_checks.py in depot_tools/ with an added exception for base/memory/singleton.h. The corresponding code will be removed from presubmit_canned_checks.py afterwards. BUG=349861 R=phajdan.jr@chromium.org, Review URL: https://codereview.chromium.org/929043002 Cr-Commit-Position: refs/heads/master@{#316546}
* Add PRESUBMIT check if modified UMA histogram name can be found (2)mcasas2015-02-041-0/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL is an iteration of http://crrev.com/766713004, that got reverted after http://crbug.com/445265 because it could not cope correctly with structures of the type: <histogram_suffixes name="SafeBrowsingStores.SBWhiteLists" separator="."> <suffix name="CSD" label="CSD"/> <suffix name="DownloadWhitelist" label="DownloadWhitelist"/> <affected-histogram name="SB2.DatabaseKilobytes"/> </histogram_suffixes> (in particular: affected-histogram-suffixes). Limitation that should be solved now. Original description --------------------------------------------------- Add PRESUBMIT check if modified UMA histogram name can be found This Presubmit checks if some diffs affect any UMA_HISTOGRAM_* macro and, if so, checks if the histogram name is to be found in either tools/metrics/histograms/histograms.xml or in the CL diffs. Addresses the problem of someone modifying code and inadvertently forgetting a corresponding histograms.xml adaptation, that has happened in the past. BUG=434420, 445265 Review URL: https://codereview.chromium.org/885783007 Cr-Commit-Position: refs/heads/master@{#314557}
* Removed references to linux_gpu, which has been removedsergiyb2015-01-301-2/+0
| | | | | | | | | BUG=426897 R=kbr@chromium.org,phajdan.jr@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/800013002 Cr-Commit-Position: refs/heads/master@{#313978}
* Revert of Add PRESUBMIT check if modified UMA histogram name can be found ↵asvitkine2015-01-091-22/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:40001 of https://codereview.chromium.org/766713004/) Reason for revert: Produces false positive warnings on histograms using histogram_suffixes, see: https://code.google.com/p/chromium/issues/detail?id=445265 Original issue's description: > Add PRESUBMIT check if modified UMA histogram name can be found > > This Presubmit checks if some diffs affect any UMA_HISTOGRAM_* > macro and, if so, checks if the histogram name is to be found > in either tools/metrics/histograms/histograms.xml or in the > CL diffs. > > Addresses the problem of someone modifying code and > inadvertently forgetting a corresponding histograms.xml > adaptation, that has happened in the past. > > BUG=434420 > > Committed: https://crrev.com/2ece5270462346b1ac3bccd3bfe5e68d024b98b5 > Cr-Commit-Position: refs/heads/master@{#306388} TBR=phajdan.jr@chromium.org,mcasas@chromium.org NOTREECHECKS=true NOTRY=true BUG=434420, 445265 Review URL: https://codereview.chromium.org/841323002 Cr-Commit-Position: refs/heads/master@{#310863}
* Removed references to mac_gpu, which has been removedsergiyb2014-12-181-2/+0
| | | | | | | | | BUG=426897 R=kbr@chromium.org,phajdan.jr@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/805483002 Cr-Commit-Position: refs/heads/master@{#308995}
* Presubmit checks for user actions introduced in HTML files.gayane2014-12-041-78/+2
| | | | | | | | | | This presubmit task will catch the case when HTML files are modified with new user action and action.xml is not updated BUG=431393 Review URL: https://codereview.chromium.org/719463003 Cr-Commit-Position: refs/heads/master@{#306842}
* Add PRESUBMIT check if modified UMA histogram name can be foundmcasas2014-12-021-0/+22
| | | | | | | | | | | | | | | | | This Presubmit checks if some diffs affect any UMA_HISTOGRAM_* macro and, if so, checks if the histogram name is to be found in either tools/metrics/histograms/histograms.xml or in the CL diffs. Addresses the problem of someone modifying code and inadvertently forgetting a corresponding histograms.xml adaptation, that has happened in the past. BUG=434420 Review URL: https://codereview.chromium.org/766713004 Cr-Commit-Position: refs/heads/master@{#306388}
* Clean up PRESUBMIT.py - remove references to removed clang trybotsPaweł Hajdan, Jr2014-11-051-4/+0
| | | | | | | | | BUG=none R=maruel@chromium.org Review URL: https://codereview.chromium.org/683733009 Cr-Commit-Position: refs/heads/master@{#302800}
* Convert manually triggered try runs to use bots without _swarming prefix.John Abd-El-Malek2014-10-221-4/+0
| | | | | | | | | BUG=425813 R=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/664413006 Cr-Commit-Position: refs/heads/master@{#300691}
* remove obsolete OVERRIDE/FINAL presubmit checksmostynb2014-10-221-60/+0
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/655693003 Cr-Commit-Position: refs/heads/master@{#300675}
* Remove references to linux_asan from PRESUBMIT files.Paweł Hajdan, Jr2014-10-211-2/+0
| | | | | | | | | BUG=404694 R=earthdok@chromium.org Review URL: https://codereview.chromium.org/637953005 Cr-Commit-Position: refs/heads/master@{#300468}
* Adding Presubmit error when OVERRIDE and FINAL is not used as C++11 standardmohan.reddy2014-10-161-0/+60
| | | | | | | | | | | Alerting the error for use to use c++11 constructs |override| and |final| instead of OVERRIDE and FINAL respctively BUG=417463 Review URL: https://codereview.chromium.org/653883002 Cr-Commit-Position: refs/heads/master@{#299880}
* Add PRESUBMIT check for #ifdefs on values that are always defined.lliabraa2014-10-011-0/+22
| | | | | | | | | | | Several values are always defined and the developer actually wants to do an #if check, not #ifdef. BUG=417804 Review URL: https://codereview.chromium.org/595213004 Cr-Commit-Position: refs/heads/master@{#297627}
* Update some paths from components/breakpad/ to components/crash/philipj2014-08-281-1/+1
| | | | | | | | | | | | | | It was moved in https://crrev.com/55b8563 Found by git grep 'components.*breakpad' BUG=406410 R=rsesek@chromium.org TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/511223002 Cr-Commit-Position: refs/heads/master@{#292376}
* Rename components/breakpad to components/crash.Robert Sesek2014-08-271-1/+1
| | | | | | | | | | | | | | In the near future, Crashpad (the new Mac crash reporter) will be integrated, and it should be integrated/exposed transparently to the users of this component. BUG=406410 R=blundell@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/485893007 Cr-Commit-Position: refs/heads/master@{#292162}
* Do not run header include order checks on blacklisted filesdominik.rottsches@intel.com2014-08-151-1/+1
| | | | | | | | | | | | | | The header include order checks were running on all affected files, including third_party for example, this causes issues when rolling harfbuzz-ng. BUG=404105 NOTRY=true Review URL: https://codereview.chromium.org/462323003 Cr-Commit-Position: refs/heads/master@{#289968} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289968 0039d316-1c4b-4281-b951-d872f2087c98
* Update masters after the tryserver split.sergeyberezin@chromium.org2014-07-261-0/+113
| | | | | | | | | | | Also replace deprecated linux_chromium_rel with linux_chromium_rel_swarming, while I'm at it. R=agable@chromium.org, maruel@chromium.org BUG=395196 Review URL: https://codereview.chromium.org/415323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285752 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Add PRESUBMIT.py warning for contradictory NOTREACHED() use. ↵miguelg@chromium.org2014-06-251-46/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/344563003/) Reason for revert: It seems to be checking code that is not part of the diff. I also think there are some legitimate cases for not reached in the middle of a block but that is something that can be discussed on the bug. Filed https://code.google.com/p/chromium/issues/detail?id=388731 to track. Original issue's description: > Add PRESUBMIT.py warning for contradictory NOTREACHED() use. > > As recently discussed on chromium-dev [1] and subsequently incorporated into the > Chromium Coding Style [2], NOTREACHED() followed by code is an anti-pattern. > This CL lets PRESUBMIT.py detect most of these cases and print a warning to the > developer. > [1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/c2X0D1Z6X2o/ddkFLqQP0P0J > [2] http://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED- > > BUG=none > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279681 TBR=maruel@chromium.org,tnagel@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/357693004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279710 0039d316-1c4b-4281-b951-d872f2087c98
* Add PRESUBMIT.py warning for contradictory NOTREACHED() use.tnagel@chromium.org2014-06-251-0/+46
| | | | | | | | | | | | | | | As recently discussed on chromium-dev [1] and subsequently incorporated into the Chromium Coding Style [2], NOTREACHED() followed by code is an anti-pattern. This CL lets PRESUBMIT.py detect most of these cases and print a warning to the developer. [1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/c2X0D1Z6X2o/ddkFLqQP0P0J [2] http://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED- BUG=none Review URL: https://codereview.chromium.org/344563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279681 0039d316-1c4b-4281-b951-d872f2087c98
* Make JSON validity presubmit test less stringent.yoz@chromium.org2014-06-171-5/+6
| | | | | | | | | On Mac, Python 2.7 gives different results (line 1 column 3 char 2) than Python 2.6 (line 1 column 2 char 2). Review URL: https://codereview.chromium.org/335263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277728 0039d316-1c4b-4281-b951-d872f2087c98
* Add global presubmit that JSON and IDL files can be parsed.yoz@chromium.org2014-06-031-0/+216
| | | | | | | | | | | | | Sometimes, changes to JSON/IDL files make them invalid. It's easier to check these at presubmit time than discovering they can't be parsed at runtime. This just moves the check from chrome/common/extensions/api to top-level. This presubmit check excludes files in test/data directories. BUG=366395 Review URL: https://codereview.chromium.org/239283008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274432 0039d316-1c4b-4281-b951-d872f2087c98
* Change top-level PRESUBMIT to support split tryserverphajdan.jr@chromium.org2014-03-121-2/+2
| | | | | | | | | | | | | This also fixes problems with generic trybots not being triggered when other presubmit files which already support multiple masters get in scope. BUG=334892 R=maruel@chromium.org Review URL: https://codereview.chromium.org/197963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256698 0039d316-1c4b-4281-b951-d872f2087c98
* Do per-file OWNERS check for per-file DEPS changes.joi@chromium.org2014-01-081-7/+8
| | | | | | | | | | Before this, an OWNER of the entire directory that a new DEPS rule was pointing to would be required, even when the DEPS rule specified an individual file for which there are per-file OWNERS in the OWNERS file. BUG=290401 Review URL: https://codereview.chromium.org/116443011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243459 0039d316-1c4b-4281-b951-d872f2087c98
* Include order check should work better for files containing uncheckable includesb.kelemen@samsung.com2014-01-071-8/+8
| | | | | | | | | | Currently as soon as we see an uncheckable include (like ipc/*macros.h or windows.h) we stop checking the file. Instead we should just skip that line and continue checking. Review URL: https://codereview.chromium.org/105633012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243427 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 'using base::string16;' from base/strings/string16.h and remove temporarydbeam@chromium.org2013-12-301-40/+0
| | | | | | | | | | | | PRESUBMIT.py _CheckForString16(). R=brettw@chromium.org, maruel@chromium.org TBR=sky@chromium.org, tsepez@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/93903011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242733 0039d316-1c4b-4281-b951-d872f2087c98
* Adds PRESUBMIT.py check to look for unprefixed string16.dbeam@chromium.org2013-12-181-0/+40
| | | | | | | | | | | R=maruel@chromium.org BUG=329295 TEST=PRESUBMIT_test.py NOTRY=true Review URL: https://codereview.chromium.org/98143005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241485 0039d316-1c4b-4281-b951-d872f2087c98
* Implement presubmit support for _unittest_win includes, etc.erikwright@chromium.org2013-10-091-0/+10
| | | | | | | | | | Without this change, xxx_unittest_win.cc would cause an erroneous presubmit error by including xxx_win.h as its first 'special' include. BUG=None Review URL: https://codereview.chromium.org/26486003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227823 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude more files from the PRESUBMIT #include check.marja@chromium.org2013-09-201-1/+15
| | | | | | | | | | | These files need to be included out-of-order. BUG=NONE NOTRY=true Review URL: https://chromiumcodereview.appspot.com/24177004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224367 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore +grit entries in DEPS files.tony@chromium.org2013-07-261-0/+37
| | | | | | | | | | | | Sometimes the trailing slash doesn't exist on the DEPS on grit, but we were expecting it. BUG=None R=maruel@chromium.org Review URL: https://codereview.chromium.org/20770002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213989 0039d316-1c4b-4281-b951-d872f2087c98
* Update PRESUBMIT scripts to use PresubmitPromptOrNotify helper.wez@chromium.org2013-04-021-13/+6
| | | | | | | | NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13093006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191863 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-05-04 00:25:28 +0000