summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT_test.py
Commit message (Collapse)AuthorAgeFilesLines
...
* Adding _Check* function for invalid OS_MACROs in src/PRESUBMIT.pydbeam@chromium.org2013-03-261-1/+21
| | | | | | | | | | | | R=maruel@chromium.org BUG=none CONTEXT=http://goo.gl/hrlj1 TEST=PRESUBMIT_test.py and less OS_MAXOSX! NOTRY=true Review URL: https://chromiumcodereview.appspot.com/12845013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190693 0039d316-1c4b-4281-b951-d872f2087c98
* Don't issue try jobs for OWNERS-only changes.dbeam@chromium.org2013-01-101-0/+16
| | | | | | | | | | | BUG=None R=maruel@chromium.org TEST=PRESUBMIT_test.py, less needless try jobs. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11830057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176192 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT #include check: exclude known cases which need a non-standard order.marja@chromium.org2012-12-181-0/+34
| | | | | | | | | | BUG=NONE NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11607019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173773 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT #include check: don't add a warning if we're committing.marja@chromium.org2012-12-101-0/+17
| | | | | | | | | | | | | This enables the commit queue to commit patches where the #include order is "wrong" according to the check. NOTRY=true BUG= Review URL: https://chromiumcodereview.appspot.com/11496010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172084 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT #include check enhancements.marja@chromium.org2012-12-061-9/+38
| | | | | | | | | | | | | | | | | 1) Handle #define and #undef the same way as #if etc. See e.g., https://codereview.chromium.org/11363222/diff/10015/chrome/browser/history/history_unittest.cc line 545. 2) Also headers can have the special first include, not only sources. See e.g., net/disk_cache/storage_block-inl.h. NOTRY=true BUG=NONE Review URL: https://chromiumcodereview.appspot.com/11441035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171511 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check to prevent committing .rej/.orig patch filesenne@chromium.org2012-12-051-0/+59
| | | | | | | | | | | | | This is a follow-up to me having to remove some of these by hand in r171143. R=maruel@chromium.org NOTRY=true BUG=none Review URL: https://chromiumcodereview.appspot.com/11448014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171287 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT #include check enhancement: <sys/..> includes can be in any order.marja@chromium.org2012-11-221-0/+10
| | | | | | | | | | | E.g., need to be in this order, since the latter uses definitions from the former. BUG=NONE Review URL: https://codereview.chromium.org/11418128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169290 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a presubmit that looks for version control conflicts.dbeam@chromium.org2012-11-201-0/+19
| | | | | | | | | | R=maruel@chromium.org,thakis@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/11417044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168715 0039d316-1c4b-4281-b951-d872f2087c98
* Fix include order PRESUBMIT check: #if-#elif-#elsemarja@chromium.org2012-11-161-0/+16
| | | | | | | | BUG=161390 Review URL: https://codereview.chromium.org/11413036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168191 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the PRESUBMIT include check some more.marja@chromium.org2012-11-151-0/+160
The previous version didn't take into account that source files can have a platform specific suffix. BUG=NONE TBR=ben@chromium.org Review URL: https://codereview.chromium.org/11413012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167996 0039d316-1c4b-4281-b951-d872f2087c98