| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files are a legacy from when the native_client_sdk
and ppapi were DEPS'd in from an external repos rather
than being part of chromium.
Second attempt at landing this change.
> Initial: https://codereview.chromium.org/54983002
> Revert: https://codereview.chromium.org/55983003
Review URL: https://codereview.chromium.org/54673014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds "2-clause BSD" and "3-clause BSD" to whitelisted licenses.
This is only a wording issue, since "BSD 2-clause" and "BSD 3-clause"
are already whitelisted.
This makes third_party/mach_override pass webview license check, even
though that particular library is not used by webview.
BUG=315381
NOTRY=true
TBR=joth
Review URL: https://codereview.chromium.org/62663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
git log 141ef86..e98b112 --date=short --format="%ad %an %s" | sed 's/@chromium\.org//'
2013-11-05 Marc-Antoine Ruel Make licensecheck.pl happy by tweaking the license header.
2013-11-05 Marc-Antoine Ruel Update copyright to the Swarming Authors and codereview.settings.
2013-11-05 Marc-Antoine Ruel Update colorama to 5a3100113a3a.
2013-10-30 vadimsh Report all swarming and isolate fatal errors in a consistent way.
2013-10-28 csharp Set the Swarm Test encoding to UTF-8
This removes the need to blacklist colorama for license check.
R=vadimsh@chromium.org,boliu@chromium.org
BUG=
Review URL: https://codereview.chromium.org/59913006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL updates all references to the WebKit namespace outside of content,
chrome, and components.
TBR=darin@chromium.org
BUG=295096
Review URL: https://codereview.chromium.org/61553006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce a way to call NavigationControllerImpl::ReloadIgnoringCache()
from the Java-side TabBase.
Also, consolidate reload() functions.
BUG=307333
Review URL: https://codereview.chromium.org/49353008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure we don't call into native after the native pointer has been
destroyed.
Internal bug b/11555111
BUG=
NOTRY=true
R=kristianm@chromium.org
Review URL: https://codereview.chromium.org/61763005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL removes code duplication around storage partition related data removal code from BrowsingDataRemover and re-uses StoragePartition::ClearData* method.
BUG=180118
Test=
Review URL: https://codereview.chromium.org/37843003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When throttling, either when paused or when in background, only throttle
fallback tick. There are apps relying on the fact that invalidates are
not throttled when paused. When in background, framework should take
care of not calling back with draw for invalidates.
Internal bug b/11230312
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/58483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> [Net] Assert that URLRequests with LOAD_IGNORE_LIMITS have MAXIMUM_PRIORITY
>
> Also remove the priority juggling in ClientSocketPoolBaseHelper, and instead
> assert that any requests with ignore_limits = true also has priority =
> MAXIMUM_PRIORITY.
>
> BUG=166689
> R=asanka@chromium.org, gene@chromium.org, joaodasilva@chromium.org, mmenke@chromium.org, simonjam@chromium.org
> TBR=benm@chromium.org, jamesr@chromium.org
>
> Review URL: https://codereview.chromium.org/51683002
Broke PrerenderBrowserTest.PrerenderDeferredSynchronousXHR. Running locally I was hitting a check on url_request.cc:979.
TBR=akalin@chromium.org
Review URL: https://codereview.chromium.org/47563006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove the priority juggling in ClientSocketPoolBaseHelper, and instead
assert that any requests with ignore_limits = true also has priority =
MAXIMUM_PRIORITY.
BUG=166689
R=asanka@chromium.org, gene@chromium.org, joaodasilva@chromium.org, mmenke@chromium.org, simonjam@chromium.org
TBR=benm@chromium.org, jamesr@chromium.org
Review URL: https://codereview.chromium.org/51683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split content::CreatePersistentCookieStore into two overloads; one which
uses the default task runners for both client and background tasks, and
one which takes both the client and background task runners as
parameters. Change existing callsites that pass null background task
runners (all of them except for android_webview) to just use the version
with fewer parameters.
For now, the android_webview callsite explicitly passes the IO thread as
the client task runner, which is the same as the default, but a followup
CL for this bug will introduce new callsites in android_webview that
make use of this parameter.
BUG=304813
NOTRY=true
Review URL: https://codereview.chromium.org/56183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a content API function which allows JNI registration to
be performed immediately during JNI_OnLoad, instead of always
being deferred until LibraryLoaded.
Add a call to this new API in android_webview's entry point,
since it benefits from the eager registration by allowing
more pages to be shared, and for certain JNI functions to
be called without starting all of Chromium (e.g. to enable
AwCookieManager).
BUG=304813
Review URL: https://codereview.chromium.org/50493015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor the code a bit and don't ignore return value of delete().
BUG=230209
TEST=AndroidWebViewTest
Review URL: https://codereview.chromium.org/52723009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
512x512 tiles uses exactly 1MB in memory. However the allocator
on certain devices allocates 1.25MB instead (due to performance
heuristics), so 20% of allocated tile memory is wasted in this
case.
Determined experimentally that 384 tiles do not have any overhead, so
update tile size to 384.
Also reduce the number of resources per webview from 200 to 150 to
overcome potential file handle limit problems, and add a command line
switch to control this value.
Internal bug b/11446261
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/56083003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This value was previously computed into the font scale factor.
BUG=252828
Review URL: https://codereview.chromium.org/49043010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is so that it is clearer what the intended initial priority of
a URLRequest is.
It is also needed so that we can later enforce that if a URLRequest
is set to ignore limits, it has MAXIMUM_PRIORITY; otherwise, we'd have
to mandate that SetPriority() is called before set_load_flags(), which
is fiddly.
Also standardize on a single URLRequest constructor.
BUG=166689
R=jam@chromium.org, jamesr@chromium.org, joth@chromium.org, mmenke@chromium.org, scottbyer@chromium.org, sky@chromium.org, tommi@chromium.org
Review URL: https://codereview.chromium.org/51953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify all the references to use src/tools/swarming_client/.
The build scripts already support both.
R=csharp@chromium.org, torne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/29993003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables the Android WebView to fire accessibility events for
sub-layer scrolling. Currently this is only limited to touch-driven
scrolling (JavaScript-initiated scrolling only works for the root
layer at the moment).
BUG=312318
android-only change, trybots are happy
NOTRY=true
Review URL: https://codereview.chromium.org/48973004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mode.
Using the measureSpec from the onMeasure callback to decide whether to set a
fixed layout size or not has proven to be a bit unpredictable. Changing the
code to look at the LayoutParams instead.
BUG=None
TEST=AndroidWebViewTest
// android_webview-only, trybots were happy.
NOTRY=true
Review URL: https://codereview.chromium.org/35403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On WebCore::MIDIAccess::stop(), renderer didn't cancel the MIDI
permission request infobar. As a result, when an iframe webpage that
requested MIDI permission is navigated away, the MIDI infobar is not
dismissed, unlike the geolocation infobar. This CL makes the MIDI infobar
be dismissed on WebCore::MIDIAccess::stop().
BUG=309893
Review URL: https://codereview.chromium.org/38043004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These tests are wrong as explained in the bug. The fix for this is in
blink code, so fix these tests, and also disable them for now until the
fix can land in blink and roll into chromium.
BUG=311495
NOTRY=true
Review URL: https://codereview.chromium.org/49003007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the pattern we follow for projects under ui/, each top-level directory
(app_list, aura, compositor, events) have its own gyp file for its main target
(library).
BUG=299841
TEST=build/gyp_chromium, ninja -C out/Debug shell_dialogs, and other targets
still build.
R=ben@chromium.org
Review URL: https://codereview.chromium.org/47323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous commit r231276 renamed some javascript file of Files.app but it've broken the check_licenses test because the whitelist file has not modified. This patch modify it.
BUG=none
TEST=none
TBR=benm@chromium.org
Review URL: https://codereview.chromium.org/47903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=pfeldman,bulach,mnaganov
BUG=311014
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231043
Review URL: https://codereview.chromium.org/39993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Introduce DevToolsTargetImpl" breaks Telemetry because it no longer returns
type: "other" for prerenders. "Add URL query parameter" had to go because it
builds atop the broken change.
BUG=311652
TBR=kaznacheev@chromium.org
NOTRY=True
Revert "DevTools: Add URL query parameter to json/new command"
This reverts commit 296d770a744a554751bca5bdf16e681bb8615589.
Revert "DevTools: Introduce DevToolsTargetImpl to unify debug target across several places in Chrome"
This reverts commit 329082e9edfe5a0e5672250abc269a66ba33bdf1.
Review URL: https://codereview.chromium.org/46523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
downstream build breakage
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/46453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=pfeldman,bulach,mnaganov
BUG=311014
Review URL: https://codereview.chromium.org/39993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Setting FLAG_HARDWARE_ACCELERATED when we only support software rendering
leads to the test activity always rendering white.
Also, setting the root layout to MATCH_PARENT as that's a saner default.
BUG=None
TEST=AndroidWebViewTest
// android_webview-only, trybots are happy with the CL.
NOTRY=true
Review URL: https://codereview.chromium.org/44433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The default behavior in the existing implementation was to reject the
client cert request but allow the SSL connection to proceed (so allowing
the server to choose policy on how to handle this scenario). Implement
the content callbacks to acheive the same.
BUG=
Review URL: https://codereview.chromium.org/42583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android
In version 29.0.1545.0, https://chromiumcodereview.appspot.com/16255010
removed onScrollChanged from ContentView.java and this caused having
no accessibility scroll event from ContentView when scrolling. Added onScrollChanged back to ContentView.java
BUG=296676
Review URL: https://codereview.chromium.org/26572003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=b/11267456
Review URL: https://codereview.chromium.org/31083005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=305352
Internal b/10932261
This allows the AwSettings (java only) instance to be created in advance
of AwContents, thereby allowing the AwSettings to be used early on when
the chromium stack has not be fully started.
As a result AwSettings is now able to live as a 'dumb' Java container of
settings, prior to the chromium stack being initialized at all.
Change-Id: I4059a93a7ad132043998fe2eab318a3b066c882e
Review URL: https://codereview.chromium.org/26959003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The standalone libwebviewchromium.so "clashes" with the one built using
android_webview_build==1; rename it in the standalone case so that if
you end up with both available, the correct one is used.
product_prefix is used because this ensures that the existing logic to
use product_extension to make component builds work is not disrupted.
Tested change with component and non-component builds.
BUG=
Review URL: https://codereview.chromium.org/37373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/26546006/ made it unnecessary
for non-WebView code to enable fixed layout mode. This patch
cleans up the Chromium side results of those changes.
BUG=285397
Review URL: https://codereview.chromium.org/35503005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
client code
TBR=pfeldman,bulach,mnaganov
BUG=None
Review URL: https://codereview.chromium.org/36303006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=305352
Internal Bug b/10932261
Originally from http://crrev.com/25092005/ PS9
Original Description:
[Android] Android code should not assume main thread == UI thread.
Although typically the case, the main thread of an android app is not
necessarily the thread in which the View is hosted (the Android "UI"
thread). Update base.ThreadUtils to be able to specify a non-main thread
UI thread, and update places in the code that make this assumption to
use the refactored ThreadUtils class.
Change-Id: Ie2967fedafcece90f4e65b52a84bdd21f6b745cd
Review URL: https://codereview.chromium.org/26424003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As currently implemented spatial navigation and touch event handling
have some unexpected interactions (see bug link) so instead:
1/ make a better-guess initial value based on presence of touchscreen
2/ dynamically enable spatnav when a DPAD event is received, and disable
it when touch down event received.
BUG=309425
Review URL: https://codereview.chromium.org/33823005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
viewport tags
This enables support for mobile frameworks that dynamically add several meta
viewport tags -- instead of discarding the previous tag when processing the new
one, we merge their values.
BUG=306548
Review URL: https://codereview.chromium.org/26144003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an Android-specific boolean pref defaulting to true, which indicates
whether font_scale_factor includes the 1.05-1.3x multiplier that is currently
applied by Clank on startup.
The goal is to move this multiplier out of Clank and into the content layer.
When font_scale_factor_quirk is false, the multiplier is applied in
content::ApplyWebPreferences.
This pref can be removed after Clank code is updated.
BUG=
Review URL: https://codereview.chromium.org/28053002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds a new Chrome-specific dynamic linker for Android,
that implements RELRO section sharing in order to save about 1.3 MB
of RAM per renderer process in content-based programs (ContentShell,
ChromiumTestShell, Chrome, etc...)
The linker is disabled by default. For more details, see the corresponding bug entry.
This introduces a new test package (content_linker_test_apk) as well as a new test category. To build and test this feature, do the following:
ninja -C out/Debug content_linker_test_apk
build/android/test_runner.py linker
BUG=287739
R=qsr@chromium.org
Review URL: https://codereview.chromium.org/23717023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes two obsolete files (they don't exist anymore) from
the whitelist used by the third-party license verification tool
for the Android webview.
BUG=NONE
R=torne@chromium.org,joth@chromium.org
Review URL: https://codereview.chromium.org/32723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The android-webview scheme is used to embed a defualt HTML5 video
poster. Register this scheme as secure such that it doesn't generate
mixed content warnings on https pages that embed HTML5 video.
Bug: b/11059667
Review URL: https://codereview.chromium.org/27567003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderViewForInterstitialPageCreated was actually incorrectly called by content, since it should have been called when the RenderView is created (to match RenderViewCreated callback), and not the RenderViewHost.
Also remove the overriding of RenderViewForInterstitialPageCreated in android_webview, which doesn't have interstitials.
BUG=306569
R=jochen@chromium.org, mkosiba@chromium.org
Review URL: https://codereview.chromium.org/29393004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The onSizeChanged callback was arriving after the AwContents was destroyed.
Ignoring the setFixedLayoutSize call is fine since the AwContents is going
away anyway.
BUG=308497
R=mnaganov@chromium.org
Review URL: https://codereview.chromium.org/28923005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of posting tasks to the FILE thread, use the IO thread to match
the rest of Chromium (which normally only calls CookieMonster on the IO
thread). This is a workaround for a possible thread safety issue in
CookieMonster, but it's fine to change this permanently as the original
choice of the FILE thread was not significant.
BUG=308589
Review URL: https://codereview.chromium.org/28943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to a rounding issue the tests were waiting for the width to be
600 CSS pixels when in fact it was 601 pixels.
BUG=308520
R=kristianm@chromium.org
Review URL: https://codereview.chromium.org/29483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will make it possible to depend on components from content shell
BUG=247431
R=jam@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/28123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RVH when WebContents is destructed.
Currently this doesn't happen because these RVHs get destructed in RenderViewHostManager's destruction, which happens after WCO::WebContentsImplDestroyed is called. That call removes the observers from WC.
Destructing RVHM before the observers isn't practical because a lot of observers assumes they can call WC::GetRenderViewHost in their destructors. So instead, expliclity call out RenderViewDeleted.
This is needed because many of the use cases of RenderViewHostObserver is to watch for the destruction of a RenderViewHost, so this will make it less error-prone to switch to a WebContentsObserver.
BUG=306569
R=avi@chromium.org, benm@chromium.org
Review URL: https://codereview.chromium.org/27545010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently as implemented, this will ensure clearView can be
unset even if AwContents.onPause is called.
Should considering refactoring clearView such that this case
can be dealt with more sanely.
Internal bug b/11230312.
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/27418007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
physical pixels
This enables the browser to return screen.width / availWidth (and height),
@media device-width (and height), window.outerWidth (and height),
but not window.innerWidth (and height) in physical rather than CSS
pixels.
BUG=305236
Review URL: https://codereview.chromium.org/26460004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229023 0039d316-1c4b-4281-b951-d872f2087c98
|