| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EXTENSION_FUNCTION_VALIDATE_TYPESAFE; make the former return a
"ValidationFailure" type with an operator for each required type, and delete
the latter.
BUG=365732
R=jyasskin@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/269153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The basic idea is that the webstore will provide signed expected hashes
of file content that can be checked during runtime in the browser to
detect corruption due to disk errors or malware.
This CL has a lot of the high-level pieces, with several of the details
left out for subsequent CLs to make this one more easily digestible.
The design is that there is a ContentVerifier for each BrowserContext
which can be used anywhere we read from files inside an extension. It
vends out ContentVerifyJob's, which need to be informed of the bytes
read from each file, and will know how to check those against a set of
expected block hashes. If the job detects contents that don't match what
was expected, it will notify the verifier.
BUG=369895
R=rvargas@chromium.org, yoz@chromium.org
Review URL: https://codereview.chromium.org/266963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This severs all remaining link-time dependencies on source
modules in //chrome, with the exception of some generated
resources.
BUG=349042,359656
Review URL: https://codereview.chromium.org/268363007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds default implementations for AppWindowRegistry notifications
as suggested in https://codereview.chromium.org/234673002.
This allows observers to avoid writing their own empty implementations of
unwanted notifications.
BUG=363470
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/236363011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves the runtime API schema and implementation to //extensions,
offloading some of its responsibilities out to a new RuntimeAPIDelegate
provided by the active ExtensionsBrowserClient.
BUG=369391
TBR=derat for mechanical chromeos changes
TBR=tzik for +webkit/browser/fileapi to extensions/browser/DEPS
TBR=sky for new chrome/test dependency
Review URL: https://codereview.chromium.org/264743014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Permissions declared in extensions/common are registered there.
This doesn't yet break AppShell's dependencies on Chrome features/permissions (that will be a simple change after this, and it will likely cause breakage).
BUG=339301
R=rockot@chromium.org
Review URL: https://codereview.chromium.org/265833014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL relands the rest of https://codereview.chromium.org/234673002/
following https://codereview.chromium.org/262633003/ and
removes the ChromeOS #ifdefs, effectively unreverting the revert.
This CL concludes the work required to merge
https://codereview.chromium.org/234673002/ into M35.
BUG=360896
TBR=stevenjb@chromium.org, skuhne@chromium.org
Review URL: https://codereview.chromium.org/266663004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, Chrome processes initialized AppShimHostManager before taking
the singleton lock. This meant new processes would replace the App Shim
Socket symlink and then delete it as soon as they fail to become the
singleton process.
BUG=168080
TEST= Start Chrome.
Start Chrome again via the command line. I.e. Chromium.app/Contents/MacOS/Chromium
Start an app via its shim. It should work.
Review URL: https://codereview.chromium.org/268903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Page IDs are not safe to use on their own, without knowing which SiteInstance
they correspond to.
BUG=369661
TEST=Dead code, no behavior change.
TBR=jam
TBR=mkosiba
Review URL: https://codereview.chromium.org/266053003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TestWebContentsView goes away since it's not needed anymore
BUG=304341
R=avi@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/262823006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SyncExtensionFunction and AsyncExtensionFunction derivates now expose RunSync
and RunAsync respectively. New extension function implementations should just
implement Run directly.
BUG=365732
R=rockot@chromium.org
TBR=dmazzoni@chromium.org
Review URL: https://codereview.chromium.org/257333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce a simple ShellNetworkController class that asks
shill to connect to networks when running on Chrome OS.
BUG=364297
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/264953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When extensions are reloaded they are freed immediately. App window
closing is asynchronous so this could cause bad race conditions. The
fix is to not hold on to any extension pointers in the app window.
TBR=stevenjb
BUG=352308
Review URL: https://codereview.chromium.org/257383003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The chrome.shell API is only available in app_shell, so it should not be part
of the common extensions _api_features.json.
This fixes a CHECK failure in the renderer when loading the Calculator sample
app, which tests for the existence of chrome.shell. (The schema is not
available, because the API is only implemented in app_shell, but chrome.shell
returns true because the "shell" is in the shared extensions _api_features.json.)
BUG=369318
TEST=manual
Review URL: https://codereview.chromium.org/260963006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This breaks another //extensions -> //chrome circular dependency.
* Split out Chrome-specific parts of ExtensionHelper to ChromeExtensionHelper
* Move ExtensionHelper to //extensions
* Move UserScriptScheduler to //extensions (a dependency of ExtensionHelper)
* Tighten DEPS
BUG=162530
TEST=compiles, existing browser_tests
TBR=bbudge@chromium.org for mechanical header file move touching chrome/renderer/pepper
Review URL: https://codereview.chromium.org/261733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is a reland of a portion of https://codereview.chromium.org/234673002/
with all changes #ifdefed for ChromeOS only. This will allow for a ChromeOS
only merge of the fix.
BUG=360896
TBR=stevenjb@chromium.org, skuhne@chromium.org
Review URL: https://codereview.chromium.org/269613003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves Dispatcher into //extensions along with
several of its remaining dependencies.
This also introduces a DispatcherDelegate interface along with implementations for chrome and app_shell.
BUG=359836
TBR=sky for CCRC and ChromeRenderViewTest
Review URL: https://codereview.chromium.org/260083006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds two new options to the FrameOptions field, activeColor and
inactiveColor. These cannot be set if color is also set.
BUG=339558
Review URL: https://codereview.chromium.org/203913008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/234673002/)
Reason for revert:
Revert to reland in more merge-able chunks. See crbug.com/360896
for details.
Original issue's description:
> Make hidden app windows have no shelf presence [ChromeOS].
>
> This CL fixes an issue with hidden app windows appearing in the shelf by
> unregistering the app windows when they are hidden and registering them
> again when shown.
>
> Window visibility wasn't enough here as the window is not visible
> if it is minimized.
>
> This CL adds OnAppWindowShown() and OnAppWindowHidden() methods to
> AppWindowObserver.
>
> BUG=360896
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265903
TBR=stevenjb@chromium.org, benwells@chromium.org, skuhne@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/262723003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to remove our hacky chrome.app.runtime stub schema in favor
of a real chrome.shell API generated from an IDL.
Also cleaned up the unused chrome.app.window.create stub and tweaked the
Calculator sample app to allow the use of chrome.shell.onLaunched.
This CL depends on https://codereview.chromium.org/254473011/
BUG=349042
TEST=app_shell --app=<path/to/calculator/app> loads calculator
Review URL: https://codereview.chromium.org/258053010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of attempting to validate the parameters by hand.
I did not change ShellAppWindowCreateFunction as that class is going away
in https://codereview.chromium.org/258053010/
BUG=368706
TEST=manual, changing Calculator example app to call createWindow() with bad params causes appropriate validation failures, with good params still opens a window
Review URL: https://codereview.chromium.org/261653002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The chrome.app.window.create API has too many Chrome dependencies to be practically extracted from src/chrome. Rather than create an incomplete chrome.app.window API stub just for app_shell, introduce chrome.shell.createWindow which can be used in place of chrome.app.window with a small stub.
* Introduce chrome.shell.createWindow for app_shell.
* Introduce an app_shell_resources target to hold the resource for the chrome.shell custom bindings JS.
* Extend ExtensionsRendererClient to allow an extensions embedder to supply additional custom APIs.
* Modify the Calculator example to use a small chrome.shell polyfill for window creation.
BUG=349042
TEST=browser_tests *Extension*, app_shell --app=<path/to/calculator/app> loads calculator
TBR=isherman@chromium.org for mechanical update of existing ExtensionFunction enum in histograms.xml
Review URL: https://codereview.chromium.org/254473011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move GetDefaultAppIcon and GetDefaultExtensionIcon out of src/extensions
into chrome/browser.
* Inline one call to GetDefaultAppIcon in src/apps
This requires a DEPS exception in src/apps for grit/theme_resources.h, but
that's better than having one in src/extensions (as src/apps is much higher
in the dependency tree).
No functional changes.
BUG=368334
TEST=Clean build of extensions_unittests succeeds, Chrome about:extensions still displays default icon for extension with no icon.
TBR=msw@chromium.org for mechanical namespace/include changes in chrome/browser/ui/views/
Review URL: https://codereview.chromium.org/259343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is added behind --apps-keep-chrome-alive.
When Chrome is quit, a notification is shown to let the user know that
Chrome will continue running.
The browser session should be shut down like on Windows, but that is
not yet implemented. Similarly, quitting all the apps should quit
Chrome. These will be added in followup CLs.
BUG=333429
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265889
Review URL: https://codereview.chromium.org/220373003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move ImageCursors from ash/wm/ to ui/base/cursors/ and add a
NativeCursorManager implementation for
ShellDesktopController to use.
BUG=364290
TEST=cursor is visible when running app_shell on a Chrome OS
device and changes after mousing over a link
Review URL: https://codereview.chromium.org/258893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Features defined in _*_features.json are split into chrome/common/extensions/api and extensions/common/api, according to where those features are implemented.
This also creates extensions_resources.pak.
With support for more than one features source, we can eliminate the AppShell dependency on Chrome features.
BUG=339301
TBR=sergeyberezin@chromium.org
Review URL: https://codereview.chromium.org/246423002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new GN template for generating static extensions API
library bundles from sets of schemas. It also adds invocations of
the template for core extensions and apps API targets.
BUG=None
TBR=kalman
Review URL: https://codereview.chromium.org/256453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=330735
Review URL: https://codereview.chromium.org/246633004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QuitWithAppsControllerInteractiveTest.QuitBehavior fails with a use-after-free
under ASan on Mac.
> Prevent Chrome from quitting when apps are open. (Mac)
>
> This is added behind --apps-keep-chrome-alive.
>
> When Chrome is quit, a notification is shown to let the user know that
> Chrome will continue running.
>
> The browser session should be shut down like on Windows, but that is
> not yet implemented. Similarly, quitting all the apps should quit
> Chrome. These will be added in followup CLs.
>
> BUG=333429
>
> Review URL: https://codereview.chromium.org/220373003
TBR=jackhou@chromium.org
Review URL: https://codereview.chromium.org/256503003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes an issue with hidden app windows appearing in the shelf by
unregistering the app windows when they are hidden and registering them
again when shown.
Window visibility wasn't enough here as the window is not visible
if it is minimized.
This CL adds OnAppWindowShown() and OnAppWindowHidden() methods to
AppWindowObserver.
BUG=360896
Review URL: https://codereview.chromium.org/234673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is added behind --apps-keep-chrome-alive.
When Chrome is quit, a notification is shown to let the user know that
Chrome will continue running.
The browser session should be shut down like on Windows, but that is
not yet implemented. Similarly, quitting all the apps should quit
Chrome. These will be added in followup CLs.
BUG=333429
Review URL: https://codereview.chromium.org/220373003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/247143004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These windows aren't meant to have titles or icons, but still need to
get a proper title as far as the OS is concerned. This means using a
custom but glass frame, similarly to how unthemed browser windows look.
BUG=339558
TEST=Try out frame:chrome app windows windows on Windows 7, 8 and XP.
Use the windows in various states (maximised, fullscreen, normal).
Make sure they work after switching in and out of aero mode.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262516
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265598
Review URL: https://codereview.chromium.org/213743017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Causing failures on "Linux ASan LSan Tests (2)" with unit_tests ("ShapedAppWindowTargeterTest.ResizeInsetsWithinBounds")
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/1874
> Remove title and icon from chrome apps native style title bars.
>
> These windows aren't meant to have titles or icons, but still need to
> get a proper title as far as the OS is concerned. This means using a
> custom but glass frame, similarly to how unthemed browser windows look.
>
> BUG=339558
> TEST=Try out frame:chrome app windows windows on Windows 7, 8 and XP.
> Use the windows in various states (maximised, fullscreen, normal).
> Make sure they work after switching in and out of aero mode.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262516
>
> Review URL: https://codereview.chromium.org/213743017
TBR=benwells@chromium.org
Review URL: https://codereview.chromium.org/248083006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These windows aren't meant to have titles or icons, but still need to
get a proper title as far as the OS is concerned. This means using a
custom but glass frame, similarly to how unthemed browser windows look.
BUG=339558
TEST=Try out frame:chrome app windows windows on Windows 7, 8 and XP.
Use the windows in various states (maximised, fullscreen, normal).
Make sure they work after switching in and out of aero mode.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262516
Review URL: https://codereview.chromium.org/213743017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=362672
Review URL: https://codereview.chromium.org/244363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
What I want to do:
Open text files which have unknown extensions(e.g. access.log.1) using packaged apps which can handle 'text/plain'(e.g. Text, Caret,...).
Current situation:
By following reasons, text files with unknow extension can't be opened.
1. FileManager guess the MIME type as empty, so 'text/plain'-supporting apps are not shown as handlers.
2. PlatformAppLauncher guess the MIME type as 'application/octet-stream', and it launch apps with no data because those apps don't handle 'application/octet-stream'.
What I changed:
Modified FileManager and PlatformAppLauncher to sniff MIME types if they are unknown based on extensions.
BUG=352250
R=benwells@chromium.org, hashimoto@chromium.org, jorgelo@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264167
Review URL: https://codereview.chromium.org/224883008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTIFICATION_EXTENSION_LOADED_DEPRECATED
to have bidirect with NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED.
This CL is the result of below script, and 'git cl format'.
find -regex '.*/.*\.\(mm\|cc\|h\)$' | xargs sed -i s/NOTIFICATION_EXTENSION_LOADED/NOTIFICATION_EXTENSION_LOADED_DEPRECATED/g
BUG=354367
Review URL: https://codereview.chromium.org/242613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
<webview> loads page in an isolated context inside platform app and hosts drive-by web. Platform app's CSP is too restrictive for <webview>, we stop using that CSP and use the default instead in this CL.
BUG=363437
Test=Load an chrome app. Load a webview html from accessible resources. Make the webview page contain inline JS. Check that the JS loads. It didn't use to load w/o this CL.
Review URL: https://codereview.chromium.org/237793003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This revert is requested by fukino, who is the author of the patch.
This patch breaks a browser test on Windows.
> Sniff MIME type for files which have unknown extensions.
>
> What I want to do:
> Open text files which have unknown extensions(e.g. access.log.1) using packaged apps which can handle 'text/plain'(e.g. Text, Caret,...).
>
> Current situation:
> By following reasons, text files with unknow extension can't be opened.
> 1. FileManager guess the MIME type as empty, so 'text/plain'-supporting apps are not shown as handlers.
> 2. PlatformAppLauncher guess the MIME type as 'application/octet-stream', and it launch apps with no data because those apps don't handle 'application/octet-stream'.
>
> What I changed:
> Modified FileManager and PlatformAppLauncher to sniff MIME types if they are unknown based on extensions.
>
> BUG=352250
> R=benwells@chromium.org, hashimoto@chromium.org, jorgelo@chromium.org
>
> Review URL: https://codereview.chromium.org/224883008
>
> Patch from Naoki Fukino <fukino@chromium.org>.
TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/240313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chromeos::DBusThreadManager."
A build dependency got renamed while this was in the CQ.
BUG=354711
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/239843004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
What I want to do:
Open text files which have unknown extensions(e.g. access.log.1) using packaged apps which can handle 'text/plain'(e.g. Text, Caret,...).
Current situation:
By following reasons, text files with unknow extension can't be opened.
1. FileManager guess the MIME type as empty, so 'text/plain'-supporting apps are not shown as handlers.
2. PlatformAppLauncher guess the MIME type as 'application/octet-stream', and it launch apps with no data because those apps don't handle 'application/octet-stream'.
What I changed:
Modified FileManager and PlatformAppLauncher to sniff MIME types if they are unknown based on extensions.
BUG=352250
R=benwells@chromium.org, hashimoto@chromium.org, jorgelo@chromium.org
Review URL: https://codereview.chromium.org/224883008
Patch from Naoki Fukino <fukino@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionsRendererClient defines an interface for clients
who wish to embed the extensions system into their renderer
processes.
This initial CL introduces two simple client methods to abstract
away Chrome dependencies within UserScriptSlave.
BUG=359836
R=yoz@chromium.org
TBR=jochen@chromium.org for ChromeContentRendererClient
Review URL: https://codereview.chromium.org/237833002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> app_shell: Initialize chromeos::DBusThreadManager.
>
> Let app_shell communicate with Chrome OS system processes.
> Also start notifying the power manager about user activity.
>
> BUG=354711
> TBR=sky@chromium.org
>
> Review URL: https://codereview.chromium.org/239433002
TBR=derat@chromium.org
Review URL: https://codereview.chromium.org/239823003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Let app_shell communicate with Chrome OS system processes.
Also start notifying the power manager about user activity.
BUG=354711
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/239433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows file_util::LoadExtension to be used from app_shell.
Also added a trivial unit test for the one function remaining in
extension_file_util.
BUG=362752
TEST=unit_tests, added GetBrowserImagePaths
TBR=stevenjb@chromium.org for mechanical header file renames touching c/b/chromeos
Review URL: https://codereview.chromium.org/236213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New dependency model:
ui/ozone -> ui/display/types
ui/display -> ui/ozone
ui/display -> ui/display/types
Note ui/display/types is its own module separate from ui/display.
TBR=derat@chromium.org
Review URL: https://codereview.chromium.org/230763004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=297026
Review URL: https://codereview.chromium.org/232773008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also moves ModuleSystem, RequestSender,
ObjectBackedNativeHandler, and SafeBuiltins
over to //extensions.
Other renderer code is updated minimally to support
these changes.
BUG=359836
TBR=sky@chromium.org for chrome/test
TBR=jamescook@chromium.org for apps/shell
TBR=maruel@chromium.org for PRESUBMIT.py
Review URL: https://codereview.chromium.org/234413005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This breaks Chrome dependencies in ExtensionProtocolHandler and moves //chrome/browser/extensions/extension_protocol.cc into //extensions/browser so it can be used in app_shell.
* Extract URLRequestResourceBundleJob to Chrome as it is used only to load component extension resources from Chrome's PAK files.
* Replace Profile::ProfileType usage with is_incognito to break the Profile dependency.
* Delegate out the decision to allow cross-renderer extension resource loads because this is primarily used for Chrome-specific extension features
* Eliminate chrome-extension-resource:// handling in app_shell (it allows sharing common extension data in the <chrome-install>/resources/extension/ directory, which app_shell doesn't need).
BUG=361373
TEST=browser_tests *Extension* and PlatformApp*, unit_tests ExtensionProtocol*, app_shell loads calculator
TBR=sky@chromium.org for mechanical header file move/refactor across chrome/browser
Review URL: https://codereview.chromium.org/229733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263198 0039d316-1c4b-4281-b951-d872f2087c98
|