| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Attempt to define and standardize usage of "luma" vs. "(relative) luminance" vs. "lightness", at least as far as color_utils functions, comments, and direct callers are concerned. Especially the first two terms are often both called "luminance" (universally, not just in Chrome code), so the distinction is confusing.
* Misc. cleanups to make caller code shorter or clearer.
* Naming consistency: remove "Get" from function names where we're not doing some simple "getter" operation, but rather computing a value.
* Modify some caller behaviors to be hopefully-more-correct
* Note that GetReadableColor() can accept values with alpha, it will just ignore the alpha.
* Add a PickContrastingColor() function, which is basically a subset of GetReadableColor(). This will be useful for an upcoming change where we want to choose between two fixed colors instead of luma-inverting a single input.
* Use more precise multipliers in Luma().
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1761183002
Cr-Commit-Position: refs/heads/master@{#379643}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The change introduces a "include_directories" entry in the manifest
file for file_handlers. In case the value is true, the file handler
becomes a generic handler and adds the given extension to the right
click menu.
BUG=415897
R=mtomasz@chromium.org
Review URL: https://codereview.chromium.org/1407473003
Cr-Commit-Position: refs/heads/master@{#377467}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch moves the last function in net_util.h into url_util.h. We are
moving it there because it also operates on a URL part (host).
BUG=488531
TEST=net_unittests --gtest_filter=UrlUtilTest.IsLocalhost
R=eroman@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/1726693002
Cr-Commit-Position: refs/heads/master@{#377115}
|
|
|
|
|
|
|
|
|
|
|
|
| |
❆(੭ु ◜◡‾)੭ु⁾☃❆
BUG=557422
R=avi@chromium.org
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1550693002
Cr-Commit-Position: refs/heads/master@{#366956}
|
|
|
|
|
|
|
|
| |
BUG=138542, 488550
Review URL: https://codereview.chromium.org/1499423004
Cr-Commit-Position: refs/heads/master@{#364429}
|
|
|
|
|
|
|
|
| |
BUG=517735
Review URL: https://codereview.chromium.org/1497193002
Cr-Commit-Position: refs/heads/master@{#363918}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap.
Also use std::move() instead of scoped_ptr::Pass().
TBR=avi@chromium.org
BUG=554291, 557422
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1458553006
Cr-Commit-Position: refs/heads/master@{#360745}
|
|
|
|
|
|
|
|
| |
BUG=484381
Review URL: https://codereview.chromium.org/1417313004
Cr-Commit-Position: refs/heads/master@{#356106}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace a bunch of pointers with const&.
TBR=pkotwicz@chromium.org (themes)
TBR=atwilson@chromium.org (background)
TBR=rogerta@chromium.org (ui/sync)
BUG=455414
Review URL: https://codereview.chromium.org/1365443003
Cr-Commit-Position: refs/heads/master@{#351631}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Public APIs from base should live inside base:: so moved Singleton class
and structs to base{} and fixed consumers.
also fixed:
** Presubmit ERRORS **
Found Singleton<T> in the following header files.
Please move them to an appropriate source file so that the template
gets instantiated in a single compilation unit.
chrome/browser/plugins/plugin_finder.h \
chromecast/media/base/media_message_loop.h \
content/browser/media/android/media_drm_credential_manager.h
Presubmit warnings:
src/chrome/browser/extensions/warning_badge_service_factory.h:5:
#ifndef header guard has wrong style, please use:
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_
[build/header_guard] [5]
src/chrome/browser/extensions/warning_badge_service_factory.h:39:
#endif line should be "#endif //
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_"
[build/header_guard] [5]
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1308823002
Cr-Commit-Position: refs/heads/master@{#348136}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
generated bundle names.
At the moment the 3 modules that use extension API schemas, those in
extensions/common/api, chrome/common/extensions/api, and extensions/shell/api,
are generated with different C++ namespaces: "core_api", "api", and
"shell::api" respectively.
This is a pointless distinction to make since as far as JS is concerned they
must all go on the window.chrome object, therefore namespace conflicts are
impossible. It just ends up adding code noise.
The only problem it solves is that all bundle compiles are generated to the
same name, "GeneratedSchemas" and "GeneratedFunctionRegistry". This patch
solves that a different way, by adding a JSON schema compiler option to give
those generated classes a prefix such that they are "GeneratedSchemas",
"ChromeGeneratedSchemas", and "ShellGeneratedSchemas" respectively.
This lets us to a global substitution from "core_api" to just "api".
R=rockot@chromium.org, dpranke@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/1226353004
Cr-Commit-Position: refs/heads/master@{#340119}
|
|
|
|
|
|
|
|
|
|
|
| |
I'm moving to a new project.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1250453002
Cr-Commit-Position: refs/heads/master@{#339655}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Almost all code that uses a std::map + STLValueDeleter has been modified
to use a ScopedPtrMap. This makes pointer ownership much clearer, and
removes a lot of manual pointer deletion.
BUG=478594
Review URL: https://codereview.chromium.org/1096983002
Cr-Commit-Position: refs/heads/master@{#336096}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionHostMsg_Request is sent when an extension calls an API function. Before
this patch, this IPC would be sent to one of 11 different call sites, all of
which then routed it to the ExtensionFunctionDispatcher - and all of which
have to implement ExtensionFunctionDispatcher::Delegate.
Instead, have ExtensionWebContentsObserver handle the IPC, since it is created
(or should be) for all extension web contents. This also lets us eliminate many
(though not all) of the ExtensionFunctionDispatcher::Delegate implementations
(I will try to clean more up in a later patch).
The size of this patch is due to a number of yaks that needed shaving along the
way - in particular, around GuestView.
BUG=498017
BUG=405246
Review URL: https://codereview.chromium.org/1169223002
Cr-Commit-Position: refs/heads/master@{#333843}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the variable containing ViewsDelegate singleton object can be
set by anyone and there are cases (at least in tests) where it is freely
replaced without properly deleting the old one which can lead to
situations where multiple ViewsDelegate objects are in existence. This
patch tries to ensure that there is at most one instance available at
each time.
Also, cleaned up some ViewsDelegate related includes.
BUG=492991
Review URL: https://codereview.chromium.org/1159033008
Cr-Commit-Position: refs/heads/master@{#333692}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid depending on (or including) extensions related code when enable_extensions
gyp/gn flag is not set. This fixes 'gn gen' for android with toolkit_views turned
on.
BUG=488576
Review URL: https://codereview.chromium.org/1160773004
Cr-Commit-Position: refs/heads/master@{#333690}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is everything but the chrome directory
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=zelidrag@chromium.org (chromeos)
TBR=keybuk@chromium.org (device/bluetooth)
Review URL: https://codereview.chromium.org/1162943002
Cr-Commit-Position: refs/heads/master@{#332626}
|
|
|
|
|
|
|
|
|
|
| |
This patch removes lazy_background_task_queue accessor from ExtensionSystem.
It can be its own browser context keyed service.
It can be built by its new factory.
Review URL: https://codereview.chromium.org/1129063011
Cr-Commit-Position: refs/heads/master@{#330815}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1144713003
Cr-Commit-Position: refs/heads/master@{#330538}
|
|
|
|
|
|
|
|
|
|
| |
He is no longer on the team.
R=rdevlin.cronin@chromium.org,mpearson@chromium.org,jhawkins@chromium.org
Review URL: https://codereview.chromium.org/1079973006
Cr-Commit-Position: refs/heads/master@{#325099}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
observer at the correct time.
"Extensions.ExtensionHostMonitoring.NumLoaded" UMA is now correctly recorded.
I also cleaned up ExtensionHost and its Start/Stop events a little to make it
more obvious, but in a way that my previous attempt at this (r320536) won't
cause crashes.
R=yoz@chromium.org
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/1016473002
Cr-Commit-Position: refs/heads/master@{#320806}
|
|
|
|
|
|
|
|
| |
BUG=417532
Review URL: https://codereview.chromium.org/938453002
Cr-Commit-Position: refs/heads/master@{#317690}
|
|
|
|
|
|
|
|
|
|
| |
This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read.
Minor updates to Win64 build, including some fixes for size_t to int conversions.
Review URL: https://codereview.chromium.org/929793006
Cr-Commit-Position: refs/heads/master@{#317162}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These IPCs hold this param as a gfx::Rect and the RenderWidget and RenderView
set the size. On the receiving end, the size is sometimes used so initial_pos
was a misnomer.
This is a mechanical rename, there should be no functional difference.
TBR=
BUG=
Review URL: https://codereview.chromium.org/889403004
Cr-Commit-Position: refs/heads/master@{#314430}
|
|
|
|
|
|
|
|
|
|
|
| |
This flag was being discarded if it was set on the command line, causing
problems for ASAN tests on windows.
BUG=449588
Review URL: https://codereview.chromium.org/859683004
Cr-Commit-Position: refs/heads/master@{#312161}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.
BUG=417463
Review URL: https://codereview.chromium.org/818113002
Cr-Commit-Position: refs/heads/master@{#309493}
|
|
|
|
|
|
|
|
|
|
| |
BUG=444596
TEST=none
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/802473003
Cr-Commit-Position: refs/heads/master@{#309448}
|
|
|
|
|
|
|
|
| |
BUG=417532
Review URL: https://codereview.chromium.org/788953002
Cr-Commit-Position: refs/heads/master@{#307617}
|
|
|
|
|
|
|
|
| |
BUG=432359
Review URL: https://codereview.chromium.org/718133005
Cr-Commit-Position: refs/heads/master@{#305688}
|
|
|
|
|
|
|
|
|
|
| |
The bare pointer could cause crashes if the extension is uninstalled (thus being deleted) while the launch logic is progressing on the FILE thread; storing an extension ID prevents this.
BUG=372270
Review URL: https://codereview.chromium.org/736233002
Cr-Commit-Position: refs/heads/master@{#304993}
|
|
|
|
|
|
|
|
|
|
| |
The added parameter helps us avoid a potential timing-related security issue. The UI can be instructed to open a new tab and show a dialog roughly at the same time, and since it's handled asynchronously the dialog may end up in front of the new tab. Knowing what web contents issued the dialog would allow us to prevent that from happening.
BUG=428793
Review URL: https://codereview.chromium.org/691823002
Cr-Commit-Position: refs/heads/master@{#304781}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AppWindow::Show.
The previous logic in AppLifetimeMonitor::OnAppWindowShown causes
OnAppActivated to be fired whenever a window is shown.
With this change, it will only fire when the first non-visible window
becomes visible.
This includes http://crrev.com/699363002 but passes |was_hidden|
insetad of AppWindow::ShowType.
BUG=410435
TEST=Create two windows using the Window State Sample app:
https://chrome.google.com/webstore/detail/window-state-sample/hcbhfbnaaancmblfhdknlnojpafjohbi
On one of the windows, set a delay of a few seconds, then click "Show".
Focus a non-Chrome window so that both app windows are obscured.
After the delay, only one app window should be brought to the front.
Review URL: https://codereview.chromium.org/705173003
Cr-Commit-Position: refs/heads/master@{#304144}
|
|
|
|
|
|
|
|
| |
BUG=23581
Review URL: https://codereview.chromium.org/689063002
Cr-Commit-Position: refs/heads/master@{#303142}
|
|
|
|
|
|
|
|
|
|
| |
trace launch source.
BUG=chromium:400619
Review URL: https://codereview.chromium.org/657023008
Cr-Commit-Position: refs/heads/master@{#302617}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change removes ProcessManager's //chrome dependency because while
ProcessManager and ExtensionSystem are in //extensions the
ExtensionSystemFactory is in //chrome. This allows a service in
//extensions to declare a dependency on the ProcessManager's factory
directly.
Most of this patch is changing,
extensions::ExtensionSystem::Get(profile_)->process_manager() to, extensions::ProcessManager::Get(profile_).
BUG=
TBR=erikwright@chromium.org
Review URL: https://codereview.chromium.org/671763002
Cr-Commit-Position: refs/heads/master@{#301636}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prefix all CommandLine usage in the apps/ directory with the
base:: namespace.
R=scheib@chromium.org
BUG=422426
Review URL: https://codereview.chromium.org/667723003
Cr-Commit-Position: refs/heads/master@{#301607}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=scheib@chromium.org
Review URL: https://codereview.chromium.org/666213002
Cr-Commit-Position: refs/heads/master@{#300609}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the current implementation, the helper function DoMakePathAbsolute
may rewrite the input even in the case of failure,
which makes the warning log less readable.
BUG=none
TEST=./chrome --app --app-id=someapp --enable-logging=stderr non/existing/path
Review URL: https://codereview.chromium.org/665053002
Cr-Commit-Position: refs/heads/master@{#300424}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/641963002
Cr-Commit-Position: refs/heads/master@{#298808}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's currently a dependency cycle between gyp files: components.gyp
and extensions.gyp. extensions.gyp depends on a number of components,
and two components depend on exetensions.gyp. These are:
- components/renderer_context_menu/
- components/native_app_window/ (more recently)
renderer_context_menu has an "optional" extensions dependency, which can
be skipped when ENABLE_EXTENSIONS is not defined. Still, it is necessary
for renderer_context_menu.gyp to omit its extensions.gyp dependency and
build as a static library.
For native_app_window, since it is not compiled on Mac, the gyp circular
check is not performed on the bots.
This CL fixes the layering by adding a folder,
src/extensions/components. Things here may depend on extensions, but not
on other extensions/components folders in a way that creates a cycle.
This also allows the benefits of a component-architecture to make sense
of interdependencies between the ~1337 files under src/extensions.
This layout also makes it clear that by depending on one of these
components, a target is also depending on src/extensions. Currently,
this is not clear.
BUG=35878, 418455
TBR=reed@google.com
Review URL: https://codereview.chromium.org/606953002
Cr-Commit-Position: refs/heads/master@{#297952}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This service doesn't need any Chrome dependencies after all and so it
can move into //extensions. This will make it possible for the USB
extensions API code to directly depend on it. In the process I have
rewritten the service with a couple improvements:
* C++11 for-each loops are used instead of explicit iterators.
* The DevicePermissions object is no longer an inner class (so it can
be forward declared) and it is explicitly copied when requested so
that the ownership of data on the FILE and UI threads is clear.
BUG=
Review URL: https://codereview.chromium.org/606503002
Cr-Commit-Position: refs/heads/master@{#297230}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The common string descriptors: iManufacturer, iProduct and iSerialNumber
should be accessible without opening the device. On Linux these can be
read out of sysfs without having access to the usbfs device node. This
is critical on Chrome OS because otherwise the permission broker needs
to be asked for permission to access the device. On other platforms we
fall back to opening the device temporarily. This will stop being the
case on OS X when libusb is no longer used and on Windows this will be
part of the initial enumeration process.
BUG=
TBR=dgozman@chromium.org
Review URL: https://codereview.chromium.org/601073002
Cr-Commit-Position: refs/heads/master@{#296802}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
App Shims are small .app bundles for Mac, which run in their own
process to provide packaged apps with an OSX Dock icon, using IPC to
communicate with the browser process.
Most of the app_shim code currently lives in src/apps/app_shim, but app
shims are very much a browser feature, so it doesn't belong there. It's
causing DEPS problems for athena efforts.
This CL moves most of apps/app_shim to chrome/browser/apps/app_shim
(c/b/apps didn't exist until a few months after src/apps/app_shim).
The shim itself (i.e. chrome_main_app_mode_mac.mm) doesn't run in the
browser process - it has its own, shim process. Those parts are moved to
a new folder: src/chrome/app_shim, consolidating files currently spread
across src/apps/app_shim and src/chrome/app.
app_shim_launch.h and app_shim_messages.h are used in both the shim
process and the browser process. They're moved to chrome/common/mac.
Summary of changes:
{apps => chrome/browser/apps}/app_shim/*
except
{apps => chrome}/app_shim/chrome_main_app_mode_mac.mm
{apps/app_shim => chrome/common/mac}/app_shim_launch.h
{apps/app_shim => chrome/common/mac}/app_shim_messages.h
app_shim.gypi renamed to browser_app_shim.gypi
chrome/app_shim/app_shim.gypi added
and
chrome/{app => app_shim}/app_mode-Info.plist
chrome/{app => app_shim}/app_mode_loader_mac.mm
- apps/app_shim/DEPS now just generated_resources.h
- 'app_mode_app' target moved from chrome.gyp to app_shim.gypi
BUG=266705
Review URL: https://codereview.chromium.org/585123004
Cr-Commit-Position: refs/heads/master@{#296576}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The flakiness only occurs on ASan builds. The test times out because the
shim does not successfully launch when the app launches.
LSOpenApplication returns procNotFound(-600). It's not clear why this
happens, but it could be some interaction with WaitForSingleProcess.
Reversing the order of the two test cases fixes the flakiness.
BUG=415422
Review URL: https://codereview.chromium.org/597113003
Cr-Commit-Position: refs/heads/master@{#296389}
|
|
|
|
|
|
|
|
| |
BUG=415422
Review URL: https://codereview.chromium.org/602483002
Cr-Commit-Position: refs/heads/master@{#296332}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The stack trace suggests LSOpenApplication fails to find the shim, and this
happens after waiting on a run loop. So a likely cause is that we're not
successfully waiting for the file operations to finish.
This CL changes the test to observe the parent directory instead of the shim
directory, and adds checks that the path exists before proceeding. If the test
still fails for this reason, at least it'll say so.
BUG=415422
Review URL: https://codereview.chromium.org/598443002
Cr-Commit-Position: refs/heads/master@{#296185}
|
|
|
|
|
|
|
|
|
| |
BUG=408049
TEST=Manual, see bug
Review URL: https://codereview.chromium.org/586323002
Cr-Commit-Position: refs/heads/master@{#296133}
|
|
|
|
|
|
|
|
| |
BUG=305852
Review URL: https://codereview.chromium.org/586623002
Cr-Commit-Position: refs/heads/master@{#296067}
|
|
|
|
|
|
|
|
|
|
|
| |
custom frame color
BUG=416214
TEST=Manual, see bug
Review URL: https://codereview.chromium.org/588873002
Cr-Commit-Position: refs/heads/master@{#295922}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
apps::SavedDevicesService tracks USB devices that have been selected by
the user in the context of a given extension. Devices that can be
identified accurately after they have been reconnected because they have
a serial number are written out to ExtensionPrefs. All others are only
remembered until they are disconnected.
A new OnDisconnect observer function has been added to UsbDevice to
enable this monitoring.
BUG=346953
Review URL: https://codereview.chromium.org/580963002
Cr-Commit-Position: refs/heads/master@{#295708}
|