| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the screen is locked via the wrench menu instead of by
holding the power button, we skip the slow-close animation
and don't show the black background layer. This formerly
caused the compositor's blue clear color to be visible and
now results in a neat hall-of-mirrors effect due to previous
frames not being cleared.
This change makes us show the background if it isn't already
visible when we start the fast-close animation after getting
notice that we're locking.
BUG=113526
TEST=added, also manual
Review URL: http://codereview.chromium.org/9385030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Putting this behind --aura-dynamic-window-mode until we're sure we need it. Reverted default window mode to overlapping, unless --aura-force-window-mode-compact is specified. This simplifies unit test setup, as the tests assume overlapping mode. I made the new flag set a bool so I can write unit tests without modifying CommandLine::ForCurrentProcess().
BUG=114018
TEST=aura_shell_unittests updated
Review URL: https://chromiumcodereview.appspot.com/9388013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=112914
TEST=aura_shell_unittests:ShellTest.FullscreenWindowHidesShelf
Review URL: https://chromiumcodereview.appspot.com/9374008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Run aura_shell_unittest
Review URL: http://codereview.chromium.org/9317027
TBR=zork@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9387002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Run aura_shell_unittest
Review URL: http://codereview.chromium.org/9317027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
capture lost (eg from a popup)
2) Invoke OS level SetCapture, ReleaseCapture as a result of setting capture on root window
BUG=107875
TEST=
1) Make sure that bug 105993 does not repro
Review URL: https://chromiumcodereview.appspot.com/9228004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes us adjust the position of the status area when it
compact mode depending on whether we're currently showing
the login/lock screen or not.
BUG=113001
TEST=added; also did manual testing
Review URL: http://codereview.chromium.org/9379024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
must be cast to and from the correct type at each use point. This CL introduces typed properties and templated aura::Window::[GS]etProperty methods that enforce the use of the declared type. Only pointer types and integral types that fits in intptr_t are supported, and ownership behavior is the same as before. This CL also adds support for default property values other than NULL/0.
BUG=none
TEST=updated unit tests
Review URL: http://codereview.chromium.org/8533025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make Launcher owns its widget;
- Update Shell's dtor since we no longer need to explicitly release launcher;
Also removed explicit tooltip_controller_.reset() and let scoped_ptr handle its release.
BUG=113466,104672
TEST=Verify crash in issue 113466 no longer happens and ASAN failure in 104672 does not regress.
Review URL: http://codereview.chromium.org/9369061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pass in an instance of a window to use for testing whether the inner dispatcher can receive events.
The |associated_window| should be such that it is behind a window which stops event propagation whenever the inner dispatcher should not receive events.
This fixes menus on the login screen because menus are above the lock screen in z order.
Bug=113247
Testing=Manual
Review URL: http://codereview.chromium.org/9374028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A. Unit tests run in 800x600 (so width != height) with a special static bool set to force overlapping window mode.
B1. Developers with no switches set start with a 1280x1024 window in overlapping mode.
B2. The screen resolution heuristic will choose overlapping mode if the screen is > 800 pixels tall, which makes B1 easy.
C. Developer host window reshapes are interpreted as resolution changes, so if the developer makes the window big the mode switches to
overlapping.
D. Passing --aura-window-mode=<foo> sets the window mode for the entire session. This is *not* passed by session manager. If a device starts up with a low-resolution external monitor, it gets compact mode.
BUG=113299
TEST=aura_shell_unittests ShellTest.*, manually running linux_chromeos with --aura-window-mode=compact / overlapping, manual test on device
Review URL: http://codereview.chromium.org/9369050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
can be centralized and not impact maximized/fullscreen code.
BUG=111285
TEST=none
R=oshima@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9375046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- disable other window animation when windows are placed into default container, avoid both window_animation and compact layout manager animating the same window.
- do not animate the current window if there is already an animation going on on it.
BUG=111875
TEST=tested on alex manually.
Review URL: http://codereview.chromium.org/9369048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support multimedia keys on an external USB keyboard. Since Windows does not define VKs for brightness keys, add new VKEYs to keyboard_codes_posix.h.
BUG=110407
TEST=ran aura_shell_unittests
Review URL: http://codereview.chromium.org/9309098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we have fixed crbug.com/110572, we no longer have to use a dummy window in the tests.
BUG=None
TEST=ran aura_shell_unittests
Review URL: http://codereview.chromium.org/9375009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
popup)
2) Adds support for capture lost events due to Window::SetCapture
BUG=107875
TEST=
1) Make sure that browser does not brash when drag and drop from bookmarks tab and Ctrl-Tab
2) Make sure that bug 105993 does not repro
Review URL: https://chromiumcodereview.appspot.com/9228004
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9373047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was caused by a mismatch in window and layer stacking. We use a NULL layer delegate as a signal that a window is hidden or closed and is animating out. The bottom-of-window status bubble frequently shows and hides, and hence is commonly in this state. If you tried to activate a background window while the status bubble was animating out the window would activate and start processing events, but its layer would not be brought to front, so it would visually appear behind other windows. The problem was probably introduced in either http://crrev.com/119453 (which introduced stacking changes for NULL layer delegate windows) or http://crrev.com/119753 (which fixed a similar issue with transient child windows). This patch ensures that window stacking order always matches layer stacking order and adds unit tests for this situation.
BUG=112562
TEST=aura_unittests WindowTest.Stack*
Review URL: https://chromiumcodereview.appspot.com/9371028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2) Adds support for capture lost events due to Window::SetCapture
BUG=107875
TEST=
1) Make sure that browser does not brash when drag and drop from bookmarks tab and Ctrl-Tab
2) Make sure that bug 105993 does not repro
Review URL: https://chromiumcodereview.appspot.com/9228004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds an always-visible black background when ash is
using the compact window mode, to prevent the compositor's
blue clear color from being visible when logging in, in the
middle of animations, etc.
BUG=chromium:10801
TEST=manual: logged in, switched windows, locked the screen, logged out, and shut down without seeing the blue background
Review URL: http://codereview.chromium.org/9371004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gets things compiling and running again on Mac/Aura after new
accelerator / dispatcher changes.
BUG=None
TEST=aura_shell_unittests
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9374002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the modal screen is animating on its way to hide itself, if another call to
CreateModalScreen is called, then it doesn't stop the hiding process. So make
sure that when creating the modal-screen, and it already exists, it is
explicitly told to Show.
BUG=113139
TEST=see bug
Review URL: http://codereview.chromium.org/9365018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=112608,112610
TEST=Verify fix to issue 112608 and 112610.
Review URL: https://chromiumcodereview.appspot.com/9340002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120887
Speculatively reverted at https://src.chromium.org/viewvc/chrome?view=rev&revision=120931
Review URL: https://chromiumcodereview.appspot.com/9363009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original change: http://codereview.chromium.org/9101010/
Aura: Convert Alt-tab to most-recently-used order
* Windows should cycle A -> B -> A for repeated Alt-tab presses.
* Holding down Alt allows cycling A -> B -> C -> D...
* Extracted cycling logic into WindowCycleController.
* Added unit tests for new behavior.
BUG=109193
TEST=aura_shell_unittests WindowCycleControllerTest
Review URL: https://chromiumcodereview.appspot.com/9190030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add accessible names to the launcher buttons
BUG=104192
TEST=None
Review URL: https://chromiumcodereview.appspot.com/9307037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Canvas::TileImageInt take a gfx::Rect.
BUG=100898
R=pkasting@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9332006
TBR=tfarina@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9358015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm suspicious this may have caused win_aura views_unittest failures.
BUG=none
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9363009
TBR=jamescook@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9360010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=112195
TEST=
Review URL: http://codereview.chromium.org/9310037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Posting another task when destroying widget in posted CloseNow is too late.
BUG=75023
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9339001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9363009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100898
R=pkasting@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9332006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Shift-Ctrl-F5 is reserved for taking partial screenshot.
So far it is NOTIMPLEMENTED().
BUG=108763
TEST=none
Review URL: http://codereview.chromium.org/9341001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=108763
TEST=manually
Review URL: http://codereview.chromium.org/9325086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Delegate needs to be deleted but window has to be deleted prior to it.
* a few minor leak fixes.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9350013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105964
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/9224001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=104192
TEST=Use ctrl+forward/back to move between browser window and status area/launcher
Review URL: http://codereview.chromium.org/9295049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
r120147 accidentally removed widget observer instead of the animation observer.
BUG=112654
TEST=Verify fix for issue 112654.
Review URL: http://codereview.chromium.org/9331007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the user plugs in a high-resolution external monitor, dynamically switch out of compact window mode into overlapping window mode. Force re-layout of all containers to ensure launcher, status area, etc. show up in proper locations.
BUG=110174
TEST=aura_shell_unittests ShellTest, try plugging and unplugging a monitor with resolution > 1400 pixels wide
Review URL: http://codereview.chromium.org/9320076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add ash::BrightnessControlDelegate.
BUG=110407
TEST=ran aura_shell_unittests
Review URL: https://chromiumcodereview.appspot.com/9309095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110407
TEST=None
TBR=mazda
Review URL: https://chromiumcodereview.appspot.com/9346001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Support multimedia keys on an external USB keyboard.
BUG=110407
TEST=manually checked that volume buttons on a Microsoft Natural keyboard work.
Review URL: https://chromiumcodereview.appspot.com/9318015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=105964
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/9224001
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9334008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105964
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/9224001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently it's handled in chrome/browser/chromeos/system_key_event_listener.cc by checking the X event loop directly, but for Aura, it'd be better to remove the X dependency by moving the code to ash/accelerators/ since any class except aura::RootWindowHost should not handle an X event directly.
BUG=110407
TEST=ran aura_shell_unittests
Review URL: https://chromiumcodereview.appspot.com/9301021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=105964
TEST=Manual
Depends on http://codereview.chromium.org/9124021
Review URL: https://chromiumcodereview.appspot.com/9224001
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9310124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=105964
TEST=Manual
Depends on http://codereview.chromium.org/9124021
Review URL: https://chromiumcodereview.appspot.com/9224001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements a sample implementation of a WidgetDelegateView (PanelWindow) and a LayoutManager to provide an initial out
ash_shell must be run with --aura-panels to get the new behavior, since Chrome currently relies on existing behavior for wi
BUG=98330
TEST=Run ash_shell --aura-panels to see a simple panel test implementation. Ensure panels work as expected in Chrome.
Original Review URL: http://codereview.chromium.org/9104027
TBR=dslomov@chromium.org
Review URL: http://codereview.chromium.org/9325051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements a sample implementation of a WidgetDelegateView (PanelWindow) and a LayoutManager to provide an initial outline for developing panels.
ash_shell must be run with --aura-panels to get the new behavior, since Chrome currently relies on existing behavior for widgets of TYPE_PANEL.
BUG=98330
TEST=Run ash_shell --aura-panels to see a simple panel test implementation. Ensure panels work as expected in Chrome.
Review URL: http://codereview.chromium.org/9104027
TBR=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9328026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements a sample implementation of a WidgetDelegateView (PanelWindow) and a LayoutManager to provide an initial outline for developing panels.
ash_shell must be run with --aura-panels to get the new behavior, since Chrome currently relies on existing behavior for widgets of TYPE_PANEL.
BUG=98330
TEST=Run ash_shell --aura-panels to see a simple panel test implementation. Ensure panels work as expected in Chrome.
Review URL: http://codereview.chromium.org/9104027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disables SystemModalContainerLayoutManagerTest.CanActivateAfterEndModalSession
on Mac aura_shell_unittests. Will reenable once modality is implemented.
BUG=None
TEST=SystemModalContainerLayoutManagerTest.CanActivateAfterEndModalSession
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9325043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120451 0039d316-1c4b-4281-b951-d872f2087c98
|