| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#4 id:60001 of https://codereview.chromium.org/1828133004/ )
Reason for revert:
Memory failures, eg.
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/8340
Original issue's description:
> Refine ash shelf tooltip closing on non-mash ChromeOS.
>
> Fixes a regression from: https://codereview.chromium.org/1816753002
> Also reverse expected behavior for touching tooltips.
> (closes on stable, tests expected them to stay open...)
>
> Inline bubble function definitions.
> Call WillDeleteShelf earlier to fix a test crash...
> TODO: Encapsulate more ShelfLayoutManager code.
>
> BUG=595853
> TEST=ChromeOS tooltips stay open on hover; close for external touches.
> R=sky@chromium.org
>
> Committed: https://crrev.com/1a0d283fa81e19b47fb85523f28c4a03f7dc1d24
> Cr-Commit-Position: refs/heads/master@{#383404}
TBR=sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=595853
Review URL: https://codereview.chromium.org/1836753002
Cr-Commit-Position: refs/heads/master@{#383444}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a regression from: https://codereview.chromium.org/1816753002
Also reverse expected behavior for touching tooltips.
(closes on stable, tests expected them to stay open...)
Inline bubble function definitions.
Call WillDeleteShelf earlier to fix a test crash...
TODO: Encapsulate more ShelfLayoutManager code.
BUG=595853
TEST=ChromeOS tooltips stay open on hover; close for external touches.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/1828133004
Cr-Commit-Position: refs/heads/master@{#383404}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows them to be used with the idiomatic mojo::ConvertTo<Foo>() template.
(In particular, ConvertTo<Foo>(my_vector) matches my_vector to "const U&" to
determine which TypeConverter to call. If my_vector is either a "std::vector"
or a "const std::vector" it ends up looking for TypeConverter<Foo, std::vector>.
Since the second TypeConverter template parameter isn't const, the compiler
can't find our existing TypeConverter<Foo, const std::vector> functions. These
functions don't need their template parameter to be const std::vector, as they
use "const std::vector&" for their inputs regardless.)
BUG=none
TEST=compiles
Review URL: https://codereview.chromium.org/1832133002
Cr-Commit-Position: refs/heads/master@{#383366}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use the large icon from WidgetDelegate::GetWindowAppIcon().
* In the mojo app's NativeWidgetMus, serialize the icon's SkBitmap as a vector of bytes and set it as a shared window property.
* In the window manager, pass the serialized icon to any UserWindowObservers.
* In the system UI, deserialize the icon and use it on the shelf.
* Set an icon in task_viewer as a demonstration.
The window property serialization is handled by a custom TypeConverter for vector<uint8>, SkBitmap. In the future it would be nice to use the serialized form of the Skia Mojom struct skia.Bitmap, but that will require Mojo to generate a public API to read the serialized bytes.
Also fixed an issue where the app's primary widget and the window manager's non-client-frame widget would fight over window titles.
A screenshot of the shelf is attached to the bug.
BUG=595850
TEST=launch mash, run mojo:task_viewer, note QuickLaunch shelf icon is default but TaskViewer icon is a gear
Review URL: https://codereview.chromium.org/1824183002
Cr-Commit-Position: refs/heads/master@{#383312}
|
|
|
|
|
|
|
|
|
| |
BUG=597274
TBR=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/1827083003
Cr-Commit-Position: refs/heads/master@{#383190}
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use ComputeBoundary to detect edges instead of using DisplayPlacement.
* This also fixes a bug where wrong key was used when saving preference.
BUG=597274
TEST=covered by unit tests.
Review URL: https://codereview.chromium.org/1823913002
Cr-Commit-Position: refs/heads/master@{#383153}
|
|
|
|
|
|
|
|
|
|
| |
(The call was re-introduced recently crrev.com/1816753002)
BUG=NONE
Review URL: https://codereview.chromium.org/1829123002
Cr-Commit-Position: refs/heads/master@{#383132}
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the implementation of toast. Currently this is not used from anywhere. The client code will be added in separated patch.
BUG=b/25797993
Review URL: https://codereview.chromium.org/1782793002
Cr-Commit-Position: refs/heads/master@{#383003}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make ShelfItemDelegateMus::ShouldShowTooltip() return true.
Put sysui menu/bubble widgets in mus's MENUS container.
(bubbles are used for shelf tooltips and volume/etc. settings)
Put sysui tooltip widgets in mus's TOOLTIPS container.
Rewrite ShelfTooltipManager as an aura::Window pre-target handler.
(can't install itself as a pre-target handler for the desktop root...)
Remove ShelfButtonHost; simplify ShelfButton and AppListButton.
(contain event observation logic within ShelfTooltipManager)
Update unit tests and helper classes; note currently broken behavior:
TODO: Make tooltips close on touch events outside the shelf.
TODO: Push item state to items; avoid shelf item delegates, etc.
BUG=595853
TEST=mash shelf shows tooltips; no cros regressions (except not closing on touch/gesture outside shelf).
R=sky@chromium.org
Review URL: https://codereview.chromium.org/1816753002
Cr-Commit-Position: refs/heads/master@{#382976}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
("quirks") from a Quirks Server. These provide display-specific tuning
(e.g. gamma ramps) on a per-monitor basis.
Each Quirks Client handles downloading and writing a single file. The
single Quirks Manager handles external requests for file paths, creates
clients when downloads are needed, and manages their life cycle. For
more info, see go/cros-quirks-client-dd (particularly the "Code Design"
section).
BUG=549349
TEST=Start up device that has a an icc file on the Quirks Server, check
that file is downloaded to /var/cache/display_profiles. At next startup,
the gamma correction in the icc file should be applied to the display
(this will only be visible to the degree that the gamma correction is
large enough to be noticeable; the correct functioning of the Quirks
Client is primarily determined by the appearance of the file).
Review URL: https://codereview.chromium.org/1528963002
Cr-Commit-Position: refs/heads/master@{#382962}
|
|
|
|
|
|
|
|
|
|
| |
Now that JSONValueConverter isn't used any more, we can use std::vector.
BUG=595498
Review URL: https://codereview.chromium.org/1819533002
Cr-Commit-Position: refs/heads/master@{#382748}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ApplicationRunner is used
This was originally at https://codereview.chromium.org/1814223002/ , but Ben is out and
I need this for tests, so I'm taking over.
BUG=none
TEST=covered by tests
TBR=ben@chromium.org
R=ben@chromium.org
Committed: https://crrev.com/a50f9840749052fbdec087a304548217cc6fd00b
Cr-Commit-Position: refs/heads/master@{#382389}
Review URL: https://codereview.chromium.org/1819063002
Cr-Commit-Position: refs/heads/master@{#382688}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds a WindowTreeHostManager::Observer to exo that
sets the appropriate output secure flag to the compositors
when the display configuration changes.
The first iteration for the logic that determines if the output
is secure is simply a check if the connected display is internal and
mirroring is disabled on all the devices.
Additionally this patch moves the 'is_secure_' flag from the OutputSurface
to LayerTreeImpl, since the lifetime of the latter better matches the
display configuration changes.
BUG=b/27173841,b/27174223
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1821553002
Cr-Commit-Position: refs/heads/master@{#382683}
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Stop using Shell::GetAppListWindow() from the Ash code. (This is in
preparation for limiting the AppListController API that Ash uses).
- Clarify the comment for Shell::GetAppListView().
BUG=NONE
Review URL: https://codereview.chromium.org/1759133003
Cr-Commit-Position: refs/heads/master@{#382646}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ApplicationRunner is used (patchset #2 id:20001 of https://codereview.chromium.org/1819063002/ )
Reason for revert:
Looks like to made the mojo_apptests go red. I think this is also making MUS tests fail?
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/39128
Original issue's description:
> Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used
>
> This was originally at https://codereview.chromium.org/1814223002/ , but Ben is out and
> I need this for tests, so I'm taking over.
>
> BUG=none
> TEST=covered by tests
> TBR=ben@chromium.org
> R=ben@chromium.org
>
> Committed: https://crrev.com/a50f9840749052fbdec087a304548217cc6fd00b
> Cr-Commit-Position: refs/heads/master@{#382389}
TBR=ben@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/1821913002
Cr-Commit-Position: refs/heads/master@{#382460}
|
|
|
|
|
|
|
|
|
|
|
| |
Separate the JSON processing code out of DisplayLayout in preparing to move to
ui/gfx since ui/gfx has no JSON dependency.
BUG=595498
Review URL: https://codereview.chromium.org/1808253004
Cr-Commit-Position: refs/heads/master@{#382398}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ApplicationRunner is used
This was originally at https://codereview.chromium.org/1814223002/ , but Ben is out and
I need this for tests, so I'm taking over.
BUG=none
TEST=covered by tests
TBR=ben@chromium.org
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1819063002
Cr-Commit-Position: refs/heads/master@{#382389}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add ash/mus/context_menu_mus.* for mash context menus.
(populates local ash items like ash_shell_with_content)
Tangential ShelfView refactoring (can be split).
BUG=557406
TEST="chrome --mash" context menus appear.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/1760743002
Cr-Commit-Position: refs/heads/master@{#382326}
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1817443002
Cr-Commit-Position: refs/heads/master@{#381889}
|
|
|
|
|
|
|
|
|
|
| |
BUG=589194
TEST=Put too many icons on shelf, move shelf to left, click chevron to
open overflow bubble. Observe that bubble doesn't overlap shelf.
Review URL: https://codereview.chromium.org/1809963003
Cr-Commit-Position: refs/heads/master@{#381855}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid most window->shelf lookup calls; misc cleanup.
Remove some ChromeLauncherController auto-hide functions.
(inline pref lookup function call, context menu ops)
Add Shell::OnShelfAlignmentChanged to revise set pattern.
(support ShelfLayoutManager::SetAlignment, w/o Shell::SetShelfAlignment)
Prerequisite for https://codereview.chromium.org/1760743002
BUG=557406
TEST=No behavior changes or regressions.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/1812013003
Cr-Commit-Position: refs/heads/master@{#381849}
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
R=sky@chromium.org
Review URL: https://codereview.chromium.org/1811203002
Cr-Commit-Position: refs/heads/master@{#381842}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1810713002
Cr-Commit-Position: refs/heads/master@{#381660}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upcoming changes in the Chrome OS networking daemon (shill) will allow
third party VPNs to transition "backwards" from Online->Configuring if
the default physical connection changes. Add a "reconnect" flag so
that VPN apps can signal their compatibility with this new scheme,
and add the necessary UI changes so that Chrome can identify
reconnections and present them to the user in a sensible way.
Also, change the UI so that users can cancel VPN reconnections
(and connections) using the "Disconnect" button.
BUG=514343
Review URL: https://codereview.chromium.org/1722453002
Cr-Commit-Position: refs/heads/master@{#381566}
|
|
|
|
|
|
|
|
|
| |
BUG=570761
TEST=None
Review URL: https://codereview.chromium.org/1765383003
Cr-Commit-Position: refs/heads/master@{#381422}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This just adds the boilerplate for five new accessibility features and hides
them behind a flag. All five have been prototyped and are ready for
implementation.
The first three are related, they just provide visual highlighting to
help low-vision users keep track of things on the screen:
* Caret highlight
* Cursor highlight
* Focus highlight
Hold down a key and click or drag to speak any visible text on screen
* Select to speak
Control the whole computer with a single switch (for motor impaired users)
* Switch access
For now, there's no need to put these in the tray. They can graduate to the
tray when they launch.
BUG=314889,593887,593885
Review URL: https://codereview.chromium.org/1785833002
Cr-Commit-Position: refs/heads/master@{#381353}
|
|
|
|
|
|
|
|
|
| |
BUG=579226
TEST=ToplevelWindowEventHandler.CancelWhileDragStart
Review URL: https://codereview.chromium.org/1800793003
Cr-Commit-Position: refs/heads/master@{#381243}
|
|
|
|
|
|
|
|
|
|
| |
screen.
BUG=515594
Review URL: https://codereview.chromium.org/1753473003
Cr-Commit-Position: refs/heads/master@{#380724}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When running ash inside of mash_shell on a device, DisplayConfigurator
will request a NativeDisplayDelegate from Ozone. Ozone is initialized
only in the mus process, not in the ash process, so ash crashes at this
point.
Add accessor for configure_display_ to avoid crashing. The default
display size can be set via command line with --ash-host-window-bounds
flag until a better solution exists.
BUG=590096
Review URL: https://codereview.chromium.org/1782093003
Cr-Commit-Position: refs/heads/master@{#380663}
|
|
|
|
|
|
|
|
|
|
|
| |
This is not a complete conversion of setShader() sites, but is intended to be a canary, to tryout the new patterns. More will follow once this is approved.
BUG=skia:5077
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1778913002
Cr-Commit-Position: refs/heads/master@{#380613}
|
|
|
|
|
|
|
|
| |
BUG=585312
Review URL: https://codereview.chromium.org/1759453002
Cr-Commit-Position: refs/heads/master@{#380411}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise they aren't picked up as runtime dependencies and isolates
won't work.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1783533003
Cr-Commit-Position: refs/heads/master@{#380347}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#380300}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The accelerator for starting the feedback app should be non-repeatable.
We should only request system information once the UI is shown not before, and
limit doing the initialization only to when we determine we need to create a new
feedback window.
R=rkc@chromium.org
BUG=590892
TEST=manually
Review URL: https://codereview.chromium.org/1780553002
Cr-Commit-Position: refs/heads/master@{#380230}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch removes unary and binary function, since those are deprecated
in C++11. They also only provide two typedefs, so this cleans up some
code. In rare cases where the typedefs are actually required, it's
easier to just provide the typedef directly instead of deriving from
one of these functions.
BUG=593407
Review URL: https://codereview.chromium.org/1420333006
Cr-Commit-Position: refs/heads/master@{#380179}
|
|
|
|
|
|
|
|
|
| |
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1769163002
Cr-Commit-Position: refs/heads/master@{#379757}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Attempt to define and standardize usage of "luma" vs. "(relative) luminance" vs. "lightness", at least as far as color_utils functions, comments, and direct callers are concerned. Especially the first two terms are often both called "luminance" (universally, not just in Chrome code), so the distinction is confusing.
* Misc. cleanups to make caller code shorter or clearer.
* Naming consistency: remove "Get" from function names where we're not doing some simple "getter" operation, but rather computing a value.
* Modify some caller behaviors to be hopefully-more-correct
* Note that GetReadableColor() can accept values with alpha, it will just ignore the alpha.
* Add a PickContrastingColor() function, which is basically a subset of GetReadableColor(). This will be useful for an upcoming change where we want to choose between two fixed colors instead of luma-inverting a single input.
* Use more precise multipliers in Luma().
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1761183002
Cr-Commit-Position: refs/heads/master@{#379643}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
layers less likely to be misused in the same way in the future.
Also fix some unnecessary calls to aura::Window::SetTransparent().
BUG=none
TBR=avi@chromium.org
Review URL: https://codereview.chromium.org/1732173002
Cr-Commit-Position: refs/heads/master@{#379619}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
BUG=
patch from issue 1760963003 at patchset 20001 (http://crrev.com/1760963003#ps20001)
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1770533002
Cr-Commit-Position: refs/heads/master@{#379476}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mojo IPC). Support for (scoped) pointers for abstract ui::Event objects implemented using ui::ScopedEvent, and trusting ui::EventType information to instantiate the correct concrete type.
BUG=584687
Committed: https://crrev.com/482ddfefe2602f440146eebf4b56e8e040fb81fa
Cr-Commit-Position: refs/heads/master@{#378821}
Committed: https://crrev.com/74b231ad33ec44bc2662fef2831a3cd90e1f3834
Cr-Commit-Position: refs/heads/master@{#379094}
Review URL: https://codereview.chromium.org/1695783002
Cr-Commit-Position: refs/heads/master@{#379348}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove ash::ShelfItemDelegate::CreateContextMenu.
Use ash::ShellDelegate::CreateContextMenu instead.
(this is what all the impls do anyway...)
Don't pass the ShelfItemDelegate, look up as needed.
Only create |extension_items_| as needed.
Don't ask |extension_items_| for local enabled/checked state.
Remove non-cros logic from LauncherContextMenu.
Support null in GetAppIDForShelfID for app list button.
TODO: Refine menu model creation pattern to support mash.
BUG=557406
TEST=No behavior changes or regressions.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/1762813002
Cr-Commit-Position: refs/heads/master@{#379158}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #18 id:340001 of https://codereview.chromium.org/1695783002/ )
Reason for revert:
Breaks compile: https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/19183
Original issue's description:
> Implements and tests IPC::ParamTraits for ui::Event (towards ui::Events over mojo IPC). Support for (scoped) pointers for abstract ui::Event objects implemented using ui::ScopedEvent, and trusting ui::EventType information to instantiate the correct concrete type.
>
> BUG=584687
>
> Committed: https://crrev.com/482ddfefe2602f440146eebf4b56e8e040fb81fa
> Cr-Commit-Position: refs/heads/master@{#378821}
>
> Committed: https://crrev.com/74b231ad33ec44bc2662fef2831a3cd90e1f3834
> Cr-Commit-Position: refs/heads/master@{#379094}
TBR=rockot@chromium.org,sadrul@chromium.org,kenrb@chromium.org,tsepez@chromium.org,jam@chromium.org,sky@chromium.org,fsamuel@chromium.org,markdittmer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584687
Review URL: https://codereview.chromium.org/1765693002
Cr-Commit-Position: refs/heads/master@{#379123}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mojo IPC). Support for (scoped) pointers for abstract ui::Event objects implemented using ui::ScopedEvent, and trusting ui::EventType information to instantiate the correct concrete type.
BUG=584687
Committed: https://crrev.com/482ddfefe2602f440146eebf4b56e8e040fb81fa
Cr-Commit-Position: refs/heads/master@{#378821}
Review URL: https://codereview.chromium.org/1695783002
Cr-Commit-Position: refs/heads/master@{#379094}
|
|
|
|
|
|
|
|
|
| |
BUG=591241
TEST=manual
Review URL: https://codereview.chromium.org/1759213002
Cr-Commit-Position: refs/heads/master@{#379082}
|
|
|
|
|
|
|
|
|
|
|
| |
Verify for tray display messages, that rotation is not shown on the internal display. Other display changes will still be shown.
TEST=manual testing on device
BUG=513397
Review URL: https://codereview.chromium.org/1728793002
Cr-Commit-Position: refs/heads/master@{#379068}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reboots.
This cl added a new attribute to device's active state settings to describe if the device is made active by user's selection or by automatic priority selection. The device made active by user has a higher priority than the device made active by priority.
With the stable device id, the active device selection rule is different than before, which only select the active device by its priority. Please see the details in the following document.
https://docs.google.com/a/google.com/document/d/1zmSeM956Njh_9ZdLqyld-NTOpJyXVIfzv8DvQ1Xcksw/edit?usp=sharing
BUG=308143
TBR=stevenjb,rkc,derat
Review URL: https://codereview.chromium.org/1746843002
Cr-Commit-Position: refs/heads/master@{#378812}
|
|
|
|
|
|
|
|
| |
BUG=589562
Review URL: https://codereview.chromium.org/1752923003
Cr-Commit-Position: refs/heads/master@{#378797}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove Shelf::[G|S]etShelfViewBounds.
Remove ShelfWidget::DelegateView::Layout override.
Use FillLayout instead, with an empty border on the parent.
Use ScreenUtil::GetShelfDisplayBoundsInRoot consistently.
Refactor ShelfLayoutManager::CalculateTargetBounds, etc.
BUG=57406
TEST=No behavior changes or regressions.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/1742953002
Cr-Commit-Position: refs/heads/master@{#378707}
|
|
|
|
|
|
|
|
| |
BUG=NONE
Review URL: https://codereview.chromium.org/1752483003
Cr-Commit-Position: refs/heads/master@{#378691}
|
|
|
|
|
|
|
|
| |
BUG=452599
Review URL: https://codereview.chromium.org/1745653002
Cr-Commit-Position: refs/heads/master@{#378475}
|