summaryrefslogtreecommitdiffstats
path: root/ash
Commit message (Collapse)AuthorAgeFilesLines
* Fix SpeechUIModel lifetime issue in Chrome's AppListViewDelegate when ↵tapted2014-09-091-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | switching profiles The AppListView observes the SpeechUIModel directly, so SpeechUIModel must outlive profile changes within Chrome's AppListViewDelegate. Profile changes only recreate the app_list::ContentView and subviews, which updates app_list::AppListModel observers, but not app_list::SpeechUIModel observers. This comes up when switching profiles in the desktop app list. To fix, this change gives SpeechUIModel a default constructor to simplify setting the initial speech recognition state, which needs the profile. Then, decouples the lifetime of the SpeechUIModel from the Profile in Chrome's AppListViewDelegate. BUG=405827 TBR=jamescook@chromium.org Review URL: https://codereview.chromium.org/550883002 Cr-Commit-Position: refs/heads/master@{#293878}
* Add lots of testonly annotations to the GN build.Brett Wilson2014-09-081-0/+3
| | | | | | | | | BUG= R=hclam@chromium.org Review URL: https://codereview.chromium.org/547793002 Cr-Commit-Position: refs/heads/master@{#293774}
* Revert of Removing X11 native_event uses for key events. (patchset #7 ↵arv2014-09-081-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:180001 of https://codereview.chromium.org/479873002/) Reason for revert: Broke Android Tests (dbg) C 427.575s Main [FAIL] org.chromium.content.browser.input.ImeTest#testKeyCodesWhileComposingText: C 427.575s Main junit.framework.AssertionFailedError C 427.575s Main at org.chromium.content.browser.input.ImeTest.assertUpdateStateCall(ImeTest.java:694) C 427.575s Main at org.chromium.content.browser.input.ImeTest.testKeyCodesWhileComposingText(ImeTest.java:410) C 427.575s Main at java.lang.reflect.Method.invokeNative(Native Method) C 427.575s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 427.575s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 427.575s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 427.575s Main at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227) C 427.575s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 427.575s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 427.575s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) C 427.575s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701) Original issue's description: > Removing uses of X11 native key events. > > BUG=380349 > > Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822 > > Committed: https://chromium.googlesource.com/chromium/src/+/13d90b146a400156427243d05159cadd8d72c0b9 TBR=sadrul@chromium.org,sky@chromium.org,erg@chromium.org,jamesr@chromium.org,boliu@chromium.org,kpschoedel@chromium.org NOTREECHECKS=true NOTRY=true BUG=380349 Review URL: https://codereview.chromium.org/548303003 Cr-Commit-Position: refs/heads/master@{#293732}
* Disable failing TouchFeedback tests.jonross2014-09-081-2/+6
| | | | | | | | | | | Disable WebNotificationTrayTest.TouchFeedback and TouchFeedbackCancellation which are failing on ASAN machines. TBR=skuhne@chromium.org BUG=411881 Review URL: https://codereview.chromium.org/551833002 Cr-Commit-Position: refs/heads/master@{#293724}
* Adds touch feedback to tray icons in touchview when ↵jonross2014-09-066-1/+117
| | | | | | | | | | | --ash-enable-touchview-touch-feedback flag is passed. TEST=WebNotificationTrayTest.MAYBE_NoTouchFeedback, WebNotificationTrayTest.MAYBE_MaximizeModeTouchFeedback, WebNotificationTrayTest.MAYBE_TouchFeedbackCancellation BUG=398398 Review URL: https://codereview.chromium.org/515573002 Cr-Commit-Position: refs/heads/master@{#293608}
* chromeos: Update battery icons.Daniel Erat2014-09-054-0/+0
| | | | | | | | | | | | | Switch to updated battery icons with less-opaque backgrounds that are more visible against the white notification background. BUG=166645 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/549573003 Cr-Commit-Position: refs/heads/master@{#293586}
* Removing uses of X11 native key events.kpschoedel2014-09-051-7/+8
| | | | | | | | | | BUG=380349 Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822 Review URL: https://codereview.chromium.org/479873002 Cr-Commit-Position: refs/heads/master@{#293520}
* Declaring the weak_ptr_factory in proper order.anand.ratn2014-09-055-13/+17
| | | | | | | | | | | | Cleaning up weak_ptr_factorydestruction order in "src/ash" module. WeakPtrFactory should remain the last member so it'll be destroyed and invalidate its weak pointers before any other members are destroyed. BUG=303818 Review URL: https://codereview.chromium.org/497733002 Cr-Commit-Position: refs/heads/master@{#293450}
* Reset the default work_area when start observing.mukai2014-09-051-0/+1
| | | | | | | | | | | | | In OOBE screen, shelf is not yet ready fully so that work_area_ isn't set well. It needs to be initialized here. BUG=401743 R=stevenjb@chromium.org TEST=manually Review URL: https://codereview.chromium.org/544883002 Cr-Commit-Position: refs/heads/master@{#293435}
* Do not mutate ui::Event properties during nested event processingtdanderson2014-09-051-0/+3
| | | | | | | | | | | | | | | | | | | | | | | If an EventProcessor starts to process a ui::Event while it is already being processed by another EventProcessor, then the properties of the event (e.g., target, phase) should not be mutated by the inner processor before control is returned to the outer processor. The exception being whether or not the event has been handled. To guarantee this, the inner processor should dispatch a copy of the event rather than the original event itself. This CL also introduces the static ui::Event::Clone() method, which is used to create a copy of a ui::Event. BUG=404232 TEST=EventProcessorTest.NestedEventProcessing, updated WindowManagerTest.Focus Review URL: https://codereview.chromium.org/519113002 Cr-Commit-Position: refs/heads/master@{#293410}
* Revert of Removing X11 native_event uses for key events. (patchset #6 ↵dcheng2014-09-041-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | id:160001 of https://codereview.chromium.org/479873002/) Reason for revert: Causing check_licenses to fail on android_clang_dbg_recipe trybot: The following files are whitelisted unnecessarily. You must remove the following files from the whitelist. content/browser/renderer_host/web_input_event_aurax11.cc The following files are whitelisted, but do not exist. content/browser/renderer_host/web_input_event_aurax11.cc Original issue's description: > Removing uses of X11 native key events. > > BUG=380349 > > Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822 TBR=sadrul@chromium.org,sky@chromium.org,erg@chromium.org,jamesr@chromium.org,kpschoedel@chromium.org NOTREECHECKS=true NOTRY=true BUG=380349 Review URL: https://codereview.chromium.org/536313002 Cr-Commit-Position: refs/heads/master@{#293254}
* Removing uses of X11 native key events.kpschoedel2014-09-031-7/+8
| | | | | | | | BUG=380349 Review URL: https://codereview.chromium.org/479873002 Cr-Commit-Position: refs/heads/master@{#293166}
* Use standardized and extendable accelerometer update type.flackr2014-09-028-147/+173
| | | | | | | | | | | | | | | Updates the type used when delivering accelerometer updates in ash to: - support a variable number of accelerometers - be measured in m/s^2 - use axes consistent with the web device motion API. BUG=380831 TEST=MaximizeModeController unit tests still pass. TEST=Run on a touchview device and verify that entering / exiting touchview as well as screen rotation still works. Review URL: https://codereview.chromium.org/500613003 Cr-Commit-Position: refs/heads/master@{#292968}
* Make apps grid view scroll vertically in experimental app list.mgiuca2014-09-011-1/+6
| | | | | | | | | | | | | Scrolling remains horizontal in the normal (and centered) app lists. BUG=406222 TEST=Run with --enable-experimental-app-list --show-app-list. Apps grid view should scroll vertically. Normal app list should still scroll horizontally. Review URL: https://codereview.chromium.org/491973004 Cr-Commit-Position: refs/heads/master@{#292826}
* Make sure primary root window is deleted last.oshima2014-08-301-11/+22
| | | | | | | | | BUG=403380 R=mukai@chromium.org Review URL: https://codereview.chromium.org/520273002 Cr-Commit-Position: refs/heads/master@{#292759}
* Move gestureCreated, touchMaxDistance and touchDuration UMA logs into ↵lanwei2014-08-291-165/+0
| | | | | | | | | | gesture provider, so that they can also record data from other platforms, such as Android, Windows, not only from ChromeOS. BUG=352654 Review URL: https://codereview.chromium.org/501553004 Cr-Commit-Position: refs/heads/master@{#292570}
* Cleanup: Remove misc unneeded grit includes.thestig2014-08-2812-16/+6
| | | | | | Review URL: https://codereview.chromium.org/512663002 Cr-Commit-Position: refs/heads/master@{#292448}
* Clear restore bounds for user resize/drag actions.wnwen2014-08-273-17/+44
| | | | | | | | | | | | | When the window is not snapped, user resizes should always clear restore bounds. This allows user initiated resizes to not be unexpectedly ignored. BUG=405563 TEST=WorkspaceWindowResizerTest.RestoreClearedOnResize Review URL: https://codereview.chromium.org/477823003 Cr-Commit-Position: refs/heads/master@{#292228}
* Cleanup: Remove unneeded ui/ grit header includes.thestig2014-08-271-1/+0
| | | | | | | | Command used: for f in `find ui -name *.grd`; do echo GRD: $f; ./tools/unused-grit-header.py $f android_webview apps ash cc chromecast chromeos content chrome extensions gpu media pdf printing remoting webkit; done Review URL: https://codereview.chromium.org/515433002 Cr-Commit-Position: refs/heads/master@{#292226}
* Fixed BubbleBorder sizing problems & added unit tests.bruthig2014-08-271-1/+1
| | | | | | | | | | BUG=395622 TEST=automated Review URL: https://codereview.chromium.org/454173002 Cr-Commit-Position: refs/heads/master@{#292145}
* Split AppListController::SetVisible into Show and Dismiss.calamity2014-08-273-17/+40
| | | | | | | | | | | | This CL is in preparation for passing a reason for showing the app list. This split is necessary to pass a reason only when showing and not when dismissing. BUG=391348 Review URL: https://codereview.chromium.org/485453003 Cr-Commit-Position: refs/heads/master@{#292080}
* Part 3: Merged FakedDBusThreadManager with DBusThreadManager.zelidrag2014-08-274-10/+5
| | | | | | | | | | BUG=401192 TEST=existing tests TBR=sky,stevenjb,keybuk Review URL: https://codereview.chromium.org/477663004 Cr-Commit-Position: refs/heads/master@{#292072}
* Fixes moving fully occluded windows when the a11y keyboard shows.rsadam2014-08-272-5/+21
| | | | | | | | | TEST=WorkspaceLayoutManagerKeyboardTest.AdjustWindowForA11yKeyboard BUG=407094 Review URL: https://codereview.chromium.org/506133002 Cr-Commit-Position: refs/heads/master@{#292056}
* Set the shelf icon title explicitly for settings and task managerstevenjb2014-08-262-5/+8
| | | | | | | | | | | This allows us to set the icon title (used for hovertext) independently of the window title (which is empty for Settings windows). BUG=406954 Review URL: https://codereview.chromium.org/507003002 Cr-Commit-Position: refs/heads/master@{#292029}
* Resize BrowserFrameAsh and not RenderWidgetHostViewAura when keyboard bounds ↵rsadam2014-08-262-24/+77
| | | | | | | | | | | | | change. TextInputClient returns a BrowserFrameAsh is the omnibar is clicked, and RenderWidgetHostViewAura if a textfield on the page is clicked. We always want to resize BrowserFrameAsh. TEST=WorkspaceLayoutManagerKeyboardTest.ChildWindowFocused BUG=407094 Review URL: https://codereview.chromium.org/504793003 Cr-Commit-Position: refs/heads/master@{#292004}
* Use qualified path for grit/ui_strings.htfarina2014-08-253-3/+2
| | | | | | | | | | | | | | | | | | This was generated by the following command line: $ for f in $(g grep -l '"grit/ui_strings.h"' -- '*.cc' '*.mm' '*.h'); do sed -i -e 's/"grit\/ui_strings.h"/"ui\/strings\/grit\/ui_strings.h"/' $f; done $ python ./tools/git/for-all-touched-files.py -c "./tools/sort-headers.py -f [[FILENAME]]" BUG=401588 TEST=None R=thestig@chromium.org,thakis@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/499163002 Cr-Commit-Position: refs/heads/master@{#291700}
* Ash: Double-clicking on a shelf item now opens the itemjamescook2014-08-254-11/+79
| | | | | | | | | | | | | Previously it would open the item then immediately minimize it. This caused user confusion because they tried a double-click and didn't see anything open on the screen. BUG=404060 TEST=ash_unittests ShelfViewTest.ClickingTwiceActivatesOnce Review URL: https://codereview.chromium.org/492963008 Cr-Commit-Position: refs/heads/master@{#291695}
* Ash: Fix browser icon menu model lifetimejamescook2014-08-232-5/+4
| | | | | | | | | | | | The menu model needs to be cleaned up if the menu is suppressed for being too short. BUG=406609 TEST=manual, see bug Review URL: https://codereview.chromium.org/486193004 Cr-Commit-Position: refs/heads/master@{#291600}
* Stop painting when receiving delegated frameenne2014-08-234-23/+27
| | | | | | | | | | | | | | The SchedulePaintInRect call in DelegatedFrameHost is only there to eventually notify an observer on the aura::Window that damage has occurred (for the video detector). Instead, just pass along the damage to the LayerDelegate API and don't schedule a paint. R=jbauman@chromium.org BUG=none Review URL: https://codereview.chromium.org/464643003 Cr-Commit-Position: refs/heads/master@{#291582}
* Fix stale keyboard bounds on login screennkostylev@chromium.org2014-08-222-2/+33
| | | | | | | | | BUG=401667 Review URL: https://codereview.chromium.org/495923002 Cr-Commit-Position: refs/heads/master@{#291281} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291281 0039d316-1c4b-4281-b951-d872f2087c98
* Multiprofile security: Show a warning messagebox when desktopskuhne@chromium.org2014-08-2211-7/+496
| | | | | | | | | | | | | | | | | | | | casting/sharing is turned on upon user switch Purpose of this change: Asks the user with a system modal dialog box if he wants to turn off screen sharing/screen casting and then switch users or abort switching users. BUG=353170 TEST=TrySwitchingUserTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291152 Review URL: https://codereview.chromium.org/496563002 Cr-Commit-Position: refs/heads/master@{#291276} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291276 0039d316-1c4b-4281-b951-d872f2087c98
* Move startup_helper_win.cc to separate target for incremental buildscottmg@chromium.org2014-08-221-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the .cc is included in multiple targets. In incremental builds this results in errors like: [609->8104/8713 ~0] LINK_EMBED unit_tests.exe FAILED: d:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True unit_tests.exe "d:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:unit_tests.exe @unit_tests.exe.rsp" 1 mt.exe rc.exe "obj\chrome\unit_tests.unit_tests.exe.intermediate.manifest" obj\chrome\unit_tests.unit_tests.exe.generated.manifest ..\..\build\win\compatibility.manifest content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl content::InitializeSandboxInfo(struct sandbox::SandboxInterfaceInfo *)" (?InitializeSandboxInfo@content@@YAXPAUSandboxInterfaceInfo@sandbox@@@Z) already defined in test_support_content.startup_helper_win.obj content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl `anonymous namespace'::InvalidParameter(wchar_t const *,wchar_t const *,wchar_t const *,unsigned int,unsigned int)" (?InvalidParameter@?A0xc496daa2@@YAXPB_W00II@Z) already defined in test_support_content.startup_helper_win.obj content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl `anonymous namespace'::PureCall(void)" (?PureCall@?A0xc496daa2@@YAXXZ) already defined in test_support_content.startup_helper_win.obj content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl content::RegisterInvalidParamHandler(void)" (?RegisterInvalidParamHandler@content@@YAXXZ) already defined in test_support_content.startup_helper_win.obj content_app_both.startup_helper_win.obj : error LNK2005: "void __cdecl content::SetupCRT(class base::CommandLine const &)" (?SetupCRT@content@@YAXABVCommandLine@base@@@Z) already defined in test_support_content.startup_helper_win.obj unit_tests.exe : fatal error LNK1169: one or more multiply defined symbols found when incremental_chrome_dll=1 used in Release build. By putting the .cc in a static_library target and depending on it as necessary, rather than including the .cc into multiple places, this is avoided. R=jam@chromium.org TBR=sky@chromium.org BUG=404809 Review URL: https://codereview.chromium.org/470523005 Cr-Commit-Position: refs/heads/master@{#291256} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291256 0039d316-1c4b-4281-b951-d872f2087c98
* Enable subpixel positioning for internal display with dsf larger than 1.0oshima@chromium.org2014-08-214-0/+117
| | | | | | | | | | | | Remove enable-browser-text-subpixel-positioning flag. BUG=388844 TEST=covered by tests Review URL: https://codereview.chromium.org/485873002 Cr-Commit-Position: refs/heads/master@{#291227} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291227 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Multiprofile security: Show a warning messagebox when desktop ↵dewittj@chromium.org2014-08-2111-496/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | casting/sharing is turned on upon user (patchset #3 of https://codereview.chromium.org/496563002/) Reason for revert: Broke Linux ChromiumOS Tests on waterfall: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/47585 Original issue's description: > Multiprofile security: Show a warning messagebox when desktop > casting/sharing is turned on upon user switch > > Purpose of this change: > > Asks the user with a system modal dialog box if he wants to > turn off screen sharing/screen casting and then switch users > or abort switching users. > > BUG=353170 > TEST=TrySwitchingUserTest.* > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291152 TBR=jennyz@chromium.org,jamescook@chromium.org,skuhne@chromium.org NOTREECHECKS=true NOTRY=true BUG=353170 Review URL: https://codereview.chromium.org/473953004 Cr-Commit-Position: refs/heads/master@{#291180} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291180 0039d316-1c4b-4281-b951-d872f2087c98
* Multiprofile security: Show a warning messagebox when desktopskuhne@chromium.org2014-08-2111-7/+496
| | | | | | | | | | | | | | | | | | casting/sharing is turned on upon user switch Purpose of this change: Asks the user with a system modal dialog box if he wants to turn off screen sharing/screen casting and then switch users or abort switching users. BUG=353170 TEST=TrySwitchingUserTest.* Review URL: https://codereview.chromium.org/496563002 Cr-Commit-Position: refs/heads/master@{#291152} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291152 0039d316-1c4b-4281-b951-d872f2087c98
* Restore window size after accessbility keyboard hides.wnwen@chromium.org2014-08-212-16/+33
| | | | | | | | | | | | | | | | | | | BUG=366886 R=kevers@chromium.org TEST: Open any non-maximized window covering at least the lower portion of the screen (so that normally on-screen keyboard would obscure part of the window). Turn on accessibility keyboard. Click on a text box, notice that keyboard shows up and window is resized so keyboard does not obscure any part of it. Click outside the text box (defocus), keyboard disappears and window bounds are restored to state before the keyboard showed up. Review URL: https://codereview.chromium.org/468923002 Cr-Commit-Position: refs/heads/master@{#291087} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291087 0039d316-1c4b-4281-b951-d872f2087c98
* Use a different button to restore and maximize windows on Ashpkotwicz@chromium.org2014-08-209-9/+28
| | | | | | | | | | | | BUG=401175 TEST=Manual, see bug R=jamescook TBR=oshima (asset additions) Review URL: https://codereview.chromium.org/473323002 Cr-Commit-Position: refs/heads/master@{#290885} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290885 0039d316-1c4b-4281-b951-d872f2087c98
* Rotation Locked saved through device shutdownjonross@chromium.org2014-08-206-20/+95
| | | | | | | | | | | | Add display rotation preferences to DisplayPreferences. Save the current rotation locked state, along with the screen orientation. These are re-applied upon device reboot, while the device is in maximize mode. Leaving maximize mode clears these settings. TEST=DisplayPreferencesTest.StoreRotationStateNoLogin, DisplayPreferencesTest.StoreRotationStateGuest, DisplayPreferencesTest.StoreRotationStateNormalUser, DisplayPreferencesTest.LoadRotationNoLogin, DisplayPreferencesTest.LoadRotationIgnoredInNormalMode, DisplayPreferencesTest.RotationLockTriggersSTore BUG=chrome-os-partner:30681 Review URL: https://codereview.chromium.org/440773005 Cr-Commit-Position: refs/heads/master@{#290842} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290842 0039d316-1c4b-4281-b951-d872f2087c98
* [New assets] Use different button to restore and maximize windows on Ashpkotwicz@chromium.org2014-08-208-0/+0
| | | | | | | | | | | | | This CL lands the new assets for https://codereview.chromium.org/473323002/ BUG=401175 TEST=None TBR=jamescook Review URL: https://codereview.chromium.org/489843002 Cr-Commit-Position: refs/heads/master@{#290838} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290838 0039d316-1c4b-4281-b951-d872f2087c98
* Change type of drag-drop window to popupmohsen@chromium.org2014-08-201-1/+3
| | | | | | | | | | | | | Currently, the window for drag-drop is a normal window. This is not right and cuases a few issues (e.g. see crbug.com/404634). This patch changes the type to popup. BUG=404634 Review URL: https://codereview.chromium.org/472373006 Cr-Commit-Position: refs/heads/master@{#290753} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290753 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ui::SHOW_STATE_DETACHED and related thingstapted@chromium.org2014-08-195-6/+0
| | | | | | | | | | | | | | | | | Removes enum values ui::SHOW_STATE_DETACHED and wm::WINDOW_STATE_TYPE_DETACHED, and bool NativeAppWindow::IsDetached(). These were added a year ago in r198918 but nothing currently uses them. PersistedWindowShowState is added in session_service.cc to decouple the on-disk state from the enum in ui_base_types.h. BUG=233556 Review URL: https://codereview.chromium.org/337243005 Cr-Commit-Position: refs/heads/master@{#290526} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290526 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce new WebApp header style for hosted apps and fizzy apps on ash.benwells@chromium.org2014-08-1911-62/+67
| | | | | | | | | | | | | | The new header style currently has a back button and a title, as well as the normal caption buttons (minimize, maximize / restore, close). The new header style is only used in --enable-streamlined-hosted-apps is enabled. BUG=368372 Review URL: https://codereview.chromium.org/441803004 Cr-Commit-Position: refs/heads/master@{#290502} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290502 0039d316-1c4b-4281-b951-d872f2087c98
* Add new binaries for chromeos for web app style app frames.benwells@chromium.org2014-08-194-0/+0
| | | | | | | | | | | | These are the binaries from https://codereview.chromium.org/441803004/ TBR=oshima BUG=368372 Review URL: https://codereview.chromium.org/479083003 Cr-Commit-Position: refs/heads/master@{#290462} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290462 0039d316-1c4b-4281-b951-d872f2087c98
* Fix app list toggling causing app list to change position.calamity@chromium.org2014-08-191-1/+1
| | | | | | | | | | | | This CL fixes an issue where clicking the app list button would cause the app list to move down. This was introduced by r289889. BUG=404538 Review URL: https://codereview.chromium.org/482633002 Cr-Commit-Position: refs/heads/master@{#290458} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290458 0039d316-1c4b-4281-b951-d872f2087c98
* Use a qualified path for ui_resources.h grit includes.tfarina@chromium.org2014-08-177-7/+6
| | | | | | | | | | | | BUG=401588 TEST=None R=thestig@chromium.org,thakis@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/480693002 Cr-Commit-Position: refs/heads/master@{#290178} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290178 0039d316-1c4b-4281-b951-d872f2087c98
* Updating XTBs based on .GRDs from branch 2062amineer@chromium.org2014-08-1511-11/+11
| | | | | Cr-Commit-Position: refs/heads/master@{#289925} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289925 0039d316-1c4b-4281-b951-d872f2087c98
* Split Shell::ToggleAppList() into ShowAppList and DismissAppList.calamity@chromium.org2014-08-159-32/+48
| | | | | | | | | | | | | This CL is in preparation for passing a reason for showing the app list. This split is necessary to pass a reason only when showing and not when dismissing. BUG=None Review URL: https://codereview.chromium.org/460933002 Cr-Commit-Position: refs/heads/master@{#289889} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289889 0039d316-1c4b-4281-b951-d872f2087c98
* Replace redundant frame images with a color constant.benwells@chromium.org2014-08-157-39/+22
| | | | | | | | | | | | | | | The frame images are just a single color in all pixels. Using a constant makes it easier to support other colors for the frame, which we want to do for both packaged apps and service worker based apps. BUG=400958 TEST=Make sure packaged app and hosted app frames on ChromeOS look like they did before this change. Review URL: https://codereview.chromium.org/447663002 Cr-Commit-Position: refs/heads/master@{#289808} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289808 0039d316-1c4b-4281-b951-d872f2087c98
* Disable core keyboard device as well when entering touchview.flackr@chromium.org2014-08-142-0/+11
| | | | | | | | | | | | Repeated keypress events seem to be coming from the core keyboard device for the internal keyboard. Amazingly, they seem to come from the correct device (for my external keyboard at least) so this patch may be all we need. BUG=402868 TEST=Flip open device past 180 to enter touchview. Hold a key on keyboard. Key is not typed. External keyboard still works while in touchview. Review URL: https://codereview.chromium.org/460093003 Cr-Commit-Position: refs/heads/master@{#289524} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289524 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Remove a few unused includes.thakis@chromium.org2014-08-1418-21/+1
| | | | | | | | | | | See https://codereview.chromium.org/467193003/ for how. BUG=none Review URL: https://codereview.chromium.org/470663002 Cr-Commit-Position: refs/heads/master@{#289472} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289472 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-15 08:00:50 +0000