summaryrefslogtreecommitdiffstats
path: root/ash
Commit message (Collapse)AuthorAgeFilesLines
* Some cleanup and a small bug in the WorkspaceLayoutManagerskuhne@chromium.org2014-03-062-13/+5
| | | | | | | | | BUG=- TEST=- Review URL: https://codereview.chromium.org/188743003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255461 0039d316-1c4b-4281-b951-d872f2087c98
* Move WriteFile and WriteFileDescriptor from file_util to base namespace.brettw@chromium.org2014-03-061-1/+1
| | | | | | | | | R=viettrungluu@chromium.org TBR=viettrungluu Review URL: https://codereview.chromium.org/184563006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255418 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Remove client::UserActionClient.sadrul@chromium.org2014-03-067-23/+0
| | | | | | | | | | | | | | | | | | | UserActionClient is used to navigate back/forward when the back/forward on a supported mouse-device is clicked on X11. This can instead be achieved by installing an event-handler on the browser window. This does change the behaviour a little on ChromeOS: clicking these navigation buttons when the cursor is not on top of the browser window will not navigate after this change. I have confirmed with UX that this is a desirable change. BUG=319636 R=sky@chromium.org Previously landed in r255385, reverted in r255398 to allow another revert in r255399. Review URL: https://codereview.chromium.org/183853037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255416 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 255368 "Clean up WindowEventDispatcher some more."ben@chromium.org2014-03-066-4/+4
| | | | | | | | | | | | | | | | | | | > Clean up WindowEventDispatcher some more. > > . Eliminate the implementation of LayerAnimationObserver. It seems no one expects WED to be a LAO anymore. > . Remove WindowTreeHostDelegate. This involves moving some of the functions to WTH, removing some completely, and moving the remainder to the WED public API. A little icky for now, but I plan to take a pass on cleaning up WED's public API once I get it pared down. > . window_tree_host_x11_unittest provided an implementation of WTHD that was not WED. This is not a valid situation now since various functions in WTH now call directly through to WED. Replaced this with a simple EventHandler to test that events are being dispatched. > > R=sky@chromium.org > http://crbug.com/308843 > > Review URL: https://codereview.chromium.org/188223002 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/188843003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255399 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 255385 "aura: Remove client::UserActionClient."ben@chromium.org2014-03-067-0/+23
| | | | | | | | | | | | | | | | | | | | | | | > aura: Remove client::UserActionClient. > > UserActionClient is used to navigate back/forward when the back/forward on a > supported mouse-device is clicked on X11. This can instead be achieved by > installing an event-handler on the browser window. > > This does change the behaviour a little on ChromeOS: clicking these navigation > buttons when the cursor is not on top of the browser window will not navigate > after this change. I have confirmed with UX that this is a desirable change. > > BUG=319636 > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/183853037 TBR=sadrul@chromium.org Review URL: https://codereview.chromium.org/186123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255398 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Remove client::UserActionClient.sadrul@chromium.org2014-03-067-23/+0
| | | | | | | | | | | | | | | | | UserActionClient is used to navigate back/forward when the back/forward on a supported mouse-device is clicked on X11. This can instead be achieved by installing an event-handler on the browser window. This does change the behaviour a little on ChromeOS: clicking these navigation buttons when the cursor is not on top of the browser window will not navigate after this change. I have confirmed with UX that this is a desirable change. BUG=319636 R=sky@chromium.org Review URL: https://codereview.chromium.org/183853037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255385 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up WindowEventDispatcher some more.ben@chromium.org2014-03-066-4/+4
| | | | | | | | | | | | | . Eliminate the implementation of LayerAnimationObserver. It seems no one expects WED to be a LAO anymore. . Remove WindowTreeHostDelegate. This involves moving some of the functions to WTH, removing some completely, and moving the remainder to the WED public API. A little icky for now, but I plan to take a pass on cleaning up WED's public API once I get it pared down. . window_tree_host_x11_unittest provided an implementation of WTHD that was not WED. This is not a valid situation now since various functions in WTH now call directly through to WED. Replaced this with a simple EventHandler to test that events are being dispatched. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/188223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255368 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Enable the volume slider in Ash for windows. ↵pkotwicz@chromium.org2014-03-068-221/+1
| | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/178883004/) Reason for revert: Experimentally reverting this CL because it may have broken AshTestHelperTest.AshTestHelper on Windows Vista . Will revert the revert if this CL is innocent See http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%282%29/builds/41640/steps/ash_unittests/logs/AshTestHelper Original issue's description: > Enable the volume slider in Ash for windows. > > BUG=227247 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255215 TBR=henrika@chromium.org,tommi@chromium.org,jennyz@chromium.org,dewittj@chromium.org,zturner@chromium.org NOTREECHECKS=true NOTRY=true BUG=227247 Review URL: https://codereview.chromium.org/188693004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255363 0039d316-1c4b-4281-b951-d872f2087c98
* Add LogoutConfirmationController to show LogoutConfirmationDialogsbartfab@chromium.org2014-03-0621-690/+696
| | | | | | | | | | | | | | LogoutButtonTray uses and owns LogoutConfirmationDialogView, a dialog that asks the user to confirm or deny logout. This CL generalizes the dialog and moves its ownership to a LogoutConfirmationController accessible via ash::Shell, allowing other classes to show the same dialog. BUG=278247 TEST=Updated unit tests Review URL: https://codereview.chromium.org/178183005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255316 0039d316-1c4b-4281-b951-d872f2087c98
* Add a11y virtual keyboard icon when a11y VK is enabledbshe@chromium.org2014-03-069-0/+220
| | | | | | | | | | | This CL adds a virtual keyboard icon when a11y VK is enabled. Click or tap on the icon will force the VK to show and lock. BUG=346695 Review URL: https://codereview.chromium.org/177123016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255307 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the volume slider in Ash for windows.zturner@chromium.org2014-03-068-1/+221
| | | | | | | | BUG=227247 Review URL: https://codereview.chromium.org/178883004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255215 0039d316-1c4b-4281-b951-d872f2087c98
* Add use_allocator instead of linux_use_tcmalloc to switch the allocator.dmikurube@chromium.org2014-03-051-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change is to add a new build option 'use_allocator' which will replace 'linux_use_tcmalloc' in the future. It doesn't change the behavior immediately. The migration plan is as follows: 1) (this change) ... Add 'use_allocator' and set its default to "see_use_tcmalloc". ... Change allocator conditions to check use_allocator firstly. ... Use linux_use_tcmalloc if use_allocator=="see_use_tcmalloc". ... NO IMPACT without specifying use_allocator explicitly. 2) Change Blink to accept use_allocator. http://crrev.com/177053003/ 3) Change gyp to accept use_allocator. http://crrev.com/178643004/ 4) PSA the transition period to chromium-dev@. 5) (after the PSA-ed transition period) ... Make 'use_allocator' to "tcmalloc" or "none" (it depends) by default. ... Remove all linux_use_tcmalloc. ... Assert in gyp_chromium to check if linux_use_tcmalloc is not specified. At the point of this change (1), linux_use_tcmalloc is still used by default because 'use_allocator%': "see_use_tcmalloc". As written in http://crbug.com/345554, linux_use_tcmalloc would be confusing to have more options about allocators. We plan to: A) enable gperftools' heap-profiler with non-tcmalloc allocator, B) add a new memory allocator instead of tcmalloc. BUG=345554, 339604, 341349 R=agl@chromium.org, brettw@chromium.org, dgarrett@chromium.org, jam@chromium.org, jamesr@chromium.org, joi@chromium.org, miket@chromium.org, nick@chromium.org, rsleevi@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, shess@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, willchan@chromium.org Review URL: https://codereview.chromium.org/177353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255129 0039d316-1c4b-4281-b951-d872f2087c98
* Add sticky key support for AltGrzork@chromium.org2014-03-054-0/+20
| | | | | | | | BUG=335368 Review URL: https://codereview.chromium.org/175343007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255116 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RootWindowObserver -> WindowTreeHostObserver.ben@chromium.org2014-03-0512-72/+53
| | | | | | | | | | | Move observer management and notification to WTH. R=sky@chromium.org http://crbug.com/348874 Review URL: https://codereview.chromium.org/186423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255108 0039d316-1c4b-4281-b951-d872f2087c98
* Make Chrome OS virtual keyboard to work with cursor compositing.hshi@chromium.org2014-03-054-5/+38
| | | | | | | | | | | | | | | | | | Explicitly define container IDs for the parent container of the virtual keyboard, as well as the mouse cursor container. This is to ensure the correct ordering in which containers are stacked together. Specifically the virtual keyboard parent container should be above all non-lock screen, lock screen and lock screen related containers, but below the mouse cursor container, which sits immediately below the power animation container. BUG=347304 TEST=trybots and manual verification. R=kevers@chromium.org, oshima@chromium.org Review URL: https://codereview.chromium.org/186673008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255096 0039d316-1c4b-4281-b951-d872f2087c98
* Disallow maximize mode managed windows to be draggedskuhne@chromium.org2014-03-055-8/+75
| | | | | | | | | BUG=348818 TEST=unittest & visual test Review URL: https://codereview.chromium.org/185713011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255015 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ash audio menu related switches.jennyz@chromium.org2014-03-056-38/+15
| | | | | | | | BUG=348784 Review URL: https://codereview.chromium.org/184983004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254964 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce WMEvent classoshima@chromium.org2014-03-0527-271/+412
| | | | | | | | | | | | * Moved out SnapEdge enum from SnapSizer class * Moved SnapWindow logic completely inside DefaultState * Further simplified the bounds calculation for snapped window. BUG=318325 Review URL: https://codereview.chromium.org/168573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254922 0039d316-1c4b-4281-b951-d872f2087c98
* Bluetooth: show notification when adapter is discoverablekeybuk@chromium.org2014-03-053-0/+52
| | | | | | | | | | | | | | | | Certain white-listed apps will be allowed to make the adapter discoverable to other nearby devices, we may also permit the user to make the adapter discoverable as well. For users security, inform them if the adapter is in this state when they login, or when the adapter moves into this state. BUG=239801 TEST=using bt_console, enter 'discoverable on' Review URL: https://codereview.chromium.org/184783004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254881 0039d316-1c4b-4281-b951-d872f2087c98
* Bluetooth: show notification when device is pairedkeybuk@chromium.org2014-03-042-4/+35
| | | | | | | | | | | | | | Chrome OS security team are concerned that users may not be aware that pairing a device makes it available to all users of the system. Use the notification popups to inform of that after pairing, as agreed with the security team. BUG=239801 TEST=chromeos=1 on Linux, pair a device Review URL: https://codereview.chromium.org/184963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254839 0039d316-1c4b-4281-b951-d872f2087c98
* Remove |disable_drawing| flag from GLSurface::InitializeOneOffForTests.danakj@chromium.org2014-03-041-1/+1
| | | | | | | | | | | | This flag is always passed as true now that all test suites opt in for it, so we can remove it. R=sievers, sky, joi BUG=270918 Review URL: https://codereview.chromium.org/176843008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254837 0039d316-1c4b-4281-b951-d872f2087c98
* Use detailed time format in session length / logout confirmationtnagel@chromium.org2014-03-042-14/+9
| | | | | | | | | | | | At that occasion, remove explicit rounding in logout confirmation because rounding to nearest int is handled by the time formatting functions since 2dd24c86 (Jan 30 2014). BUG=264361 Review URL: https://codereview.chromium.org/184943003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254825 0039d316-1c4b-4281-b951-d872f2087c98
* Rename WMEventType to match the style.oshima@chromium.org2014-03-046-82/+87
| | | | | | | | | BUG=319325 R=abodenha@chromium.org Review URL: https://codereview.chromium.org/186653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254815 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the ash switch ash-disable-usb-charger-notification.jennyz@chromium.org2014-03-043-14/+1
| | | | | | | | | BUG=348787 R=mukai@chromium.org Review URL: https://codereview.chromium.org/181063023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254800 0039d316-1c4b-4281-b951-d872f2087c98
* Bluetooth: notify user of incoming pairing requestskeybuk@chromium.org2014-03-049-2/+429
| | | | | | | | | | | | | | Implement a low-priority pairing delegate in the form of an Aura Status Tray Notification Controller that displays a rich notification when an incoming pairing request is received and allows the user to accept or reject it when appropriate. BUG=345535 TESTS=chromeos=1 on Linux presents fake pairing requests Review URL: https://codereview.chromium.org/183853010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254697 0039d316-1c4b-4281-b951-d872f2087c98
* Adding Overview mode started / ended observable events to the shellskuhne@chromium.org2014-03-044-3/+30
| | | | | | | | | | | | Splitting my CL for the backdrop creation into smaller fragments. This portion is adding an observable event to the shell which allows to monitor overview mode de-/activations. BUG=337567 TEST=none Review URL: https://codereview.chromium.org/185423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254664 0039d316-1c4b-4281-b951-d872f2087c98
* Window ownership -> WindowTreeHostben@chromium.org2014-03-0442-170/+170
| | | | | | | | | | | | | Replaces Window::GetDispatcher with Window::GetHost(). Had to clear ScreenPositionClient property prior to window teardown as tests on desktop delete it prior to destroying the window hierarchy. Unhooking the property appears to have no ill-effect. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/184903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254642 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed problem with missing maximized mode destructor. Odd must have been ↵skuhne@chromium.org2014-03-041-0/+4
| | | | | | | | | | | | | removed by a merge operation. Very odd. This was there - but somehow it got lost. Must have been some merge operation. BUG=348070 TEST=manual Review URL: https://codereview.chromium.org/185393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254613 0039d316-1c4b-4281-b951-d872f2087c98
* Move TrimWhitespace to the base namespace.brettw@chromium.org2014-03-031-1/+1
| | | | | | | | R=viettrungluu@chromium.org, viettrungluu Review URL: https://codereview.chromium.org/183853011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254521 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on the alternate caption button style by default.pkotwicz@chromium.org2014-03-033-20/+16
| | | | | | | | | | | | | | The alternate caption button style - Has a dedicated minimize button - Does not have a help bubble for the maximize button - Crossfades the minimize buttons into buttons for snapping left and right after pressing and holding the size button BUG=None TEST=None Review URL: https://codereview.chromium.org/183753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254496 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup shill_stub_helper, GetSharedProfilePath -> ShillProfileClientstevenjb@chromium.org2014-03-031-1/+1
| | | | | | | | | | | Also replaces IsStubPortalledWifiEnabled() with more robust logic. BUG=345033 R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/183033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254492 0039d316-1c4b-4281-b951-d872f2087c98
* Added a special badge to wifi-networks behind a captive portal.ygorshenin@google.com2014-03-0315-5/+114
| | | | | | | | | | | | BUG=240237 TEST=manual tests on Lumpy R=oshima@chromium.org, stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254079 Review URL: https://codereview.chromium.org/175053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254447 0039d316-1c4b-4281-b951-d872f2087c98
* Removal of drag window to user tray icon functionalityskuhne@chromium.org2014-03-0315-426/+14
| | | | | | | | | BUG=348133 TEST=let it run and compiled - removal of code Review URL: https://codereview.chromium.org/184113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254435 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the crash in ShelfView::UpdateDragIconProxy.jennyz@chromium.org2014-03-011-2/+6
| | | | | | | | | BUG=347222 R=skuhne@chromium.org, xiyuan@chromium.org Review URL: https://codereview.chromium.org/185003004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254317 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Ash:Shelf - Cleanup of Alternate Shelf (part 1) ↵dgrogan@chromium.org2014-03-0148-301/+1171
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/140323010/) Reason for revert: Broke Linux ChromiumOS Builder (dbg): http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/45933/steps/compile/logs/stdio FAILED: /b/build/goma/gomacc c++ -MMD -MF obj/ash/system/web_notification/ash.web_notification_tray.o.d .... ../../ash/system/web_notification/web_notification_tray.cc: In constructor 'ash::WebNotificationTray::WebNotificationTray(ash::internal::StatusAreaWidget*)': ../../ash/system/web_notification/web_notification_tray.cc:322:7:error: 'UseAlternateShelfLayout' is not a member of 'ash::switches' ../../ui/message_center/message_center_style.h: At global scope: ../../ui/message_center/message_center_style.h:103:15:error: 'message_center::kButtonSeparatorColor' defined but not used [-Werror=unused-variable] ../../ui/message_center/message_center_style.h:104:15:error: 'message_center::kHoveredButtonBackgroundColor' defined but not used [-Werror=unused-variable] ../../ui/message_center/message_center_style.h:111:15:error: 'message_center::kProgressBarBackgroundColor' defined but not used [-Werror=unused-variable] ../../ui/message_center/message_center_style.h:112:15:error: 'message_center::kProgressBarSliceColor' defined but not used [-Werror=unused-variable] ../../ui/message_center/message_center_style.h:43:15:error: 'message_center::settings::kEntrySeparatorColor' defined but not used [-Werror=unused-variable] Original issue's description: > Part 1) of cleaning up the code related to the shelf layout, specifically removing all instances of branching related to the 'alternate shelf layout' as this is now the only option. > Removed the about:flags entry relating to alternate shelf layout. > > A patch will follow to simplify the remaining layout code as it is still a bit of a spaghetti like mess. > > R=jamescook@chromium.org, skuhne@chromium.org > TBR=miket@chromium.org > BUG=338429 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254301 TBR=jamescook@chromium.org,skuhne@chromium.org,harrym@chromium.org NOTREECHECKS=true NOTRY=true BUG=338429 Review URL: https://codereview.chromium.org/185143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254306 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1) of cleaning up the code related to the shelf layout, specifically ↵harrym@chromium.org2014-03-0148-1171/+301
| | | | | | | | | | | | | | | | removing all instances of branching related to the 'alternate shelf layout' as this is now the only option. Removed the about:flags entry relating to alternate shelf layout. A patch will follow to simplify the remaining layout code as it is still a bit of a spaghetti like mess. R=jamescook@chromium.org, skuhne@chromium.org TBR=miket@chromium.org BUG=338429 Review URL: https://codereview.chromium.org/140323010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254301 0039d316-1c4b-4281-b951-d872f2087c98
* Converts MessagePopupCollection into a long-lived object (2nd).mukai@chromium.org2014-02-281-12/+11
| | | | | | | | | | | | | | | | | | | | | | This improves the behavior since there were several scenarios where observer methods would cause re-entrancy into the destructor of MessagePopupCollection. Since it observes MessageCenter, it knows when it should show popups and when it shouldn't. This CL is based on dewittj's crrev.com/114553002 with a fix for some tests in linux-aura and win because of screen_aura. This is the reland of r254101 with a fix on tests. The previous CL broke some tests because the initialization delay reset their test expectations. BUG=327363 TBR=dewittj@chromium.org, stevenjb@chromium.org TEST=message_center_unittests on linux_chromeos Review URL: https://codereview.chromium.org/184843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254234 0039d316-1c4b-4281-b951-d872f2087c98
* Remove --ash-disable-drag-and-drop-applist-to-launcheroshima@chromium.org2014-02-283-10/+2
| | | | | | | | BUG=340466 Review URL: https://codereview.chromium.org/182633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254230 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Start/Stop in OutputConfigurator to better reflect their intentdnicoara@chromium.org2014-02-282-4/+3
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/181483004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254180 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Converts MessagePopupCollection into a long-lived object. ↵erikwright@chromium.org2014-02-281-11/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/180513002/) Reason for revert: Possible cause of build breakage: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/40180 http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/40180/steps/message_center_unittests/logs/LeftPositioningWithLeftTaskbar MessagePopupCollectionTest.LeftPositioningWithLeftTaskbar (run #1): [ RUN ] MessagePopupCollectionTest.LeftPositioningWithLeftTaskbar Xlib: extension "RANDR" missing on display ":9". ../../ui/message_center/views/message_popup_collection_unittest.cc:341: Failure Expected: (r1.x()) \u003C (GetWorkArea().CenterPoint().x()), actual: 433 vs 400 [ FAILED ] MessagePopupCollectionTest.LeftPositioningWithLeftTaskbar (430 ms) Original issue's description: > Converts MessagePopupCollection into a long-lived object. > > This improves the behavior since there were several scenarios where > observer methods would cause re-entrancy into the destructor of > MessagePopupCollection. Since it observes MessageCenter, it knows when > it should show popups and when it shouldn't. > > This CL is based on dewittj's crrev.com/114553002 with a fix > for some tests in linux-aura and win because of screen_aura. > > BUG=327363 > R=dewittj@chromium.org, stevenjb@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254101 TBR=dewittj@chromium.org,stevenjb@chromium.org,mukai@chromium.org NOTREECHECKS=true NOTRY=true BUG=327363 Review URL: https://codereview.chromium.org/183883006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254145 0039d316-1c4b-4281-b951-d872f2087c98
* Remove --ash-memory-monitor and related codeoshima@chromium.org2014-02-286-169/+0
| | | | | | | | BUG=340466 Review URL: https://codereview.chromium.org/182063003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254128 0039d316-1c4b-4281-b951-d872f2087c98
* Make the minimize and close button crossfade animations end simultaneously. ↵pkotwicz@chromium.org2014-02-284-16/+25
| | | | | | | | | | | This was previously not the case when a user pressed the size button and quickly dragged left to hover the minimize button. BUG=None TEST=None Review URL: https://codereview.chromium.org/176403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254115 0039d316-1c4b-4281-b951-d872f2087c98
* Converts MessagePopupCollection into a long-lived object.mukai@chromium.org2014-02-281-12/+11
| | | | | | | | | | | | | | | | | This improves the behavior since there were several scenarios where observer methods would cause re-entrancy into the destructor of MessagePopupCollection. Since it observes MessageCenter, it knows when it should show popups and when it shouldn't. This CL is based on dewittj's crrev.com/114553002 with a fix for some tests in linux-aura and win because of screen_aura. BUG=327363 R=dewittj@chromium.org, stevenjb@chromium.org Review URL: https://codereview.chromium.org/180513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254101 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 254089 "Use the default dispatcher where possible for nes..."sadrul@chromium.org2014-02-284-20/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is still breaking interactive-ui-tests on the win-dbg buildbots. > Use the default dispatcher where possible for nested message loops. > > Notable changes: > * Add QuitNestedMessageLoop() to client::DispatcherClient, which can be used to > terminate a nested loop started by RunWithDispatcher(). > * FirstRunDialog and SimpleMessageBoxViews are no longer > MessagePumpDispatchers. The default dispatcher is used instead, and > QuitNestedMessageLoop() is called to terminate the loop instead of returning > POST_DISPATCH_QUIT_LOOP from the Dispatch() override. > > BUG=none > R=sky@chromium.org > > Previously committed in r253723, but reverted in r253744 because it broke > interactive_ui_tests on win-dbg. > > Review URL: https://codereview.chromium.org/182143002 TBR=sadrul@chromium.org Review URL: https://codereview.chromium.org/183683006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254095 0039d316-1c4b-4281-b951-d872f2087c98
* Use the default dispatcher where possible for nested message loops.sadrul@chromium.org2014-02-284-5/+20
| | | | | | | | | | | | | | | | | | | | Notable changes: * Add QuitNestedMessageLoop() to client::DispatcherClient, which can be used to terminate a nested loop started by RunWithDispatcher(). * FirstRunDialog and SimpleMessageBoxViews are no longer MessagePumpDispatchers. The default dispatcher is used instead, and QuitNestedMessageLoop() is called to terminate the loop instead of returning POST_DISPATCH_QUIT_LOOP from the Dispatch() override. BUG=none R=sky@chromium.org Previously committed in r253723, but reverted in r253744 because it broke interactive_ui_tests on win-dbg. Review URL: https://codereview.chromium.org/182143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254089 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Honor power button when in docked mode.derat@chromium.org2014-02-284-9/+98
| | | | | | | | | | | | Ash ignores power button events while the display's brightness is set to 0%. Make it honor them if an external display is still on. BUG=chrome-os-partner:24912 Review URL: https://codereview.chromium.org/177043004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254087 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 254079 "Added a special badge to wifi-networks behind a c..."ygorshenin@google.com2014-02-2815-114/+5
| | | | | | | | | | | | | | | | > Added a special badge to wifi-networks behind a captive portal. > > BUG=240237 > TEST=manual tests on Lumpy > R=oshima@chromium.org, stevenjb@chromium.org > > Review URL: https://codereview.chromium.org/175053003 TBR=ygorshenin@google.com Review URL: https://codereview.chromium.org/180613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254086 0039d316-1c4b-4281-b951-d872f2087c98
* Added a special badge to wifi-networks behind a captive portal.ygorshenin@google.com2014-02-2815-5/+114
| | | | | | | | | | BUG=240237 TEST=manual tests on Lumpy R=oshima@chromium.org, stevenjb@chromium.org Review URL: https://codereview.chromium.org/175053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254079 0039d316-1c4b-4281-b951-d872f2087c98
* Invert the ownership relationship between WindowEventDispatcher and ↵ben@chromium.org2014-02-2810-135/+111
| | | | | | | | | | | | | | | | | WindowTreeHost. Prior to this change, WindowEventDispatcher owns WindowTreeHost. Code wishing to own an aura::Window hierarchy must create a WindowEventDispatcher, which will either create a default WTH implementation or use the one supplied by the caller. This relationship made more sense long ago in the days when WED was called RootWindow, and served a purpose broader than just event dispatch bookkeeping. Those days are gone. For code using Aura, it makes more sense for them to create the WTH directly. I predict this may permit some simplification of shutdown code in some situations, since I think it is more intuitive to think of the destruction cascade initiating at the object that most closely binds to the platform accelerated widget. Today, ownership of the window tree sits with WED, which must destroy the window tree and the host. This CL attempts to make as few changes as possible to invert the ownership. The effect of this is that there is a bunch of code left that probably only needs a WTH but instead has a WED. I will get around to cleaning these up in a future CL. http://crbug.com/308843 R=sky@chromium.org Review URL: https://codereview.chromium.org/180003006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254071 0039d316-1c4b-4281-b951-d872f2087c98
* Add a window parameter to WindowDelegate's OnWindowDestroying/Destroyed methods.ben@chromium.org2014-02-284-7/+7
| | | | | | | | | | | This aligns this aspect of WindowDelegate with WindowObserver, that I hope to replace this part of WD with in the future. It also allows me to clean up a little bit of the DWTH/DNWA interaction (subsequent CL). BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/183143006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253983 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 10:14:52 +0000