| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By exposing the status area, we will be able to use the date button
in the status tray menu to launch the Set Time UI when that is ready.
To make the status menu and network screen play nicely, this CL:
* wires up changes from the input method tray item to the network screen's keyboard select
* allows detailed tray items in OOBE, so the accessibility notification shows correctly when enabled via hotkey
BUG=363870
TEST=browser_tests::WizardControllerFlowTest.ControlFlowMainBrowser
R=nkostylev@chromium.org,stevenjb@chromium.org
TBR=derat@chromium.org
Review URL: https://codereview.chromium.org/239083004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original description from r265125:
1- Remove exclusion rule for cocoa files, this target does not have more
cocoa files.
2- Remove dependency on chromeos library, this target does not need to
link with them anymore.
It was reverted in r265137 because it caused a breakage in ash_unittests in
chromeos build, not sure why CQ didn't catch this.
obj/ash/display/ash_unittests.projecting_observer_chromeos_unittest.o:projecting_observer_chromeos_unittest.cc:function
testing::internal::TestFactoryImpl<ash::ProjectingObserverTest_CheckStopProjectingAfterDisconnectingSecondOutput_Test>::CreateTest():
error: undefined reference to
'chromeos::FakePowerManagerClient::FakePowerManagerClient()'
obj/ash/display/ash_unittests.projecting_observer_chromeos_unittest.o:projecting_observer_chromeos_unittest.cc:function
testing::internal::TestFactoryImpl<ash::ProjectingObserverTest_CheckStopProjectingAfterClosingAllCastingSessions_Test>::CreateTest():
error: undefined reference to
'chromeos::FakePowerManagerClient::FakePowerManagerClient()'
BUG=331829
TEST=ui_unittests,content_unittests,ash_unittests links
TBR=ben@chromium.org,nona@chromium.org,avi@chromium.org
Review URL: https://codereview.chromium.org/246283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
size when leaving the maximized mode
BUG=364950
TEST=ash test & visual control
Review URL: https://codereview.chromium.org/244653006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't have to have a container for IME separately, the settings
bubble container is better for the IME UIs.
This switch also makes the following effects:
- IME UIs would appear in the lock screen / login screen
- IME UIs wouldn't move across the root window when removed (like
display state switch among mirroring<->extended)
The first is good, because we can show the mode indicator when
switching the layout between qwerty and Dvorak. Candidate windows
will not appear in lock/login screen anyways.
The second seems no problem because IME UIs are more ephemeral
anyways. People won't get frustrated if disappears in such situation.
They will re-appear when the user types another key.
BUG=364667
R=oshima@chromium.org, shuchen@chromium.org
Review URL: https://codereview.chromium.org/245783003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=356883
TEST=ash_unittests --gtest_filter=WindowPositionerTest.SecondMaximizedWindowHasProperRestoreSize
Review URL: https://codereview.chromium.org/233323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IdleActionImminent signals sent by powerd now include the
remaining time until the idle action will be performed; make
PowerManagerClient decode it and pass it to observers.
Also update PowerManagerClient to listen for SuspendDone
signals rather than SuspendStateChanged; the latter is
confusing and will be removed soon.
Updates the system_api dependency to a9acc4df.
BUG=287787,359619
TBR=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/240343004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes an issue where the shelf id for browser windows was
getting set directly by BrowserStatusMonitor regardless of whether the
browser window was represented by BrowserShortcutLauncherItemController,
causing strange shelf behavior.
BUG=359816
Review URL: https://codereview.chromium.org/237693003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window when the mouse is pressed.
BUG=364337
TBR=xiyuan
Review URL: https://codereview.chromium.org/241643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Chrome side that
1- removes windows 8 specific checks
2- disconnects the fake window_tree_host_win
3- connects the remote_window_tree_host_win
With this change you can now see the ash desktop but not interact with
it since input events have not been enabled.
Here is the second part
https://codereview.chromium.org/211863003/
First part with rationale:
https://codereview.chromium.org/199843004/
Note: this is a redo & rebase of
https://codereview.chromium.org/227573007/
BUG=356475
TEST=none
patch from issue 235683005
BUG=
Review URL: https://codereview.chromium.org/235933004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Synthetic mouse events should be generated when window bounds changes such
that the cursor previously outside the window becomes inside, or vice versa,
but subject to the following conditions:
- If one or more mouse buttons is down, we should synthesize MOUSE_DRAGGED
event instead of MOUSE_MOVED, and also set the appropriate mouse button flags.
- Do not generate synthesized mouse move events for windows that ignore events, such
as the cursor window, because they do not accept synthesized events and pass them
directly to the windows beneath.
After this fix we can safely re-enable cursor compositing mode.
BUG=363651
TEST=trybot and manual testing
R=derat@chromium.org, sadrul@chromium.org
Review URL: https://codereview.chromium.org/237893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Labels will show the title of the active tab or selected panel. They have a blurred shadow and are animated similarly to the close buttons.
See the bug for some screenshots.
BUG=361181
TEST=WindowSelectorTest.CreateLabelUnderWindow,WindowSelectorTest.CreateLabelUnderPanel
Review URL: https://codereview.chromium.org/231643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=362314
R=sky@chromium.org
Review URL: https://codereview.chromium.org/240183004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use event->SetHandled() instead of StopPropagating so that MouseCursorEventFilter
can still see the event but it is prevented from being sent to the renderer.
When cursor is inside a target window in overview mode, we still want to propagate
MOUSE_MOVED events so that they can be received by MouseCursorEventFilter to update
the cursor window.
BUG=chrome-os-partner:28034
TEST=trybot and manual verification
Review URL: https://codereview.chromium.org/238253009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce AttachedPanelWindowTargeter, a new derived
class of EasyResizeWindowTargeter. When installed as
the EventTargeter of a panel container, the extended
touch hit-testing inset is set to 0 for the edges of
panels adjacent to the shelf. This makes it
significantly easier to correctly target shelf buttons
with touch because shelf-adjacent edges of panels are
prevented from themselves being targets.
BUG=351348
TEST=WorkspaceControllerTest.WindowEdgeTouchHitTestPanel,PanelLayoutManagerTest.TouchHitTestPanel
Review URL: https://codereview.chromium.org/232703006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=354951
TEST=Enter overview with windows on multiple monitors. Close buttons should be displayed on both monitors.
Review URL: https://codereview.chromium.org/240153004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The separation will allow other components (views, ozone) to use the utilities
without pulling in the whole display components.
TBR=sadrul@chromium.org
BUG=333413
Review URL: https://codereview.chromium.org/239393003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
collection of files (removing un-used files) and user the moniker shelf as opposed to launcher.
This part 3 of a 3 part commit (1 - create the new file collection, 2 - update ash_resources.grd to use the new file collection, 3 - delete the old files)
Relevant CL's:
1 - https://codereview.chromium.org/238293003/
2 - https://codereview.chromium.org/238483002/
3 - https://codereview.chromium.org/238503002/
BUG=338429
Review URL: https://codereview.chromium.org/238503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chromeos::DBusThreadManager."
A build dependency got renamed while this was in the CQ.
BUG=354711
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/239843004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert "Revert of Prevents double-clicks on a tab close button from aslo maximizing the browser (https://codereview.chromium.org/222203006/)"
This reverts commit 5dc9060cc7db4e6f51771eba356476a1b1da2b35.
The revert of the original: https://codereview.chromium.org/239213003/ (263855)
The original implementation: https://codereview.chromium.org/222203006/ (263841)
TEST=WorkspaceEventHandlerTest
TEST=DesktopScreenX11Test
BUG=348817
Review URL: https://codereview.chromium.org/239433004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
collection of files (removing un-used files) and user the moniker shelf as opposed to launcher.
This part 2 of a 3 part commit (1 - create the new file collection, 2 - update ash_resources.grd to use the new file collection, 3 - delete the old files)
Relevant CL's:
1 - https://codereview.chromium.org/238293003/
2 - https://codereview.chromium.org/238483002/
3 - https://codereview.chromium.org/238503002/
BUG=338429
Review URL: https://codereview.chromium.org/238483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> app_shell: Initialize chromeos::DBusThreadManager.
>
> Let app_shell communicate with Chrome OS system processes.
> Also start notifying the power manager about user activity.
>
> BUG=354711
> TBR=sky@chromium.org
>
> Review URL: https://codereview.chromium.org/239433002
TBR=derat@chromium.org
Review URL: https://codereview.chromium.org/239823003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Let app_shell communicate with Chrome OS system processes.
Also start notifying the power manager about user activity.
BUG=354711
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/239433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes alphabetical ordering in ash/ash.gyp
Issue rased post commit of review: https://codereview.chromium.org/212923002/
Original commit=263764
BUG=337627
Review URL: https://codereview.chromium.org/239123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extracted from https://codereview.chromium.org/209383003/
http://crbug.com/308710
TBR=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263812
Review URL: https://codereview.chromium.org/237873003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
collection of files (removing un-used files) and user the moniker shelf as opposed to launcher.
This part 1 of a 3 part commit (1 - create the new file collection, 2 - update ash_resources.grd to use the new file collection, 3 - delete the old files).
Relevant CL's:
1 - https://codereview.chromium.org/238293003/
2 - https://codereview.chromium.org/238483002/
3 - https://codereview.chromium.org/238503002/
BUG=338429
R=jamescook@chromium.org
Review URL: https://codereview.chromium.org/238293003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New dependency model:
ui/ozone -> ui/display/types
ui/display -> ui/ozone
ui/display -> ui/display/types
Note ui/display/types is its own module separate from ui/display.
TBR=derat@chromium.org
Review URL: https://codereview.chromium.org/230763004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the browser (https://codereview.chromium.org/222203006/)
Reason for revert:
Broke build.
Original issue's description:
> Prevents double-clicks on a tab close button from aslo maximizing the browser
>
> The code responsible for listening to a double-click, and for maximizing the
> browser is platform dependant. The path on Aura desktop differs from that of
> Chrome OS. In both cases they use alternate means to trigger the maximizing.
>
> This change modifies both so that they only attempt to maximize if the initial
> click has the same target as the second click. Tab deletion is destructive by
> nature, lead do different targets processing different parts of the same series
> of user events.
>
> TEST=WorkspaceEventHandlerTest
> BUG=348817
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263841
TBR=flackr@chromium.org,varkha@chromium.org,sadrul@chromium.org,jonross@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=348817
Review URL: https://codereview.chromium.org/239213003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code responsible for listening to a double-click, and for maximizing the
browser is platform dependant. The path on Aura desktop differs from that of
Chrome OS. In both cases they use alternate means to trigger the maximizing.
This change modifies both so that they only attempt to maximize if the initial
click has the same target as the second click. Tab deletion is destructive by
nature, lead do different targets processing different parts of the same series
of user events.
TEST=WorkspaceEventHandlerTest
BUG=348817
Review URL: https://codereview.chromium.org/222203006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
just wm (https://codereview.chromium.org/237873003/)
Reason for revert:
Seems to have broken compile on the Linux builders:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/29879
ninja -C /b/build/slave/Linux_Builder/build/src/out/Release app_list_unittests aura_unittests base_unittests browser_tests cacheinvalidation_unittests cast_unittests cc_unittests chrome chromedriver_unittests chromium_swarm_tests components_unittests compositor_unittests content_browsertests content_unittests crypto_unittests dbus_unittests device_unittests events_unittests gcm_unit_tests gfx_unittests google_apis_unittests gpu_unittests interactive_ui_tests ipc_tests jingle_unittests media_unittests mojo_apps_js_unittests mojo_common_unittests mojo_js_unittests mojo_public_bindings_unittests mojo_public_environment_unittests mojo_public_system_unittests mojo_public_utility_unittests mojo_service_manager_unittests mojo_system_unittests net_unittests ppapi_unittests printing_unittests remoting_unittests sandbox_linux_unittests sql_unittests sync_integration_tests sync_unit_tests ui_unittests unit_tests url_unittests views_unittests webkit_compositor_bindings_unittests wm_core_unittests -j50
ninja: Entering directory `/b/build/slave/Linux_Builder/build/src/out/Release'
ninja:error: unknown target 'wm_core_unittests'
Original issue's description:
> Rename wm_core_export.h to wm_export.h and the wm_core target to just wm
>
> Extracted from https://codereview.chromium.org/209383003/
>
> http://crbug.com/308710
> TBR=sky@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263812
TBR=sky@chromium.org,ben@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/239023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Extracted from https://codereview.chromium.org/209383003/
http://crbug.com/308710
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/237873003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The remaining use of the X11 mesage-pump was opening the connection to the
X11 server. This patch moves that out of the message-pump, into gfx. This
allows us to remove the X11 message-pump, and just use the base Glib-based
message-pump on Linux and ChromeOS.
BUG=354062
R=darin@chromium.org, sky@chromium.org
Previously landed in r263726, but reverted in r263733 to allow reverting another CL.
Review URL: https://codereview.chromium.org/235043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The icon will have a visual indicator of the state in the status area. The
system tray will have an interactive entry that will toggle the rotation lock.
The lock is only available for the primary display.
TEST=TrayRotationLockTest
TEST=MaximizeModeControllerTest
BUG=337627
Review URL: https://codereview.chromium.org/212923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: along with 263718 blamed for
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/45298
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/29956
> x11: Remove X11 message-pump.
>
> The remaining use of the X11 mesage-pump was opening the connection to the
> X11 server. This patch moves that out of the message-pump, into gfx. This
> allows us to remove the X11 message-pump, and just use the base Glib-based
> message-pump on Linux and ChromeOS.
>
> BUG=354062
> R=darin@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/235043005
TBR=sadrul@chromium.org
Review URL: https://codereview.chromium.org/238093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=355898
TEST=
1.1. Start a kiosk app without network connection,
1.2. when offered an option, select a WPA/WEP protected network (make sure
it's not shared)
1.3. A network configuration dialog should appear;
"Share this network with other users" checkbox should be disabled and unchecked
1.4. Enter credentials and connect.
1.5. When connected, exit and make sure that network config dialog
is shown when connecting to the same network at the login screen
2.1. Login as guest and try connecting to a WPA/WEP protected unshared network.
proceed with step 1.3.
Review URL: https://codereview.chromium.org/232493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The remaining use of the X11 mesage-pump was opening the connection to the
X11 server. This patch moves that out of the message-pump, into gfx. This
allows us to remove the X11 message-pump, and just use the base Glib-based
message-pump on Linux and ChromeOS.
BUG=354062
R=darin@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/235043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With keyboard-usability-experiment flag, the primary root
window should only show a virtual keyboard. Instead, a all
white root window is showing. The problem is virtual keyboard
container is not set to the root window's size. This CL sets
the virtual keyboard container's bounds to the bounds of
root window.
BUG=362700
Review URL: https://codereview.chromium.org/235613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was that we were creating the ImmersiveModeControllerAsh even when
the host desktop type was not HOST_DESKTOP_TYPE_ASH.
BUG=355571, 356419
Review URL: https://codereview.chromium.org/217273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes sure that multi-profile user adding UI gets 100% of working area and
also works fine with onscreen keyboard.
BUG=361157
Review URL: https://codereview.chromium.org/231123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=362197
TEST=ash_unittests --gtest_filter=WorkspaceControllerTest.AutoPlacingMovesTransientChild
TEST=Repeat the repro steps in the bug
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263507
Review URL: https://codereview.chromium.org/233853002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=359709,359685
TEST=MaximizeModeControllerTest.LaptopTest,MaximizeModeControllerTest,MaximizeModeTest
Review URL: https://codereview.chromium.org/235573004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New test fails on win8 builder: http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/18140/steps/ash_unittests/logs/AutoPlacingMovesTransientChild
> Moves transient parent together with its children when auto-positioning
>
> BUG=362197
> TEST=ash_unittests --gtest_filter=WorkspaceControllerTest.AutoPlacingMovesTransientChild
> TEST=Repeat the repro steps in the bug
>
> Review URL: https://codereview.chromium.org/233853002
TBR=varkha@chromium.org
Review URL: https://codereview.chromium.org/235883003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=362197
TEST=ash_unittests --gtest_filter=WorkspaceControllerTest.AutoPlacingMovesTransientChild
TEST=Repeat the repro steps in the bug
Review URL: https://codereview.chromium.org/233853002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=353409
TEST=MaximizeModeControllerTest.BlocksKeyboardAndMouse
Review URL: https://codereview.chromium.org/230613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We are missing some IME & event functionality. Disable those tests until
we've implemented them, so that we can run more tests.
BUG=361341
Review URL: https://codereview.chromium.org/235673005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
well as windows which get maximized in maximized mode
BUG=353189,359714
TEST=unittest & visual verification
Review URL: https://codereview.chromium.org/232023007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=skuhne@chromium.org
TBR=jamescook@chromium.org, miket@chromium.org, skuhne@chromium.org
BUG=338429
re-landing of https://codereview.chromium.org/176883022/ with fix for the inset of app panel as discussed offline /w jennyz@
Review URL: https://codereview.chromium.org/229453005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=359701
TEST=visual
Review URL: https://codereview.chromium.org/233083004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes some build errors for the "chromeos=1 use_ozone=1" build. We
need to generalize this X11 interface for controlling the system keyboard
for use under ozone.
This currently forces ozone builds to use the fake implementation, which
merely fixes the build. We still need to implement an ozone version.
BUG=361341
TEST=chrome --ozone-platform=test
TBR=derat, sky
Review URL: https://codereview.chromium.org/232333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Other notable changes:
* Removed WindowTreeHostFactory as this is no longer necessary.
* Moved RootWindowTransformer to ash/host
* Removed Set/GetInsets which are no longer necessary (a code in SetInsets is now a part of
SetRootWindowTransformer)
* Added TransformerHelper that implements common behavior to transform root window for AshWindowTreeHost
* Added DEPS files
* Updated metro_viewer code to make sure it creates ash::AshRemoteWindowHostTree
A few more simplifications to come:
* Simplify RootWindowTransformer
* Eliminate EnvObserver in AshWindowTreeHostX11
I'll also work on DEPS reorg to make it more explicit under ash/
BUG=355771
TEST=No functional change. ui/aura/window_tree_host_x11_unittests has been moved to ash/host/ash_window_tree_host_x11_unittests
Review URL: https://codereview.chromium.org/201573015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263192 0039d316-1c4b-4281-b951-d872f2087c98
|