| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
ET_TOUCH_STATIONARY is never generated on any platform. So remove it.
BUG=none
R=oshima@chromium.org, tdresser@chromium.org
Review URL: https://codereview.chromium.org/268483004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows and too small screens
BUG=366315
TEST=ash_unittest's and visual tests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267084
Review URL: https://codereview.chromium.org/255063004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=skuhne@chromium.org
Review URL: https://codereview.chromium.org/266523005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only ash_shell needs to link with views_examples_lib to show the views
examples within ash shell.
This removes "test/demo" code from unit tests/production code.
This dependency issue was found while we were doing
https://codereview.chromium.org/201093002/ - r258758
BUG=355205
TEST=ninja -C out_cros/Debug ash ash_with_content ash_test_support ash_unittests
ash_shell_lib ash_shell ash_shell_unittests
All the above targets link.
R=ben@chromium.org, jamescook@chromium.org, harrym@chromium.org
Review URL: https://codereview.chromium.org/258003003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=nkostylev@chromium.org
TBR=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267158
Review URL: https://codereview.chromium.org/253063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=242933
Original commit broke ash_unittests for restoration of work area after login. With overscrolling, the size of the work area is no longer changes as the keyboard is shown or hidden.
Review URL: https://codereview.chromium.org/266513003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> CleanUp: Introduce UserInfo. Move session_state stuff to ash/session.
>
> BUG=None
> R=nkostylev@chromium.org
> TBR=sky@chromium.org
>
> Review URL: https://codereview.chromium.org/253063002
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/260783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The patch alerts a11y support that the overview
mode has been activated. If chromevox is enabled, it
will speak aloud "Alert, entered window overview mode".
BUG=332992
TEST=WindowSelectorTest.A11yAlertOnOverviewMode
Review URL: https://codereview.chromium.org/257763008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make it so that the tray view is only visible when rotation is actually locked.
Updates to the display strings will follow in a future review once they have
been decided upon.
TEST=TrayRotationLockTest
BUG=365736
Review URL: https://codereview.chromium.org/254653002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Seems like this revert dir not help.
> Revert 267122 "Exit overview before exiting maximize mode."
>
> > Exit overview before exiting maximize mode.
> >
> > BUG=366605
> > TEST=MaximizeModeWindowManagerTest.ExitsOverview
> > TEST=Enter maximize mode, enter overview, exit maximize mode. Overview should have exited on exiting maximize mode.
> >
> > Review URL: https://codereview.chromium.org/262433002
>
> TBR=flackr@chromium.org
>
> Review URL: https://codereview.chromium.org/261593004
TBR=henrika@chromium.org
Review URL: https://codereview.chromium.org/263613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=nkostylev@chromium.org
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/253063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Exit overview before exiting maximize mode.
>
> BUG=366605
> TEST=MaximizeModeWindowManagerTest.ExitsOverview
> TEST=Enter maximize mode, enter overview, exit maximize mode. Overview should have exited on exiting maximize mode.
>
> Review URL: https://codereview.chromium.org/262433002
TBR=flackr@chromium.org
Review URL: https://codereview.chromium.org/261593004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=366605
TEST=MaximizeModeWindowManagerTest.ExitsOverview
TEST=Enter maximize mode, enter overview, exit maximize mode. Overview should have exited on exiting maximize mode.
Review URL: https://codereview.chromium.org/262433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen windows and too small screens (https://codereview.chromium.org/255063004/)
Reason for revert:
[Sheriff] Breaks NormalOrPanel/DockedWindowLayoutManagerTest.WidthMoreThanMax/1 on CrOS:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/42711
Original issue's description:
> Ignoring minimum size requirements for maximized windows, full screen windows and too small screens
>
> BUG=366315
> TEST=ash_unittest's and visual tests
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267084
TBR=ben@chromium.org,skuhne@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=366315
Review URL: https://codereview.chromium.org/262593003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
windows and too small screens
BUG=366315
TEST=ash_unittest's and visual tests
Review URL: https://codereview.chromium.org/255063004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid reporting that 60 minutes remain when the time
interval is just under an hour boundary.
BUG=368261
Review URL: https://codereview.chromium.org/258303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=323766
TBR=skuhne@chromium.org
Review URL: https://codereview.chromium.org/250843007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move ImageCursors from ash/wm/ to ui/base/cursors/ and add a
NativeCursorManager implementation for
ShellDesktopController to use.
BUG=364290
TEST=cursor is visible when running app_shell on a Chrome OS
device and changes after mousing over a link
Review URL: https://codereview.chromium.org/258893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
windows to prevent occlusion by the virtual keyboard, the inner viewport is resized to extend the vertical scroll range.
BUG=242933
Review URL: https://codereview.chromium.org/195793004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The primary use-case for QueryMouseLocation() is for X11 interactive
tests. The only other use was in WindowEventDispatcher, but that code
is no longer necessary.
BUG=none
R=sky@chromium.org
Review URL: https://codereview.chromium.org/251743004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents overwriting target bounds when reparenting layers during animation. In snapped scenario we snap a window (with a call to WindowState::OnWMEvent in WorkspaceWindowResizer::CompleteDrag()) which starts animation and then immediately reparent it (back to workspace in DockedWindowResizer::MaybeReparentWindowOnDragCompletion). Stopping (completing) BOUNDS animation allows the child window to honor previously set target bounds and keep them when it gets reparented.
BUG=364517, 366993
TEST=aura_unittests --gtest_filter=WindowTest.RootWindowSetWhenReparenting
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266115
Review URL: https://codereview.chromium.org/241983003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the time has not been set automatically via network syncing, the system
clock can be changed. This dialog allows the user to change the date, time
and time zone when possible. The motivation is to unbrick devices with
the wrong time that need to be rolled out into time-sensitive networks.
Documentation of the changes to Chrome OS and Ash for this CL is here:
https://docs.google.com/a/google.com/drawings/d/1T3demthtROnXf1iE31p5aIPcQzK9SmjfE9EjnJbZ4zs
System Time Manual Update UI design doc:
https://docs.google.com/a/google.com/document/d/1djzhBrtbx-52Gctp3Fd5MIosARbTwQh_lMmd_qUnqgo
Screenshot with timezone:
https://drive.google.com/a/google.com/file/d/0B6HSBrih6pNUd3p2SFBoVktjVzQ
Screenshot from settings page, no timezone:
https://drive.google.com/a/google.com/file/d/0B6HSBrih6pNUXzk0TjNiT0tKMTQ
BUG=232066
TEST=SetTimeWebUITest, DateTimeOptionsWebUITest
R=stevenjb@chromium.org,nkostylev@chromium.org,dbeam@chromium.org,derat@chromium.org,asvitkine@chromium.org
TBR=sky@chromium.org
# TBR for adding resources to chrome/browser/chrome_resources.grd
Please review:
stevenjb@chromium.org
- ash/system
- chromeos/dbus
derat@chromium.org:
- chrome/browser/chromeos
- chrome/browser/ui/ash
- chromeos/dbus (optional)
nkostylev@chromium.org:
- chrome/app
- chrome/browser/chromeos
- chrome/browser/resources/chromeos
- chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
- chrome/browser/ui/webui/chromeos
- chrome/browser/ui/webui/options/chromeos
- chrome/browser/browser_resources.grd
- chrome/chrome_*.gypi
- chrome/common
dbeam@chromium.org:
- chrome/browser/resources/options
- chrome/browser/ui/webui/options/*.cc
sky@chromium.org:
- chrome/browser/browser_resources.grd
Review URL: https://codereview.chromium.org/247663003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=359672
TEST=WindowSelectorTest.DisplayOrientationChanged
TEST=While overview is active, rotate or resize the display. Windows should reposition / relayout in response.
Review URL: https://codereview.chromium.org/256413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hidden and an edge swipe brings the shelf back.
Allowing immersive / full screen mode in maximize mode
BUG=359606
TEST=ash tests and visual
Review URL: https://codereview.chromium.org/247363005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window-modal depending on where it got initiated from. Previous implementation created window-modal with no parent window which allowed it to hide underneath its browser window.
Fixed handling of window-modal dialogs. Modal dialogs and their toplevel parent windows weren't properly activated on events (i.e. mouse click) that happen in toplevel parent windows area but outside of the modal dialog.
TEST=added WindowModalityControllerTest.EventsForEclipsedWindows, manual: start go/present/<whatever>, try to alt-tab away from the pop up dialog, try to eclipse it with another browser window
BUG=366956
Review URL: https://codereview.chromium.org/252673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only relevant for the --enable-experimental-app-list-position flag.
AppListView now has a mode where it automatically keeps the bubble
centered on the screen's primary display, rather than a fixed position.
BUG=363928
TEST=Run with --enable-experimental-app-list-position. Open the app
list, press Ctrl+Shift+F3 to rotate. App list should remain centered.
Review URL: https://codereview.chromium.org/237533015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
after maximize mode starts
BUG=365868
TEST=visual and unit test
Review URL: https://codereview.chromium.org/249723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=366993
NOTRY=true
Review URL: https://codereview.chromium.org/256693003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With my previous 'cleanup', the candidate view becomes a CustomButton
and the 'PRESSED' button status indicates the highlighted. I thought
this is good enough, but hovering also changes the button state.
Using a button state is a bad idea, so this CL adds a boolean flag
for highlighted status.
BUG=365959
R=oshima@chromium.org
TEST=manually, ash_unittests
Review URL: https://codereview.chromium.org/258463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/237963019/
BUG=351553
Review URL: https://codereview.chromium.org/258533003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=333413
Review URL: https://codereview.chromium.org/250163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=365914
TEST=covered by unit tests
R=skuhne@chromium.org
Review URL: https://codereview.chromium.org/246393012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The menu item reads "Hide Notifications Icon" and is default un-checked. When
clicked, it is checked (and remains that way even across restarts.) This selection
is saved in a machine-wide preference.
R=rsesek@chromium.org,thakis@chromium.org
TBR=gene@chromium.org,atwilson@chromium.org,stevenjb@chromium.org
BUG=305398
Review URL: https://codereview.chromium.org/242453012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rest of the code seem to suggest that we always check validity of status_area_widget() pointer before calling method on it.
Also a specific comment in the code "status_area_widget() may be NULL during the shutdown." seems to suggest status_area_widget being NULL is expected.
shelf_ could have been a possible culprit here, but before we reach this particular statment, we have already called methods on it, so possibility of status_area_widget() being culprit is more. This bug doesn't repro on my machine so have to go with guess work.
BUG=365631
R=skuhne@chromium.org
Review URL: https://codereview.chromium.org/251343003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Make Window::SetTransform() non-virtual.
* Remove Window::SetEventFilter() (and use AddPreTargetHandler() instead).
BUG=none
R=sky@chromium.org
Review URL: https://codereview.chromium.org/248773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
because gfx::Display's DSF may differ from
platform's one when UI scaling is used.
BUG=361672
TEST=covered by unit test
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265592
R=sky@chromium.org, tdanderson@chromium.org
Review URL: https://codereview.chromium.org/226293005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in native code and in VK's javascript code through window.resizeTo
It sometimes creates conflict and cause strange animation issues.
In this CL, the window height logic in native side is removed.
The default window height is set to 0 and we expect javascript
will set the window to correct height.
If window is resized from a non zero height to another non
zeor height, we current dont do any animation.
BUG=363622
Review URL: https://codereview.chromium.org/240443006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
NOTRY=true
R=jamescook@chromium.org, derat@chromium.org
Review URL: https://codereview.chromium.org/249783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
0. (https://codereview.chromium.org/237963019/)
Reason for revert:
Causing browser_test failures on main waterfall, probably due to shelf animations:
EnterpriseKioskApp
AutolaunchWarningCancel
AutolaunchWarningConfirm
KioskEnableCancel
KioskEnableConfirmed
See crbug.com/366142 for stacks.
Original issue's description:
> Remove remaining window states where window is shown with opacity 0.
>
> BUG=351553
> TEST=Unit tests pass, can enter overview mode and show/hide panels in debug mode without triggering DCHECK in window.cc.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265330
TBR=sky@chromium.org,skuhne@chromium.org,flackr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=351553
Review URL: https://codereview.chromium.org/249063003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also fixes bug with default wallpaper cache.
BUG=348136,363134
TEST=manual
Review URL: https://codereview.chromium.org/236013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/226293005/)
Reason for revert:
There are no resize cursors in DevTools on Linux Aura anymore.
Original issue's description:
> Use platform's device scale factor for cursor instead of gfx::Display because gfx::Display's DSF may differ from
> platform's one when UI scaling is used.
>
> BUG=361672
> TEST=covered by unit test
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265592
TBR=tdanderson@chromium.org,sky@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=361672
Review URL: https://codereview.chromium.org/249303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
because gfx::Display's DSF may differ from
platform's one when UI scaling is used.
BUG=361672
TEST=covered by unit test
Review URL: https://codereview.chromium.org/226293005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This target is related to ui/base and in turn contain only files from
ui/base. So move it to the appropriate place and rename to
ui_base_test_support.
BUG=299841,331829
TEST=ash_unittests,unit_tests,aura_unittests,ui_unittests,views_unittests
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/247293008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't have to have a container for IME separately, the settings
bubble container is better for the IME UIs.
This switch also makes the following effects:
- IME UIs would appear in the lock screen / login screen
- IME UIs wouldn't move across the root window when removed (like
display state switch among mirroring<->extended)
The first is good, because we can show the mode indicator when
switching the layout between qwerty and Dvorak. Candidate windows
will not appear in lock/login screen anyways.
The second seems no problem because IME UIs are more ephemeral
anyways. People won't get frustrated if disappears in such situation.
They will re-appear when the user types another key.
This is the reland of r265161. r265161 was reverted because
there's a conflict about keyboard focus among the candidate window
and the text-input context. This CL contains the fix for this
situation.
BUG=364667
TBR=oshima@chromium.org, shuchen@chromium.org
Review URL: https://codereview.chromium.org/248133004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
maximize mode & missing fill behind shelf
BUG=365866, 365740
TEST=visual
Review URL: https://codereview.chromium.org/248413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Disable TOGGLE_OVERVIEW and CYCLE_WINDOW accelerator;
- Do not allow overview to be toggled for kiosk;
BUG=365775
Review URL: https://codereview.chromium.org/247533004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
window controls
BUG=364253
TEST=Alex is happy
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/242273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert reason: the candidate window doesn't work well on the new
container. It doesn't appear.
> Removes InputMethodContainer, merge into SettingsBubbleContainer
>
> We don't have to have a container for IME separately, the settings
> bubble container is better for the IME UIs.
>
> This switch also makes the following effects:
> - IME UIs would appear in the lock screen / login screen
> - IME UIs wouldn't move across the root window when removed (like
> display state switch among mirroring<->extended)
>
> The first is good, because we can show the mode indicator when
> switching the layout between qwerty and Dvorak. Candidate windows
> will not appear in lock/login screen anyways.
>
> The second seems no problem because IME UIs are more ephemeral
> anyways. People won't get frustrated if disappears in such situation.
> They will re-appear when the user types another key.
>
> BUG=364667
> R=oshima@chromium.org, shuchen@chromium.org
>
> Review URL: https://codereview.chromium.org/245783003
TBR=mukai@chromium.org
Review URL: https://codereview.chromium.org/247913004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=351553
TEST=Unit tests pass, can enter overview mode and show/hide panels in debug mode without triggering DCHECK in window.cc.
Review URL: https://codereview.chromium.org/237963019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This did not affect maximize mode changes very much as with the incorrect calculation the hinge angle tends towards 0 or 360 (depending on whether it is past 180 or not) which would preserve the current mode.
BUG=None
TEST=Manual, verified with logging that angle is consistent as device is rotated towards near vertical angle.
Review URL: https://codereview.chromium.org/246013005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265324 0039d316-1c4b-4281-b951-d872f2087c98
|