summaryrefslogtreecommitdiffstats
path: root/ash
Commit message (Collapse)AuthorAgeFilesLines
* Replace simple network properties in settings with ONC valuesstevenjb@chromium.org2014-07-071-41/+0
| | | | | | | | | | | | | | | | | | | This is step 2 (of many) in converting the network settings to Web UI. This CL passes the ONC dictionary to the network UI, along with additional existing non-ONC properties that require more complicated handling (which will be converted in follow-up CLs). The only functional change is that previously the string "Access to this network is protected" was never shown before due to a typo in JS which was fixed as a renaming side-effect. BUG=279351 R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/367453004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281604 0039d316-1c4b-4281-b951-d872f2087c98
* Noneamineer@chromium.org2014-07-0752-303/+355
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281556 0039d316-1c4b-4281-b951-d872f2087c98
* Added text filtering to Overview Modensatragno@chromium.org2014-07-0416-53/+387
| | | | | | | | | | | | | | | | | | This patch adds a text widget to the window overview in Ash that allows the user to filter the windows, making it easier to select among multiple active items. Windows that do not match the pattern are set to 0.5 transparency and their selection is prevented. The pretarget event handler in WindowSelector has been removed in favour of handling the key events in the widget, which produces cleaner code. BUG=388726 TEST=WindowSelectorTest.BasicTextFiltering TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/358553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281450 0039d316-1c4b-4281-b951-d872f2087c98
* [M-37]: Fix dragging tab via mouse when touch is down on ChromeOSpkotwicz@chromium.org2014-07-042-2/+37
| | | | | | | | | | | | | | | | | Do not change value of |ToplevelWindowEventHandler::drag_reverted_| if ET_MOUSE_CAPTURE_CHANGED is received after ET_MOUSE_RELEASED but before the move loop has ended. This is currently the case with views::Widget. This CL does not fix all of the possible places where CompleteDrag() may be called after the drag was completed for the sake of being easier to merge back to M-37 BUG=380481 TEST=ToplevelWindowEventHandlerTest.CaptureLossAfterMouseRelease Review URL: https://codereview.chromium.org/354343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281448 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo.avi@chromium.org2014-07-031-1/+1
| | | | | | | | | BUG=none TEST=less typo Review URL: https://codereview.chromium.org/367983003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281174 0039d316-1c4b-4281-b951-d872f2087c98
* setConfig is deprecated, use setInfo or allocPixels instead.reed@google.com2014-07-025-10/+5
| | | | | | | | | | | kPNColor_SkColorType is now kN32_SkColorType TBR= BUG=skia:2706 Review URL: https://codereview.chromium.org/363933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281044 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 280721 "Specifies the popup alignment from Ash."mukai@chromium.org2014-07-011-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Specifies the popup alignment from Ash. > > MessagePopupCollection estimates the popup alignment by itself, > checking the work area and display bounds. However, this approach > may misunderstand the reserved area of docked windows as the > taskbar, which causes weird effect as is described in the bug. > > Actually, this estimation is not necessary at all in Ash, because > Ash knows the exact taskbar alignment. This CL allows Ash to > specify the popup alignment, and ignores the estimation code. > > BUG=389656 > R=stevenjb@chromium.org, dimich@chromium.org > TEST=manually > > Review URL: https://codereview.chromium.org/353243002 Revert reason: - this causes a memory leak (referring uninitialized value) - also this doesn't work well with temporary alignment change (in ChromeOS ash, the shelf moves bottom in the lock screen and some important notifications may appear in that situation. However this does not cause SetShelfAlignment() event) TBR=mukai@chromium.org BUG=390500 Review URL: https://codereview.chromium.org/361003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280844 0039d316-1c4b-4281-b951-d872f2087c98
* Specifies the popup alignment from Ash.mukai@chromium.org2014-07-011-0/+10
| | | | | | | | | | | | | | | | | | | MessagePopupCollection estimates the popup alignment by itself, checking the work area and display bounds. However, this approach may misunderstand the reserved area of docked windows as the taskbar, which causes weird effect as is described in the bug. Actually, this estimation is not necessary at all in Ash, because Ash knows the exact taskbar alignment. This CL allows Ash to specify the popup alignment, and ignores the estimation code. BUG=389656 R=stevenjb@chromium.org, dimich@chromium.org TEST=manually Review URL: https://codereview.chromium.org/353243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280721 0039d316-1c4b-4281-b951-d872f2087c98
* cros: Remove SystemTrayDelegate::IsNetworkBehindCaptivePortal()sadrul@chromium.org2014-06-304-15/+5
| | | | | | | | | | | | | The NetworkPortalDetector has moved out of chrome/ into chromeos/, so the code in NetworkIcon can query the state directly from the portal detector, instead of going through the SystemTrayDelegate. BUG=387199 R=derat@chromium.org, stevenjb@chromium.org Review URL: https://codereview.chromium.org/354283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280687 0039d316-1c4b-4281-b951-d872f2087c98
* Currently when the virtual keyboard shows, we shrink panels that would be ↵rsadam@chromium.org2014-06-271-11/+21
| | | | | | | | | | pushed above the screen. This CL restores the window bounds for these panels when the keyboard hides. BUG=389149 Review URL: https://codereview.chromium.org/356043003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280361 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Update the window labels if they change in overview mode."nsatragno@chromium.org2014-06-276-62/+105
| | | | | | | | | | | | | | | | | | | Original issue: 331643004 Fixed: use of pointer after being freed in test. Update the window labels if they change in overview mode. This code adds a function to a WindowObserver that notfies it of a window title change, allowing to update the label in overview mode dynamically. BUG=387130 TBR=flackr@chromium.org, sky@chromium.org TEST=WindowSelectorTest.CreateLabelUnderWindow Review URL: https://codereview.chromium.org/352363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280176 0039d316-1c4b-4281-b951-d872f2087c98
* Overview Mode Close Buttons Not Rendering on 2nd Displayjonross@chromium.org2014-06-262-20/+32
| | | | | | | | | | | | | | | The bounds of a layer are already mapped to the given display coordinate space. This makes ScreenUtil::ConvertRectFromScreen redundant on the primary display. However for other displays this incorrectly changes the coordinate space. This change switches to use the correct layer bounds for placing the close button. TEST=WindowSelectorTest.MultipleDisplays BUG=388848 Review URL: https://codereview.chromium.org/358703005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280175 0039d316-1c4b-4281-b951-d872f2087c98
* AshWindowTreeHostWin is an implementation detail in an anonymous namespace ↵hans@chromium.org2014-06-261-2/+2
| | | | | | | | | | and should not be exported BUG=82385 Review URL: https://codereview.chromium.org/359563002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280037 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 279887 "Update the window labels if they change in overvi..."pastarmovj@google.com2014-06-266-104/+62
| | | | | | | | | | | | | | | | | | | | | The test failed on one of the bots: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31032 > Update the window labels if they change in overview mode. > > This code adds a function to a WindowObserver that notfies it of a window title > change, allowing to update the label in overview mode dynamically. > > BUG=387130 > TEST=WindowSelectorTest.CreateLabelUnderWindow > > Review URL: https://codereview.chromium.org/331643004 TBR=nsatragno@chromium.org Review URL: https://codereview.chromium.org/352633007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279951 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Block internal PlatformEvents before they are dispatched in touchview."flackr@chromium.org2014-06-2612-537/+216
| | | | | | | | | | | | | | | Using KeyboardCodeFromXKeyEvent instead to avoid dependency on events from events_base. Previous attempt review here: https://codereview.chromium.org/313913004/ TBR=sadrul BUG=374002, 368669 TEST=EventsXTest.Disable* TEST=On device opened past 180 degrees, hold shift and click on link. Link should open in same window. Review URL: https://codereview.chromium.org/351083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279922 0039d316-1c4b-4281-b951-d872f2087c98
* Update the window labels if they change in overview mode.nsatragno@chromium.org2014-06-266-62/+104
| | | | | | | | | | | | This code adds a function to a WindowObserver that notfies it of a window title change, allowing to update the label in overview mode dynamically. BUG=387130 TEST=WindowSelectorTest.CreateLabelUnderWindow Review URL: https://codereview.chromium.org/331643004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279887 0039d316-1c4b-4281-b951-d872f2087c98
* Shrink panels when keyboard deployed to prevent them being pushed above the ↵rsadam@chromium.org2014-06-261-0/+19
| | | | | | | | | | work area. BUG=370926 Review URL: https://codereview.chromium.org/352233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279881 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Block internal PlatformEvents before they are dispatched in touchview."avi@chromium.org2014-06-2512-216/+537
| | | | | | This reverts r279732. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279734 0039d316-1c4b-4281-b951-d872f2087c98
* Block internal PlatformEvents before they are dispatched in touchview.flackr@chromium.org2014-06-2512-537/+216
| | | | | | | | | | | | | This prevents updating the key state. BUG=374002,368669 TEST=EventsXTest.Disable* TEST=On device opened past 180 degrees, hold shift and click on link. Link should open in same window. Review URL: https://codereview.chromium.org/313913004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279732 0039d316-1c4b-4281-b951-d872f2087c98
* Added --custom-launcher-page. Adds a page to the experimental launcher.mgiuca@chromium.org2014-06-251-0/+4
| | | | | | | | | | | | | | | | | | | This allows the user to specify a custom web page (which must be in the chrome-extension:// scheme) which will appear as a third top-level page in the experimental launcher, alongside the start and apps pages. This command-line switch is intended to be temporary; eventually, extensions will be able to specify their own custom launcher pages. For now, the command-line switch is sufficient for testing. Most of the Chrome APIs are not yet available for these pages. BUG=386004 TBR=mukai@chromium.org,jamescook@chromium.org Review URL: https://codereview.chromium.org/352033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279685 0039d316-1c4b-4281-b951-d872f2087c98
* Do not consume Alt-Shift-Up event for IME switch.nona@chromium.org2014-06-253-14/+22
| | | | | | | | | | | | To be compatible with Windows, Alt-Shift-Up key event should not be consumed by ASH even it fires IME switch. BUG=387583 TEST=manual and try bots Review URL: https://codereview.chromium.org/348293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279667 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary #includes in ash/wm/window_positioner.cc.sungmann.cho@navercorp.com2014-06-251-2/+0
| | | | | | | | | | | | After the landing https://codereview.chromium.org/173883005, ash/wm/window_positioner.cc doesn't need the command line switch related headers anymore. So we can remove these. BUG=340466 Review URL: https://codereview.chromium.org/347783004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279635 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce minimum visibility only for normal and panel windowsmohsen@chromium.org2014-06-252-0/+22
| | | | | | | | | | | | | | Enforcing minimum visibility is to ensure that the user is always able to interact with the window. This is only needed for normal and panel windows which are positioned by user. Other types of windows are positioned programmatically. BUG=364117 TEST=WorkspaceLayoutManagerTest.NoMinimumVisibilityForPopupWindows Review URL: https://codereview.chromium.org/348943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279630 0039d316-1c4b-4281-b951-d872f2087c98
* Status Area disappears during Multi-User Sign-injonross@chromium.org2014-06-242-3/+23
| | | | | | | | | | | Update StatusAreaLayoutManager to acccount for animations when it is updating its bounds. TEST=ShelfLayoutManagerTest.ShelfAutoHideToggleDuringAnimationUpdatesBounds BUG=386069 Review URL: https://codereview.chromium.org/343193007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279504 0039d316-1c4b-4281-b951-d872f2087c98
* Extract touchscreen device management into a generic managerdnicoara@chromium.org2014-06-236-9/+8
| | | | | | | | | | DeviceDataManager is currently X11 specific, so CrOS code that is responsible for touchscreen management would only work under X11. This CL starts extracting device state as generic state that X11 and Ozone implementations can share. BUG=375848 Review URL: https://codereview.chromium.org/289283015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279126 0039d316-1c4b-4281-b951-d872f2087c98
* Move GetMirroredDisplayAreaRatioMap() out of ui::DisplayConfiguratordnicoara@chromium.org2014-06-234-7/+76
| | | | | | | | | | | | Rather than caching this information early on, compute the ratios when needed. This change is also required in order to extract the touchscreen configuration logic from ui/display. BUG=381326 Review URL: https://codereview.chromium.org/335883003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279105 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing tab-ability of multi user items in system tray menu.skuhne@chromium.org2014-06-214-20/+131
| | | | | | | | | BUG=364652 TEST=visual (Tab in, tab out, Tab in, activate, add user, tabbable, ..) Review URL: https://codereview.chromium.org/339783003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278972 0039d316-1c4b-4281-b951-d872f2087c98
* Convert sticky keys to a chromeos::EventRewriter phase.kpschoedel@chromium.org2014-06-215-1150/+559
| | | | | | | | | | BUG=354035 TEST=unit_tests,ash_unittests,manual R=sadrul@chromium.org,derat@chromium.org Review URL: https://codereview.chromium.org/255033003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278919 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Do not create a second InputMethod for the keyboard.sadrul@chromium.org2014-06-212-4/+2
| | | | | | | | | | | | | An InputMethod instance is created by the wm::InputMethodEventFilter object owned by the ash::Shell singleton. The keyboard-controller proxy should use that input-method, instead of create a new one. BUG=none R=jamescook@chromium.org Review URL: https://codereview.chromium.org/344183005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278898 0039d316-1c4b-4281-b951-d872f2087c98
* Optimize png files in ui/resources, ash/resourcesoshima@chromium.org2014-06-206-0/+0
| | | | | | | | | | | | | with -o2 Optimized 6/16 files in 00:03:20s Result: 6014 => 4014 bytes (2000 bytes: 33%) BUG=387254 TBR=msw@chromium.org Review URL: https://codereview.chromium.org/343203004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278836 0039d316-1c4b-4281-b951-d872f2087c98
* [cros touch] Proper handling of non-maximized/fullscreen windows in lock ↵nkostylev@chromium.org2014-06-202-17/+125
| | | | | | | | | | | | | screen container Switch cros login host window back to ui::SHOW_STATE_FULLSCREEN since new layout manager handles that correctly even with virtual keyboard. This way login window state will be consistent with screen lock state which is full screen. BUG=384849 Review URL: https://codereview.chromium.org/330763005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278691 0039d316-1c4b-4281-b951-d872f2087c98
* Manage settings window icon for multi profilestevenjb@chromium.org2014-06-202-1/+17
| | | | | | | | | | | | Includes some minor refactoring: merges launcher_item_util.cc into ash:shelf_util.cc BUG=385161 R=ben@chromium.org, skuhne@chromium.org Review URL: https://codereview.chromium.org/332163006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278629 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Reland Window Control Animations for TouchView. ↵jonross@chromium.org2014-06-197-266/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/316693002/) Reason for revert: In Immersice Fullscreen, when a mouse hovers near the top of the screen the header animates in. This is done by animating TopContainerView. However this view does not contain all of the title bar, and forces a paint to its canvas. With FrameCaptionButtonContainerView painting to a layer it no longer paints to the canvas of TopContainerView. Due to z-order of the views FrameCaptionButtonContainer exists below the TopContainerView as well as below the ClientView of the browser. Reverting the use of layers in M37. For M38 the use of layers can be rexamined, however changes to the header views, or how immersive mode renders, will be needed before relanding this. Original issue's description: > Reland Window Control Animations for TouchView > > The original change contained a use-after-free bug. This was caused by window crossfade animation during > maximizing, combined with input event processing. The crossfade would take the current layer and delete it. > However the next input event to the window tree would attempt to access the now deleted layer. > Original Code Review: https://codereview.chromium.org/271913002/ > Revert Review: https://codereview.chromium.org/309973002/ > Revert "Revert of Animate window control changes in TouchView (https://codereview.chromium.org/271913002/)" > This reverts commit 8863218a5e97c4914a5a03df59e9d5d17f53a2cb. > > TBR=jamescook@chromium.org > TEST=FrameCaptionButtonContainerViewTest.AnimationUpdatesLayerTree > BUG=363717 > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276782 TBR=jamescook@chromium.org BUG=384612, 363717 Review URL: https://codereview.chromium.org/343433009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278520 0039d316-1c4b-4281-b951-d872f2087c98
* Added ignored_by_shelf bit to overview mode selection widget.nsatragno@chromium.org2014-06-191-0/+4
| | | | | | | | | | | | This change enables the selection widget to pass under the shelf without activating it. BUG=367766 TEST=none Review URL: https://codereview.chromium.org/347813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278479 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 278342 "Convert sticky keys to a chromeos::EventRewriter ..."oshima@chromium.org2014-06-195-559/+1150
| | | | | | | | | | | | | | | | > Convert sticky keys to a chromeos::EventRewriter phase. > > BUG=354035 > TEST=unit_tests,ash_unittests,manual > R=sadrul@chromium.org,derat@chromium.org > > Review URL: https://codereview.chromium.org/255033003 TBR=kpschoedel@chromium.org Review URL: https://codereview.chromium.org/341923006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278419 0039d316-1c4b-4281-b951-d872f2087c98
* Enable pointer warping with multiple displays under Ozonerobert.bradford@intel.com2014-06-191-0/+5
| | | | | | | | | | | | | | | Mouse events generated from Ozone do not have a NativeEvent associated with them and so they need to go through the non native event based flow in the multi-monitor warping code. With this change it is now possible to move the pointer from one display to the next under Ozone. TEST=On link_freon attach a second display and move the pointer from one display to the other. BUG=361144 Review URL: https://codereview.chromium.org/340773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278406 0039d316-1c4b-4281-b951-d872f2087c98
* Convert sticky keys to a chromeos::EventRewriter phase.kpschoedel@chromium.org2014-06-195-1150/+559
| | | | | | | | | | BUG=354035 TEST=unit_tests,ash_unittests,manual R=sadrul@chromium.org,derat@chromium.org Review URL: https://codereview.chromium.org/255033003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278342 0039d316-1c4b-4281-b951-d872f2087c98
* Prevents windows that cannot snap from snapping using a keyboard acceleratorvarkha@chromium.org2014-06-191-1/+2
| | | | | | | | | BUG=386254 TEST=Open a non-resizable app such as a calculator. Alt+] should not snap it. Review URL: https://codereview.chromium.org/342823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278273 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Label::PaintText overrides.msw@chromium.org2014-06-192-40/+4
| | | | | | | | | | | | | | | | | This is simple cleanup in preparation for a Label rewrite. These overrides were supplying an extra gfx::Canvas flag. Instead, add an explicit label flag for NO_SUBPIXEL_RENDERING. Update some callers and the unit test. TODO(followup): Update more Label::SetBackgroundColor callers. BUG=240037 TEST=No exit warning or sticky keys label rendering changes. R=sky@chromium.org Review URL: https://codereview.chromium.org/341713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278213 0039d316-1c4b-4281-b951-d872f2087c98
* Change to CustomFrameView Caption Button Inset.jonross@chromium.org2014-06-181-2/+4
| | | | | | | | | | Restrict increase of button inset to linux only. This will allow the Windows Classic theme to maintain its look, while the updated linux look is still available. This returns the inset size on non-linux platforms to their state pre r272576 BUG=381821 Review URL: https://codereview.chromium.org/336553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278173 0039d316-1c4b-4281-b951-d872f2087c98
* Require the cursor to move a minimum distance after the mouse press before ↵pkotwicz@chromium.org2014-06-183-10/+84
| | | | | | | | | | | | | initiating a mouse drag. The CL also makes ShelfViewTest send ui::MouseEvents in the coordinates of |ShelfView::drag_view_|. BUG=377522 TEST=ShelfViewTest.ClickAndMoveSlightly Review URL: https://codereview.chromium.org/338833008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278129 0039d316-1c4b-4281-b951-d872f2087c98
* WorkspaceLayoutManager backdrop should fill entire region.jonross@chromium.org2014-06-185-7/+45
| | | | | | | | | | | Changes to the visible state of the shelf causes the WorkspaceLayoutManager to change the size of its children. This includes changing the size of the backdrop. In order for the backdrop to cover the entire workspace it needs to be notified of changes to the available area. Such as when the shelf causes the inset regions to update. TEST=WorkspaceLayoutManagerBackdropTest.ShelfVisibilityChangesBounds BUG=383383 Review URL: https://codereview.chromium.org/337193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278106 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor views::Label and gfx::RenderText shadow functions.msw@chromium.org2014-06-183-14/+7
| | | | | | | | | | | | | | This is mechanical cleanup in preparation for a Label rewrite. Use simple gfx::ShadowValues setter functions everywhere. Remove a forbidden static FontList instance. BUG=240037 TEST=No appearance changes for views text shadows. R=sky@chromium.org Review URL: https://codereview.chromium.org/343513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278101 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary #includes in system_tray.cc and tray_user_unittest.cc.sungmann.cho@navercorp.com2014-06-172-3/+0
| | | | | | | | | | | | After the landing https://codereview.chromium.org/184113005, system_tray.cc and tray_user_unittest.cc don't need the command line switch related headers anymore. So we can remove these. BUG=348133 Review URL: https://codereview.chromium.org/338133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277894 0039d316-1c4b-4281-b951-d872f2087c98
* Make BoundsAnimator always own its animation delegate.pkasting@chromium.org2014-06-171-11/+13
| | | | | | | | | | | All non-unittest code wanted this behavior. BUG=none TEST=none Review URL: https://codereview.chromium.org/331323005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277707 0039d316-1c4b-4281-b951-d872f2087c98
* Notifies capslock state changed in fake ime keyboard.shuchen@chromium.org2014-06-162-32/+15
| | | | | | | | | BUG=375586 TEST=Verified on Pixel device and linux_chromeos. Review URL: https://codereview.chromium.org/334863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277524 0039d316-1c4b-4281-b951-d872f2087c98
* Add const to PanelLayoutManagerTest::IsPanelAboveLauncherIcon 'panel' parameterbruthig@chromium.org2014-06-169-15/+14
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/331843003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277511 0039d316-1c4b-4281-b951-d872f2087c98
* Stop Status Area Creation Animationsjonross@chromium.org2014-06-164-3/+2
| | | | | | | | | | | | TrayBackgroundViews animate their visual state transitions. However upon creation some set their visibility to false. This is causing them to first appear on screen, only to animate to hidden. It is not desireable, especially for startup. Switch the children to set their initial visibility via View::SetVisible instead of TrayBackgroundView::SetVisible in order to not animate. Those items that should be visible based on the login status are already receiving login state notifications and will become visible accordingly. BUG=383005 Review URL: https://codereview.chromium.org/329993003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277506 0039d316-1c4b-4281-b951-d872f2087c98
* Close Button on Panels in Overview Modejonross@chromium.org2014-06-166-119/+198
| | | | | | | | | | | Move the control of the close button into window_selector_item, so that it is used for both windows and panels. Allow window_selector_window and window_selector_panel to decide on the placement of the close button. For panels place the close button on the currently active window. Once it is closed the button moves to the next panel in the list, and the label of the selection item updates. TEST=WindowSelectorTest.CloseButtonOnPanels BUG=352143 Review URL: https://codereview.chromium.org/329203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277483 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary #includes in power_status_unittest.cc.sungmann.cho@navercorp.com2014-06-161-4/+0
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/336233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277476 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 00:59:59 +0000