summaryrefslogtreecommitdiffstats
path: root/base/base_paths_win.h
Commit message (Collapse)AuthorAgeFilesLines
* Reverted how taskbar pinning works.pmonette2015-10-161-1/+1
| | | | | | | | | | | | | | | | The change was causing Chrome to chrash when pinning shortcuts because because of third-party shell extensions (See bug). Also removed the unused start menu pinning in Windows 10. Previous CLs: Changing pin to taskbar crrev.com/1193363003 Adding pin to start menu crrev.com/1242763002 BUG=540710 Review URL: https://codereview.chromium.org/1402003002 Cr-Commit-Position: refs/heads/master@{#354621}
* Pin Chrome's shortcut to the Win10 Start menu on install and OS upgrade.gab2015-07-271-2/+2
| | | | | | | | | BUG=503682 TBR=thakis@chromium.org (for method rename having side-effects in chrome/browser/ui and base/). Review URL: https://codereview.chromium.org/1242763002 Cr-Commit-Position: refs/heads/master@{#340493}
* Cleanup: Fix base header include guards.tfarina2015-05-131-3/+3
| | | | | | | | | | | | | | | | The header include guards should match the file path from root. These entries were found using a modified version of Eric's fix-include-guards.py script found attached in https://code.google.com/p/chromium/issues/detail?id=435361#c7. BUG=435361 TEST=base_unittests R=danakj@chromium.org Review URL: https://codereview.chromium.org/1137323003 Cr-Commit-Position: refs/heads/master@{#329731}
* Add DIR_PROGRAM_FILES6432 to PathService to return "Program Files" on both ↵wfh2015-03-131-2/+8
| | | | | | | | | | 64-bit and 32-bit platforms. BUG= Review URL: https://codereview.chromium.org/986373006 Cr-Commit-Position: refs/heads/master@{#320498}
* remove DIR_LOCAL_APP_DATA_LOW from base.cpu2014-10-271-1/+0
| | | | | | | | | | | Not used except for cloud print. BUG=426573 TBR=rvargas Review URL: https://codereview.chromium.org/681533002 Cr-Commit-Position: refs/heads/master@{#301473}
* Fix shortcut tests and remove legacy shortcut code for the Default-usergab@chromium.org2014-08-081-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Quick Launch shortcut. InstallShortcutTest.CreateAllShortcutsSystemLevel has been broken since http://crrev.com/164849 ... The test expectations had not been adjusted in this CL as setup_unittests.exe doesn't run on the waterfall yet (issue #153829) and the breakage had gone unnoticed. Expectations have now been adjusted such that we no longer expect a system-level (Default-user) Quick Launch shortcut, but a per-user Quick Launch shortcut for the admin running the install as the product code's logic has been doing for over a year... Also remove the code cleaning up the legacy Default-user Quick Launch shortcut as this cleanup code has been running for 21 months now and leaving this shortcut behind for a few users is a no-op (i.e. the Default-user shortcut will get copied to new Windows profiles and Active Setup will kick in a few seconds later to try to install the same shortcut which will already exist... the UX result will be the same: a single Chrome Quick Launch shortcut will be installed). BUG=329239, 153829 Review URL: https://codereview.chromium.org/432273005 Cr-Commit-Position: refs/heads/master@{#288393} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288393 0039d316-1c4b-4281-b951-d872f2087c98
* Support DirectWrite with sandbox onscottmg@chromium.org2014-03-261-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | This seems to be enough to get DirectWrite working with the sandbox on. There's two parts: 1. Warmup for three things: the dwrite.dll, creating a font, and accessing glyph metrics. 2. A renderer sandbox policy allowing readonly fonts directory access. Manually tested working on Win 8.1, Win 7 Pro SP1 with QFE 2670838, and Win Home Basic RTM (no SPs or QFEs). Blink side here: https://codereview.chromium.org/210243004 but can land independently after this change. R=brettw@chromium.org, cpu@chromium.org, jam@chromium.org, jschuh@chromium.org, darin@chromium.org BUG=333029 TEST=Run with --enable-direct-write and http://wikipedia.org/ Review URL: https://codereview.chromium.org/209163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259434 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for GetHomeDir for Mac and Windows.brettw@chromium.org2014-02-191-1/+0
| | | | | | | | | | | | Unifies the Path Service's base::DIR_HOME on Posix and base::DIR_PROFILE on Windows to just be base::DIR_HOME everywhere, and DIR_HOME will now work on Mac. This removes the AssertIOAllowed check in the Posix implementation because that was only executed in a fallback case that no developer is likely to ever hit. In addition, the we do call this type of function on the UI thread, so either we need to promote the assertion to be at the top of the function or delete it. It seemed unreasonable to disallow using this one key of the path service on the UI thread (the other ones are OK) so I just went for deleting the assertion. R=benwells@chromium.org Review URL: https://codereview.chromium.org/159833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252066 0039d316-1c4b-4281-b951-d872f2087c98
* Re-commit: Introduce RemoveChromeTaskbarShortcuts() to delete all ↵gab@chromium.org2012-11-061-0/+2
| | | | | | | | | | | | | | pinned-to-taskbar shortcuts owned by the uninstalled Chrome. Original commit http://crrev.com/165505 Reverted in http://crrev.com/165524 BUG=158632 TEST=No user-level shortcut Chrome left behind in taskbar post user-level self-destruct. Review URL: https://chromiumcodereview.appspot.com/11368040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166285 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 165505 - Introduce RemoveChromeTaskbarShortcuts() to delete all ↵gab@chromium.org2012-11-011-2/+0
| | | | | | | | | | | | | | | | pinned-to-taskbar shortcuts owned by the uninstalled Chrome. TBR=brettw@chromium.org BUG=158632 TEST=No user-level shortcut Chrome left behind in taskbar post user-level self-destruct. Review URL: https://chromiumcodereview.appspot.com/11361015 TBR=gab@chromium.org Review URL: https://codereview.chromium.org/11366047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165524 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce RemoveChromeTaskbarShortcuts() to delete all pinned-to-taskbar ↵gab@chromium.org2012-11-011-0/+2
| | | | | | | | | | | | | shortcuts owned by the uninstalled Chrome. TBR=brettw@chromium.org BUG=158632 TEST=No user-level shortcut Chrome left behind in taskbar post user-level self-destruct. Review URL: https://chromiumcodereview.appspot.com/11361015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165505 0039d316-1c4b-4281-b951-d872f2087c98
* Add new PathService paths for Windows' All Users Desktop and Quick Launch ↵gab@chromium.org2012-09-201-0/+6
| | | | | | | | | | | | | | | | | | | | | | | folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 157667 - Add new PathService paths for Windows' All Users Desktop and ↵wjia@chromium.org2012-09-201-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | Quick Launch folders. The previous patch failed PathServiceTest.Get. This allows usage of PathService to cache the paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10910209 TBR=gab@chromium.org Review URL: https://codereview.chromium.org/10958009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157680 0039d316-1c4b-4281-b951-d872f2087c98
* Add new PathService paths for Windows' All Users Desktop and Quick Launch ↵gab@chromium.org2012-09-201-0/+6
| | | | | | | | | | | | | | | | | | | | folders. This allows usage of PathService to cache the paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10910209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157667 0039d316-1c4b-4281-b951-d872f2087c98
* Delete Chrome's secondary tiles on Windows 8 when uninstalling.benwells@chromium.org2012-08-301-1/+3
| | | | | | | | | | | The Windows secondary tiles deletion functions are only available to Chrome itself when running in metro mode. To get around this, the folder containing the installation's secondarty tiles is removed entirely. BUG=140559 Review URL: https://chromiumcodereview.appspot.com/10876057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154103 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Moved the Chromoting host configuration under %SystemDrive%\ProgramData and ↵alexeypa@chromium.org2012-04-041-4/+8
| | | | | | | | | | ACL-protected it explicitly. Raised the configuration size limit to 1MB. This CL also adds IDaemonControl::UpdateConfig stub to be used later for minor configuration changes (changing the host pin for instance). Review URL: https://chromiumcodereview.appspot.com/9963121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130558 0039d316-1c4b-4281-b951-d872f2087c98
* Extend PathService::Get to be able to return the X86 program files path.abodenha@chromium.org2011-04-251-2/+3
| | | | | | | | | | | | | | | | Cloud print's virtual driver needs this to be able to find the Chrome install directory. Since the port monitor is a 64 bit DLL on 64 bit Windows it needs to request the X86 folder explicitly. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82567 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82686 Review URL: http://codereview.chromium.org/6873159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82891 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82686 - Extend PathService::Get to be able to return the X86 program ↵abodenha@google.com2011-04-221-3/+2
| | | | | | | | | files path.Cloud print's virtual driver needs this to be able to find the Chrome install directory. Since the port monitor is a 64 bit DLL on 64 bit Windows it needs to request the X86 folder explicitly.BUG=TEST=Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82567Review URL: http://codereview.chromium.org/6873159 TBR=abodenha@chromium.org Review URL: http://codereview.chromium.org/6880147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82699 0039d316-1c4b-4281-b951-d872f2087c98
* Extend PathService::Get to be able to return the X86 program files path.abodenha@chromium.org2011-04-221-2/+3
| | | | | | | | | | | | | | Cloud print's virtual driver needs this to be able to find the Chrome install directory. Since the port monitor is a 64 bit DLL on 64 bit Windows it needs to request the X86 folder explicitly. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82567 Review URL: http://codereview.chromium.org/6873159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82686 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82567 - Extend PathService::Get to be able to return the X86 program ↵arv@chromium.org2011-04-211-3/+2
| | | | | | | | | files path.Cloud print's virtual driver needs this to be able to find the Chrome install directory. Since the port monitor is a 64 bit DLL on 64 bit Windows it needs to request the X86 folder explicitly.BUG=TEST=Review URL: http://codereview.chromium.org/6873159 TBR=abodenha@google.com Review URL: http://codereview.chromium.org/6899005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82572 0039d316-1c4b-4281-b951-d872f2087c98
* Extend PathService::Get to be able to return the X86 program files path.abodenha@google.com2011-04-211-2/+3
| | | | | | | | | | | Cloud print's virtual driver needs this to be able to find the Chrome install directory. Since the port monitor is a 64 bit DLL on 64 bit Windows it needs to request the X86 folder explicitly. BUG= TEST= Review URL: http://codereview.chromium.org/6873159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82567 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Make acrobat work with --safe-plugins by giving it write accessnsylvain@chromium.org2010-02-011-1/+2
| | | | | | | | | | | | | | | to HKCU\Software\Adobe. Since we already have write access to HKCU\Software\Macromedia, I don't believe this is making it less secure than it actually is. We also give it write access to AppData\Adobe. Finally, we also need to let it do a directory listing in c:\users\<user> and c:\users\<user>\AppData, otherwise it crashes. Review URL: http://codereview.chromium.org/554095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37719 0039d316-1c4b-4281-b951-d872f2087c98
* posix: refactor duplicated path-handling codeevan@chromium.org2009-11-211-7/+0
| | | | | | | | | We had the same code in three headers, and an "if FREEBSD" in a _linux.cc file. Review URL: http://codereview.chromium.org/414063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32722 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-1/+0
| | | | | | | | | Normalize end of file newlines in base/. All files end in a single newline. Review URL: http://codereview.chromium.org/42011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11329 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE (except one global std::wstring changed to const wchar_t* ↵maruel@chromium.org2009-03-031-2/+2
| | | | | | | | | | | const per style compliance). Preliminary work to enforce new PRESUBMIT.py rules: - <=80 cols - no trailing whitespaces - svn:eol-style=LF git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10791 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Part two of file_util porting. Almost all of the functionality has been ↵erikkay@google.com2008-08-151-0/+3
| | | | | | ported, including the unit tests now. Some of this API isn't great, and should be cleaned up, but I'd like to hold off and do that in a followup changelist. More general code cleanup is likely needed here as well. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@944 0039d316-1c4b-4281-b951-d872f2087c98
* refactor base_paths so that windows-specific paths are pulled out into their ↵erikkay@google.com2008-08-051-0/+64
own file. Note that some of the same path key names will exist in other platform-specific files. For example, base_paths_mac.mm will have FILE_EXE and DIR_APP_DATA (among others). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@389 0039d316-1c4b-4281-b951-d872f2087c98