summaryrefslogtreecommitdiffstats
path: root/base/command_line.h
Commit message (Collapse)AuthorAgeFilesLines
* Take a StringPiece when looking up CommandLine switches.jackhou2015-05-211-7/+26
| | | | | | | | | | | | | | | | | | | | | | | | | This avoids the string allocation when searching for a char* in a std::map<std::string>. CommandLine now maintains a parallel map of StringPieces that reference the strings in |switches_|. StringPiece is trivial to construct from a string, and only requires a strlen to construct from a char*. On a profile with 2 extensions, HasSwitch is called ~12k times during startup. In an ideal situation (no paging/cache pressure), the string allocation under Windows takes ~137ns on a Xeon E5-2690 @ 2.9Ghz. A strlen on a typical switch takes about 50ns, and 91% of calls pass a char*, so there's a net saving of at least (137 - 0.9 * 50)ns * 12k = 1.1ms from a typical startup with this hardware. For context, Startup.BrowserMessageLoopStartTimeFromMainEntry is typically 280-300ms on the same hardware, so we should get a ~0.4% improvement. BUG=472383 Review URL: https://codereview.chromium.org/1063933002 Cr-Commit-Position: refs/heads/master@{#330902}
* Enforce lowercase switches when calling CommandLine::HasSwitch.jackhou2015-04-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | At the moment, all compile-time switches are lowercase. By enforcing this, we can skip converting it to lowercase on Windows, which saves one string allocation per call. On a profile with 2 extensions, HasSwitch is called ~12k times during startup. In an ideal situation (no paging/cache pressure), the string allocation under Windows takes ~137ns on an Xeon E5-2690 @ 2.9Ghz. So this should shave off at least 1.6ms off a typical startup with this hardware. For context, Startup.BrowserMessageLoopStartTimeFromMainEntry is typically 280-300ms on the same hardware, so we should get a ~0.5% improvement. BUG=472383 Committed: https://crrev.com/f58961749a980032241fe6c3fc829ac2e6652030 Cr-Commit-Position: refs/heads/master@{#325576} Review URL: https://codereview.chromium.org/1046363002 Cr-Commit-Position: refs/heads/master@{#326219}
* Revert of Enforce lowercase switches when calling ↵yoichio2015-04-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CommandLine::HasSwitch(const char*). (patchset #5 id:80001 of https://codereview.chromium.org/1046363002/) Reason for revert: This causes test fails on Android: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27294 The test uses upper case with HasSwitch(): https://code.google.com/p/chromium/codesearch#chromium/src/content/public/android/javatests/src/org/chromium/content/browser/ContentCommandLineTest.java&q=testJavaNativeTransition&sq=package:chromium&type=cs&l=96 Original issue's description: > Enforce lowercase switches when calling CommandLine::HasSwitch. > > At the moment, all compile-time switches are lowercase. By enforcing > this, we can skip converting it to lowercase on Windows, which saves > one string allocation per call. > > On a profile with 2 extensions, HasSwitch is called ~12k times during > startup. In an ideal situation (no paging/cache pressure), the > string allocation under Windows takes ~137ns on an Xeon E5-2690 @ > 2.9Ghz. So this should shave off at least 1.6ms off a typical startup > with this hardware. For context, > Startup.BrowserMessageLoopStartTimeFromMainEntry is typically > 280-300ms on the same hardware, so we should get a ~0.5% improvement. > > BUG=472383 > > Committed: https://crrev.com/f58961749a980032241fe6c3fc829ac2e6652030 > Cr-Commit-Position: refs/heads/master@{#325576} TBR=tapted@chromium.org,brettw@chromium.org,jackhou@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=472383 Review URL: https://codereview.chromium.org/1091993002 Cr-Commit-Position: refs/heads/master@{#325610}
* Enforce lowercase switches when calling CommandLine::HasSwitch.jackhou2015-04-171-1/+1
| | | | | | | | | | | | | | | | | | | | At the moment, all compile-time switches are lowercase. By enforcing this, we can skip converting it to lowercase on Windows, which saves one string allocation per call. On a profile with 2 extensions, HasSwitch is called ~12k times during startup. In an ideal situation (no paging/cache pressure), the string allocation under Windows takes ~137ns on an Xeon E5-2690 @ 2.9Ghz. So this should shave off at least 1.6ms off a typical startup with this hardware. For context, Startup.BrowserMessageLoopStartTimeFromMainEntry is typically 280-300ms on the same hardware, so we should get a ~0.5% improvement. BUG=472383 Review URL: https://codereview.chromium.org/1046363002 Cr-Commit-Position: refs/heads/master@{#325576}
* Provide CommandLine::HasSwitch(const char*) to save 76kB in sizes perftapted2015-03-301-0/+3
| | | | | | | | | | | | | | | | | | | | Currently every callsite to CommandLine::HasSwitch() has to generate code to allocate a string on the stack, malloc(), copy characters from the switch constant, and then free things when it goes out of scope. Testing on a Mac release build, this results in about 76kB of generated object code. (about 40 bytes for each of the ~1928 calls in the non-test codebase). Adding a char[] overload allows this codegen to happen only once. And there's no lost inlining benefit since the new overload can inline its call instead. BUG=468184 Review URL: https://codereview.chromium.org/1007283012 Cr-Commit-Position: refs/heads/master@{#322737}
* Make callers of CommandLine use it via the base:: namespace, and remove the ↵avi2014-12-251-3/+0
| | | | | | | | | | | | global alias. BUG=422426 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/812353003 Cr-Commit-Position: refs/heads/master@{#309644}
* base::CommandLine: Added optional quoting of placeholder arguments.mgiuca2014-10-011-2/+39
| | | | | | | | | | | | | | | | Added an optional parameter |quote_placeholder| to GetCommandLineString and GetArgumentsString. If true, placeholder command-line arguments such as "%1" will also be quoted. These need quoting in case the substituted argument has a space in it. It was previously not possible to build a CommandLine that would contain a quoted "%1" when converted to a string. Only affects Windows. BUG=416785 Review URL: https://codereview.chromium.org/595803002 Cr-Commit-Position: refs/heads/master@{#297617}
* base::CommandLine: Replace use of wstring with string16.mgiuca2014-10-011-3/+4
| | | | | | | | | | | | | | wstring is deprecated in Chromium. Since all the code in CommandLine using wstring is Windows-only, string16 is equivalent. This change is necessary to avoid a presubmit warning when touching the CommandLine code. BUG=416785 Review URL: https://codereview.chromium.org/602253006 Cr-Commit-Position: refs/heads/master@{#297608}
* Move CommandLine to base namespace.brettw@chromium.org2014-03-171-7/+12
| | | | | | | | | | | | Fix all forward-declares and header files referencing CommandLine. This keeps a "using base::CommandLine" in the command line header file so that the rest of the source files can be changes in a follow-up. TBR=sky Review URL: https://codereview.chromium.org/196413016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257514 0039d316-1c4b-4281-b951-d872f2087c98
* Allow typing label names on Windows by not treating things that start with ↵brettw@chromium.org2013-09-251-0/+11
| | | | | | | | | | | | | | | slashes as arguments rather than switches. The old command line parsing is still run so some code could get confused later since / will also be treated as a switch if you ask for it. This seems not as likely to happen that the label will match a switch. If it does, we'll have to change the CommandLine class to make the "/" behavior optional. Fix a "desc" crash attributing blame due to a null pointer. BUG= R=scottmg@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/24613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225277 0039d316-1c4b-4281-b951-d872f2087c98
* Allow tracing to console everywhere.vollick@chromium.org2013-07-111-0/+3
| | | | | | | | | | | | This patch gets rid of the cc-only trace-to-vlog stuff and replaces it with a general trace-to-console approach that can be used everywhere, even the browser. BUG=None Review URL: https://chromiumcodereview.appspot.com/18174006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211245 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath to base namespace.brettw@chromium.org2013-02-021-6/+9
| | | | | | | This updates headers that forward-declare it and a few random places to use the namespace explicitly. There us a using declaration in file_path.h that makes the rest compile, which we can do in future passes. Review URL: https://codereview.chromium.org/12163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180245 0039d316-1c4b-4281-b951-d872f2087c98
* Extract arguments reconstruction logic out of GetCommandLineString() into ↵gab@chromium.org2012-10-291-1/+7
| | | | | | | | | | | | GetArgumentsString(). BUG=To get arguments we had to GetCommandLineString() and piece out the program: http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/installer/util/install_util.cc&exact_package=chromium&q=GetCommandLineString&type=cs&l=125 TEST=base_unittests.exe --gtest_filter=CommandLineTest* Review URL: https://chromiumcodereview.appspot.com/11305010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164740 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Allow callers of CommandLine::Init to know whether they were the first caller.erikwright@chromium.org2012-02-271-3/+5
| | | | | | | | | | | | | | | | If there are multiple callers to Init, only one should call Reset. The boolean return value tells the caller whether they are the one responsible for the destruction. As long as the lifetimes of clients are strictly nested (i.e., a client X who uses CommandLine after client Y has initialized it always ceases its use before client Y destroys it) this secures access to this singleton object. One client in particular is updated to follow this model. I will submit follow-up CLs for remaining clients (at least, those who currently do call Reset). This is motivated by a crash in the chrome_frame_net_tests. This test executable nests a TestSuite within the lifetime of a ContentMainRunner (i.e., the engine that is typically used to run Chrome). The content layer initializes CommandLine and Resets it, but the TestSuite also resets it, leading to a DCHECK. This is currently the last remaining issue keeping the chrome_frame_net_tests off the waterfall, and I am very eager to get them back there to reduce the likelihood of further issues being introduced. BUG=114369 TEST=A test has been modified to reflect this change. Review URL: http://codereview.chromium.org/9477001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123763 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BASE_API to BASE_EXPORT.darin@chromium.org2011-08-051-2/+2
| | | | | | | R=rvargas Review URL: http://codereview.chromium.org/7461141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95618 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CommandLine::GetCommandLineString().msw@chromium.org2011-07-201-2/+1
| | | | | | | | | | | | Fix string hackery in net/tools/dump_cache/dump_cache.cc Fix const casts in chrome/installer/util/product.cc and base/process_util_win.cc. BUG=73195 TEST=none Review URL: http://codereview.chromium.org/7386002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93165 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CommandLine::GetArgs(), update callers.msw@chromium.org2011-07-131-2/+1
| | | | | | | | | BUG=73195 TEST=none Review URL: http://codereview.chromium.org/7352006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92448 0039d316-1c4b-4281-b951-d872f2087c98
* Nix CommandLine::GetSwitchCount.msw@chromium.org2011-07-131-4/+0
| | | | | | | | | BUG=73195 TEST=none Review URL: http://codereview.chromium.org/7342024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92423 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate most CommandLine code across platforms.msw@chromium.org2011-05-141-41/+29
| | | | | | | | | | | | | | | | | | | | | | Significant refactoring with some notable behavior changes: 1. Switches are appended preceding existing arguments (after other swtiches). 2. (Windows) command_line_string() is generated and properly quoted/escaped. 3. Appended switches will retain their (optional) included prefixes (--,-,/). Notable internal changes (shouldn't affect behavior): 1. (Windows) Generate the cl string, instead of storing&updating the original. 2. Explicitly retain switch prefixes (--,-,/) (was automatic in init*/ctor). Update (obvious) code expecting switches to be appended antecedent to args. Add Nico's test from: codereview.chromium.org/6728016/. An intermediary CL landed between patch set 3 and 4, see: http://codereview.chromium.org/6596020 BUG=73195,67764 TEST=Commandline usage. Review URL: http://codereview.chromium.org/6526040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85360 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Cleanup in the following files:jhawkins@chromium.org2011-04-041-1/+1
| | | | | | | | | | | | | | | | | | | | | * at_exit.cc * atomicops.h * base_paths.h * bzip2_error_handler.cc * callback_internal.h * command_line.cc * cpu.cc * environment.h * event_recorder.cc * file_descriptor_shuffle.cc * file_path.cc BUG=none TEST=none Review URL: http://codereview.chromium.org/6759017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80340 0039d316-1c4b-4281-b951-d872f2087c98
* Base: A few more files using BASE_API (for base.dll)rvargas@google.com2011-03-241-1/+2
| | | | | | | | BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6729002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79303 0039d316-1c4b-4281-b951-d872f2087c98
* Out-of-line default Commandline ctor and provide dtor.msw@chromium.org2011-03-011-2/+4
| | | | | | | | | BUG=73195 TEST=none Review URL: http://codereview.chromium.org/6588087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76419 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize CommandLine code.msw@chromium.org2011-03-011-108/+80
| | | | | | | | | | | | The majority of these changes are purely moving code. Conducted some minor (and hopefully straightforward) refactoring. BUG=73195 TEST=none Review URL: http://codereview.chromium.org/6596020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76339 0039d316-1c4b-4281-b951-d872f2087c98
* Register Application Restart with Windows Restart Manager on browser_main ↵msw@chromium.org2011-02-201-0/+3
| | | | | | | | | | | | | startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Use GetFunctionPointer/GetProcAddress to avoid XP link and run errors. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring. BUG=70824 TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75405 Review URL: http://codereview.chromium.org/6462024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75516 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75405 - Register Application Restart with Windows Restart Manager on ↵msw@chromium.org2011-02-181-3/+0
| | | | | | | | | | | | | | browser_main startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring. BUG=70824 TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments. Review URL: http://codereview.chromium.org/6462024 TBR=msw@chromium.org Review URL: http://codereview.chromium.org/6538059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75410 0039d316-1c4b-4281-b951-d872f2087c98
* Register Application Restart with Windows Restart Manager on browser_main ↵msw@chromium.org2011-02-181-0/+3
| | | | | | | | | | | startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring. BUG=70824 TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments. Review URL: http://codereview.chromium.org/6462024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75405 0039d316-1c4b-4281-b951-d872f2087c98
* Start sorting methods in class declarations.erg@google.com2011-01-071-23/+28
| | | | | | | | | | | | | | | | | | | | | | | | A lot of our headers are a mess and aren't organized. Impose the following order on files in the base/ directory: class Blah { each public/protected/private section: typedefs; enums; static constants; ctors; dtors; methods; overridden virtual methods; data members; }; BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70749 0039d316-1c4b-4281-b951-d872f2087c98
* Move the SetProcTitle code out of base and into chrome/common. This is onlybrettw@chromium.org2010-12-291-9/+1
| | | | | | | | | | | | | | used to support the weird way Chrome manages processes, so doesn't belong in the central CommandLine class. This also provides an empty implementation on Mac & Windows to avoid some ifdefs in the main functions. TEST=everything compiles BUG=none Review URL: http://codereview.chromium.org/6002013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70276 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of std::wstring version of HasSwitch.tfarina@chromium.org2010-12-081-7/+0
| | | | | | | | | BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/5649003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68650 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CommandLine::ARGUMENTS_ONLY to NO_PROGRAM.mattm@chromium.org2010-10-211-3/+4
| | | | | | | | | | | ARGUMENTS_ONLY was misleading since CommandLine has methods for handling "switches" and "arguments", but that constructor still allows both. BUG=none TEST=still builds Review URL: http://codereview.chromium.org/3935001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63325 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: remove wstring-based program() accessorevan@chromium.org2010-10-141-1/+0
| | | | | | | | | | | | | | This was already removed on non-Windows, so this change modifies the remaining Windows-specific usage. In a few places I converted use of wstring paths into FilePath, but in general for Windows-specific code I don't think it's too important to use FilePath everywhere, because it is equivalent on Windows and the current code already works. BUG=23581 Review URL: http://codereview.chromium.org/3817001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62637 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: deprecate another function on non-Windowsevan@chromium.org2010-10-081-1/+1
| | | | | | | | | BUG=23581 TEST=CommandLine unit tests Review URL: http://codereview.chromium.org/3549023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61889 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: remove deprecated wstring APIevan@chromium.org2010-10-071-2/+0
| | | | | | | | | | | | (o3d still uses an older version of base; if they update past this change they will need to apply the change I reverted in r55433.) BUG=23581 TEST=compiles, existing tests still pass Review URL: http://codereview.chromium.org/3552011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61839 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move some heavy, repeatedly emitted symbols to implementation files.erg@google.com2010-08-301-9/+2
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3162047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57896 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: eliminate wstring-accepting AppendLooseValueevan@chromium.org2010-08-131-2/+8
| | | | | | | | Instead use AppendArg variants which accept a FilePath or an ASCII string. Review URL: http://codereview.chromium.org/3134008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56100 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: remove three useless functions.evan@chromium.org2010-08-121-13/+0
| | | | | | | | | | | | | PrefixedSwitchString was full of encoding conversions, but there was only one real caller, and the function is trivial. Terminate is leftover cruft. TEST=compiles Review URL: http://codereview.chromium.org/3138001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55931 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: Deprecate a function on non-Windows.evan@chromium.org2010-08-091-11/+10
| | | | | | | | | | Merge deprecated functions together. TEST=compiles Review URL: http://codereview.chromium.org/3029068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55460 0039d316-1c4b-4281-b951-d872f2087c98
* PrependWrapper is platform-specific, so it should take a platform string.evan@chromium.org2010-08-041-3/+3
| | | | | | | | | Though the comments said it was POSIX only, I see it used on Windows as well so I'm updating the comment. Review URL: http://codereview.chromium.org/3030043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54933 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated CommandLine API.evan@chromium.org2010-07-301-9/+0
| | | | | | | | | Cleaned up the final few callers, punting the remaining harder ones to TODOs. Review URL: http://codereview.chromium.org/3043033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54400 0039d316-1c4b-4281-b951-d872f2087c98
* Add an AppendSwitchASCII to CommandLine, and convert a test to it.evan@chromium.org2010-07-301-2/+5
| | | | | | | | | | | I'm removing all the AppendSwitchWithValue() users due to wstrings, and this is one caller. Since fixing this one caller requires touching many files, I thought I'd isolate this change from the other WithValue->ASCII conversions. Review URL: http://codereview.chromium.org/2878065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54257 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: add a CopySwitchesFrom() and AppendSwitchPath()evan@chromium.org2010-07-291-6/+15
| | | | | | | | | | | These are two common patterns in Chrome code: copying a subset of switches from one CommandLine to another, and appending a FilePath to a CommandLine. This sets me up to do a lot more deprecation in a follow-up change. Review URL: http://codereview.chromium.org/3012021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54218 0039d316-1c4b-4281-b951-d872f2087c98
* base/ header cleanup. Forward declaration instead of including.erg@google.com2010-07-281-32/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3068004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated CommandLine::GetLooseValues(), rename to args().evan@chromium.org2010-07-211-7/+5
| | | | | | | | | | | | | | | It returned a wstring, when really we wanted the native encoded strings. Fixing the majority of callers actually simplified them in many cases because the callers wanted native strings too. Since I'm touching every caller, I gave it a more useful name. I'm not sure where "loose" came from but it never made sense to me. BUG=24672 Review URL: http://codereview.chromium.org/3028010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53193 0039d316-1c4b-4281-b951-d872f2087c98
* Move implementation from header to source.erg@chromium.org2010-07-151-1/+2
| | | | | | | | | | | | | | | | | | | | This is an effort to speed up compile and link time, and also minimizing the size of the intermediary .o files on disk. For example, just moving the constructor/destructor from the classes in chrome/browser/pref_member.{cc,h} netted a 368k drop in total .o file size. In aggregate, this shrinks libbrowser.a by 10 megabytes, and a few odd megabytes on most other chrome .a files. A lot of this was done before I started harvesting what the most included symbols were across all of chrome's code. Most of them are in webkit, but there's plenty in base/ that are used everywhere to keep me busy for several patches to come. BUG=none TEST=none Review URL: http://codereview.chromium.org/3012001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52528 0039d316-1c4b-4281-b951-d872f2087c98
* Make out-of-process tests output correct XML file (re-submitting due to ↵kinuko@chromium.org2010-05-241-2/+5
| | | | | | | | | | | | | | | | wrong revert) - Disable XML output for children - Output XML file with failed, disabled and timing information in the parent launcher process. BUG=40473,42781 TEST=run the browser_tests (or other tests that uses out-of-proc-test runner) with 1) --gtest_output=xml 2) --gtest_output=xml:test.xml 3) --gtest_output=xml:/tmp/ and see if the output XML file (test_detail.xml for 1), test.xml for 2), /tmp/browser_tests.xml for 3)) contains correct information. TBR=phajdan.jr,satorux Review URL: http://codereview.chromium.org/2148002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48028 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 48015 - Make outofprocess tests output correct XML file (filepath fixed)kinuko@chromium.org2010-05-241-5/+2
| | | | | | | | | | | | | | | | | | | | | Original issue was: http://codereview.chromium.org/2071001/show (reverted due to build break) Disable XML output for children Output XML file with failed, disabled and timing information in the parent launcher process. BUG=40473,42781 TEST=run the browser_tests (or other tests that uses outofproctest runner) with 1) gtest_output=xml 2) gtest_output=xml:test.xml 3) gtest_output=xml:/tmp/ and see if the output XML file (test_detail.xml for 1), test.xml for 2), /tmp/browser_tests.xml for 3)) contains correct information. Review URL: http://codereview.chromium.org/2071001 Review URL: http://codereview.chromium.org/2067022 TBR=satorux@chromium.org Review URL: http://codereview.chromium.org/2161001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48019 0039d316-1c4b-4281-b951-d872f2087c98
* Make out-of-process tests output correct XML file (filepath fixed)kinuko@chromium.org2010-05-241-2/+5
| | | | | | | | | | | | | | | | | | Original issue was: http://codereview.chromium.org/2071001/show (reverted due to build break) - Disable XML output for children - Output XML file with failed, disabled and timing information in the parent launcher process. BUG=40473,42781 TEST=run the browser_tests (or other tests that uses out-of-proc-test runner) with 1) --gtest_output=xml 2) --gtest_output=xml:test.xml 3) --gtest_output=xml:/tmp/ and see if the output XML file (test_detail.xml for 1), test.xml for 2), /tmp/browser_tests.xml for 3)) contains correct information. Review URL: http://codereview.chromium.org/2071001 Review URL: http://codereview.chromium.org/2067022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48015 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a TODO in data export of net-internals, added Chrome version and ↵maruel@chromium.org2010-05-211-0/+3
| | | | | | | | | | | | | command line. BUG=none TEST=Go to about:net-internals click on dump to text, check if version and command line are good. Patch contributed by malavv Review URL: http://codereview.chromium.org/2104012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47926 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-05-18 07:38:54 +0000