summaryrefslogtreecommitdiffstats
path: root/base/file_version_info.h
Commit message (Collapse)AuthorAgeFilesLines
* Redefine CreateFileVersionInfoForCurrentModule() as a macro on Windows.gab2015-08-281-10/+13
| | | | | | | | | | | | | This makes extra sure that inlining occurs. When __force_inline doesn't work... brute-force-inline..! BUG=516359 TBR=gene@chromium.org Review URL: https://codereview.chromium.org/1306603003 Cr-Commit-Position: refs/heads/master@{#346041}
* Cleanup: Fix base header include guards.tfarina2015-05-131-3/+3
| | | | | | | | | | | | | | | | The header include guards should match the file path from root. These entries were found using a modified version of Eric's fix-include-guards.py script found attached in https://code.google.com/p/chromium/issues/detail?id=435361#c7. BUG=435361 TEST=base_unittests R=danakj@chromium.org Review URL: https://codereview.chromium.org/1137323003 Cr-Commit-Position: refs/heads/master@{#329731}
* FileVersionInfoWin: BASE_EXPORT the class instead of select methods.mgiuca2015-05-071-5/+4
| | | | | | | | | | | | | | | | | | Some methods are being called from a different component, so should be exported. Rather than selectively exporting them, we just made the entire class (and its parent class, FileVersionInfo) BASE_EXPORTed. Note: This is not currently breaking the build, because the methods are called by virtual dispatch, but in principle, they should be exported. Context: I am investigating adding the "final" keyword to a bunch of classes (http://crbug.com/482800) and this breaks once "final" is added to FileVersionInfoWin. BUG=484939 Review URL: https://codereview.chromium.org/1122413002 Cr-Commit-Position: refs/heads/master@{#328683}
* Move more uses of string16 to specify base::brettw@chromium.org2013-12-031-15/+15
| | | | | | | | | | This makes base, ui, and net compile without the "using base::string16" directive that's currently checked in. BUG= Review URL: https://codereview.chromium.org/100303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238246 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in base/.avi@chromium.org2013-06-111-1/+1
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16745002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205530 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath to base namespace.brettw@chromium.org2013-02-021-1/+3
| | | | | | | This updates headers that forward-declare it and a few random places to use the namespace explicitly. There us a using declaration in file_path.h that makes the rest compile, which we can do in future passes. Review URL: https://codereview.chromium.org/12163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180245 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BASE_API to BASE_EXPORT.darin@chromium.org2011-08-051-4/+4
| | | | | | | R=rvargas Review URL: http://codereview.chromium.org/7461141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95618 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Components build for base, easy partthakis@chromium.org2011-07-291-1/+1
| | | | | | | | | | BUG=90078 TEST=none Review URL: http://codereview.chromium.org/7474010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94636 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Fix FileVersionInfo::CreateFileVersionInfoForCurrentModule so thatrvargas@google.com2011-04-221-3/+28
| | | | | | | | | | | when base is built as a dll, the module that is inspected for the version info is the one that makes the call instead of base.dll BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6897016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82754 0039d316-1c4b-4281-b951-d872f2087c98
* Base: A few more files using BASE_API (for base.dll)rvargas@google.com2011-03-251-4/+4
| | | | | | | | BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6733031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79426 0039d316-1c4b-4281-b951-d872f2087c98
* Update file version info/memory details/process utils to use string16.avi@chromium.org2010-12-231-25/+27
| | | | | | | | | BUG=23581 TEST=everything still works Review URL: http://codereview.chromium.org/5968008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70071 0039d316-1c4b-4281-b951-d872f2087c98
* file_version_info was not finding Mac values correctly. Got it now looking ↵dmaclach@chromium.org2010-12-201-1/+4
| | | | | | | | | | | in the appropriate bundle. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69728 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69592 - file_version_info was not finding Mac values correctly.dmaclach@chromium.org2010-12-181-4/+1
| | | | | | | | | | | | | | Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 TBR=dmaclach@chromium.org Review URL: http://codereview.chromium.org/6017003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69601 0039d316-1c4b-4281-b951-d872f2087c98
* file_version_info was not finding Mac values correctly.dmaclach@chromium.org2010-12-181-1/+4
| | | | | | | | | | | Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69592 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Add virtual destructor to base class to resolve leak.jar@chromium.org2010-05-211-0/+1
| | | | | | | | | | | | | | This appears to resolve the regression that might have been instigated in 44435. This was very significant on Windows, as the derived class held a lot of data in file_version_info_win.cc. BUG=44320 r=mbelshe Review URL: http://codereview.chromium.org/2131023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47964 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor FileVersionInfo into an interface with platform implementations.tony@chromium.org2010-04-141-63/+20
| | | | | | | | | | | | | This allows us to move the chrome specific version informaton used by Linux into src/chrome. Add a GetChromeVersionInfo() for Linux in src/chrome/app/ and make sure to use this in src/chrome. In src/webkit/glue, add a new glue method for getting the product version. When compiling chrome, use an implementation in src/chrome/renderer (which uses GetChromeVersionInfo()) and a stub implementation for test_shell. Review URL: http://codereview.chromium.org/1560027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44435 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to base/ from a combination of FreeBSD and OpenBSD patches.evan@chromium.org2009-12-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/495002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35321 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in base/phajdan.jr@chromium.org2009-06-031-1/+2
| | | | | | | | Also adds more explicit #includes for needed things. Review URL: http://codereview.chromium.org/118162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17479 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-1/+0
| | | | | | | | | Normalize end of file newlines in base/. All files end in a single newline. Review URL: http://codereview.chromium.org/42011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11329 0039d316-1c4b-4281-b951-d872f2087c98
* Make file_version_info work even without including windows.hbrettw@chromium.org2009-03-051-1/+4
| | | | | | Review URL: http://codereview.chromium.org/39166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10942 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE (except one global std::wstring changed to const wchar_t* ↵maruel@chromium.org2009-03-031-1/+1
| | | | | | | | | | | const per style compliance). Preliminary work to enforce new PRESUBMIT.py rules: - <=80 cols - no trailing whitespaces - svn:eol-style=LF git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10791 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome not starting up by implementing a straw-man, lieing versionerg@google.com2009-02-231-0/+2
| | | | | | | | | | | | | | of FileVersionInfoLinux. This will need to be ripped out later on, but we need it for now because we can't just return NULL on CreateFileVersionInfoForCurrentModule(), because the interfaces only expect a NULL on being unable to open a file. Review URL: http://codereview.chromium.org/27070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10218 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath support to FileVersionInfo, fix Mac memory issues.avi@google.com2008-12-231-1/+4
| | | | | | Review URL: http://codereview.chromium.org/15082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7417 0039d316-1c4b-4281-b951-d872f2087c98
* Some more passing tests in base for Linuxmmentovai@google.com2008-08-271-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1460 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* I accidentally committed file_version_info. Since comments were relatively ↵erikkay@google.com2008-08-121-3/+3
| | | | | | minor, I created a new CL rather than reverting the old one. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@722 0039d316-1c4b-4281-b951-d872f2087c98
* Bring over the changes from the Mac branch.paulg@google.com2008-08-051-0/+17
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@392 0039d316-1c4b-4281-b951-d872f2087c98
* Add base to the repository.initial.commit2008-07-261-0/+97
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8 0039d316-1c4b-4281-b951-d872f2087c98