summaryrefslogtreecommitdiffstats
path: root/base/scoped_observer.h
Commit message (Collapse)AuthorAgeFilesLines
* Switch to standard integer types in base/.avi2015-12-261-1/+3
| | | | | | | | | | BUG=138542 TBR=mark@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1538743002 Cr-Commit-Position: refs/heads/master@{#366910}
* Cleanup: Use ContainsValue() instead of std::find() in base/thestig2015-12-071-2/+2
| | | | | | | | BUG=561800 Review URL: https://codereview.chromium.org/1473983004 Cr-Commit-Position: refs/heads/master@{#363519}
* Add callback in UserScriptLoader to notify users when scripts are loaded.hanxi2015-05-051-0/+2
| | | | | | | | BUG=461052, 482446 Review URL: https://codereview.chromium.org/1110143002 Cr-Commit-Position: refs/heads/master@{#328385}
* Listen to Off The Record profiles in ContentSettingsHandler.scheib2014-10-271-1/+4
| | | | | | | | | | | | | | | | | | | | | | ContentSettingsHandler is now made aware of Off The Record profiles and will observe them as well, correcting bugs where changes from the settings webUI would function incorrectly. This is a rework of a previously landed fix [fix] which was reverted due to a crash bug [crash] when OTR profiles already existed before settings were opened. [fix] https://codereview.chromium.org/585953003 [crash] https://code.google.com/p/chromium/issues/detail?id=417597 BUG=425079, 418931 Committed: https://crrev.com/c9ba380c606442a025a38eb67f4d35c65b1a293c Cr-Commit-Position: refs/heads/master@{#301273} Review URL: https://codereview.chromium.org/676083003 Cr-Commit-Position: refs/heads/master@{#301461}
* Revert of Listen to Off The Record profiles in ContentSettingsHandler. ↵avi2014-10-251-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #3 id:60001 of https://codereview.chromium.org/676083003/) Reason for revert: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 is dying consistently in GuestModeOptionsBrowserTest.LoadOptionsByURL: [16175:16175:1024/205028:FATAL:observer_list.h(159)] Check failed: false. Observers can only be added once! #0 0x7fca41ce4b8e base::debug::StackTrace::StackTrace() This looks like a very related CL. Original issue's description: > Listen to Off The Record profiles in ContentSettingsHandler. > > ContentSettingsHandler is now made aware of Off The Record profiles > and will observe them as well, correcting bugs where changes from the > settings webUI would function incorrectly. > > This is a rework of a previously landed fix [fix] which was reverted due to > a crash bug [crash] when OTR profiles already existed before settings > were opened. > > [fix] https://codereview.chromium.org/585953003 > [crash] https://code.google.com/p/chromium/issues/detail?id=417597 > > BUG=425079, 418931 > > Committed: https://crrev.com/c9ba380c606442a025a38eb67f4d35c65b1a293c > Cr-Commit-Position: refs/heads/master@{#301273} TBR=thestig@chromium.org,scheib@chromium.org NOTREECHECKS=true NOTRY=true BUG=425079, 418931 Review URL: https://codereview.chromium.org/652183006 Cr-Commit-Position: refs/heads/master@{#301292}
* Listen to Off The Record profiles in ContentSettingsHandler.scheib2014-10-251-1/+4
| | | | | | | | | | | | | | | | | | | ContentSettingsHandler is now made aware of Off The Record profiles and will observe them as well, correcting bugs where changes from the settings webUI would function incorrectly. This is a rework of a previously landed fix [fix] which was reverted due to a crash bug [crash] when OTR profiles already existed before settings were opened. [fix] https://codereview.chromium.org/585953003 [crash] https://code.google.com/p/chromium/issues/detail?id=417597 BUG=425079, 418931 Review URL: https://codereview.chromium.org/676083003 Cr-Commit-Position: refs/heads/master@{#301273}
* Cleanup: Remove NOTIFICATION_EXTENSION_UNLOADED usage in MediaScanManager.thestig@chromium.org2014-04-081-7/+9
| | | | | | | | BUG=354046 Review URL: https://codereview.chromium.org/207613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262295 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in a few of the tests in content_browsertests on Linux. The ↵jam@chromium.org2012-10-051-1/+9
| | | | | | | | | problem was that DesktopActivationClient would be created after an aura::Window so it would never register for notifications that it went away. As a result it would call a deleted Window in its ActivateWindow method. BUG=146077 Review URL: https://codereview.chromium.org/11062004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160386 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Redo how activation is handled.erg@chromium.org2012-06-221-0/+47
This is an almost complete overhaul of how activation works. oshima@ recently changed ActivationController/FocusManager so that there was a single one per desktop instead of per RootWindow. Because of this, our code that listens for activation changes from X11 is wrong, and has been moved to its own class which also owns the singleton ActivationController. DesktopActivationController had a wrong model. It should be activating the toplevel window like BrowserFrameAura, even across RootWindows. This has been fixed. Also moved the utility class ScopedObserver to base/. TODO: This fixes all activation problems I've seen except for trying to cause a bubble to show when the chrome window is deactivated while a non-chrome window is active. BUG=130798,133055,133089 TEST=none Review URL: https://chromiumcodereview.appspot.com/10631008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143716 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-05-18 08:00:34 +0000