| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=mark@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1538743002
Cr-Commit-Position: refs/heads/master@{#366910}
|
|
|
|
|
|
|
|
| |
BUG=138542,488550
Review URL: https://codereview.chromium.org/1498003003
Cr-Commit-Position: refs/heads/master@{#363854}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, Pass() did not work correctly for ScopedMachReceiveRight,
ScopedMachSendRight, or ScopedMachPortSet. These were defined as
subclasses of ScopedGeneric<> with appropriate traits types. They did
not have the full range of constructors made available by
ScopedGeneric<>, and their Pass() methods referred to their
ScopedGeneric<> superclass rather than their proper class types.
This changes these scopers to work as ScopedGeneric<> intends, with a
"using" or "typedef" declaration, so that names such as
ScopedMachReceiveRight actually refer to the same type as the underlying
ScopedGeneric<>. This allows Pass() and all other ScopedGeneric<>
functionality to work as intended.
Unfortunately, ScopedGeneric<> doesn't provide a type conversion
operator to the underlying wrapped type, so many use sites need to be
transformed to use the get() accessor. Many existing use sites already
used this accessor.
Review URL: https://codereview.chromium.org/1411523006
Cr-Commit-Position: refs/heads/master@{#355112}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The presubmit is already robust to handle Objective-C .h files. Not
checking .mm files just adds extra review burden. Plus I can't just
press F5 in Sublime to sort lines in .mm files due to import vs include,
so it actually needs some brainpower when adding something and I keep
forgetting to do that.
This adds .mm to the list of file extensions the header sorting
presubmit checks for, and fixes the current mistakes to avoid annoying
people on presubmit with this change.
BUG=None
TBR=keybuk@chromium.org,jamescook@chromium.org,stuartmorgan@chromium.org,xhwang@chromium.org,rsesek@chromium.org,zea@chromium.org
R=thakis@chromium.org,jochen@chromium.org
Review URL: https://codereview.chromium.org/1133713009
Cr-Commit-Position: refs/heads/master@{#330509}
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's only called from one place, so move it there:
- chrome/browser/metrics/drive_metrics_provider.cc
R=rvargas@chromium.org,asvitkine@chromium.org
BUG=463209
Review URL: https://codereview.chromium.org/1051663002
Cr-Commit-Position: refs/heads/master@{#323526}
|
|
|
|
|
|
|
|
|
|
| |
BUG=463209
R=rvargas@chromium.org
TBR=asvitkine@chromium.org
Review URL: https://codereview.chromium.org/1011433002
Cr-Commit-Position: refs/heads/master@{#321224}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
explicit and clear.
ScopedMachPort was only properly handling send rights, accidentally leaking
receive rights in some places. This adds an additional scoper for handling
receive rights.
BUG=none
R=mark@chromium.org
Review URL: https://codereview.chromium.org/294393007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Function is duplicate of Mac OSX version
BUG=338760
Review URL: https://codereview.chromium.org/183063004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This updates callers in base but I left a forwarding header so I can the rest in pieces (there are >300).
Review URL: https://codereview.chromium.org/12213061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
During startup, the system name and/or version is requested a number of times, and each call is 1ms or more. Changed the numbers parsing to use std::string instead of NSString so that the static variable could be an std::string, avoiding having to make the conversion every function call.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11437046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ScopedMachPort class.
BUG=119379
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11188003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and Linux.
BUG=136519
TEST=browser_test --gtest_filter=SystemInfoCpuApiTest.*
Review URL: https://chromiumcodereview.appspot.com/10914060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=NONE
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/10704123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146106 0039d316-1c4b-4281-b951-d872f2087c98
|