| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
This is a followup to https://codereview.chromium.org/1657433002/ to
move the LL_* macros to prtime.h
Review URL: https://codereview.chromium.org/1713433002
Cr-Commit-Position: refs/heads/master@{#376709}
|
|
|
|
|
|
|
|
| |
BUG=567982
Review URL: https://codereview.chromium.org/1657433002
Cr-Commit-Position: refs/heads/master@{#375481}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After http://llvm.org/viewvc/llvm-project?rev=259271&view=rev, clang points
out that lineno is sometimes assigned a value > SHRT_MAX, which causes
an overflow. All values are smaller than USHRT_MAX, so just make lineno
an unsigned short.
No behavior change.
BUG=none
Review URL: https://codereview.chromium.org/1653973005
Cr-Commit-Position: refs/heads/master@{#372952}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's needed by clock_gettime() on glibc < 2.17, and that function is
called in various places in the codebase. This library is part of glibc,
so just put in the default toolchain libs so we get it everywhere.
It fixes the following build error:
gn gen out_gn_ozone --args='use_ozone=true toolkit_views=false is_component_build=true'
ninja -C out_gn_ozone content_shell
../ui/gl/sync_control_vsync_provider.cc:70: error: undefined reference to
'clock_gettime'
../ui/gl/sync_control_vsync_provider.cc:71: error: undefined reference to
'clock_gettime'
Review URL: https://codereview.chromium.org/1565983002
Cr-Commit-Position: refs/heads/master@{#368383}
|
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=mark@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1538743002
Cr-Commit-Position: refs/heads/master@{#366910}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This saves a nontrivial amount of space for some of the smaller targets in release builds. See the comment added to the base target for more.
Remove libmojo_sdk. This is a complete static library that depended on base. Since base is now a static library, this dependency is not allowed. The mojo team says this target is no longer needed, so it was deleted.
Reland of https://codereview.chromium.org/1528233002/
The difference is that this now depends on https://codereview.chromium.org/1540953003/ which merges base into one library. This prevents the component build issues that were causing problems.
TBR=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1545493002
Cr-Commit-Position: refs/heads/master@{#366621}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This simplifies the process of bootstrapping gn standalone.
And libevent is not really used outside of base. base is actually its only client.
BUG=569352
TEST=See CL for details for how to reproduce this.
R=thestig@chromium.org
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/1531573008
Cr-Commit-Position: refs/heads/master@{#366282}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1528233002/ )
Reason for revert:
Breaks Win GN link:
unresolved external symbol JSONFileValueDeserializer::JSONFileValueDeserializer ... referenced in function "class JsonPrefStore::ReadResult> > __cdecl `anonymous namespace'::ReadPrefsFromDisk ...
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/15424/steps/compile/logs/stdio
Original issue's description:
> Make base a static ibrary
>
> This saves a nontrivial amount of space for some of the smaller targets in release builds. See the comment added to the base target for more.
>
> Remove libmojo_sdk. This is a complete static library that depended on base. Since base is now a static library, this dependency is not allowed. The mojo team says this target is no longer needed, so it was deleted.
>
> Committed: https://crrev.com/89c7be623e3cc5052aaf8c3be3996432a9d4bceb
> Cr-Commit-Position: refs/heads/master@{#365955}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1532953003
Cr-Commit-Position: refs/heads/master@{#366062}
|
|
|
|
|
|
|
|
|
|
| |
This saves a nontrivial amount of space for some of the smaller targets in release builds. See the comment added to the base target for more.
Remove libmojo_sdk. This is a complete static library that depended on base. Since base is now a static library, this dependency is not allowed. The mojo team says this target is no longer needed, so it was deleted.
Review URL: https://codereview.chromium.org/1528233002
Cr-Commit-Position: refs/heads/master@{#365955}
|
|
|
|
|
|
|
|
|
|
| |
The old URL is a manual redirect to the new URL, so use the new URL.
BUG=chromium:476190
Review URL: https://codereview.chromium.org/1388303003
Cr-Commit-Position: refs/heads/master@{#353590}
|
|
|
|
|
|
|
|
|
| |
TBR=thestig@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1371513003
Cr-Commit-Position: refs/heads/master@{#350695}
|
|
|
|
|
|
|
|
|
| |
TBR=mmoss@chromium.org (chrome/installer/linux)
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1324623005
Cr-Commit-Position: refs/heads/master@{#348727}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clang warns if there are missing braces around a subobject
initializer. The most common idiom that triggers this is:
STRUCT s = {0};
if the first field of STRUCT is itself a struct. This can
be more simply written as:
STRUCT s = {};
which also prevents the warning from firing.
BUG=505297
Review URL: https://codereview.chromium.org/1218243002
Cr-Commit-Position: refs/heads/master@{#337139}
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/1187063003
Cr-Commit-Position: refs/heads/master@{#335702}
|
|
|
|
|
|
|
|
|
|
| |
- use of pointer after being freed.
BUG=
Review URL: https://codereview.chromium.org/1037023002
Cr-Commit-Position: refs/heads/master@{#326352}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes required:
- fold //base/third_party/nspr/prtime.cc into base
- fixed a compile error causing issues in media_blink_unittests
- fixed various missing dependencies
- disabled chrome_sync_shell_test_apk which needs some more work
Note that this does not mean that things run. I expect they don't :).
R=cjhopman@chromium.org
BUG=359249
Review URL: https://codereview.chromium.org/1089143002
Cr-Commit-Position: refs/heads/master@{#325568}
|
|
|
|
|
|
|
|
| |
TBR=ncbray
Review URL: https://codereview.chromium.org/1016443002
Cr-Commit-Position: refs/heads/master@{#320771}
|
|
|
|
|
|
|
|
|
|
| |
BUG=401761
TBR=brettw
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/972203003
Cr-Commit-Position: refs/heads/master@{#319987}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Application of https://codereview.chromium.org/962003002/.
TBR=keybuk@chromium.org
R=brettw@chromium.org
BUG=456014
Review URL: https://codereview.chromium.org/960413003
Cr-Commit-Position: refs/heads/master@{#318574}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should get most of NaCl and the PPAPI stuff needed
for NaCl building and linking. There is more work to be
done to get some of the test binaries working (and
probably fill out parts of the NaCl SDK) and possibly
some pnacl support work remaining as well.
NaCl is still disabled by default (set enable_nacl=true
to change). Enabling nacl is still mostly untested and
likely doesn't work at all :).
R=ncbray@chromium.org, brettw@chromium.org
BUG=432959
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/877553008
Cr-Commit-Position: refs/heads/master@{#318180}
|
|
|
|
|
|
|
|
| |
This fixes the header issues in these directories and adds them to the list of targets to be checked.
Review URL: https://codereview.chromium.org/926593007
Cr-Commit-Position: refs/heads/master@{#316705}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In crrev.com/316164, a bug was fixed to handle comments in
a source list correctly.
In this patch, a bug was fixed to handle comments at the
end of a source list.
Along the way, sort some GYP files in sub directories under
base and net, which I forgot to sort previously.
BUG=456014
TEST=everything should build as before
Review URL: https://codereview.chromium.org/924743002
Cr-Commit-Position: refs/heads/master@{#316418}
|
|
|
|
|
|
|
|
|
|
|
|
| |
For tools/sort_sources.py to be useful, existing GYP files
should be sorted.
BUG=456014
TEST=everything should build as before
Review URL: https://codereview.chromium.org/923853002
Cr-Commit-Position: refs/heads/master@{#316183}
|
|
|
|
|
|
|
|
|
|
| |
BUG=349861
TBR=danakj@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/783953002
Cr-Commit-Position: refs/heads/master@{#307225}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change makes all libraries in the Android component build link
successfully (including fixing and enabling libchrome_shell). This also makes
all the libraries link in a component build for Linux, but without bot coverage
for that platform it'll surely regress.
This is almost entirely just fixing some missing/incorrect dependencies and
adding missing source files for Android.
Some targets were depending on an internal source_set/static_library when they
should have been (or already were) depending on the corresponding component. In
these cases, I added some visibility restrictions to those internal targets to
try to prevent those types of dependencies from coming back.
BUG=359249
Review URL: https://codereview.chromium.org/666813002
Cr-Commit-Position: refs/heads/master@{#301386}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
explicit casts.
I didn't check whether there were other, better fixes here by changing more
underlying types/behaviors; I assumed the existing code was correct and just
made the typecasts explicit.
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/601593002
Cr-Commit-Position: refs/heads/master@{#296668}
|
|
|
|
|
|
|
|
|
|
|
| |
by inserting explicit casts; I didn't try to actually change any behavior).
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/590413006
Cr-Commit-Position: refs/heads/master@{#296666}
|
|
|
|
|
|
|
|
| |
BUG=411909
Review URL: https://codereview.chromium.org/555373004
Cr-Commit-Position: refs/heads/master@{#295306}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently this is either a list or a string. However, this is causing some problems because templates can't add to the invoker's visibility list without knowing if the original is a string or a list.
In an effort to make this consistent, I'm converting all visibiltiy to be lists, and will remove support for strings in a future build.
This exempts cld from header checking since it was confusing GN's header checker. It adds a ppapi header target as well that will be used by libyuv (that requires a roll).
TBR=scottmg
Review URL: https://codereview.chromium.org/544423002
Cr-Commit-Position: refs/heads/master@{#293638}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
edition
This contains fixes for the following sorts of issues:
* Assignment inside conditional
This updates the relevant .patch and README files, combining these fixes with
the previous set of MSVC warning fixes. This also removes the now-unused
vs2013-optimization.patch file.
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/385503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This contains fixes for the following sorts of issues:
* Signedness mismatch
Defining UChar32 as a signed type may look wrong, but it's actually how the type
is already defined over in third_party/icu/.
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/380913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These should be fixed on the current version of VS2013.
R=brettw@chromium.org
BUG=288948
Review URL: https://codereview.chromium.org/338523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change some targets to source sets. These are small ones that are currently depended on by other source sets. This avoids some duplicate symbols.
duplicated.
Fix some conditions around the touch_device in ui/base.
Lots of Skia build fixes. It turns out our skia library does not use the "util" target, and some of the files in "util" reference functions that it seems are never defined in any file. This removes the ones in our list that weren't in skia_library.gypi to make accessibility_unittests link.
Update gesture recogniser file lists.
BUG=377890
TBR=scottmg
Review URL: https://codereview.chromium.org/305993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
parsing in SyslogParser.
Previously, SyslogParser::ParseTime() would parse time, reformat it in a way that is understood by NSPR and then hand it off to PR_ParseTimeString() where it is parsed again. This double-parsing is unnecessarily convoluted and slow. Extending PR_ParseTimeString() simplifies and speeds up SyslogParser::ParseTime() which is time-critical in case of large log files.
BUG=370509
Review URL: https://codereview.chromium.org/266193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Implement GN visibility in the build, which this new version implements
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/217273004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This removes the GYP generator code and associated build stuff.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/206813002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Copy the type and macro definitions we need to base/third_party/nspr/prtime.h.
Add chromium-prtypes.h to crypto/third_party/nss.
content/common/plugin_list_posix.cc doesn't need to include prcpucfg_linux.h.
R=ananta@chromium.org,mark@chromium.org,rsleevi@chromium.org
Review URL: https://codereview.chromium.org/209343003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=354405
Review URL: https://codereview.chromium.org/206073009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org
BUG=354261
Review URL: https://codereview.chromium.org/205723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add missing definitions for MIPS NaCl.
BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275
TEST= build and run Chromium with NaCl
Review URL: https://codereview.chromium.org/192883003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- demangle.cc
- demangle.h
- symbolize.cc
- symbolize.h
The new functionality is a callback mechanism to allow users of
google.glog to provide their own implementation of
OpenObjectFileContainingPcAndGetStartAddress.
BUG=
Review URL: https://codereview.chromium.org/180163013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code was written by Paul Hsieh under a 3-clause BSD license. It
belongs in third_party.
I did not move the existing implementation, but re-downloaded the code
from upstream:
http://www.azillionmonkeys.com/qed/hash.html
This version is formatted differently and is written in plain C, but it
is identical to the version that was previously in hash.cc.
Added LICENSE and README.chromium files, as well as adding license text
to the top of superfasthash.cc, as required by checklicenses.py.
BUG=347393
Review URL: https://codereview.chromium.org/181643004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=wtc@chromium.org, phajdan.jr@chromium.org
TBR=willchan
Review URL: https://codereview.chromium.org/167693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=scottmg@chromium.org, scottmg
Review URL: https://codereview.chromium.org/138273007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also removes thread_local_storage.cc which was removed from the .gyp file.
R=viettrungluu@chromium.org
TBR=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/119323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Various minor fixes in base needed for [P]NaCl port of remoting client:
- added base_i18n_untrusted target
- md5 is included in base_untrusted.
- base/metrics is compiled in base_untrusted (src/net depends on it).
- enabled PNaCl build of base_untrusted
- __builtin_extract_return_addr() is not allowed in PNaCl (validator
rejects it).
- sys_byteorder.h now works in NaCl.
BUG=276739
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242270
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/116803005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Somewhat speculative, to try and fix
chromeos-chrome-34.0.1755.0_alpha-r1: armv7a-cros-linux-gnueabi-g++ -B/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.22-gold '-DV8_DEPRECATION_WARNINGS' '-D_FILE_OFFSET_BITS=64' '-DCHROMIUM_BUILD' '-DTOOLKIT_VIEWS=1' '-DUI_COMPOSITOR_IMAGE_TRANSPORT' '-DUSE_AURA=1' '-DUSE_ASH=1' '-DUSE_CAIRO=1' '-DUSE_CRAS=1' '-DUSE_GLIB=1' '-DUSE_DEFAULT_RENDER_THEME=1' '-DUSE_NSS=1' '-DUSE_X11=1' '-DOS_CHROMEOS=1' '-DUSE_XI2_MT=2' '-DFILE_MANAGER_EXTENSION=1' '-DIMAGE_LOADER_EXTENSION=1' '-DENABLE_REMOTING=1' '-DENABLE_WEBRTC=1' '-DENABLE_PEPPER_CDMS' '-DENABLE_CONFIGURATION_POLICY' '-DENABLE_INPUT_SPEECH' '-DENABLE_NOTIFICATIONS' '-DENABLE_HIDPI=1' '-DUSE_UDEV' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DENABLE_EGLIMAGE=1' '-DENABLE_TASK_MANAGER=1' '-DENABLE_EXTENSIONS=1' '-DENABLE_PLUGINS=1' '-DENABLE_SESSION_SERVICE=1' '-DENABLE_THEMES=1' '-DENABLE_AUTOFILL_DIALOG=1' '-DENABLE_BACKGROUND=1' '-DENABLE_AUTOMATION=1' '-DENABLE_GOOGLE_NOW=1' '-DCLD_VERSION=2' '-DENABLE_FULL_PRINTING=1' '-DENABLE_PRINTING=1' '-DENABLE_SPELLCHECK=1' '-DENABLE_CAPTIVE_PORTAL_DETECTION=1' '-DENABLE_APP_LIST=1' '-DENABLE_MANAGED_USERS=1' '-DENABLE_MDNS=1' '-DNET_IMPLEMENTATION' '-DENABLE_BUILT_IN_DNS' '-DU_USING_ICU_NAMESPACE=0' '-DU_STATIC_IMPLEMENTATION' '-D__STDC_CONSTANT_MACROS' '-D__STDC_FORMAT_MACROS' '-DNDEBUG' '-DNVALGRIND' '-DDYNAMIC_ANNOTATIONS_ENABLED=0' '-D_FORTIFY_SOURCE=2' -I. -Isdch/open-vcdiff/src -Ithird_party/icu/source/i18n -Ithird_party/icu/source/common -Ithird_party/zlib -Ic/Release/obj/gen/net -Inet/third_party/nss/ssl -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-unused-local-typedefs -pthread -I/build/daisy/usr/include/glib-2.0 -I/build/daisy/usr/lib/glib-2.0/include -I/build/daisy/usr/include/nss -I/build/daisy/usr/include/nspr -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=hard -mthumb --sysroot=/build/daisy/ -O2 -fno-ident -fdata-sections -ffunction-sections -g -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -Wno-abi -MMD -MF c/Release/.deps/c/Release/obj.target/net/net/quic/quic_crypto_stream.o.d.raw -pipe -march=armv7-a -mtune=cortex-a15 -mfpu=neon -mfloat-abi=hard -D__google_stl_debug_vector=1 -c -o c/Release/obj.target/net/net/quic/quic_crypto_stream.o net/quic/quic_crypto_stream.cc
chromeos-chrome-34.0.1755.0_alpha-r1: md5.cc: In function 'void base::MD5Final(base::MD5Digest*, char (*)[88])':
chromeos-chrome-34.0.1755.0_alpha-r1: md5.cc:254:33: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
chromeos-chrome-34.0.1755.0_alpha-r1: ((uint32 *)ctx->in)[ 14 ] = ctx->bits[0];
chromeos-chrome-34.0.1755.0_alpha-r1: ^
chromeos-chrome-34.0.1755.0_alpha-r1: md5.cc:255:33: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
chromeos-chrome-34.0.1755.0_alpha-r1: ((uint32 *)ctx->in)[ 15 ] = ctx->bits[1];
chromeos-chrome-34.0.1755.0_alpha-r1: ^
on http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28daisy%29/builds/15156/steps/BuildPackages/logs/stdio
(We don't build with type-based alias analysis enabled, so the warning isn't all
that helpful, but the bot is red none the less.)
> Fixes in base for [P]NaCl port of remoting client
>
> Various minor fixes in base needed for [P]NaCl port of remoting client:
> - added base_i18n_untrusted target
> - md5 is included in base_untrusted.
> - base/metrics is compiled in base_untrusted (src/net depends on it).
> - enabled PNaCl build of base_untrusted
> - __builtin_extract_return_addr() is not allowed in PNaCl (validator
> rejects it).
> - sys_byteorder.h now works in NaCl.
>
> BUG=276739
>
> Review URL: https://codereview.chromium.org/116803005
TBR=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/120463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Various minor fixes in base needed for [P]NaCl port of remoting client:
- added base_i18n_untrusted target
- md5 is included in base_untrusted.
- base/metrics is compiled in base_untrusted (src/net depends on it).
- enabled PNaCl build of base_untrusted
- __builtin_extract_return_addr() is not allowed in PNaCl (validator
rejects it).
- sys_byteorder.h now works in NaCl.
BUG=276739
Review URL: https://codereview.chromium.org/116803005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/third_party/icu/icu_utf.h.
These macros referenced type UChar which is not defined in base_icu. Define a
type for it in the base_icu:: namespace.
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/93973007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Missing includes of <algorithm> for std::min/std::max.
- Update prep_libc.py for different obj path in runtime library.
- Disable optimization in a couple files that currently fail in /O2.
Upstream bugs filed that are supposedly fixed in the next release.
R=thakis@chromium.org
BUG=288948
Review URL: https://codereview.chromium.org/26885007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228754 0039d316-1c4b-4281-b951-d872f2087c98
|