| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/1550493002
Cr-Commit-Position: refs/heads/master@{#366802}
|
|
|
|
|
|
|
|
|
|
|
| |
Current implicit assumption for VerifierTraits when it is using ActiveVerifier seems to be that these are all one category of handles, espcially kernel handles as it is hooking up CloseHandle API. HDC/Printer Handle/Device Info handle all different from kernel handles.
BUG=475872
R=cpu@chromium.org,grt@chromium.org,wfh@chromium.org,vitalybuka@chromium.org,keybuk@chromium.org, armansito@chromium.org, rpaquay@chromium.org
Review URL: https://codereview.chromium.org/1121233003
Cr-Commit-Position: refs/heads/master@{#328402}
|
|
|
|
|
|
|
|
|
| |
TEST=Existing unit-tests, Chrome runs, everybody happy.
Review URL: https://chromiumcodereview.appspot.com/10696185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Use scoping objects more in the omnibox code.
BUG=110105
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10545045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So we don't destroy the dc with gdi objects selected.
Also remove implicit conversion to HDC.
BUG=110113,113683
TEST=chrome runs, base unittests green.
Review URL: https://chromiumcodereview.appspot.com/9212020
TBR=cpu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9387027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
So we don't destroy the dc with gdi objects selected.
Also remove implicit conversion to HDC.
BUG=110113,113683
TEST=chrome runs, base unittests green.
Review URL: https://chromiumcodereview.appspot.com/9212020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Use ScopedSelectObject for changed files
BUG=99139
TEST=no user visible change
Review URL: http://codereview.chromium.org/8139022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* To mark@, sky@
** base/win/scoped_hdc.h
** base/win/scoped_select_object.h
2 Fix leak in printing
* To kmadhusu@
** Play object creation command in metafile once
** Fix trivial leaks
3 Fix leak in SKIA
* To twiz@
** Fix font leak
BUG=98523
TEST=Manual on Win7
Review URL: http://codereview.chromium.org/8084018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
base::win namespace.
This keeps old headers that forward to the new versions and have using declarations that allow the existing code to compile. I fixed all the callers in base to use the new ones, and also the other files I happened to touch.
This splits out the stuff from scoped_handle into a few separate files. I just deleted ScopedFindFile since it was only used in one place and it wasn't even really helping there.
I removed StackBstr which was a #define and used the "regular" ScopedBstr in the 7 places that used it. This is an optimization to avoid an extra allocation, but none of the callers are remotely performance critical.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3781009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62843 0039d316-1c4b-4281-b951-d872f2087c98
|