summaryrefslogtreecommitdiffstats
path: root/base/win/scoped_variant.h
Commit message (Collapse)AuthorAgeFilesLines
* Switch to standard integer types in base/win/.avi2015-12-241-9/+10
| | | | | | | | | BUG=138542 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/1550493002 Cr-Commit-Position: refs/heads/master@{#366802}
* base: Remove operator& from ScopedVariant and ScopedPropVariant.danakj2015-03-101-3/+1
| | | | | | | | | | | | | | | | | | | | | The operator& is dangerous as it makes code unclear what is happening. For ScopedPropVariant there is already a get() method returning a const& of the internal type. So doing &foo.get() will get a pointer to the internal type. For ScopedVariant, there is only operator&, so replace it with an operator*() that returns a const&. This changes callsites from doing something like V_FOO(&scoper) to V_FOO(&*scoper) which makes it clear that it is getting the address of the thing inside scoper, not the scoper itself. R=Nico BUG=464816 Review URL: https://codereview.chromium.org/985853005 Cr-Commit-Position: refs/heads/master@{#319795}
* base: Add/Fix namespace closing comments.danakj2015-03-071-1/+1
| | | | | | | | | | | A namespace foo should end with a comment "// namespace foo", this corrects errors in base/. BUG=464816 Review URL: https://codereview.chromium.org/981803003 Cr-Commit-Position: refs/heads/master@{#319543}
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BASE_API to BASE_EXPORT.darin@chromium.org2011-08-051-2/+2
| | | | | | | R=rvargas Review URL: http://codereview.chromium.org/7461141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95618 0039d316-1c4b-4281-b951-d872f2087c98
* Remove explicit keyword from multi-argument (w/o default values) constructorsdilmah@chromium.org2011-07-261-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7477008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94115 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Last set of files to use BASE_API (for base.dll)rvargas@google.com2011-03-281-2/+3
| | | | | | | | | | Note that a bunck of these files have no unit tests :( BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6747014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79633 0039d316-1c4b-4281-b951-d872f2087c98
* Move the windows-specific scoped_* stuff from base to base/win and in the ↵brettw@chromium.org2010-10-161-0/+166
base::win namespace. This keeps old headers that forward to the new versions and have using declarations that allow the existing code to compile. I fixed all the callers in base to use the new ones, and also the other files I happened to touch. This splits out the stuff from scoped_handle into a few separate files. I just deleted ScopedFindFile since it was only used in one place and it wasn't even really helping there. I removed StackBstr which was a #define and used the "regular" ScopedBstr in the 7 places that used it. This is an optimization to avoid an extra allocation, but none of the callers are remotely performance critical. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3781009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62843 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 23:05:30 +0000