summaryrefslogtreecommitdiffstats
path: root/base
Commit message (Collapse)AuthorAgeFilesLines
* Update CrOS to use scoped_refptr<T>::get() rather than implicit "operator T*"rsleevi@chromium.org2013-06-141-1/+1
| | | | | | | | | BUG=110610 TBR=darin Review URL: https://chromiumcodereview.appspot.com/16998003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206357 0039d316-1c4b-4281-b951-d872f2087c98
* Move message_loop to the message_loop directory.brettw@chromium.org2013-06-146-735/+742
| | | | | | | | | | | Keep a forwarding header to avoid updating all callers. BUG= TBR=avi Review URL: https://chromiumcodereview.appspot.com/15682017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206279 0039d316-1c4b-4281-b951-d872f2087c98
* Add LeakSanitizer annotations to base/debug/leak_annotations.hearthdok@google.com2013-06-131-12/+37
| | | | | | | | | | | If building with LeakSanitizer, define leak annotations appropriately. http://clang.llvm.org/docs/LeakSanitizer.html R=glider@chromium.org,jar@chromium.org Review URL: https://chromiumcodereview.appspot.com/15652009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206167 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite scoped_ptr<T>(NULL) to use the default ctor in base/.dcheng@chromium.org2013-06-134-12/+5
| | | | | | | | | | | This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on Linux in the base/ directory. BUG=173286 Review URL: https://chromiumcodereview.appspot.com/16950008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206116 0039d316-1c4b-4281-b951-d872f2087c98
* Notify TraceLog observers outside of the lockjamescook@chromium.org2013-06-133-102/+193
| | | | | | | | | | | This allows observers to call code that uses TRACE_EVENT macros. BUG=none, noticed while developing memory tracing patch TEST=Added to base_unittests TraceEventTestFixture Review URL: https://chromiumcodereview.appspot.com/16829002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206109 0039d316-1c4b-4281-b951-d872f2087c98
* Move nullable_string16.h to the string subdirectory.avi@chromium.org2013-06-132-25/+40
| | | | | | | | | | BUG=247723 TEST=no change TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/16415016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206066 0039d316-1c4b-4281-b951-d872f2087c98
* add more string -> unsigned number conversion unit tests (attempt 2)mostynb@opera.com2013-06-131-1/+206
| | | | | | | | | | | Add unit tests for the following functions in base: StringToUint StringToUint64 StringToSizeT Review URL: https://chromiumcodereview.appspot.com/15521004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206031 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Fix component build again.yfriedman@chromium.org2013-06-122-1/+2
| | | | | | | | | After this, android_clang_dbg (tree-closer) will be switched to use components. BUG=247855 Review URL: https://chromiumcodereview.appspot.com/15942017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205926 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "GTTF: Lower the action max timeout to 30s for everyone."phajdan.jr@chromium.org2013-06-121-0/+4
| | | | | | | | | | TBR=sky BUG=none Review URL: https://codereview.chromium.org/15663007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205819 0039d316-1c4b-4281-b951-d872f2087c98
* Adds MemoryPressureListener.bulach@chromium.org2013-06-1210-0/+281
| | | | | | | | | | | | | | | | Some platforms, like android, send clear signals when under memory pressure. Create a centralized place so that: - Underlying platform can advise the rest of the system of its memory status. - Individual subsystems can then listen to such notifications and free their memory as per their own policies. BUG=246125 Review URL: https://chromiumcodereview.appspot.com/15995014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205796 0039d316-1c4b-4281-b951-d872f2087c98
* [Autofill] Determine Popup RTLness from pagecsharp@chromium.org2013-06-121-0/+1
| | | | | | | | | | | Have the Autofill popup determine if it is RTL based on the element it is a popup for, instead of just following the RTL setting of the UI. BUG=238055 Review URL: https://chromiumcodereview.appspot.com/15769018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205795 0039d316-1c4b-4281-b951-d872f2087c98
* Fix aligned_memory_unittest for x86-64 NaClhamaji@chromium.org2013-06-121-2/+14
| | | | | | | | | | | | | | | | NaCl SFI on x86-64 does not allow programs to align stack to >128 byte boundaries. Technically NaCl may be able to allow bigger alignments and I think current specification is decided just because it's easy to implement a validator. (the size of operand will be bigger for >128 byte alignment) We may not want to align stack to >128 byte boundaries anyway, so let's just disable this test. BUG= Review URL: https://chromiumcodereview.appspot.com/15943005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205755 0039d316-1c4b-4281-b951-d872f2087c98
* Rename base/hash_tables to base/containers/hash_tables.brettw@chromium.org2013-06-1117-25/+19
| | | | | | | | | | | Remove forwarding header BUG= R=avi@chromium.org Review URL: https://codereview.chromium.org/16667019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205584 0039d316-1c4b-4281-b951-d872f2087c98
* Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"rsleevi@chromium.org2013-06-117-61/+48
| | | | | | | | | | | | | | | | | | | This upates calls to bound temporary objects to also use get(). While it has the same semantic equivalence to the existing code, this generally represents a dangerous pattern - indeed, part of the whole motivation for this change is to make this anti-pattern very visible to authors. This change simply updates all of the call sites, to allow the "operator T*" to be removed and preventing new instances. The existing instances will then be reviewed for "suspicious" changes and updated to use/pass scoped_refptr<T> rather than T*, as appropriate. BUG=110610 TBR=darin Review URL: https://codereview.chromium.org/15984016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205560 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in base/.avi@chromium.org2013-06-1128-34/+34
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16745002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205530 0039d316-1c4b-4281-b951-d872f2087c98
* Register a unique window class for every instance of base::MessagePumpForUI ↵alexeypa@chromium.org2013-06-112-11/+17
| | | | | | | | | | | | (Windows). Currently each base::MessagePumpForUI object registers a window class with a predefined name. This leads to races when more than one UI pump is created. This CL addresses this issue by generating a unique class name for every base::MessagePumpForUI object. BUG=241939 Review URL: https://chromiumcodereview.appspot.com/16402011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205506 0039d316-1c4b-4281-b951-d872f2087c98
* Make CreateDirectory return an error code instead of just a bool.dgrogan@chromium.org2013-06-114-4/+22
| | | | | | | | | | | | | | | | | | | Make use of the new error code in IndexedDB, where we'll histogram which errors can be recovered from by retrying and which can't. We're going to try retrying CreateDirectory because LevelDB doesn't pay attention to what env_->CreateDir returns and a frequent error on the next operation (locking the lock file) is that the directory doesn't exist. I want to find out what's causing the directories to not be created in the first place, and which errors can be considered ephemeral. BUG=225051 Review URL: https://chromiumcodereview.appspot.com/15812007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205386 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable the tcmalloc SecurityTests in base_unittests on Windowswfh@chromium.org2013-06-101-2/+7
| | | | | | | | | | These tests now function correctly because base_unittests now is built with allocator_shims - see http://crrev.com/15674003/ BUG=242304 Review URL: https://chromiumcodereview.appspot.com/16077014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205350 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in WeakPtrTest::NonOwnerThreadCanCopyAndAssignWeakPtr{,Base}akalin@chromium.org2013-06-101-12/+8
| | | | | | | | | | | The leak was caused by DeleteArrow() not being called. BUG=179758 R=jar@chromium.org Review URL: https://codereview.chromium.org/15797010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205345 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in base/.avi@chromium.org2013-06-1036-39/+39
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16344006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205309 0039d316-1c4b-4281-b951-d872f2087c98
* Update includes of message_loop_proxy.brettw@chromium.org2013-06-1018-18/+18
| | | | | | | | | | | This keeps the forwarding header, just updates all current callers. BUG= R=avi@chromium.org Review URL: https://codereview.chromium.org/16514006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205306 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in base/.avi@chromium.org2013-06-1043-47/+47
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16320009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205284 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Lower the action max timeout to 30s for everyone.phajdan.jr@chromium.org2013-06-101-4/+0
| | | | | | | | | | | Slow tests are slow. BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/15901017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205276 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in base/.avi@chromium.org2013-06-1030-34/+34
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16667013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205261 0039d316-1c4b-4281-b951-d872f2087c98
* Move hash_tables.h to base/containers.brettw@chromium.org2013-06-102-118/+123
| | | | | | | | | | | This keeps a fowrarding header to keep the change small. BUG= R=avi@chromium.org Review URL: https://codereview.chromium.org/16160022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205241 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Move more 10.7 api stuff into sdk_forward_declarations.hthakis@chromium.org2013-06-101-0/+13
| | | | | | | | | BUG=none TBR=mark@chromium.org Review URL: https://codereview.chromium.org/15870009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205234 0039d316-1c4b-4281-b951-d872f2087c98
* Add an "append flag" to base::PlatformFile.teravest@chromium.org2013-06-104-48/+132
| | | | | | | | | | | | | | PLATFORM_FILE_APPEND is exclusive with PLATFORM_FILE_WRITE. This is because on Windows, if we were to apply both flags, the behavior would not be consistent with O_APPEND. On Posix, PLATFORM_FILE_APPEND provides O_APPEND, and either O_WRONLY or O_RDWR, depending on other flags. On Windows, PLATFORM_FILE_APPEND provides FILE_APPEND_DATA, and fails to create the plaform file if PLATFORM_FILE_WRITE is also passed. BUG=242383 Review URL: https://chromiumcodereview.appspot.com/15861011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205217 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the implementation of atomic operations on Linux/ARM (including ↵digit@chromium.org2013-06-102-2/+281
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Android/ARM). The previous patch at: https://chromiumcodereview.appspot.com/10831358 actually regressed the performance of atomic operations on Linux/ARM systems, because the GCC intrinsics (e.g. __sync_fetch_and_add) are very poorly implemented at the moment (and also always provide a full barrier, even when the caller doesn't need it). This replaces the implementation with a better version which: - Uses inline assembly and LDRES/STREX instructions on ARMv6+, or the old kernel helper cmpxchg implementation on ARMv5. - Still uses the kernel helper memory barrier to optimize for single core devices on ARMv6 and ARMv7, or ARMv5 binaries running on devices with a higher architecture number. - Provide truly barrier free compare-and-swap, swap and atomic-inc operations. On tested Android/ARM devices, this speeds up atomic increments by x2 to x3. This indirectly speeds up other operations relying on it (e.g. scoped_refptr<> or base::Bind()). For details, see: https://docs.google.com/a/chromium.org/spreadsheet/ccc?key=0Arp73PHrzcIQdGNUd1NGYWlfY0dKWS1EZ2V6RThhZXc&usp=sharing BUG=234215 Review URL: https://chromiumcodereview.appspot.com/16335007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205205 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate the intentional test-only leak in base/tracked_objects.cc.earthdok@google.com2013-06-101-1/+8
| | | | | | | | | | | | Remove several HeapChecker suppressions in favor of one annotation. BUG=136936 R=jar@chromium.org CC=glider@chromium.org Review URL: https://chromiumcodereview.appspot.com/16387012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205190 0039d316-1c4b-4281-b951-d872f2087c98
* Provide nanoseconds precision for base::PlatformFileInfo on POSIXapavlov@chromium.org2013-06-103-0/+27
| | | | | | | | BUG=244430 Review URL: https://chromiumcodereview.appspot.com/16093026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205178 0039d316-1c4b-4281-b951-d872f2087c98
* Redo r203907 base_unittests.exe to use alloactor shimswfh@chromium.org2013-06-092-3/+15
| | | | | | | | | | | | | | Previous commit r203907 broke VS2012 build because in VS7.1, the new array operator is now in newaopnt.obj and not newopnt.obj. This commit modifies prep_libc.py to correctly pull the newaopnt.obj from libcmt.lib so there is no symbol clash. See also crrev.com/15674003 and crrev.com/16154020 BUG=242304 Review URL: https://chromiumcodereview.appspot.com/15979023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205115 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ProcessUtilTest.CalcFreeMemory total memory test when using tcmalloc.wfh@chromium.org2013-06-081-1/+14
| | | | | | | | | | This is because tcmalloc has an allocation strategy that sometimes causes this test to be flaky when it's enabled for base_unittests. BUG=247398 Review URL: https://chromiumcodereview.appspot.com/16634009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205088 0039d316-1c4b-4281-b951-d872f2087c98
* Move string files in base/ to the string subdirectory.avi@chromium.org2013-06-0820-957/+994
| | | | | | | | | BUG=247723 TEST=no change Review URL: https://chromiumcodereview.appspot.com/16331011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205050 0039d316-1c4b-4281-b951-d872f2087c98
* GetProcId shouldn't always upgrade the supplied handlejschuh@chromium.org2013-06-081-14/+2
| | | | | | | | | | We should use the handle we're given. TBR=brettw Review URL: https://chromiumcodereview.appspot.com/15837005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205020 0039d316-1c4b-4281-b951-d872f2087c98
* Move FileEnumerator to its own file, do some refactoring.brettw@chromium.org2013-06-0810-452/+530
| | | | | | | | | | | | | | It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked. BUG=175002 Reland of 198820 and 298824 Original review = https://codereview.chromium.org/13165005 R=rvargas@chromium.org Review URL: https://codereview.chromium.org/16392011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205019 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate LeakyLazyInstance as a leak. Remove HeapChecker suppressions.earthdok@google.com2013-06-071-0/+2
| | | | | | | | | | | | | | The two suppressions removed by this CL have not fired for a long time, for some unknown reason. It's still a good idea to annotate all intentional leaks though. BUG=83345 R=jar@chromium.org,darin@chromium.org CC=glider@chromium.org Review URL: https://chromiumcodereview.appspot.com/16440006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204953 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in android_webview/, apps/, ↵avi@chromium.org2013-06-0763-66/+66
| | | | | | | | | | | ash/, base/. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/15735027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204874 0039d316-1c4b-4281-b951-d872f2087c98
* Add a path to use CALayers to display contentccameron@chromium.org2013-06-071-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the flag --use-core-animation to enable this path. Make the RenderWidgetHostViewCocoa layer-backed, and add a default white layer. Add a CALayer, softwareLayer_ to draw into when the accelerated path is disabled. Update the software draw methods to use the CG calls (this changes the non-CA path as well, but should be equivalent to previous behavior). If accelerated compositing is enabled, then add CAOpenGLLayer to draw accelerated frames (frames using IOSurfaces). If we receive a software frame, then delete this layer (and the software layer will appear below it). This still has a number of issues to resolve before enabling, including - corrupted bookmark bars - increased CPU usage (3.5%->5% without compositing, 7%->10% with) - increased startup time BUG=245900 NOTRY=True Review URL: https://chromiumcodereview.appspot.com/16189012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204841 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate the intentional leak in weak_ptr_unittest.cc.earthdok@google.com2013-06-071-6/+13
| | | | | | | | | | | | Remove the corresponding suppressions. BUG=179758 R=akalin@chromium.org,darin@chromium.org CC=glider@chromium.org Review URL: https://chromiumcodereview.appspot.com/15848016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204833 0039d316-1c4b-4281-b951-d872f2087c98
* [MIPS] Fix memory barriers for atomic operations.paul.lind@imgtec.com2013-06-071-12/+5
| | | | | | | | | | | Add barriers using MIPS 'sync' instructions as needed for SMP systems. BUG=246947 Review URL: https://chromiumcodereview.appspot.com/16001009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204697 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Fix errors when building android with coverage=1 ilevy@chromium.org2013-06-061-1/+1
| | | | | | | | | | | | | | | Originally landed in r204547 Reverted in r204553 due to cq anomaly. Android builds with coverage=1 fail due to uninitialized variable warnings in base/linux_util.cc and base/net/net_util.cc BUG=245467 TBR=willchan Review URL: https://chromiumcodereview.appspot.com/16589002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204662 0039d316-1c4b-4281-b951-d872f2087c98
* Android: Provide futimes() implementation using utimensat()nileshagrawal@chromium.org2013-06-061-4/+19
| | | | | | | | | | | | The earlier implementation using /proc/self/fd/<num> failed when called from a non-main thread in production builds of Chrome and Android. Depends on NDK r8e: https://codereview.chromium.org/14860010/ BUG=236403 Review URL: https://chromiumcodereview.appspot.com/14649009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204633 0039d316-1c4b-4281-b951-d872f2087c98
* Add isLayoutRtl() to ApiCompatibilityUtils.java.newt@chromium.org2013-06-061-0/+14
| | | | | | | | | | | | This addresses the possible bug with using getLayoutDirection() on pre-JB MR1 devices mentioned in http://crbug.com/245224#c6 BUG=245224 R=yfriedman@chromium.org Review URL: https://codereview.chromium.org/16596002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204587 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 204556 "Fix errors when building android with coverage=1"ilevy@chromium.org2013-06-061-1/+1
| | | | | | | | | | | | | | | | | | | CQ anomaly x2. > Fix errors when building android with coverage=1 > > Android builds with coverage=1 fail due to uninitialized variable > warnings in base/linux_util.cc and base/net/net_util.cc > > BUG=245467 > > Review URL: https://chromiumcodereview.appspot.com/16077010 TBR=rwalker@codeaurora.org Review URL: https://codereview.chromium.org/16505004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204562 0039d316-1c4b-4281-b951-d872f2087c98
* Fix errors when building android with coverage=1rwalker@codeaurora.org2013-06-061-1/+1
| | | | | | | | | | | Android builds with coverage=1 fail due to uninitialized variable warnings in base/linux_util.cc and base/net/net_util.cc BUG=245467 Review URL: https://chromiumcodereview.appspot.com/16077010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204556 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 204547 "Fix errors when building android with coverage=1"ilevy@chromium.org2013-06-061-1/+1
| | | | | | | | | | | | | | | | | | | CQ error. Committed without tryjobs. > Fix errors when building android with coverage=1 > > Android builds with coverage=1 fail due to uninitialized variable > warnings in base/linux_util.cc and base/net/net_util.cc > > BUG=245467 > > Review URL: https://chromiumcodereview.appspot.com/16077010 TBR=rwalker@codeaurora.org Review URL: https://codereview.chromium.org/16415008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204553 0039d316-1c4b-4281-b951-d872f2087c98
* Fix errors when building android with coverage=1rwalker@codeaurora.org2013-06-061-1/+1
| | | | | | | | | | | Android builds with coverage=1 fail due to uninitialized variable warnings in base/linux_util.cc and base/net/net_util.cc BUG=245467 Review URL: https://chromiumcodereview.appspot.com/16077010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204547 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream ApiCompatibilityUtils.java.newt@chromium.org2013-06-061-0/+104
| | | | | | | | | | | This also merges in DeprecationUtilities, whose function is closely related. BUG=245224 R=aurimas@chromium.org, kkimlabs@chromium.org, yfriedman@chromium.org Review URL: https://codereview.chromium.org/16093035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204491 0039d316-1c4b-4281-b951-d872f2087c98
* Make expressions like "if (weak_ptr)" workakalin@chromium.org2013-06-062-0/+23
| | | | | | | | | | | | | | Use the same trick as scoped_ptr<T>. Add comments regarding == and != operators and their relation to the bool trick. BUG=245942 R=darin@chromium.org, rsleevi@chromium.org Review URL: https://codereview.chromium.org/15721007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204438 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WeakPtr<T>'s operator T*()akalin@chromium.org2013-06-061-1/+0
| | | | | | | | | | | BUG=245942 R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204293 Review URL: https://chromiumcodereview.appspot.com/16267003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204379 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-15 20:22:57 +0000