summaryrefslogtreecommitdiffstats
path: root/breakpad
Commit message (Collapse)AuthorAgeFilesLines
* Add host symlinks for microdump_stackwalk, minidump_*agrieve2016-03-221-211/+233
| | | | | | | | | | | It's not obvious how to build non-default-toolchain targets in ninja. Creating a wrapper alleviates the problem. BUG=none Review URL: https://codereview.chromium.org/1822743002 Cr-Commit-Position: refs/heads/master@{#382611}
* Add temporary _apk_run targets to GN.jbudorick2016-02-021-0/+9
| | | | | | | | BUG=580129 Review URL: https://codereview.chromium.org/1654353002 Cr-Commit-Position: refs/heads/master@{#372887}
* Emit logcats for breakpad_unittests.stip2016-01-261-0/+1
| | | | | | | | BUG=525873 Review URL: https://codereview.chromium.org/1638593003 Cr-Commit-Position: refs/heads/master@{#371575}
* Add no-deprecated-declarations to ios_breakpad clientolivierrobin2016-01-261-0/+8
| | | | | | | | | | | | | | Follow up on cl/1611283002. minidump_generator may be buit on by the breakpad_client target, which needs to allow the deprecated call. Will be removed after reland of https://codereview.chromium.org/1563223004/ BUG=579522, 569158 Review URL: https://codereview.chromium.org/1638723003 Cr-Commit-Position: refs/heads/master@{#371515}
* Roll breakpad to e654eb71272829c6f00024f96a10a1882c08a282olivierrobin2016-01-211-0/+10
| | | | | | | | | | | This effictively revert CL https://codereview.chromium.org/1567973002 to fix crash reporting on iOS. BUG=569158 Review URL: https://codereview.chromium.org/1611283002 Cr-Commit-Position: refs/heads/master@{#370738}
* GN: Move x86 Clang -mstackrealign workaround to its own config, elide it ↵mcgrathr2016-01-201-12/+8
| | | | | | | | | | | | | | | | | where problematic crrev.com/365770 tried to avoid the -mstackrealign flag for building the breakpad code, but the GN changes there were not valid. This change refactors the problematic -mstackrealign (and related -mstack-alignment=16) flags out of compiler_codegen into its own config that can be removed for components building breakpad code. BUG=418554,556393 R=brettw@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/1598523002 Cr-Commit-Position: refs/heads/master@{#370464}
* Update the version of symupload.exe to breakpad@860d7f5da18sebmarchand2016-01-121-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | It's the version I'm updating to: https://chromium.googlesource.com/breakpad/breakpad/+/860d7f5da18 It seems to be fixing the issue that we're having in crbug.com/576298, there's been a lot of bug fixes since the last time we've pushed a version of this binary (1 year and 9 months ago !) and this version doesn't seem to have the symbol upload that we're encountering on the official builders (with the 1GB PDBs). Is there any particular reason why we don't compile this binary during an official build ? It'd be more secure than checking it in directly. Once I've landed this I'll push the symbols for this binary to the symbol server. These binaries have been compiled with VS2013u5 and MSDIA 12.0 BUG=576298 Review URL: https://codereview.chromium.org/1578033002 Cr-Commit-Position: refs/heads/master@{#368880}
* Roll breakpad to c051af689cdb08d9cecaa127f3d69eba006d0bc9.sdefresne2016-01-081-10/+0
| | | | | | | | | | | | | Changes: c051af6 Fix compilation of breakpad on Linux. 8a90f7e Fix deprecatation warning when building for recent SDKs on iOS/OS X. f75cbf8 Use range-based for loops in linux/minidump_writer/minidump_writer.cc. BUG=569158 Review URL: https://codereview.chromium.org/1567973002 Cr-Commit-Position: refs/heads/master@{#368305}
* [Linux] Turn off -mstackrealign for breakpad in ia32.ljagielski2015-12-172-0/+30
| | | | | | | | | | | | There's a clang bug which causes crashes of syscalls which use many registers for argument passing in ia32 architecture. https://llvm.org/bugs/show_bug.cgi?id=16830 BUG=556393 Review URL: https://codereview.chromium.org/1473203002 Cr-Commit-Position: refs/heads/master@{#365770}
* GN: Add symlink rules for dump_syms, symuploadagrieve2015-12-111-0/+9
| | | | | | | | | | Creates a symlink.gni helper template to reduce copy / paste. BUG=552040 Review URL: https://codereview.chromium.org/1516533002 Cr-Commit-Position: refs/heads/master@{#364672}
* Run gn --format over all .gn filesagrieve2015-11-201-3/+3
| | | | | | | | | | | | | | | | The recent formatter alphebetizing change is causing a lot of noise in code reviews. Figured it'd be worth a clean-up CL. Exact command I ran: find . -name "*.gn*" -exec gn format --in-place "{}" \; TBR=ddorwin@chromium.org BUG=554928 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1464873002 Cr-Commit-Position: refs/heads/master@{#360891}
* Fix compilation of breakpad with gn for iOS.sdefresne2015-11-172-2/+12
| | | | | | | | | | | | | | | Correctly lift the sources_assignment_filter so that code shared with mac is also build on iOS and add some files that were missing from the build. Correctly export the required include_dirs and disable the deprecation warnings (so that we can build with -Werror). BUG=459705 Review URL: https://codereview.chromium.org/1450893002 Cr-Commit-Position: refs/heads/master@{#360087}
* Make minidump_stackwalk link on GN Mac.brettw2015-11-121-0/+2
| | | | | | | | | | | The _linux files were being excluded by default, but these are supposed to be included. BUG=542709 Review URL: https://codereview.chromium.org/1441493002 Cr-Commit-Position: refs/heads/master@{#359244}
* Fix breakpad_unittests on Android & GNpkotwicz2015-11-021-24/+56
| | | | | | | | BUG=510485 Review URL: https://codereview.chromium.org/1404383004 Cr-Commit-Position: refs/heads/master@{#357387}
* Update breakpad URL.bungeman2015-10-081-1/+1
| | | | | | | | BUG=chromium:476190 Review URL: https://codereview.chromium.org/1397803002 Cr-Commit-Position: refs/heads/master@{#353093}
* Fix build conditions for minidump_stackwalk et al. in GNdpranke2015-10-021-3/+3
| | | | | | | | | | | | | | | Some of the breakpad tools are not meant to be built as iOS (or android) targets, and do not work on Windows; however, the conditions for them were incorrectly specified in the build file. This patches fixes that to make it clear that they should only be built with the host toolchain. R=brettw@chromium.org BUG= Review URL: https://codereview.chromium.org/1378463005 Cr-Commit-Position: refs/heads/master@{#352075}
* Isolate breakpad_unittests.stip2015-09-302-0/+40
| | | | | | | | BUG=525873 Review URL: https://codereview.chromium.org/1376883002 Cr-Commit-Position: refs/heads/master@{#351584}
* Roll src/breakpad/src 027db3c04..9e9c3563a (fix arm64 stack overflow)primiano2015-09-242-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | This roll pulls a major breakpad fix affecting mainly arm64 (see crbug.com/534738) and causing a loss of crash reports (mainly on Android M+) ****** Note for TPMs and stability sheriffs ****** It is possible that the number of Android crashes reported for arm64 will suddenly bump up after this change. This is an expected consequence of fixing the cause of crash-report loss. Revision log: https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/027db3c04fbea96f3efa8e1f722ffff11b19a085..9e9c3563a356ce441eed044257a54aa8b4114693 9e9c356 Linux ExceptionHandler: don't allocate the CrashContext on the stack 3163a73 Fixup a bad strcmp call landed in previous commit 164ba52 Fix Mac Breakpad host tools to build in Linux cross-compile 6a0d328 solaris: fix spurious ; BUG=534738 TBR=mark@chromium.org Review URL: https://codereview.chromium.org/1361563002 Cr-Commit-Position: refs/heads/master@{#350540}
* Move sanitizer and symbol flags out of BUILDCONFIGbrettw2015-09-141-1/+1
| | | | | | | | | TBR=mmoss@chromium.org (chrome/installer/linux) CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1324623005 Cr-Commit-Position: refs/heads/master@{#348727}
* Un-nest GN configs in breakpad build file.brettw2015-09-111-7/+7
| | | | | | | | | | We're making configs nested in targets illegal. TBR=dpranke@chromium.org Review URL: https://codereview.chromium.org/1339723002 Cr-Commit-Position: refs/heads/master@{#348432}
* Annotate GN executables and shared_libraries with sanitizer deps.brettw2015-08-311-0/+27
| | | | | | | | | | | | | | | | | These are needed to link in asan/lsan/etc. mode. GYP injects these automatically but GN doesn't have automatic dependency injection. All tests and components (which cover the vast majority of such targets in actual use) are templates which add these dependencies already, so most of the time it never comes up. Only a few of these changes are actually necessary to link all tests run on the asan bot (which is also what engineers will typically build, since almost nobody will build all in asan mode). But to reduce confusion from linker errors in asan mode, I annotated all executables and shared libraries I could find with the sanitizer dependency. I moved a config out of a target in yasm, and sorted a fews deps on other targets. TBR=xhwang@chromium.org (widevine) TBR=achuith@chromium.org (tools/perf, tools/telemetry) Review URL: https://codereview.chromium.org/1318343003 Cr-Commit-Position: refs/heads/master@{#346490}
* Roll src/breakpad/src 242fb9a:c80d211 (svn 1471:1495)primiano2015-08-202-8/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is to catch up fixes to the Android microdump writer. Summary of changes available at: https://chromium.googlesource.com/external/google-breakpad/src/+log/242fb9a..e100989 e100989 Add user_regs_struct and user_fpsimd_struct for aarch64 on Android. 0ad58e6 Fix compile error with Windows clang. bdb4b7c Fix inttypes format macros in src/processor/proc_maps_linux.cc c80d211 Remove obsolete seccomp_unwinder for legacy (pre-BPF) sandbox 6d74ba8 Fix proc_maps_linux compile for non-Linux 80cfa05 [microdump] Move microdump writes to the crash ring-buffer log 947c7e9 [microdump] Fix hw architecture indication in build fingerprint line d4a6903 Add check for executable stack/heap when rating Linux exploitability. 68ad684 Add check to see if stack pointer is off the stack according to the memory mappings when rating Linux exploitability. 412d3cf Fix format specifier in proc maps to support 32-bit architectures. 5fa512b Actually remove removed files 9a19499 Remove some old unused code, add a missing include R=lei at https://codereview.chromium.org/1211963002 a601859 Fix format specifier in proc maps to support 32-bit architectures. 70e371c Allow Print() to be called by const instances of MinidumpLinuxMaps and MinidumpLinuxMapsList. d95798e Change Print method of MinidumpLinuxMaps and MinidumpLinuxMapsList to print contents of /proc/<pid>/maps instead of just the files mapped to memory. 0f5bff6 Workaround for range map overlaps caused by Android package relocation. f503948 Fix breakpad for arm on arm64 9f4a8ee Fix potential null pointer dereference. b00176d Remove unnecessary dependencies. 5c7459a Add support for Linux memory mapping stream and remove ELF header usage when checking exploitability rating. 78eab62 Fix incorrect comment. d5ca70c add aarch64 support to minidump-2-core f9d81bb tests: InstructionPointerMemoryNullPointer: make it work under llvm 31916e7 Add ELF header analysis when checking for instruction pointer in code. BUG=520075,512755,477444 Review URL: https://codereview.chromium.org/1296253006 Cr-Commit-Position: refs/heads/master@{#344561}
* Revert of Roll src/breakpad/src 242fb9a:bdb4b7c (svn 1471:1493) (patchset #3 ↵primiano2015-08-192-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:40001 of https://codereview.chromium.org/1298793003/ ) Reason for revert: Broke the arm64 builder http://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/22356 Original issue's description: > Roll src/breakpad/src 242fb9a:bdb4b7c (svn 1471:1493) > > This is to catch up fixes to the Android microdump writer. > > Summary of changes available at: > https://chromium.googlesource.com/external/google-breakpad/src/+log/242fb9a..bdb4b7c > > bdb4b7c Fix inttypes format macros in src/processor/proc_maps_linux.cc > c80d211 Remove obsolete seccomp_unwinder for legacy (pre-BPF) sandbox > 6d74ba8 Fix proc_maps_linux compile for non-Linux > 80cfa05 [microdump] Move microdump writes to the crash ring-buffer log > 947c7e9 [microdump] Fix hw architecture indication in build fingerprint line > d4a6903 Add check for executable stack/heap when rating Linux exploitability. > 68ad684 Add check to see if stack pointer is off the stack according to the memory mappings when rating Linux exploitability. > 412d3cf Fix format specifier in proc maps to support 32-bit architectures. > 5fa512b Actually remove removed files > 9a19499 Remove some old unused code, add a missing include R=lei at https://codereview.chromium.org/1211963002 > a601859 Fix format specifier in proc maps to support 32-bit architectures. > 70e371c Allow Print() to be called by const instances of MinidumpLinuxMaps and MinidumpLinuxMapsList. > d95798e Change Print method of MinidumpLinuxMaps and MinidumpLinuxMapsList to print contents of /proc/<pid>/maps instead of just the files mapped to memory. > 0f5bff6 Workaround for range map overlaps caused by Android package relocation. > f503948 Fix breakpad for arm on arm64 > 9f4a8ee Fix potential null pointer dereference. > b00176d Remove unnecessary dependencies. > 5c7459a Add support for Linux memory mapping stream and remove ELF header usage when checking exploitability rating. > 78eab62 Fix incorrect comment. > d5ca70c add aarch64 support to minidump-2-core > f9d81bb tests: InstructionPointerMemoryNullPointer: make it work under llvm > 31916e7 Add ELF header analysis when checking for instruction pointer in code. > > BUG=520075,512755,477444 > > Committed: https://crrev.com/6df482019d01d7a36eeb849dc9126102a447054a > Cr-Commit-Position: refs/heads/master@{#344204} TBR=torne@chromium.org,mark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=520075,512755,477444 Review URL: https://codereview.chromium.org/1293923003 Cr-Commit-Position: refs/heads/master@{#344207}
* Roll src/breakpad/src 242fb9a:bdb4b7c (svn 1471:1493)primiano2015-08-192-8/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is to catch up fixes to the Android microdump writer. Summary of changes available at: https://chromium.googlesource.com/external/google-breakpad/src/+log/242fb9a..bdb4b7c bdb4b7c Fix inttypes format macros in src/processor/proc_maps_linux.cc c80d211 Remove obsolete seccomp_unwinder for legacy (pre-BPF) sandbox 6d74ba8 Fix proc_maps_linux compile for non-Linux 80cfa05 [microdump] Move microdump writes to the crash ring-buffer log 947c7e9 [microdump] Fix hw architecture indication in build fingerprint line d4a6903 Add check for executable stack/heap when rating Linux exploitability. 68ad684 Add check to see if stack pointer is off the stack according to the memory mappings when rating Linux exploitability. 412d3cf Fix format specifier in proc maps to support 32-bit architectures. 5fa512b Actually remove removed files 9a19499 Remove some old unused code, add a missing include R=lei at https://codereview.chromium.org/1211963002 a601859 Fix format specifier in proc maps to support 32-bit architectures. 70e371c Allow Print() to be called by const instances of MinidumpLinuxMaps and MinidumpLinuxMapsList. d95798e Change Print method of MinidumpLinuxMaps and MinidumpLinuxMapsList to print contents of /proc/<pid>/maps instead of just the files mapped to memory. 0f5bff6 Workaround for range map overlaps caused by Android package relocation. f503948 Fix breakpad for arm on arm64 9f4a8ee Fix potential null pointer dereference. b00176d Remove unnecessary dependencies. 5c7459a Add support for Linux memory mapping stream and remove ELF header usage when checking exploitability rating. 78eab62 Fix incorrect comment. d5ca70c add aarch64 support to minidump-2-core f9d81bb tests: InstructionPointerMemoryNullPointer: make it work under llvm 31916e7 Add ELF header analysis when checking for instruction pointer in code. BUG=520075,512755,477444 Review URL: https://codereview.chromium.org/1298793003 Cr-Commit-Position: refs/heads/master@{#344204}
* clang/win: Fix warnings to prepare for building without -Wno-reorder.sammc2015-07-022-0/+13
| | | | | | | | | | | | | This changes constructor initializer list ordering to match field declaration ordering, except for gtest and breakpad, where the warning is disabled. BUG=505304 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1210013007 Cr-Commit-Position: refs/heads/master@{#337152}
* Add tandrii and vadimsh as *.isolate owners.maruel2015-06-261-1/+2
| | | | | | | | | | | | | Remove csharp since he's not working on test isolation anymore. R=vadimsh@chromium.org,tandrii@chromium.org TBR= BUG= NOTRY=true Review URL: https://codereview.chromium.org/1214673004 Cr-Commit-Position: refs/heads/master@{#336399}
* [Android] Generate scripts at build time to run android tests.mikecase2015-06-032-0/+7
| | | | | | | | | | | Making changes so that at build time scripts will be generated that can be used to easily run tests. BUG=490781 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1120883002 Cr-Commit-Position: refs/heads/master@{#332518}
* [iOS] Export Breakpad includes in breakpad.gypdroger2015-04-221-0/+5
| | | | | | | | | | breakpad.gyp did not export correctly its includes on iOS, forcing all targets depending on breakpad to manually add the breakpad include path. Review URL: https://codereview.chromium.org/1097383004 Cr-Commit-Position: refs/heads/master@{#326291}
* Windows GN tests, webcrypto warningsbrettw2015-04-211-0/+1
| | | | | | | | | | | | | | Enables many GN Windows tests. The GN build wasn't disabling the size_t to int warning in webcrypto. I decided to fix the warnings rather than disable them. This code is a random mishmash of size_t, int, unsigned, and long (partially due to third party code). In this change, I tried to do something minimal and clear: some variables were changed to size_t, while some were converted to casts. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg TBR=dpranke Review URL: https://codereview.chromium.org/1091293003 Cr-Commit-Position: refs/heads/master@{#326046}
* Always build dump_syms with the 'host' toolchainsbc2015-04-171-5/+1
| | | | | | | | | | | | | | | | | | A recent change set linux_dump_symbols=1 on the trybots and was then reverted: https://codereview.chromium.org/1081103005 The causes the ARM/Linux builder to fail since it was attempting to run the target (ARM) dump_syms binary on x86. This change makes dump_syms a host binary so that it can run at build time. BUG=476781 TEST=linux_arm_compile trybot Review URL: https://codereview.chromium.org/1061473003 Cr-Commit-Position: refs/heads/master@{#325661}
* Roll src/breakpad/src 2c37c22:ad88d96 (svn 1434:1447)Gordana.Cmiljanovic2015-04-172-0/+4
| | | | | | | | | | | | | | | | | | | | | | This pulls the following changes: r1447 ad88d96 Fix call to rt_sigaction r1446 3f8a019 MIPS64: Initial MIPS64 related change. r1443 ecf9e2b Use __NR_rt_sigaction instead of __NR_sigaction r1442 b8a7ea6 Microdump processor: be more tolerant for different logcat formats r1441 d0b34ab Add address and reason for IN_PAGE_ERROR. r1438 16c6ed2 Workaround Android sigaction bug r1435 8828713 Fix compilation with gcc --std=c++11 Summary of changes available at: https://chromium.googlesource.com/external/google-breakpad/src/+log/2c37c22..ad88d96 Plus modifies gn and gyp files to support changes. BUG=system_webview_apk compile error for MIPS64 Review URL: https://codereview.chromium.org/1086423002 Cr-Commit-Position: refs/heads/master@{#325625}
* Treat "xcode-ninja" generator the same as "ninja" generatorsdefresne2015-03-181-3/+3
| | | | | | | | | | | | When generator is "xcode-ninja" there is no need to do the recursive reinvocation of gyp to work-around Xcode not supporting iOS targets to depend on Mac tools. BUG=467575 Review URL: https://codereview.chromium.org/1013753002 Cr-Commit-Position: refs/heads/master@{#321124}
* Apply gn format with 'sources' sorting to src/scottmg2015-02-281-17/+17
| | | | | | | | | | | | Application of https://codereview.chromium.org/962003002/. TBR=keybuk@chromium.org R=brettw@chromium.org BUG=456014 Review URL: https://codereview.chromium.org/960413003 Cr-Commit-Position: refs/heads/master@{#318574}
* Fix dump_dependency_json generator for iOSsdefresne2015-02-251-3/+3
| | | | | | | | | | | | | | The script tools/gyp-explain.py uses the output of the gyp generator "dump_dependency_json" so flip the condition in the gyp files to test if the generator is "xcode" instead of "ninja" (so that the generator dumping the JSON dependencies see the same dependency as the "ninja" generator). BUG=None Review URL: https://codereview.chromium.org/957673005 Cr-Commit-Position: refs/heads/master@{#318056}
* Update Chomium's build files to work w/ latest GN binaries.dpranke2015-02-201-2/+2
| | | | | | | | | | | | | | The latest GN binaries rename cpu_arch to current_cpu and/or target_cpu as appropriate, build_cpu_arch to host_cpu, and os to current_os and target_os as appropriate. R=brettw@chromium.org TBR=ddorwin@chromium.org EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg BUG=344767 Review URL: https://codereview.chromium.org/913373002 Cr-Commit-Position: refs/heads/master@{#317223}
* Do not build breakpad tool on target when cross-compiling for iOSSylvain Defresne2015-02-181-4/+20
| | | | | | | | | | | | | | | | The "microdump_stackwalk", "minidump_stackwalk", and "minidump_dump" tools are not expected to be run on the device, so only build them for "host" toolset not "target" when targetting iOS. When building for other targets build the tools both for "host" and "target" to fix compilation of ChromeOS build in `cros chrome-sdk` shells. BUG=459035 TBR=mark Review URL: https://codereview.chromium.org/938763004 Cr-Commit-Position: refs/heads/master@{#316879}
* Do not build breakpad tool on target when cross-compilingsdefresne2015-02-181-0/+4
| | | | | | | | | | | | The "microdump_stackwalk", "minidump_stackwalk", and "minidump_dump" tools are not expected to be run on the device, so only build them for "host" toolset not "target". BUG=459035 Review URL: https://codereview.chromium.org/924943005 Cr-Commit-Position: refs/heads/master@{#316842}
* Enable minidump_stackwalk on iOS with ninja.justincohen2015-02-111-2/+2
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/908463002 Cr-Commit-Position: refs/heads/master@{#315757}
* Move the test template to //testing/test.gni (part 2)qsr2015-01-211-0/+2
| | | | | | | | | | | | This CL move the test target from build/config/BUILDCONFIG.gn to testing/test.gni It also update the test template to automatically build an apk on Android. R=cjhopman@chromium.org,brettw@chromium.org Review URL: https://codereview.chromium.org/824263004 Cr-Commit-Position: refs/heads/master@{#312396}
* Add breakpad_sender target to GN build.vchigrin2015-01-201-0/+15
| | | | | | Review URL: https://codereview.chromium.org/859643002 Cr-Commit-Position: refs/heads/master@{#312271}
* gn format // (the rest, except mojo)scottmg2014-12-031-22/+25
| | | | | | | | | | | | | | Excluded mojo because I think that needs to happen on the other side. At gn --version = 306668 for which roll is in CQ. R=brettw@chromium.org TBR=scherkus@chromium.org BUG=348474 Review URL: https://codereview.chromium.org/774353003 Cr-Commit-Position: refs/heads/master@{#306708}
* match openbsd as well in landmine_utils and breakpadrobert.nagy2014-11-251-1/+1
| | | | | | | | | | BUG= R=thestig@chromium.org Review URL: https://codereview.chromium.org/760643002 Cr-Commit-Position: refs/heads/master@{#305686}
* Roll breakpad to r1405 and add microdump_stackwalk to build files.primiano2014-11-252-17/+73
| | | | | | | | | | | This rolls the following into breakpad: r1405 Introduce microdump_stackwalk comand line executable BUG=410294 Review URL: https://codereview.chromium.org/754923002 Cr-Commit-Position: refs/heads/master@{#305683}
* Roll Breakpad r1397:r1404 and enable Android microdump crash handler.primiano2014-11-252-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On official releases, Chrome for Android omits unwind tables to save some precious binary size (~1.5M on arm, ~10M on arm64). This, however, causes information loss on the stack traces generated on the device (logcat, tombstones, debuggerd and generally everything != breakpad). This CL solves this problem by enabling breakpad micro crash dumps when unwind tables are stripped out. Microdumps have been recently introduced in breakpad and, in the very essence, are a reduced version of minidumps which can be dumped out directly on a text console (logcat on Android). By dumping microdumps into logcat, bug reports will keep having enough information to be able to reconstruct the stack trace of the crashing thread, without needing unwind tables. Conversely to minidump, microdumps are NOT uploaded anywhere and just live in the logcat / tombstones. Furthermore, in order to avoid intefering with the conventional breakpad crash reporting, (when enabled) the microdump crash handler is registered as secondary handler and it is run after the breakpad minidump one. This change also roll breakpad/src into DEPS to catch: r1398 Introduce microdump writer class. r1399 Fix Windows client compilation on mingw. r1400 Read dynamic symbols table even if binary contains debug info r1401 Fix UMR and potential crash in Mac dump_syms. r1402 Add parameter --product to symupload.exe r1403 Microdump processing implementation r1404 Fix microdump_writer and add unittest. BUG=410294 Review URL: https://codereview.chromium.org/689923003 Cr-Commit-Position: refs/heads/master@{#305623}
* Take #2 at re-enabling breakpad in the Mac GN build.dpranke2014-11-201-6/+9
| | | | | | | | | | | | | | | The previous version failed because we seem to have rolled in a new version of breakpad that had an unused function error in a target that was previously compiling fine w/ the chromium_code config. This patch marks the target (symupload) as no_chromium_code. TBR=brettw@chromium.org BUG=431177 Review URL: https://codereview.chromium.org/743813002 Cr-Commit-Position: refs/heads/master@{#304980}
* Revert of Make breakpad work in Mac GN. (patchset #1 id:1 of ↵sky2014-11-191-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/732853002/) Reason for revert: Ironically this broke the mac gn build: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/608/steps/compile/logs/stdio FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/breakpad/src/tools/mac/symupload/symupload.symupload.o.d -DCHROMIUM_BUILD -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_OPENSSL=1 -DNO_TCMALLOC -DDISABLE_NACL -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -DENABLE_REMOTING=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1 -DCR_CLANG_REVISION=218707 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../../breakpad/src/common/mac -I../.. -Igen -fno-strict-aliasing -fstack-protector-all -arch i386 -fcolor-diagnostics -Wall -Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wnewline-eof -Wno-c++11-narrowing -Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal -fvisibility=hidden -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -O0 -g2 -std=c99 -c ../../breakpad/src/tools/mac/symupload/symupload.m -o obj/breakpad/src/tools/mac/symupload/symupload.symupload.o ../../breakpad/src/tools/mac/symupload/symupload.m:85:18:error: unused function 'CompactIdentifier' [-Werror,-Wunused-function] static NSString *CompactIdentifier(NSString *uuid) { ^ 1 error generated. Original issue's description: > Make breakpad work in Mac GN. > > R=brettw@chromium.org, thakis@chromium.org > BUG=431177 > > Committed: https://crrev.com/6ae55f928b690168c589912615894eb27cf62e1b > Cr-Commit-Position: refs/heads/master@{#304884} TBR=brettw@chromium.org,thakis@chromium.org,dpranke@chromium.org NOTREECHECKS=true NOTRY=true BUG=431177 Review URL: https://codereview.chromium.org/725373006 Cr-Commit-Position: refs/heads/master@{#304888}
* Make breakpad work in Mac GN.dpranke2014-11-191-6/+6
| | | | | | | | | R=brettw@chromium.org, thakis@chromium.org BUG=431177 Review URL: https://codereview.chromium.org/732853002 Cr-Commit-Position: refs/heads/master@{#304884}
* [iOS] Disable deprecated API warnings in skia and breakpad.lliabraa2014-11-191-0/+11
| | | | | | | | | | | | | These libraries use APIs that have been deprecated on iOS. This CL updates the gyp files so that the warnings are not generated but the bugs below still track the work to update the code to not use the deprecated APIs. BUG=408571, 408562 Review URL: https://codereview.chromium.org/726693005 Cr-Commit-Position: refs/heads/master@{#304807}
* This gets at least a chunk of the Mac GN build working.dpranke2014-11-101-4/+13
| | | | | | | | | | | With a few additional fixes in other repos, we will have substantially more working, but this'll do to at least make the bots functional. R=brettw@chromium.org BUG=431117 Review URL: https://codereview.chromium.org/702003002 Cr-Commit-Position: refs/heads/master@{#303540}
* Added support of shared_library build for testsripp2014-10-291-0/+18
| | | | | | | | | | | | | | | breakpad_unittests and sandbox_linux_unittests R=thestig@chromium.org, jbudorick@chromium.org, jorgelo@chromium.org BUG=344868 TEST=Turn on components build (component=shared_library) ensure that breakpad_unittests and sandbox_linux_unittests are starting (breakpad_unittests_deps and sandbox_linux_unittests_deps targets correspondingly) Review URL: https://codereview.chromium.org/655543005 Cr-Commit-Position: refs/heads/master@{#301797}
generated by cgit v1.1 at 2024-09-20 03:14:53 +0000