| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
| |
This fixes a subtle bug where the wrong libchromium_android_linker.so is used
when it already exists in the system library path.
BUG=587584
Review URL: https://codereview.chromium.org/1729973002
Cr-Commit-Position: refs/heads/master@{#377290}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #1 id:1 of https://codereview.chromium.org/1726703002/ )
Reason for revert:
Breaks incremental install for M devices.
Original issue's description:
> Add increment install native libraries first in lookup paths
>
> This fixes a subtle bug where the wrong libchromium_android_linker.so is used
> when it already exists in the system library path.
>
> BUG=587584
>
> Committed: https://crrev.com/86af989585dd6aac45d3087456ef7cafb37afa86
> Cr-Commit-Position: refs/heads/master@{#377074}
TBR=hanxi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=587584
Review URL: https://codereview.chromium.org/1731593003
Cr-Commit-Position: refs/heads/master@{#377171}
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a subtle bug where the wrong libchromium_android_linker.so is used
when it already exists in the system library path.
BUG=587584
Review URL: https://codereview.chromium.org/1726703002
Cr-Commit-Position: refs/heads/master@{#377074}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is that sometimes there are .apks that don't have any
resources (e.g. test apks), and so there is a javac.py call with a
single .srcjar, which has no sources in it. Ninja is expecting the call
to create a .jar.pdb file, so just create an empty file to appease it.
Without this, running "ninja chrome_public_test_apk" multiple times
causes ninja to do the same work over and over again, rather than saying
there's no work to do
BUG=none
Review URL: https://codereview.chromium.org/1706363003
Cr-Commit-Position: refs/heads/master@{#376984}
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a side effect of fixing crbug.com/525220, there is no longer need
to swap the benchmark name with the step name in the chartjson with
the test results.
BUG=568029
Review URL: https://codereview.chromium.org/1683083007
Cr-Commit-Position: refs/heads/master@{#376741}
|
|
|
|
|
|
|
|
|
|
|
| |
This also makes it return non-zero when the .html is not actually
created.
BUG=587983
Review URL: https://codereview.chromium.org/1711983002
Cr-Commit-Position: refs/heads/master@{#376348}
|
|
|
|
|
|
|
|
| |
BUG=587584
Review URL: https://codereview.chromium.org/1709543003
Cr-Commit-Position: refs/heads/master@{#376165}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1705903002
Cr-Commit-Position: refs/heads/master@{#375972}
|
|
|
|
|
|
|
|
| |
BUG=584730
Review URL: https://codereview.chromium.org/1704993002
Cr-Commit-Position: refs/heads/master@{#375927}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland of https://codereview.chromium.org/1692383002/
This improves build concurrency a little bit.
TBR=jbudorick
BUG=none
Review URL: https://codereview.chromium.org/1702663002
Cr-Commit-Position: refs/heads/master@{#375669}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android GN builds appear to run Python scripts in an environment where
the locale is 'C'. The Android linter typically produces XML output
containing strings with non-ASCII characters (such as translated string
resources). The Python 'print' statement defaults to 'ascii' encoding
and throws a UnicodeEncodeError when printing such an item.
This exception is caught and (incorrectly) interpreted as a problem
with parsing the XML file, which causes lint.py to write out the
entire XML file. This CL fixes the problem by specifying utf-8 when
printing these objects.
BUG=583098
TEST=GN build of remoting_apk no longer produces 1000s of lines of output.
Review URL: https://codereview.chromium.org/1701463002
Cr-Commit-Position: refs/heads/master@{#375652}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding scripts to make it easy to run junit test. These are named
out/bin/run_<junit_suite_name>.
Moving the helper scripts that our test runner uses to run the
junit test suites. These scripts are not meant to be run except
by the test runner. Moving them into out/bin/helper/<script_names>
so people don't accidently try to run them.
BUG=511999
Review URL: https://codereview.chromium.org/1674353004
Cr-Commit-Position: refs/heads/master@{#375603}
|
|
|
|
|
|
|
|
| |
BUG=549348
Review URL: https://codereview.chromium.org/1698283002
Cr-Commit-Position: refs/heads/master@{#375589}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1704453002
Cr-Commit-Position: refs/heads/master@{#375584}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #2 id:70001 of https://codereview.chromium.org/1690983002/ )
Reason for revert:
https://code.google.com/p/chromium/issues/detail?id=586641
Original issue's description:
> Reland #2 of Tweak GN deps of instrumentation apks
>
> Reland of https://codereview.chromium.org/1687723002/
>
> This improves build concurrency a little bit.
>
> BUG=none
TBR=agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/1692383002
Cr-Commit-Position: refs/heads/master@{#375272}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland of https://codereview.chromium.org/1687723002/
This improves build concurrency a little bit.
BUG=none
Review URL: https://codereview.chromium.org/1690983002
Cr-Commit-Position: refs/heads/master@{#375252}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One drawback of the custom java_* and android_* GN templates is that
group() does not work as you'd expect. For example, if you have a
dependency like: java_binary() -> group() -> java_library(), then the
java_library() won't actually be added to the java_binary() when
compiled (because write_build_config requires that all deps also produce
build_configs)
This adds java_group() in order to fill that gap.
BUG=586506
Review URL: https://codereview.chromium.org/1681223007
Cr-Commit-Position: refs/heads/master@{#375249}
|
|
|
|
|
|
|
|
|
|
|
| |
No longer respects setting CHROMIUM_OUT_DIR / --out-dir plus BUILDTYPE /
--release / --debug.
BUG=573345
Review URL: https://codereview.chromium.org/1659413003
Cr-Commit-Position: refs/heads/master@{#375230}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Friends:
* third_party/android_platform/development/scripts/stack
* build/android/asan_symbolize.py
Mandatory:
Required, unless CHROMIUM_OUTPUT_DIR or CHROMIUM_OUT_DIR are set or when the current working directory is an output directory (contains a build.ninja file)
BUG=573345
Review URL: https://codereview.chromium.org/1670223002
Cr-Commit-Position: refs/heads/master@{#375222}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL removes pylib.flag_changer. flag_changer has been
moved to catapult.
BUG=583785
Review URL: https://codereview.chromium.org/1691683004
Cr-Commit-Position: refs/heads/master@{#375199}
|
|
|
|
|
|
|
|
| |
BUG=567786
Review URL: https://codereview.chromium.org/1688113005
Cr-Commit-Position: refs/heads/master@{#375072}
|
|
|
|
|
|
|
|
|
|
|
| |
Reboot device during provisioning if it is not charging correctly.
After rebooting if it is still not charging correctly, blacklist.
BUG=567786
Review URL: https://codereview.chromium.org/1672543002
Cr-Commit-Position: refs/heads/master@{#375007}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For:
- build/android/adb_gdb*
- build/android/asan_symbolize.py
- build/android/tombstones.py
- third_party/android_platform/development/scripts/stack
- tools/perf/run_benchmark
BUG=573345
Review URL: https://codereview.chromium.org/1663103004
Cr-Commit-Position: refs/heads/master@{#374964}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL updates the dependency on pylib.flag_changer to
Catapult's devil.android.flag_changer in Chromium repo.
- The previous CL added devil.android.flag_changer in
catapult: https://crrev.com/1675773002/
- The next CL will remove pylib.flag_changer.
BUG=583785
Review URL: https://codereview.chromium.org/1677313002
Cr-Commit-Position: refs/heads/master@{#374936}
|
|
|
|
|
|
|
|
|
| |
BUG=
TBR=mikecase@chromium.org
Review URL: https://codereview.chromium.org/1688173002
Cr-Commit-Position: refs/heads/master@{#374903}
|
|
|
|
|
|
|
|
|
|
| |
Missed this one first time around.
BUG=none
Review URL: https://codereview.chromium.org/1684193002
Cr-Commit-Position: refs/heads/master@{#374752}
|
|
|
|
|
|
|
|
|
|
|
| |
Switches gtests to explicitly passing path to install script rather than
--incremental-install + heuristics.
BUG=575975
Review URL: https://codereview.chromium.org/1680233002
Cr-Commit-Position: refs/heads/master@{#374699}
|
|
|
|
|
|
|
|
|
|
| |
Build rule and test runner changes to follow.
BUG=575975
Review URL: https://codereview.chromium.org/1684583003
Cr-Commit-Position: refs/heads/master@{#374695}
|
|
|
|
|
|
|
|
|
|
| |
size.py
BUG=546012
Review URL: https://codereview.chromium.org/1644773005
Cr-Commit-Position: refs/heads/master@{#374679}
|
|
|
|
|
|
|
|
|
|
|
| |
As a shorthand for: --verbose --num-retries=0 --enable-device-cache \
--skip-clear-data --extract-test-list-from-filter
BUG=None
Review URL: https://codereview.chromium.org/1661253002
Cr-Commit-Position: refs/heads/master@{#374420}
|
|
|
|
|
|
|
|
|
|
|
| |
id:1 of https://codereview.chromium.org/1677193002/ )
TBR=jbudorick@chromium.org,flackr@chromium.org
BUG=573345
Review URL: https://codereview.chromium.org/1681143002
Cr-Commit-Position: refs/heads/master@{#374419}
|
|
|
|
|
|
|
|
|
|
| |
Having two scripts that cache the same thing in two different spots is a bad recipe.
BUG=none
Review URL: https://codereview.chromium.org/1679633002
Cr-Commit-Position: refs/heads/master@{#374415}
|
|
|
|
|
|
|
|
| |
BUG=580129
Review URL: https://codereview.chromium.org/1673393003
Cr-Commit-Position: refs/heads/master@{#374413}
|
|
|
|
|
|
|
|
|
| |
BUG=580129
TBR=agrieve@chromium.org
Review URL: https://codereview.chromium.org/1684513002
Cr-Commit-Position: refs/heads/master@{#374315}
|
|
|
|
|
|
|
|
|
|
|
| |
This option will make it much easier to add logcats to
individual steps in recipes.
BUG=583798
Review URL: https://codereview.chromium.org/1663933003
Cr-Commit-Position: refs/heads/master@{#374295}
|
|
|
|
|
|
|
|
|
|
| |
Meant to be used to speed up local development. Mostly applicable when running instrumentation tests against _incremental .apks.
BUG=540857
Review URL: https://codereview.chromium.org/1570043004
Cr-Commit-Position: refs/heads/master@{#374211}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the dist jar is used only for extracting the list of tests,
there's no need to create one for every apk.
Using interface jars rather than normal jars speeds up test calculation
time for ChromePublicTestApk 17s -> 5s on my machine.
Even better would be to address the TODO and create the test list at
build time, but might as well pick this lower-hanging fruit :).
BUG=none
Review URL: https://codereview.chromium.org/1679623002
Cr-Commit-Position: refs/heads/master@{#374181}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:1 of https://codereview.chromium.org/1674683002/ )
Reason for revert:
This has is failing 'Run stack tool with logcat dump' step on several android bots:
https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%206%29/builds/6322
https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%205%29/builds/5689
Original issue's description:
> Add --output-directory to stack tool buildbot step
>
> BUG=573345
>
> Committed: https://crrev.com/ec0616bfa85b1af5369766ee9dad95e69cfe1f7a
> Cr-Commit-Position: refs/heads/master@{#374136}
TBR=jbudorick@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=573345
Review URL: https://codereview.chromium.org/1677193002
Cr-Commit-Position: refs/heads/master@{#374154}
|
|
|
|
|
|
|
|
| |
BUG=573345
Review URL: https://codereview.chromium.org/1674683002
Cr-Commit-Position: refs/heads/master@{#374136}
|
|
|
|
|
|
|
|
| |
BUG=580129
Review URL: https://codereview.chromium.org/1672623002
Cr-Commit-Position: refs/heads/master@{#374004}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Friends:
* third_party/android_platform/development/scripts/stack
* build/android/asan_symbolize.py
Will make it mandatory in stack as in a follow-up.
BUG=573345
Review URL: https://codereview.chromium.org/1660693002
Cr-Commit-Position: refs/heads/master@{#373991}
|
|
|
|
|
|
|
|
|
|
| |
None of these tests exist anymore.
BUG=159935, 241730, 320005
Review URL: https://codereview.chromium.org/1678443003
Cr-Commit-Position: refs/heads/master@{#373981}
|
|
|
|
|
|
|
|
| |
BUG=583614
Review URL: https://codereview.chromium.org/1670833002
Cr-Commit-Position: refs/heads/master@{#373873}
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of https://codereview.chromium.org/1639253010/
BUG=488195
TBR=agrieve@chromium.org,maruel@chromium.org,mef@chromium.org,yfriedman@chromium.org
Review URL: https://codereview.chromium.org/1671923002
Cr-Commit-Position: refs/heads/master@{#373841}
|
|
|
|
|
|
|
|
| |
BUG=573345
Review URL: https://codereview.chromium.org/1666593002
Cr-Commit-Position: refs/heads/master@{#373832}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #4 id:60001 of https://codereview.chromium.org/1639253010/ )
Reason for revert:
I suspect this CL caused the breakage described in crbug.com/584630
Original issue's description:
> [Android] Convert TabsTest and InfoBarTest to EmbeddedTestServer.
>
> BUG=488195
> TBR=maruel@chromium.org
>
> Committed: https://crrev.com/91bb9b3d4964cb8611231722a4538afccbd9fd09
> Cr-Commit-Position: refs/heads/master@{#373588}
TBR=yfriedman@chromium.org,agrieve@chromium.org,maruel@chromium.org,mef@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=488195
Review URL: https://codereview.chromium.org/1671603003
Cr-Commit-Position: refs/heads/master@{#373789}
|
|
|
|
|
|
|
|
|
| |
BUG=488195
TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/1639253010
Cr-Commit-Position: refs/heads/master@{#373588}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead, require one of:
--output-directory
--out-dir
CHROMIUM_OUTPUT_DIR
CHROMIUM_OUT_DIR
CWD=output-dir
This should reduce developer confusion resulting from the wrong output
directory being auto-detected.
TBR=pasko
BUG=573345
Review URL: https://codereview.chromium.org/1555783002
Cr-Commit-Position: refs/heads/master@{#373580}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding this for convienance to access logcat output if you
happen to want to do things with the files (like merge them)
after recording. This way to just don't have to store the file
names alongside the logcat_monitors.
BUG=
Review URL: https://codereview.chromium.org/1668703002
Cr-Commit-Position: refs/heads/master@{#373569}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before change:
I 0.025s Main Using device cache: /usr/local/...
Could not find apk or executable for base_unittestsI 0.026s Main Wrote device cache: /usr/...
E 0.028s Main Unrecognized error occurred.
After change:
I 0.025s Main Using device cache: /usr/local/...
C 0.025s Main Could not find apk or executable for base_unittests
I 0.026s Main Wrote device cache: /usr/local/...
BUG=None
Review URL: https://codereview.chromium.org/1666983002
Cr-Commit-Position: refs/heads/master@{#373559}
|