| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Also add a statement about where to find the actual logcat.
BUG=597771,448050
Review URL: https://codereview.chromium.org/1838483002
Cr-Commit-Position: refs/heads/master@{#383330}
|
|
|
|
|
|
|
|
|
|
|
| |
This is required for any test that uses an .isolate to push files to the
device (e.g. base_unittests).
BUG=589318
Review URL: https://codereview.chromium.org/1784373002
Cr-Commit-Position: refs/heads/master@{#383127}
|
|
|
|
|
|
|
|
|
|
|
| |
This will mean even fewer UnusedResource checks, but that is covered by:
https://bugs.chromium.org/p/chromium/issues/detail?id=595810
BUG=597007
Review URL: https://codereview.chromium.org/1826563002
Cr-Commit-Position: refs/heads/master@{#382986}
|
|
|
|
|
|
|
|
|
|
|
|
| |
gyp always specified a value for --no-locals when compiling targets but
GN doesn't.
This resulted in GN erroneously stripping them.
BUG=596134
Review URL: https://codereview.chromium.org/1830693003
Cr-Commit-Position: refs/heads/master@{#382985}
|
|
|
|
|
|
|
|
| |
BUG=594807
Review URL: https://codereview.chromium.org/1828523002
Cr-Commit-Position: refs/heads/master@{#382917}
|
|
|
|
|
|
|
|
| |
BUG=484854
Review URL: https://codereview.chromium.org/1829823002
Cr-Commit-Position: refs/heads/master@{#382905}
|
|
|
|
|
|
|
|
|
|
|
|
| |
No longer trying to guess name of cached .bin file.
Previous commit forgot to set --cache-dir for GN.
BUG=583661,597251
Review URL: https://codereview.chromium.org/1828693002
Cr-Commit-Position: refs/heads/master@{#382871}
|
|
|
|
|
|
|
|
| |
BUG=583661
Review URL: https://codereview.chromium.org/1823173002
Cr-Commit-Position: refs/heads/master@{#382848}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(fix-up) (patchset #2 id:20001 of https://codereview.chromium.org/1824093002/ )
Reason for revert:
Breaks on Android 64bit unpublished builders
BUG=597251
Original issue's description:
> Android: Run lint using a cache in the output directory (fix-up)
>
> Previous commit forgot to set --cache-dir for GN.
>
> BUG=583661
>
> Committed: https://crrev.com/99748af41ad073389f3f38274a024a830585609c
> Cr-Commit-Position: refs/heads/master@{#382699}
TBR=jbudorick@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=583661
Review URL: https://codereview.chromium.org/1829683002
Cr-Commit-Position: refs/heads/master@{#382838}
|
|
|
|
|
|
|
|
|
|
| |
Previous commit forgot to set --cache-dir for GN.
BUG=583661
Review URL: https://codereview.chromium.org/1824093002
Cr-Commit-Position: refs/heads/master@{#382699}
|
|
|
|
|
|
|
|
| |
BUG=583661
Review URL: https://codereview.chromium.org/1817943005
Cr-Commit-Position: refs/heads/master@{#382582}
|
|
|
|
|
|
|
|
| |
BUG=415300
Review URL: https://codereview.chromium.org/1809893002
Cr-Commit-Position: refs/heads/master@{#382468}
|
|
|
|
|
|
|
|
|
|
| |
This fixes arch detection when 32-bit Chrome is run on a 64-bit device
BUG=596088
Review URL: https://codereview.chromium.org/1811363002
Cr-Commit-Position: refs/heads/master@{#382319}
|
|
|
|
|
|
|
|
| |
BUG=583661
Review URL: https://codereview.chromium.org/1815563005
Cr-Commit-Position: refs/heads/master@{#382306}
|
|
|
|
|
|
|
|
|
|
| |
and fix it not erroring out when multiple devices are attached
BUG=none
Review URL: https://codereview.chromium.org/1818433002
Cr-Commit-Position: refs/heads/master@{#382036}
|
|
|
|
|
|
|
|
|
|
| |
setting permissions.
BUG=591224
Review URL: https://codereview.chromium.org/1800283002
Cr-Commit-Position: refs/heads/master@{#381323}
|
|
|
|
|
|
|
|
|
|
|
| |
It was not being rebuilt when is_component_build=true, and the only
change to the .apk's inputs was to an indirect .cr.so file.
BUG=594409
Review URL: https://codereview.chromium.org/1802853002
Cr-Commit-Position: refs/heads/master@{#381253}
|
|
|
|
|
|
|
|
|
|
|
| |
Should fix aapt failure on bots.
TBR=jbudorick
BUG=589318
Review URL: https://codereview.chromium.org/1804843002
Cr-Commit-Position: refs/heads/master@{#381160}
|
|
|
|
|
|
|
|
|
|
| |
directories.
BUG=583661
Review URL: https://codereview.chromium.org/1785333004
Cr-Commit-Position: refs/heads/master@{#381035}
|
|
|
|
|
|
|
|
| |
BUG=594105,593973
Review URL: https://codereview.chromium.org/1799073004
Cr-Commit-Position: refs/heads/master@{#381032}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Official builds still using branding=Chrome so they will continue
to support codecs and containers like h264, mp3, aac, and mp4.
Adds support for video/webm videos using vp8,vorbis to the webview
tests so they will continue to work w/o proprietary codecs.
We have approval to do this now. Summary will be posted to the
src= launch bug: http://crbug.com/533190#c17
This will require some changes to the build flags for the official
WebView AOSP builders, which I'll land shortly after this.
BUG=570762
TEST=webview tests pass.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.android:android_chromium_gn_rel
Review URL: https://codereview.chromium.org/1577433004
Cr-Commit-Position: refs/heads/master@{#380839}
|
|
|
|
|
|
|
|
| |
BUG=525873
Review URL: https://codereview.chromium.org/1788963002
Cr-Commit-Position: refs/heads/master@{#380836}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It causes extra targets to be compiled when GN args change, and a target
has logic like:
target("foo") {
if (arg) {
deps = [":A"]
} else {
deps = [":B"]
}
}
BUG=589311
Review URL: https://codereview.chromium.org/1730993002
Cr-Commit-Position: refs/heads/master@{#380704}
|
|
|
|
|
|
|
|
| |
BUG=589318
Review URL: https://codereview.chromium.org/1785483005
Cr-Commit-Position: refs/heads/master@{#380648}
|
|
|
|
|
|
|
|
|
|
|
| |
This also narrows some of the specified catapult directories to avoid
isolating directories containing dependencies downloaded from cloud storage.
BUG=589318
Review URL: https://codereview.chromium.org/1783603003
Cr-Commit-Position: refs/heads/master@{#380464}
|
|
|
|
|
|
|
|
| |
BUG=476719
Review URL: https://codereview.chromium.org/1770943003
Cr-Commit-Position: refs/heads/master@{#380317}
|
|
|
|
|
|
|
|
|
|
| |
Verified this fixes android_webview_unittests
BUG=589318
Review URL: https://codereview.chromium.org/1774193004
Cr-Commit-Position: refs/heads/master@{#380183}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaces the unknowns we keep seeing with either usb_failure, missing,
or offline.
missing: Shows up in lsusb but not adb.
usb_failure: Shows up in lsusb but can't reset the device via /dev/bus.
offline: Doesn't show up in lsusb or adb.
BUG=592666
Review URL: https://codereview.chromium.org/1768423002
Cr-Commit-Position: refs/heads/master@{#380028}
|
|
|
|
|
|
|
|
|
| |
In case a crashing testcase stops following testcases in the shard from running, created a separate shard for suspicious crashing testcase.
BUG=581086
Review URL: https://codereview.chromium.org/1703863003
Cr-Commit-Position: refs/heads/master@{#379987}
|
|
|
|
|
|
|
|
|
|
| |
When devices fail to list tests, instead of treating the result of list tests, which is None as an empty list, we should raise an exception.
BUG=585585
Review URL: https://codereview.chromium.org/1716863002
Cr-Commit-Position: refs/heads/master@{#379925}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Marshmallow devices, permissions such as WRITE_EXTERNAL_STORAGE
must be set for gtest suites to run properly (otherwise you can get
strange results like "0 tests ran").
_InstallInternal in build/android/devil/android/device_utils.py will
automatically set the right permissions, but only if the permissions
parameter is None. But do_install in
build/android/incremental_install/installer.py was setting permissions
to (), hence _InstallInternal wasn't granting the permissions. This
patch fixes that.
BUG=none
Review URL: https://codereview.chromium.org/1738843003
Cr-Commit-Position: refs/heads/master@{#379826}
|
|
|
|
|
|
|
|
| |
BUG=555668
Review URL: https://codereview.chromium.org/1770883002
Cr-Commit-Position: refs/heads/master@{#379817}
|
|
|
|
|
|
|
|
| |
BUG=590394
Review URL: https://codereview.chromium.org/1772843002
Cr-Commit-Position: refs/heads/master@{#379664}
|
|
|
|
|
|
|
|
|
|
| |
chromium port of https://codereview.chromium.org/1768253002/
BUG=
Review URL: https://codereview.chromium.org/1768263002
Cr-Commit-Position: refs/heads/master@{#379612}
|
|
|
|
|
|
|
|
| |
BUG=583661
Review URL: https://codereview.chromium.org/1767103002
Cr-Commit-Position: refs/heads/master@{#379594}
|
|
|
|
|
|
|
|
|
| |
This allows running blink_platform_unittests on a local device without
explicitly specifying the isolate path.
Review URL: https://codereview.chromium.org/1766153003
Cr-Commit-Position: refs/heads/master@{#379515}
|
|
|
|
|
|
|
|
|
|
|
| |
The new script uses the adb_command_line.py script in build/android
and is therefore compatible with the --device argument.
BUG= internal b/26406816
Review URL: https://codereview.chromium.org/1750393003
Cr-Commit-Position: refs/heads/master@{#378780}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change alters the command line file handling in
python to always push, restore, and delete them in
/data/local/tmp rather than /data/local on user builds.
This will allow user builds to run all tests.
BUG=561796
Review URL: https://codereview.chromium.org/1688003004
Cr-Commit-Position: refs/heads/master@{#378562}
|
|
|
|
|
|
|
|
|
|
|
| |
Mistakenly not glient synced in my last CL which reverted the CL that
extend the emulator launch wait time to be 60s
BUG=
Review URL: https://codereview.chromium.org/1751083002
Cr-Commit-Position: refs/heads/master@{#378542}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1752493002
Cr-Commit-Position: refs/heads/master@{#378347}
|
|
|
|
|
|
|
|
| |
BUG=587986
Review URL: https://codereview.chromium.org/1711253002
Cr-Commit-Position: refs/heads/master@{#378251}
|
|
|
|
|
|
|
|
|
|
|
| |
Recent changes make the path to the known devices file configurable. This change
makes the perf test runner aware of this.
BUG=590229
Review URL: https://codereview.chromium.org/1736283002
Cr-Commit-Position: refs/heads/master@{#377926}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1736193002
Cr-Commit-Position: refs/heads/master@{#377809}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When locally building chrome_public_apk_incremental and making a
non-public change to a content_java file, this brings ninja time:
24s -> 7s
BUG=None
TBR=jbudorick
Review URL: https://codereview.chromium.org/1733893003
Cr-Commit-Position: refs/heads/master@{#377758}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous CL (https://crrev.com/1726783002/) copied
//tools/profile_chrome to Catapult. This CL removes
//tools/profile_chrome in Chromium repo and updates the
dependency.
BUG=catapult:#1937
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1738563002
Cr-Commit-Position: refs/heads/master@{#377733}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Emulators on bots are spawn in the background process so it requires
support from the launch script to wait for all the emulators to
finish booting
Related CL: 1729053002
BUG=
Review URL: https://codereview.chromium.org/1733733002
Cr-Commit-Position: refs/heads/master@{#377694}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1730143003/ )
Reason for revert:
Breaking bots.
Original issue's description:
> md5check'ify lint.py
>
> When locally building chrome_public_apk_incremental and making a
> non-public change to a content_java file, this brings ninja time:
>
> 24s -> 7s
>
> BUG=None
>
> Committed: https://crrev.com/b84f70aeb94075c8f6ec85a8211b231a9125ba41
> Cr-Commit-Position: refs/heads/master@{#377614}
TBR=jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/1739903002
Cr-Commit-Position: refs/heads/master@{#377650}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When locally building chrome_public_apk_incremental and making a
non-public change to a content_java file, this brings ninja time:
24s -> 7s
BUG=None
Review URL: https://codereview.chromium.org/1730143003
Cr-Commit-Position: refs/heads/master@{#377614}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#11 id:200001 of https://codereview.chromium.org/1387933005/ )
Reason for revert:
CRONET
Original issue's description:
> [Android] Switch instrumentation tests to platform mode.
>
> BUG=428729
>
> Committed: https://crrev.com/e5648339683b69d8eba1b7899b4e2593d2f83de0
> Cr-Commit-Position: refs/heads/master@{#377324}
TBR=mikecase@chromium.org,rnephew@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=428729
Review URL: https://codereview.chromium.org/1738543002
Cr-Commit-Position: refs/heads/master@{#377417}
|
|
|
|
|
|
|
|
| |
BUG=428729
Review URL: https://codereview.chromium.org/1387933005
Cr-Commit-Position: refs/heads/master@{#377324}
|