| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1419503006
Cr-Commit-Position: refs/heads/master@{#358025}
|
|
|
|
|
|
|
|
|
|
| |
This will add version number in generated policy_templates.
BUG=108941
Review URL: https://codereview.chromium.org/1429083003
Cr-Commit-Position: refs/heads/master@{#357400}
|
|
|
|
|
|
|
|
| |
This was removed in https://codereview.chromium.org/862043002/
Review URL: https://codereview.chromium.org/965733002
Cr-Commit-Position: refs/heads/master@{#324827}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes the grit_whitelist parameter to be a string instead of a
part of grit_defines.
This allow user to override the parameter with another file.
The goal of this is to allow creating bundles with their own whitelists.
At the moment, if you want to create a small executable (i.e. an ios extension)
that only uses 3 strings, you are required to include all the strings
whitelisted by the main chrome bundle.
By allowing to override the whitelist argument (instead of only appending the
argument array, it will allow to specify a specific whitelist for a specific
target.
BUG=456837
Review URL: https://codereview.chromium.org/862043002
Cr-Commit-Position: refs/heads/master@{#315324}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the file I'm testing with (c/b/resources/about_stats.html),
a rebuild runs 101 edges and compiles a bunch of cc files and takes 40s.
This reduces build times from 40s to 9.6s and reduces the number
of edges to 37.
BUG=439182
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/740463005
Cr-Commit-Position: refs/heads/master@{#306945}
|
|
|
|
|
|
|
|
|
|
|
| |
There are a lot of steps in processing resources and preparing them for
packaging. It will be easier if these are all done by the same script.
BUG=375431,359249
Review URL: https://codereview.chromium.org/310313005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/321453002/)
Reason for revert:
This is causing instrumentation-yakju-clankium-tot and clang-clankium-tot-builder (downstream) to fail with the following error message:
FAILED: cd ../../clank/native/framework; python ../../../build/android/gyp/process_resources.py --android-sdk /b/build/slave/instrumentation-yakju-clankium-tot/build/src/third_party/android_tools/sdk//platforms/android-19 --android-sdk-tools /b/build/slave/instrumentation-yakju-clankium-tot/build/src/third_party/android_tools/sdk//build-tools/19.0.0 --android-manifest ../../../clank/java/apps/deviceextras/AndroidManifest.xml --dependencies-res-dirs "" --extra-res-packages "" --extra-r-text-files "" --proguard-file ../../../out/Debug/device_extras_apk/proguard.txt --resource-dir ../../../clank/java/apps/deviceextras/res --res-v14-compatibility-dir ../../../out/Debug/device_extras_apk/res_v14_compatibility --crunch-output-dir ../../../out/Debug/device_extras_apk/res --R-dir ../../../out/Debug/device_extras_apk/gen --stamp ../../../out/Debug/device_extras_apk/codegen.stamp
Traceback (most recent call last):
File "../../../build/android/gyp/process_resources.py", line 217, in <module>
main()
File "../../../build/android/gyp/process_resources.py", line 166, in main
options.v14_verify_only)
File "/b/build/slave/instrumentation-yakju-clankium-tot/build/src/build/android/gyp/generate_v14_compatible_resources.py", line 335, in GenerateV14Resources
ErrorIfStyleResourceExistsInDir(input_dir)
File "/b/build/slave/instrumentation-yakju-clankium-tot/build/src/build/android/gyp/generate_v14_compatible_resources.py", line 107, in ErrorIfStyleResourceExistsInDir
'-v17 directory. Please refer to '
Exception: error: style file /b/build/slave/instrumentation-yakju-clankium-tot/build/src/clank/java/apps/deviceextras/res/values/styles.xml should be under /b/build/slave/instrumentation-yakju-clankium-tot/build/src/clank/java/apps/deviceextras/res/values-v17 directory. Please refer to http://crbug.com/243952 for the details.
I don't know resource loading well enough to tell if that's a legitimate issue or not; so for now reverting this to fix the build bots, and if it is a legitimate issue then ideally it could be fixed before relanding this?
Original issue's description:
> Add creation of v14 compatible resources to process_resources.py
>
> There are a lot of steps in processing resources and preparing them for
> packaging. It will be easier if these are all done by the same script.
>
> BUG=375431,359249
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275401
TBR=newt@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=375431,359249
Review URL: https://codereview.chromium.org/314363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There are a lot of steps in processing resources and preparing them for
packaging. It will be easier if these are all done by the same script.
BUG=375431,359249
Review URL: https://codereview.chromium.org/321453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=338759
NOTRY=true
Review URL: https://codereview.chromium.org/184783005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the default, so these are no-ops.
TBR=thakis@chromium.org
BUG=123026
Review URL: https://codereview.chromium.org/141693007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This uses tools/licenses.py internally.
BUG=160424
Review URL: https://codereview.chromium.org/12177010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This works around a MSVS bug which would change
'-f GRIT_DIR/../gritsettings/resource_ids' to '-f gritsettings/resource_ids'
and prepares for re-landing https://codereview.chromium.org/11659006/
Review URL: https://chromiumcodereview.appspot.com/11880050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> [Android] Generate localized strings.xml files at build time.
>
> This generates localized strings.xml files (e.g.
> values-fr/strings.xml) from grd and xtb files at build time. This
> means we no longer need to check in localized strings.xml files. Note:
> the xtb files are empty until translations are available.
>
> Benefits:
> - 41 fewer extraneous results when grepping Java string IDs
> - Switching from maintaining strings in strings.xml over to using a
> grd file is One Trivial CL* away: just include English in the list
> of languages for which we generate strings.xml files.
>
> *Restrictions may apply
>
> BUG=167248
>
> Review URL: https://codereview.chromium.org/11659006
TBR=newt@chromium.org
Review URL: https://codereview.chromium.org/11820058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This generates localized strings.xml files (e.g.
values-fr/strings.xml) from grd and xtb files at build time. This
means we no longer need to check in localized strings.xml files. Note:
the xtb files are empty until translations are available.
Benefits:
- 41 fewer extraneous results when grepping Java string IDs
- Switching from maintaining strings in strings.xml over to using a
grd file is One Trivial CL* away: just include English in the list
of languages for which we generate strings.xml files.
*Restrictions may apply
BUG=167248
Review URL: https://codereview.chromium.org/11659006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
remoting_resources target.
Previously all strings were in messages.json files. Moving them to GRD
file will allow to share them with native components. Also simplified
how resources are generated:
1. Now <if> is used to handle branded strings instead of generating
grd file in build time
2. Removed resource_ids - ids are now specified in grd files.
BUG=158995
Review URL: https://chromiumcodereview.appspot.com/11275101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
remoting_resources target."
This reverts commit f5dfed801f9358411900c4f9ca58ef0a11cce9ae.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
remoting_resources target.
Previously all strings were in messages.json files. Moving them to GRD
file will allow to share them with native components. Also simplified
how resources are generated:
1. Now <if> is used to handle branded strings instead of generating
grd file in build time
2. Removed resource_ids - ids are now specified in grd files.
BUG=158995
Review URL: https://codereview.chromium.org/11275101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
remoting_resources target.
Previously all strings were in messages.json files. Moving them to GRD
file will allow to share them with native components. Also simplified
how resources are generated:
1. Now <if> is used to handle branded strings instead of generating
grd file in build time
2. Removed resource_ids - ids are now specified in grd files.
BUG=158995
Review URL: https://codereview.chromium.org/11275101
TBR=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/11365095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
remoting_resources target.
Previously all strings were in messages.json files. Moving them to GRD
file will allow to share them with native components. Also simplified
how resources are generated:
1. Now <if> is used to handle branded strings instead of generating
grd file in build time
2. Removed resource_ids - ids are now specified in grd files.
BUG=158995
Review URL: https://codereview.chromium.org/11275101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When chromoting resources were converted from messages.json to .grd format
incorrect branding was used. Beside that simplified how resources are
generated:
1. Now <if> is used to handle branded strings instead of generating grd file in build time
2. Removed resource_ids - ids are now specified in grd files.
BUG=158995
Review URL: https://chromiumcodereview.appspot.com/11275101
TBR=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/11359035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When chromoting resources were converted from messages.json to .grd format
incorrect branding was used. Beside that simplified how resources are
generated:
1. Now <if> is used to handle branded strings instead of generating grd file in build time
2. Removed resource_ids - ids are now specified in grd files.
BUG=158995
Review URL: https://chromiumcodereview.appspot.com/11275101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Roll gyp has already been updated prevent the issues which happened previously with msvs 2008.
This is a second attempt at https://chromiumcodereview.appspot.com/10832121/
BUG=123026
R=scottmg,joi,thakis
Review URL: https://chromiumcodereview.appspot.com/10824268
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Try bots currently failing on pak build. Not sure that this is the cause, but
I don't see a lot of other plausible candidates. I'll revert this revert if it
doesn't help.)
R=scottmg,joi
BUG=123026
Review URL: https://chromiumcodereview.appspot.com/10832121
TBR=iannucci@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=scottmg,joi
BUG=123026
Review URL: https://chromiumcodereview.appspot.com/10832121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129619
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129818
Review URL: https://chromiumcodereview.appspot.com/9875019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resource_ids file.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129619
Review URL: https://chromiumcodereview.appspot.com/9875019
TBR=joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9959009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129619
Review URL: https://chromiumcodereview.appspot.com/9875019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resource_ids file.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/9875019
TBR=joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9924007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/9875019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were added in r28089 (http://codereview.chromium.org/256059) but
are unnecessary bloat for everyone to carry around, even those that don't
use emacs or vim.
In an earlier change, I added editor config files in src/tools/emacs/
and src/tools/vim/ so users of the appropriate editor can source those
instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7310019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This speeds up build/gyp_chromium by 7s on my system (for a total of 10s with the other grit_info changes I landed earlier).
BUG=82230
TEST=none
Review URL: http://codereview.chromium.org/7035004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
- Add two gypi files to src/build for the boilerplate added to targets and actions
- Update grit_info to also support the -E flag so it can share more of the grit build commandline
- switch over all but the webkit and webkit glue grd files to use the common support
BUG=22247
TEST=everything still localized correctly
Review URL: http://codereview.chromium.org/6705030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79548 0039d316-1c4b-4281-b951-d872f2087c98
|