| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that http://llvm.org/bugs/show_bug.cgi?id=10031 is fixed, this will hopefully
no longer crash clang.
BUG=84815
TEST=none
Review URL: http://codereview.chromium.org/7104062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs).
See the bug for a disussion of this change.
BUG=84424
TEST=none
Review URL: http://codereview.chromium.org/6995085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
features that need to be compiled out, instead of adding stubs.
Review URL: http://codereview.chromium.org/7046052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notable changes in the range:
* r132735 (hopefully) fixes a bug introduced in r131951 that made
gold 1.10 crash with
/usr/bin/ld: internal error in set_offset, at output.cc:4030
* r132535 fixes the crash at -O3 on mac
* r132565 adds a warning for "x + y ? a : b" to -Wparentheses
BUG=85289,84424
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/7046048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85289
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/7108018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang recently added a warning that warns when invoking 'delete' on a polymorphic non-final class without a virtual destructor. This finds real bugs – see the bug referenced below for a few examples.
However, one common pattern where it fires is this case:
class SomeInterface {
public:
virtual void interfaceMethod() {} // or = 0;
protected:
~SomeInterface() {}
}
class WorkerClass : public SomeInterface {
public:
// many non-virtual functions, but also:
virtual void interfaceMethod() override { /* do actual work */ }
};
void f() {
scoped_ptr<WorkerClass> c(new WorkerClass); // simplified example
}
(See the 2nd half of http://www.gotw.ca/publications/mill18.htm for an explanation of this pattern.)
It is arguably correct to fire the warning here, since someone might make a subclass of WorkerClass and replace |new WorkerClass| with |new WorkerClassSubclass|. This would be broken since WorkerClass doesn't have a virtual destructor.
The solution that the clang folks recommend is to mark WorkerClass as |final| (a c++0x keyword that clang supports as an extension in normal c++ mode – like override). But chrome's base/OWNERS deemed that as too complicated and we decided to make virtual the destructors of leaf classes that implement these interfaces and that are deleted dynamically. All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs).
(For the gtk files, this is necessary because the CHROMEGTK_CALLBACK_ macros add virtual functions.)
BUG=84424
TEST=none
Review URL: http://codereview.chromium.org/7087028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The OS-level registration isn't implemented on Linux, and so every time the
browser starts it will act as though another program has been registered to
handle the protocols it knows about and deregister them all internally.
Review URL: http://codereview.chromium.org/7024043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
relevant code if set to 0.
In chrome/browser/task_manager I moved notifications related code to their own files and allow exclusion and stubbing via GYP. Similarly I have added stubs for other parts including a chrome/browser/notifications/notification_stubs.cc which takes care of classes within that directory.
I also created some static methods in DesktopNotificationService to wrap commonly used notification related code so that we reduce the amount of stubs required.
BUG=none
TEST=existing notification tests succeed
Review URL: http://codereview.chromium.org/7053041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=nsylvain
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
TBR=nsylvain
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
want to load the touch icons (while the converse might not be true)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6993017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=run gyp, check -Wl,--icf=safe is added to *.target.mk but not to *.host.mk
Review URL: http://codereview.chromium.org/7065051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71571
TEST=Existing tests
Review URL: http://codereview.chromium.org/7020034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This deposits "FIXUPS" in the PDB, which grows the PDB file by 5% or so, but does otherwise not the generated binaries.
BUG=none
TESt=none
Review URL: http://codereview.chromium.org/7106002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=81678
TEST=none
Review URL: http://codereview.chromium.org/7102003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Existing
Review URL: http://codereview.chromium.org/7096013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This includes a new lang: Armenian (hy)
Patch from Fabien Tassin <fta@sofaraway.org>.
Review URL: http://codereview.chromium.org/7100004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Numerous targets were depending on linux/system.gyp:nss even on the openssl build and the gyp update means it shows up as a link error.
BUG=None
TEST=Builds with and without use_openssl=1
Review URL: http://codereview.chromium.org/7050040
TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/7054041
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/6962044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Numerous targets were depending on linux/system.gyp:nss even on the openssl build and the gyp update means it shows up as a link error.
BUG=None
TEST=Builds with and without use_openssl=1
Review URL: http://codereview.chromium.org/7050040
TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/7054041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Numerous targets were depending on linux/system.gyp:nss even on the openssl build and the gyp update means it shows up as a link error.
BUG=None
TEST=Builds with and without use_openssl=1
Review URL: http://codereview.chromium.org/7050040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Follow up to http://src.chromium.org/viewvc/chrome?view=rev&revision=87102 - it seems 'use_opensll!=0' is no longer supported in gyp(?)
BUG=None
TEST=build with use_openssl=1
Review URL: http://codereview.chromium.org/7096007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=mark
Review URL: http://codereview.chromium.org/7087016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7083014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This speeds up build/gyp_chromium by 7s on my system (for a total of 10s with the other grit_info changes I landed earlier).
BUG=82230
TEST=none
Review URL: http://codereview.chromium.org/7035004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=chase@chromium.org
Review URL: http://codereview.chromium.org/7080008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=81621
R=cmp@chromium.org
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86732
Review URL: http://codereview.chromium.org/6992077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=tony
Review URL: http://codereview.chromium.org/7075007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=83286
TEST=None.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86569
Review URL: http://codereview.chromium.org/7036019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change implements a settings page that allows users to manage protocol
handlers registered via navigator.registerProtocolHandler.
tony: could you review the ProtocolHandlerRegistry stuff?
estade: could you review the webui stuff?
Thanks!
TEST=Unit tests provided.
Review URL: http://codereview.chromium.org/7033018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=81621
R=cmp@chromium.org
TEST=
Review URL: http://codereview.chromium.org/6992077
TBR=nirnimesh@google.com
Review URL: http://codereview.chromium.org/6987034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=81621
R=cmp@chromium.org
TEST=
Review URL: http://codereview.chromium.org/6992077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=build all locally
BUG=83837
TBR=thakis@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=83286
TEST=None.
Review URL: http://codereview.chromium.org/7036019
TBR=shishir@chromium.org
Review URL: http://codereview.chromium.org/6979006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=83286
TEST=None.
Review URL: http://codereview.chromium.org/7036019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enabling MHTML reading on the Chrome side now that the WebKit patch
adding support for MHTML landed in WebKit.
That is necessary for the MHTML layout tests to pass.
BUG=83804
TEST=MHTML layout tests should pass.
Review URL: http://codereview.chromium.org/7064044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is just a prototype for us to play with. There are plenty of issues to
resolve before its made real, but I wanted to check something in for
others to play with rather than keeping it all local. To get it to
compile you need to set the GYP_DEFINE to views_compositor.
BUG=none
TEST=none
R=ben@chromium.org,apatrick@chromium.org
Review URL: http://codereview.chromium.org/7067029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=ran locally
BUG=83382
Review URL: http://codereview.chromium.org/7066028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TouchUI)
Add switch "--enable-inputmethod-ibus" to enable InputMethodIBus on ChromeOS
Modify gyp files to link IBus
BUG=chromium-os:15566
TEST=manually
Review URL: http://codereview.chromium.org/7004029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
conformance test support into main tree
This support breaks often because it is not built but the buildbots.
This CL adds it to the main tree so it will be built by the buildbots.
Not sure where to add it in all.gyp but I need to make sure it's built
TEST=opengl es 2.0 conformance tests still build
BUG=83382
R=apatrick@chromium.org
Review URL: http://codereview.chromium.org/7057033
TBR=gman@chromium.org
Review URL: http://codereview.chromium.org/7066003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This support breaks often because it is not built but the buildbots.
This CL adds it to the main tree so it will be built by the buildbots.
Not sure where to add it in all.gyp but I need to make sure it's built
TEST=opengl es 2.0 conformance tests still build
BUG=83382
R=apatrick@chromium.org
Review URL: http://codereview.chromium.org/7057033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7019040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=82178
Review URL: http://codereview.chromium.org/7059003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6990023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch from Fabien Tassin <fta@sofaraway.org>.
Review URL: http://codereview.chromium.org/7049015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6990006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Leave in the definition of the 'library' variable until we're
certain all users are fixed, but otherwise hardcode it to
static_library.
Review URL: http://codereview.chromium.org/7051017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We provided <(library) as a variable to support a peculiar
build configuration on Linux. We no longer support that build
configuration, so we can simplify this code to no longer use
a variable.
Review URL: http://codereview.chromium.org/7051014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=82894
TEST=none
Review URL: http://codereview.chromium.org/6975038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85798 0039d316-1c4b-4281-b951-d872f2087c98
|