| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1539203002
Cr-Commit-Position: refs/heads/master@{#366333}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pixels_recorded.
Now that the benchmark records the entire PaintableRegion, rather than just the
visual rect, use that as the space for pixels_recorded.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1528603002
Cr-Commit-Position: refs/heads/master@{#365560}
|
|
|
|
|
|
|
|
|
|
|
| |
This base class is no longer needed, removing
BUG=536104
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1383073002
Cr-Commit-Position: refs/heads/master@{#352676}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch removes the cc::Picture class, since the display list
approach is the only one supported now.
Depends on https://codereview.chromium.org/1362663002/
BUG=533151
R=danakj, enne
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1365673004
Cr-Commit-Position: refs/heads/master@{#350661}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Slimming paint has shipped so the non-sp codepaths are rapidly rotting.
This patch removes the slimming paint codepaths in chrome while leaving
the removal of PicturePile and ContentLayerClient::PaintContents to a
followup.
BUG=524314
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1343493003
Cr-Commit-Position: refs/heads/master@{#349168}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves files into cc/playback/ cc/raster/ cc/tiles/ and cc/output/
and is based on the proposal found in
https://docs.google.com/spreadsheets/d/1wmPOmV9uqd9zNJ5l2TGePH7_vlSvPeXbC-Y3SeGJ_rc/edit#gid=0
R=enne, vmpstr
TBR=piman
BUG=488755
Review URL: https://codereview.chromium.org/1144693002
Cr-Commit-Position: refs/heads/master@{#330396}
|
|
|
|
|
|
|
|
|
|
| |
This patch was autogenerated with https://codereview.chromium.org/1010073002
BUG=465354
Review URL: https://codereview.chromium.org/1078203002
Cr-Commit-Position: refs/heads/master@{#324906}
|
|
|
|
|
|
|
|
| |
BUG=474749
Review URL: https://codereview.chromium.org/1069503002
Cr-Commit-Position: refs/heads/master@{#324151}
|
|
|
|
|
|
|
|
|
|
|
| |
This patch changes CallFunctionForSubtree from using base::Bind to
using lambdas, which makes it slightly more readable at the call site.
R=enne, danakj
Review URL: https://codereview.chromium.org/937883002
Cr-Commit-Position: refs/heads/master@{#318750}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a lot of change here for relatively little effect.
That effect is important, however, for moving forward.
This depends on https://codereview.chromium.org/880653004/.
1) Move Picture::RecordingMode to RecordingSource, because
Display List recording does not use Picture.
2) Add a new recording mode for disabled caches, which has
meaning in Display List recording. Picture recording falls
back to normal recording, while Display List recording
uses painting disabled mode when null canvas is specified,
because null canvas has no meaning for Display Lists.
3) Rename the enum in ContentLayerClient to reflect the new
painting control modes and the changes in
WebContentLayerClient.
4) Adjust all the code that uses these settings.
5) Adjust the benchmark code to make use of the new modes.
R=ajuma,vmpstr
BUG=451448
Review URL: https://codereview.chromium.org/900043002
Cr-Commit-Position: refs/heads/master@{#314857}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Paint. (patchset #1 id:1 of https://codereview.chromium.org/885753004/)
Reason for revert:
This CL wasn't the culprit after all, it seems.
Original issue's description:
> Revert of Report viewport memory and timing correctly for Slimming Paint. (patchset #3 id:60001 of https://codereview.chromium.org/867803003/)
>
> Reason for revert:
> Reverting due to https://crbug.com/453131
>
> Original issue's description:
> > Report viewport memory and timing correctly for Slimming Paint.
> >
> > The rasterize_and_record benchmark was not using data from the
> > DisplayItemList. Now it does.
> >
> > R=ajuma@chromium.org,vmpstr@chromium.org
> > BUG=451448
> >
> > Committed: https://crrev.com/c76f528131949d7fe60b7facf1e7b40362aacfd5
> > Cr-Commit-Position: refs/heads/master@{#313420}
>
> TBR=ajuma@chromium.org,vmpstr@chromium.org,schenney@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=451448
>
> Committed: https://crrev.com/fae3da55913e8e163faabf787b26791a96938ab7
> Cr-Commit-Position: refs/heads/master@{#314226}
TBR=ajuma@chromium.org,vmpstr@chromium.org,schenney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=451448
Review URL: https://codereview.chromium.org/886673003
Cr-Commit-Position: refs/heads/master@{#314260}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #3 id:60001 of https://codereview.chromium.org/867803003/)
Reason for revert:
Reverting due to https://crbug.com/453131
Original issue's description:
> Report viewport memory and timing correctly for Slimming Paint.
>
> The rasterize_and_record benchmark was not using data from the
> DisplayItemList. Now it does.
>
> R=ajuma@chromium.org,vmpstr@chromium.org
> BUG=451448
>
> Committed: https://crrev.com/c76f528131949d7fe60b7facf1e7b40362aacfd5
> Cr-Commit-Position: refs/heads/master@{#313420}
TBR=ajuma@chromium.org,vmpstr@chromium.org,schenney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=451448
Review URL: https://codereview.chromium.org/885753004
Cr-Commit-Position: refs/heads/master@{#314226}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The rasterize_and_record benchmark was not using data from the
DisplayItemList. Now it does.
R=ajuma@chromium.org,vmpstr@chromium.org
BUG=451448
Review URL: https://codereview.chromium.org/867803003
Cr-Commit-Position: refs/heads/master@{#313420}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For both the impl and non-impl versions of the rasterize_and_record
benchmark, this patch add the plumbing necessary to report the
approximate bytes used by the rasterized pictures.
R=vmpstr,ajuma
BUG=434752
Review URL: https://codereview.chromium.org/739953002
Cr-Commit-Position: refs/heads/master@{#306528}
|
|
|
|
|
|
|
|
|
| |
BUG=417463
TBR=enne@chromium.org
Review URL: https://codereview.chromium.org/645853008
Cr-Commit-Position: refs/heads/master@{#300439}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/628443002
Cr-Commit-Position: refs/heads/master@{#298271}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Shouldn't have been reverted, apologies for the noise.
> Revert 261906 "cc: Add picture recording modes for benchmarking"
>
> Suspected of causing gcm_unit_tests failures
>
> http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.7%20Tests%20%282%29&number=25118
>
> Will file a bug that gcm_unit_tests isn't in default tryjob set if this is actually the cause.
>
> > cc: Add picture recording modes for benchmarking
> >
> > This patch adds three different picture recording modes for benchmarking
> > purposes:
> >
> > 1. RECORD_NORMALLY. This is the default and produces a normal recording
> > as before.
> >
> > 2. RECORD_WITH_NULL_CANVAS. This mode uses SkNullCanvas to avoid (most
> > of) the Skia processing that happen during recording. Can be used to
> > estimate the recording workload inside Blink.
> >
> > 3. RECORD_WITH_PAINTING_DISABLED. Passes a NULL canvas to Blink, which
> > causes the GraphicsContext object to disable painting. This mode
> > gives an estimate of the recording workload of Blink excluding the
> > processing inside GraphicsContext.
> >
> > This patch also modifies the rasterize_and_record_micro benchmark to
> > report the recording time for each mode (record_time_ms,
> > record_time_null_canvas_ms and record_time_painting_disabled_ms
> > respectively).
> >
> > Anecdotally on a z600 and the key_silk_cases page set, SkNullCanvas cuts
> > recording time to 50% and disabling painting down to 19%.
> >
> > BUG=357572
> > TEST=PictureTest.RecordingModes
> > TEST=tools/perf/run_benchmark rasterize_and_record_micro.key_silk_cases --browser=release
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261543
> >
> > Review URL: https://codereview.chromium.org/216933002
>
> TBR=skyostil@chromium.org
>
> Review URL: https://codereview.chromium.org/226083007
TBR=skyostil@chromium.org
Review URL: https://codereview.chromium.org/226293003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suspected of causing gcm_unit_tests failures
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.7%20Tests%20%282%29&number=25118
Will file a bug that gcm_unit_tests isn't in default tryjob set if this is actually the cause.
> cc: Add picture recording modes for benchmarking
>
> This patch adds three different picture recording modes for benchmarking
> purposes:
>
> 1. RECORD_NORMALLY. This is the default and produces a normal recording
> as before.
>
> 2. RECORD_WITH_NULL_CANVAS. This mode uses SkNullCanvas to avoid (most
> of) the Skia processing that happen during recording. Can be used to
> estimate the recording workload inside Blink.
>
> 3. RECORD_WITH_PAINTING_DISABLED. Passes a NULL canvas to Blink, which
> causes the GraphicsContext object to disable painting. This mode
> gives an estimate of the recording workload of Blink excluding the
> processing inside GraphicsContext.
>
> This patch also modifies the rasterize_and_record_micro benchmark to
> report the recording time for each mode (record_time_ms,
> record_time_null_canvas_ms and record_time_painting_disabled_ms
> respectively).
>
> Anecdotally on a z600 and the key_silk_cases page set, SkNullCanvas cuts
> recording time to 50% and disabling painting down to 19%.
>
> BUG=357572
> TEST=PictureTest.RecordingModes
> TEST=tools/perf/run_benchmark rasterize_and_record_micro.key_silk_cases --browser=release
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261543
>
> Review URL: https://codereview.chromium.org/216933002
TBR=skyostil@chromium.org
Review URL: https://codereview.chromium.org/226083007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds three different picture recording modes for benchmarking
purposes:
1. RECORD_NORMALLY. This is the default and produces a normal recording
as before.
2. RECORD_WITH_NULL_CANVAS. This mode uses SkNullCanvas to avoid (most
of) the Skia processing that happen during recording. Can be used to
estimate the recording workload inside Blink.
3. RECORD_WITH_PAINTING_DISABLED. Passes a NULL canvas to Blink, which
causes the GraphicsContext object to disable painting. This mode
gives an estimate of the recording workload of Blink excluding the
processing inside GraphicsContext.
This patch also modifies the rasterize_and_record_micro benchmark to
report the recording time for each mode (record_time_ms,
record_time_null_canvas_ms and record_time_painting_disabled_ms
respectively).
Anecdotally on a z600 and the key_silk_cases page set, SkNullCanvas cuts
recording time to 50% and disabling painting down to 19%.
BUG=357572
TEST=PictureTest.RecordingModes
TEST=tools/perf/run_benchmark rasterize_and_record_micro.key_silk_cases --browser=release
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261543
Review URL: https://codereview.chromium.org/216933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> cc: Add picture recording modes for benchmarking
>
> This patch adds three different picture recording modes for benchmarking
> purposes:
>
> 1. RECORD_NORMALLY. This is the default and produces a normal recording
> as before.
>
> 2. RECORD_WITH_NULL_CANVAS. This mode uses SkNullCanvas to avoid (most
> of) the Skia processing that happen during recording. Can be used to
> estimate the recording workload inside Blink.
>
> 3. RECORD_WITH_PAINTING_DISABLED. Passes a NULL canvas to Blink, which
> causes the GraphicsContext object to disable painting. This mode
> gives an estimate of the recording workload of Blink excluding the
> processing inside GraphicsContext.
>
> This patch also modifies the rasterize_and_record_micro benchmark to
> report the recording time for each mode (record_time_ms,
> record_time_null_canvas_ms and record_time_painting_disabled_ms
> respectively).
>
> Anecdotally on a z600 and the key_silk_cases page set, SkNullCanvas cuts
> recording time to 50% and disabling painting down to 19%.
>
> BUG=357572
> TEST=PictureTest.RecordingModes
> TEST=tools/perf/run_benchmark rasterize_and_record_micro.key_silk_cases --browser=release
>
> Review URL: https://codereview.chromium.org/216933002
TBR=skyostil@chromium.org
Review URL: https://codereview.chromium.org/224683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds three different picture recording modes for benchmarking
purposes:
1. RECORD_NORMALLY. This is the default and produces a normal recording
as before.
2. RECORD_WITH_NULL_CANVAS. This mode uses SkNullCanvas to avoid (most
of) the Skia processing that happen during recording. Can be used to
estimate the recording workload inside Blink.
3. RECORD_WITH_PAINTING_DISABLED. Passes a NULL canvas to Blink, which
causes the GraphicsContext object to disable painting. This mode
gives an estimate of the recording workload of Blink excluding the
processing inside GraphicsContext.
This patch also modifies the rasterize_and_record_micro benchmark to
report the recording time for each mode (record_time_ms,
record_time_null_canvas_ms and record_time_painting_disabled_ms
respectively).
Anecdotally on a z600 and the key_silk_cases page set, SkNullCanvas cuts
recording time to 50% and disabling painting down to 19%.
BUG=357572
TEST=PictureTest.RecordingModes
TEST=tools/perf/run_benchmark rasterize_and_record_micro.key_silk_cases --browser=release
Review URL: https://codereview.chromium.org/216933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This patch adds a rasterize and record micro benchmark.
It depends on
https://codereview.chromium.org/67563002/
R=enne@chromium.org, nduca@chromium.org, ernstm@chromium.org
Review URL: https://codereview.chromium.org/66213007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235805 0039d316-1c4b-4281-b951-d872f2087c98
|