| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=247431
R=joi@chromium.org, rsesek@chromium.org, thakis@chromium.org
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/26856002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=247431
R=bauerb@chromium.org
Review URL: https://codereview.chromium.org/26000004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77656
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/23602009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Instead, go through the breakpad client interface
BUG=247431
R=bauerb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/20513003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247431
R=marja@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/19996004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=247431
R=marja@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19697015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=247431
R=marja@chromium.org
Review URL: https://codereview.chromium.org/19672004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=247431
R=mark@chromium.org
Review URL: https://codereview.chromium.org/19556005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=247431
R=marja@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19585002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=247431
R=marja@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19577002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a first step, I added a method for returning the default crash dump location
and use this on all three platforms.
BUG=247431
R=thestig@chromium.org,joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18341002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll use a different approach to move breakpad to a component.
> Step 1: move the DIR_CRASH_DUMPS symbol to the component
>
> BUG=247431
>
> Review URL: https://chromiumcodereview.appspot.com/16924012
TBR=thestig@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18277002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is part of an effort to componentize NaCl code.
BUG=244791
Review URL: https://chromiumcodereview.appspot.com/17074012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created fully mechanically by running
git grep -l base::mac::ScopedCFTypeRef | xargs sed -i -e 's/base::mac::ScopedCFTypeRef/base::ScopedCFTypeRef/g'
git commit -a -m.
git clang-format HEAD^ --style=Chromium
git commit -a -m.
git cl upload -t $TITLE
BUG=251957
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/16917011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change doesn't build under xcode for some reason. See
http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/28702
TBR=thakis@chromium.org, yael.aharon@intel.com
BUG=244791
Review URL: https://codereview.chromium.org/16867015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is part of an effort to componentize NaCl code.
BUG=244791
Review URL: https://chromiumcodereview.appspot.com/17379019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Step 1: move the DIR_CRASH_DUMPS symbol to the component
BUG=247431
Review URL: https://chromiumcodereview.appspot.com/16924012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
abort() sends SIGABRT, breakpad unfortunately does not intercept
signal crashes. Override abort() to crash in a way that breakpad will
intercept.
BUG=57504
Review URL: https://chromiumcodereview.appspot.com/11645055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This moves includes from using base/sys_string_conversions.h to the new location in base/strings/sys_string_conversions.h
BUG=196305
Review URL: https://codereview.chromium.org/13042020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Automated clean up of style checker errors that were missed due to the plugin
not being executed on implementation files.
BUG=115047
TBR=brettw, scherkus
Review URL: https://chromiumcodereview.appspot.com/12279015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/12213104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow nacl_helper to link against breakpad_linux.cc (which
calls SetDumpWithoutCrashingFunction()) without pulling in the rest of
logging_chrome.cc, which depends on logging code generated for all IPC
messages which we don't want to pull into nacl_helper.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=2096
TEST=build
Review URL: https://chromiumcodereview.appspot.com/12090096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77656
Review URL: https://chromiumcodereview.appspot.com/11761030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a direct port of the Mac-specific one, and that has been reimplemented
on top of the new cross-platform one. Currently only the Mac implementation is
hooked up.
BUG=77656
TEST=Built official and caused some crashes, verified report data in upload.
Review URL: https://chromiumcodereview.appspot.com/11635030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
R=darin@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11308132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In addition to the at-launch reauthorization, this adds an at-update
reauthorization step. It only runs for users not on a system Keystone ticket,
because the updater runs as root when on a system ticket, and root can't read
individual user's Keychains. The at-update reauthorization is intended to
handle the reauthorization for users who rarely restart Chrome and might miss
out on the at-launch step during the window where Chrome is signed by the old
certificate but has the new reauthorization code in place. The at-update
reauthorization step can remain in place even after the certificate switch
occurs by shipping an old reauthorization stub binary signed with the old
certificate.
BUG=108238
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10377173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Less chatter on the console
Review URL: http://codereview.chromium.org/9959143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring OSX up to parity with other platforms. It is currently in use
in the thread-watcher code.
Use BreakpadGenerateAndSendReport() to generate a crash report without
actually crashing. This function does not dump the current thread's
stack, so spin up a separate thread to do the dump, then wait on that
thread to complete.
BUG=none
TEST=Monitor for thread-watcher dumps on the crash server.
Review URL: http://codereview.chromium.org/9460028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove MainAppBundle() in favor of FrameworkBundle() and update all callsites + code comments.
BUG=None
TEST=Code should compile and all unit tests should pass.
Review URL: https://chromiumcodereview.appspot.com/9220005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't want Breakpad to report crashes in NaCl untrusted code
because it does not produce useful crash dumps in this case and
because such crashes are typically not caused by a bug in Chromium.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2097
TEST=covered by NaCl's tests/inbrowser_crash_test, which will be enabled later
Review URL: http://codereview.chromium.org/8955001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should make it somewhat easier to figure out which FATAL log line
fired, in the face of inlining and branching.
BUG=none
TEST=monitor crashes.
Review URL: http://codereview.chromium.org/8401018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
------------------------------------------------------------------------
r842 | mark@chromium.org | 2011-10-03 15:54:28 -0400 (Mon, 03 Oct 2011) | 11 lines
Use a bootstrap subset port for the inspector, tying the subset to the
lifetime of the task to be monitored, the invoking task. This allows the
bootstrap server (in launchd) to automatically clean up the Mach server
registration when the task being monitored exits, avoiding leaks of
com.Breakpad.Inspector(pid) ports in "launchctl bslist".
BUG=chromium:28547
TEST=Handler should still crash catches, but inspector ports should no longer
show up in "launchctl bslist". They should show up under a subset port in
"launchctl bstree" instead. "launchctl bstree" must be invoked as root.
Review URL: http://breakpad.appspot.com/306001
------------------------------------------------------------------------
This gives each Breakpad instance its own bootstrap subset port as a subset
of the process' bootstrap port, and places the Breakpad inspector port into
the bootstrap subset port.
This completely eliminates leaks of on-demand Mach services advertised via the
bootstrap server.
This also reverts r34318 and r34534, "temporary" (21-month) hacks to mitigate
the leak. The temporary hacks were never completely effective against Breakpad
ports leaking from child processes.
DestructCrashReporter at process shutdown was deemed unnecessary and is being
removed. As this was the last caller to that function, the implementation is
removed as well.
This is addressed in Breakpad rather than Chrome because a mechanism to fix it
without changing the process' bootstrap port was discovered. It was determined
that the rohitfork port is already immune to leaks of the sort that the
Breakpad inspector port experiences. A previous attempt to fix this bug was
r103089, but that caused bug 98550. This strategy is safer.
The forked Breakpad module.cc is updated to match upstream r835, which allows
the unforking of the CFI-disabling code. A new CFI-disabling "-c" option to
dump_syms is now available and used by the dump_product_syms script.
BUG=28547
TEST=1. "launchctl bslist" should no longer show on-demand
com.Breakpad.Inspector ports (in Breakpad-enabled builds with Breakpad
on) ports.
2. "launchctl bstree" (as root) should reveal a bootstrap subset for each
process as a child of the per-user/per-session bootstrap namespace if
crash reporting is on. One com.Breakpad.Inspector port should show up
as a child of each bootstrap subset. As each process exits (even if
mercilessly killed by "kill -9"), the associated subsets and inspector
ports should disappear.
3. Breakpad reports should be generated on crashes. For example,
about:crash and about:inducebrowsercrashforrealz should each cause a
minidump to be written in
~/Library/Application Support/Google/Chrome/Crash Reports
when Breakpad is enabled. This tests that the Breakpad ports are
functioning properly.
4. The browser process should be able to access child process data.
Window:Task Manager should show valid values for the Memory, CPU, and
Network columns for all child processes. This tests that the rohitfork
port is functioning properly. Note that this version of the change
does not change the handling of rohitfork ports at all, but this test
case was useful in a previous version of this patch.
5. Test case from bug 98550: Have a link in a web browser window (in a
different browser) and drag it into Chrome. Expect the drag operation
to operate properly in both the tab strip and in web content. See bug
98550 for details.
6. Unreported test case that failed in r103089: browser relaunch should
work. Visit chrome://flags, change some flags to get the "Relaunch Now"
button at the bottom (you can put the flags back to how you found them
initially), and click "Relaunch Now". The browser should close and then
be relaunched.
Review URL: http://codereview.chromium.org/8120007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Give each process its own bootstrap subset port as a subset of its inherited
bootstrap port, and use the bootstrap subset port as the bootstrap port.
This completely eliminates leaks of on-demand Mach services advertised via the
bootstrap server.
This also reverts r34318 and r34534, "temporary" (21-month) hacks to mitigate
the leak. The temporary hacks were never completely effective against Breakpad
ports leaking from child processes.
DestructCrashReporter at process shutdown was deemed unnecessary and is being
removed. As this was the last caller to that function, the implementation is
removed as well.
This is addressed in Chrome rather than Breakpad to account for the potential
leak of rohitfork ports if the browser process crashes or is mercilessly
killed, because library code messing with the task's bootstrap port doesn't
strike me as kosher, and because the Mac Breakpad code is scheduled to be
replaced with something better that doesn't attempt to leak ports like a sieve
within a couple of months anyway.
BUG=28547, 98550
TEST=1. "launchctl bslist" should no longer show on-demand
com.Breakpad.Inspector ports (in Breakpad-enabled builds with Breakpad
on) or com.google.Chrome.rohitfork, com.google.Chrome.canary.rohitfork,
or org.chromium.Chromium.rohitfork ports.
2. "launchctl bstree" (as root) should reveal a bootstrap subset for the
browser process as a child of the per-user/per-session bootstrap
namespace containing the rohitfork port and browser's Breakpad port if
crash reporting is on. There should also be a bootstrap subset for
each child process as a child of the browser's bootstrap subset. If
crash reporting is on, each child process' bootstrap subset should
contain a Breakpad port.
3. Breakpad reports should be generated on crashes. For example,
about:crash and about:inducebrowsercrashforrealz should each cause a
minidump to be written in
~/Library/Application Support/Google/Chrome/Crash Reports
when Breakpad is enabled. This tests that the Breakpad ports are
functioning properly.
4. The browser process should be able to access child process data.
Window:Task Manager should show valid values for the Memory, CPU, and
Network columns for all child processes. This tests that the rohitfork
port is functioning properly.
Review URL: http://codereview.chromium.org/8059041
TBR=mark@chromium.org
Review URL: http://codereview.chromium.org/8086003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bootstrap port, and use the bootstrap subset port as the bootstrap port.
This completely eliminates leaks of on-demand Mach services advertised via the
bootstrap server.
This also reverts r34318 and r34534, "temporary" (21-month) hacks to mitigate
the leak. The temporary hacks were never completely effective against Breakpad
ports leaking from child processes.
DestructCrashReporter at process shutdown was deemed unnecessary and is being
removed. As this was the last caller to that function, the implementation is
removed as well.
This is addressed in Chrome rather than Breakpad to account for the potential
leak of rohitfork ports if the browser process crashes or is mercilessly
killed, because library code messing with the task's bootstrap port doesn't
strike me as kosher, and because the Mac Breakpad code is scheduled to be
replaced with something better that doesn't attempt to leak ports like a sieve
within a couple of months anyway.
BUG=28547
TEST=1. "launchctl bslist" should no longer show on-demand
com.Breakpad.Inspector ports (in Breakpad-enabled builds with Breakpad
on) or com.google.Chrome.rohitfork, com.google.Chrome.canary.rohitfork,
or org.chromium.Chromium.rohitfork ports.
2. "launchctl bstree" (as root) should reveal a bootstrap subset for the
browser process as a child of the per-user/per-session bootstrap
namespace containing the rohitfork port and browser's Breakpad port if
crash reporting is on. There should also be a bootstrap subset for
each child process as a child of the browser's bootstrap subset. If
crash reporting is on, each child process' bootstrap subset should
contain a Breakpad port.
3. Breakpad reports should be generated on crashes. For example,
about:crash and about:inducebrowsercrashforrealz should each cause a
minidump to be written in
~/Library/Application Support/Google/Chrome/Crash Reports
when Breakpad is enabled. This tests that the Breakpad ports are
functioning properly.
4. The browser process should be able to access child process data.
Window:Task Manager should show valid values for the Memory, CPU, and
Network columns for all child processes. This tests that the rohitfork
port is functioning properly.
Review URL: http://codereview.chromium.org/8059041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breakpad support currently resides in chrome/app/breakpad_mac.* this makes it inaccessible to lower level code that would also like to set crash keys e.g. The sandboxing infrastructure.
This CL refactors the crash key reporting code to reside in base/mac.
Logging is also added to the Sandbox code to try to track down the cause of crbug.com/94758.
BUG=95272, 94758
TEST=On official builds crash logs should contain crash keys e.g. OS version.
Review URL: http://codereview.chromium.org/7849011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=78782
TEST=Monitor crashes.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81855
Review URL: http://codereview.chromium.org/6861004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
/src/chrome/browser/a*
BUG=58409
Review URL: http://codereview.chromium.org/6539002
Patch from Kushal Pisavadia <kushi.p@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first step to being able to re-constitute policy from a non-generic protobuf in a policy request in a fully automated way (i.e. the code for the process can be generated). The non-generic protobuf is required for automatic merging of policy on the server-side.
BUG=68309
TEST=existing policy/provider tests
Review URL: http://codereview.chromium.org/6357021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first step to being able to re-constitute policy from a non-generic protobuf in a policy request in a fully automated way (i.e. the code for the process can be generated). The non-generic protobuf is required for automatic merging of policy on the server-side.
BUG=68309
TEST=existing policy/provider tests
Review URL: http://codereview.chromium.org/6002015
TBR=danno@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first step to being able to re-constitute policy from a non-generic protobuf in a policy request in a fully automated way (i.e. the code for the process can be generated). The non-generic protobuf is required for automatic merging of policy on the server-side.
BUG=68309
TEST=existing policy/provider tests
Review URL: http://codereview.chromium.org/6002015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix up callers to use the new location & namespace. Remove includes from
files where it wasn't necessary.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6046009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move scoped_aedesc from base to base/mac
Use namespace and proper Google-style class naming.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3828009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
properly (scoped_cftyperef -> ScopedCFTypeRef).
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3855001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57189
TEST=none
Review URL: http://codereview.chromium.org/3534001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it consistent across other platforms, such that chrome::DIR_CRASH_DUMPS on Mac actually points to the right dir.
Crash dumps used to go in ~/Library/Breakpad/Chrome_Mac
They'll now go in: ~/Library/Application Support/Google/Chrome/Crash Reports
BUG=52365
TEST=Mac breakpad continues to work
Review URL: http://codereview.chromium.org/3152021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3050035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49662
TEST=Configure MetricsReportingEnabled policy, crash browser/renderer and check whether crash dumps get generated.
Review URL: http://codereview.chromium.org/2832090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Directly include base/string_util.h, which was removed in r53969 from the indirectly included base/command_line.h
BUG=none
TEST=Mac official builder goes green.
Review URL: http://codereview.chromium.org/3032037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Demote "Breakpad Disabled" console message from WARNING->INFO to reduce console spew.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2991001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52325 0039d316-1c4b-4281-b951-d872f2087c98
|