| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=100845
Review URL: https://chromiumcodereview.appspot.com/11635039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--wallet-service-url now specifies a prefix rather than a full path to autocheckout.
The default value is https://wallet.google.com/online/v2/ and the rest of each Wallet
URL will be appended to construct a working URL.
Also changed function prototypes to use the namespace in a more common way.
(namespace wallet {... vs wallet::)
BUG=168278
Review URL: https://chromiumcodereview.appspot.com/11791003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the "Java" and rename to ExecuteScript*. This better matches
conventions elsewhere in the codebase.
Introduce ExecuteScriptInFrame* variants for the less common case
where script execution in a subframe is desired.
Make it possible to pass the ExecuteScript* family of functions either
a WebContents pointer or a RenderViewHost pointer to further simplify
callsites.
R=jam@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11753009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11740018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents each implementation from having to indepently do this. (This change also gets the views view to display the autofill popup in the correct location).
BUG=
Review URL: https://chromiumcodereview.appspot.com/11606008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Because HideInternal() now might issue a call to the |delegate_|, we cannot NULL out the delegate_ prior to calling into the method. On the other hand, because HideInternal() can immediately call "delete this", we also cannot NULL out the delegate after calling into the method so as to affect the destructor's behavior. Hence, the extra boolean for tracking whether the delegate needs to be informed of the controller's deletion.
BUG=167830
Review URL: https://chromiumcodereview.appspot.com/11704004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to take std::string (UTF-8) instead of std::wstring. This seems to help
simplify callsites considerably.
TBR=jam@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11728003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first two (PrefServiceSimple is a subclass of PrefService) know
nothing about sync or any Chrome or content concepts.
The third (PrefServiceSyncable, a separate subclass of PrefService)
knows about sync and requires users to choose whether each individual
preference is syncable or not when it is registered.
BrowserProcess::local_state() is a PrefServiceSimple after this
change, and Profile::prefs() is a PrefServiceSyncable.
COLLABORATOR=kaiwang@chromium.org
TBR=ben@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11570009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=166025
Review URL: https://codereview.chromium.org/11636040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PersonalDataManager::GetProfileSuggestions
BUG=none
TEST=AutofillManager unit tests
Review URL: https://chromiumcodereview.appspot.com/11644034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
only works for Billing data. Lots of TODOs still, but basic functionality is there.
also moved AutofillPopupDelegate to browser/ui/autofill/
BUG=164966
Review URL: https://codereview.chromium.org/11593025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
an implementation detail by declaring all its functions private.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11442041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=167018
Review URL: https://chromiumcodereview.appspot.com/11642036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) merge Hide() and DelegateDestroyed()
2) remove possible hide/show race condition
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11570057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
OAuth client.
BUG=163609
Review URL: https://chromiumcodereview.appspot.com/11293078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add support for autofilling radio buttons and checkboxes.
>
> Autofill server is equiped with provision to say a field type as
> FIELD_WITH_DEFAULT_VALUE and specify what value to use by default it
> client wants to fill it. For radio buttons, if the default value
> specified by the autofill server is same as its value, Chrome checks that
> input element.
>
> all changes are behind switch.
>
> BUG=157636
>
> Review URL: https://chromiumcodereview.appspot.com/11415221
TBR=ramankk@chromium.org
BUG=166957
Review URL: https://codereview.chromium.org/11644041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
deleting arrays.
This is based on the modifications by "Geoffrey Romer"
<gromer@google.com> to Google's internal version of scoped_ptr<>. All cleaver tricks are his, not mine. :)
It brings most of the features of C++11's unique_ptr<> into this class and should eliminate the need for scoped_array<>, scoped_malloc_free<>, and possibly a few other scopers. Please refer to the unique_ptr<> API for documentation.
Divergence from unique_ptr<>:
1) DefaultDeleter<T[n]> (sized-arrays) is explicitly disabled because this construct would cause the single-object delete to be called on a pointer to a T[n]. It is impossible to construct a single-object new expression that returns a T[n]*. You can only get this with new[] which should correspond to DefaultDeleter<T[n][]>. This issue has been raised with the C++ LWG as it is possible a unique_ptr<> spec defect.
2) Reference types for Deleters are not supported. This simplifies implementation significantly because there is no need to distinguish between the converting constructor + converting assignment operator and their move constructor + move assignment operator.
4) Move-only Deleters are not supported. Avoids the need to emulate std::forward().
BUG=109874
TBR=dhollowa,kinuko,ananta,hans,scherkus
Review URL: https://codereview.chromium.org/11149006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Autofill server is equiped with provision to say a field type as
FIELD_WITH_DEFAULT_VALUE and specify what value to use by default it
client wants to fill it. For radio buttons, if the default value
specified by the autofill server is same as its value, Chrome checks that
input element.
all changes are behind switch.
BUG=157636
Review URL: https://chromiumcodereview.appspot.com/11415221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most sites only require one such character, and many sites don't allow such
characters. This should be more likely to generate a valid password and it will
also have a smaller edit distance to a valid password if the user needs to
change it.
BUG=165318
Review URL: https://chromiumcodereview.appspot.com/11511014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=166290
TBR=isherman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11568050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=isherman@chromium.org
BUG=165697
TEST=form.requestAutocomplete() dispatches error when autofill is disabled.
Review URL: https://chromiumcodereview.appspot.com/11575023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TRB=thestig
Review URL: https://codereview.chromium.org/11571021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before:
AutofillPopupViewViews extends AutofillPopupView
AutofillExternalDelegateViews extends AutofillExternalDelegate, and owns AutofillPopupViewViews
After:
AutofillPopupController owns AutofillPopupViewViews which implements AutofillPopupView interface
AutofillExternalDelegate implements AutofillPopupDelegate, and creates / interacts with AutofillPopupController (no platform subclasses for AutofillExternalDelegate)
no dependency of AutofillPopupView and subclasses on content/
BUG=164966
Review URL: https://codereview.chromium.org/11446077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move PrefObserver out of base/prefs/public to base/prefs/ since it is
now an internal implementation detail.
Update .gyp(i) files to match.
The rest is just mechanical updates to include paths and such,
generated by the tools/git/move_source_file.py script.
TBR=brettw@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11459002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11529004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
also renamed IDS_AUTOFILL_DIALOG_XXX to IDS_AUTOFILL_FIELD_LABEL_XXX
BUG=157270
TBR=sky
Review URL: https://codereview.chromium.org/11444023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Each suggestion will show in one line, and append ellipsis at the
clipped text if the suggestion is too long to display.
BUG=163440
Review URL: https://chromiumcodereview.appspot.com/11470012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Ensure the new UI is properly placed at the start, including go above the element it is autofilling if that element is too close to the bottom of the screen.
BUG=51644
Review URL: https://chromiumcodereview.appspot.com/11275233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
credit card info when secure.
BUG=157270,162785
R=estade@chromium.org,isherman@chromium.org,jam@chromium.org
Review URL: https://codereview.chromium.org/11369236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=161867
Review URL: https://chromiumcodereview.appspot.com/11447005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the app locale.
Also:
* Pass the app locale to FormGroup::GetMatchingTypes(), FormGroup::GetNonEmptyTypes(), and CreditCard::UpdateFromImportedCard().
* Update PhoneNumber::GetRawInfo() to not rely on knowing the locale, and move all the code that depended on knowing the locale into PhoneNumber::GetInfo().
* Within the AutofillManager code, read the app locale on the UI thread, and pass it as a parameter to the worker thread.
BUG=100845
TEST=none (this is a refactoring change)
Review URL: https://chromiumcodereview.appspot.com/11417131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=164091
Review URL: https://chromiumcodereview.appspot.com/11411364
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This involved:
a) Removing methods that used PrefObserver from PrefChangeRegistrar and PrefMember.
b) Removing implementation of PrefObserver from a few remaining classes.
c) Removing NULL PrefObserver parameter for classes using PrefMember but not wishing for a callback.
d) Updating unit tests and test utility classes.
Also fixed what was most likely a bug (or at least an unintentional change in behavior) that I had introduced in CoreChromeOSOptionsHandler in a previous change. Before my series of PrefObserver-related changes, there was polymorphism involved and the subclass was only handling pref changes for a couple of preferences (kProxy and kUseSharedProxy, only one of which it registers for itself) if the PrefService was the standard one, not the incognito one, otherwise delegating to the parent class.
TBR=ben@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11316163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=157270,157273
Review URL: https://codereview.chromium.org/11428071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=estade@chromium.org,isherman@chromium.org
TBR=jschuh@chromium.org
BUG=157661
Review URL: https://codereview.chromium.org/11348273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
autocomplete dialog open.
R=isherman@chromium.org
BUG=163480
TEST=close a tab or browser window with a running interactive autocomplete UI in
it, no kaboom.
Review URL: https://chromiumcodereview.appspot.com/11308287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=157270
Review URL: https://codereview.chromium.org/11416216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make GetProfileByGUID work on all profiles (web as well as auxiliary).
BUG=161867
Review URL: https://codereview.chromium.org/11419168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and into the interactive_ui_tests target. That way they can't be misused from browser_tests.
Review URL: https://codereview.chromium.org/11414223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=100845
TEST=none (purely a refactoring change)
TBR=dhollowa@chromium.org, akalin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11415162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
local part.
BUG=163024
TEST=unit_tests --gtest_filter=AutofillProfileTest.Compare
Review URL: https://chromiumcodereview.appspot.com/11348264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11415164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The term "region" matches the name used by the libphonenumber code.
BUG=100845
TEST=none (purely refactoring)
Review URL: https://chromiumcodereview.appspot.com/11415163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Only remove gtk signal handler if connected and only hide the popup if it is still visible.
BUG=160866
Review URL: https://chromiumcodereview.appspot.com/11416015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
interacting with the form.
BUG=160476
TEST=browser_tests --gtest_filter=AutofillTest.DisableAutocompleteWhileFilling
Review URL: https://chromiumcodereview.appspot.com/11280138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=akalin@chromium.org
TBR=dhollowa@chromium.org # for autofill
Review URL: https://chromiumcodereview.appspot.com/11421047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
sweep badness back under the rug
BUG=161867
Review URL: https://chromiumcodereview.appspot.com/11417076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
[views] continue with Autofill interactive dialog
Make progress on local data sunny day: hook up AutofillDialogController to Autofill backend. Also, separate Billing and CC data inputs so they can be selected separately (to match Autofill backend).
BUG=157270, 157273
Review URL: https://codereview.chromium.org/11348112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Changing Autofill implementation to better match gtk linux implementation.
BUG=160593
Review URL: https://chromiumcodereview.appspot.com/11364179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused sizes regression due to static initializers:
http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=50&header=chrome&graph=chrome-si&rev=-1
< # autofill_dialog_template.cc autofill::kEmailInputs
< # autofill_dialog_template.cc autofill::kBillingInputs
< # autofill_dialog_template.cc autofill::kBillingInputs+0x20
< # autofill_dialog_template.cc autofill::kBillingInputs+0x40
< # autofill_dialog_template.cc autofill::kBillingInputs+0x60
< # autofill_dialog_template.cc autofill::kBillingInputs+0x80
< # autofill_dialog_template.cc autofill::kShippingInputs
< # autofill_dialog_template.cc autofill::kShippingInputs+0x20
< # autofill_dialog_template.cc autofill::kShippingInputs+0x40
< # autofill_dialog_template.cc autofill::kShippingInputs+0x60
< # autofill_dialog_template.cc autofill::kShippingInputs+0x80
< # autofill_dialog_template.cc autofill::kShippingInputs+0xa0
< # autofill_dialog_template.cc autofill::kCCInputs
< # autofill_dialog_template.cc autofill::kCCInputs+0x20
< # autofill_dialog_template.cc autofill::kCCInputs+0x40
< # autofill_dialog_template.cc autofill::kCCInputs+0x60
< # autofill_dialog_template.cc autofill::row_id
Make progress on local data sunny day: hook up AutofillDialogController to Autofill backend. Also, separate Billing and CC data inputs so they can be selected separately (to match Autofill backend).
BUG=157270, 157273
Review URL: https://codereview.chromium.org/11368158
TBR=estade@chromium.org
Review URL: https://codereview.chromium.org/11348110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168324 0039d316-1c4b-4281-b951-d872f2087c98
|