summaryrefslogtreecommitdiffstats
path: root/chrome/browser/bookmark_bar_model.cc
Commit message (Collapse)AuthorAgeFilesLines
* Moves bookmark related classes into bookmarks directory. There are nosky@google.com2008-09-091-694/+0
| | | | | | | | | | | | code changes here (other than converting to COPY_AND_BLAH_BLAH and updating include guards). BUG=none TEST=none Review URL: http://codereview.chromium.org/1868 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1944 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash. I believe this is happening during sessionsky@google.com2008-09-051-0/+3
| | | | | | | | | | | | | | | | end, which has a different shutdown path and is possible for the model to be deleted before the view. I'm also adding checking to XPFrame/VistaFrame to make sure the BookmarkBarView doesn't have a parent in the destructor. This shouldn't be possible, but I'm adding the check to be sure;) BUG=1359852 TEST=make sure you don't see problems with bookmarks Review URL: http://codereview.chromium.org/440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1754 0039d316-1c4b-4281-b951-d872f2087c98
* Moves the bookmark bar view test into the interactive tests. To getsky@google.com2008-09-021-3/+3
| | | | | | | | | | | | | | | this to work I changed the interactive ui tests to link with everything the unit tests do. I did this by way of clicking on the dependencies dialog in VS. Let me know if that wasn't right. I also had to slightly tweak BookmarkBarModel and BookmarkStorage to deal with changes I did a while back. These changes only matter during testing (background thread is NULL). BUG=1318942 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1659 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies the query parser to provide the position of the match in thesky@google.com2008-08-291-3/+11
| | | | | | | | | | | | title. I'm going to use this in the omnibox. There are a couple of other random spelling errors I came across that are included for your review pleasure. BUG=1256202 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1546 0039d316-1c4b-4281-b951-d872f2087c98
* Makes deleting history no longer delete starred urls. Thiseffectively ↵sky@google.com2008-08-271-25/+98
| | | | | | reenables the code in ExpireHistoryBackend. I also madethe code consistent so that when we delete visits as the result ofhistory deletion we don't change the typed/visit count of theunderlying url.BUG=1214201 1256202TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1423 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bogus typedef for HistoryService's empty callback. This turnedsky@google.com2008-08-241-1/+1
| | | | | | | | | | up as an UMR. I'm surprised this didn't produce a compiler error. BUG=1338601 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1291 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in BookmarkBarNode. I wasn't resetting a load handlesky@google.com2008-08-211-5/+5
| | | | | | | | | | | | | | resulting in the possibility of trying to cancel a bogus load handle. I'm TBRing this one as I just introduced this and its easy to hit a DCHECK now. BUG=1256202 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1163 0039d316-1c4b-4281-b951-d872f2087c98
* Moves bookmarks out of history into its own file (JSON).sky@google.com2008-08-211-296/+217
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Interesting points: . Migration was a bit atypical. Here is the approach I took: . If the URL db contains bookmarks it writes the bookmarks to a temporary file. . When the bookmark bar model is loaded it assumes bookmarks are stored in a file. If the bookmarks file doesn't exist it then attempts to load from history, after waiting for history to finish processing tasks. . I've broken having the omnibox query for starred only. This patch was already too ginormous for me to contemplate this too. I'll return to it after I land this. . Similarly the history page isn't searching for starred titles now. As we discussed with Glen, that is probably fine for now. . I've converted NOTIFY_STARRED_FAVICON_CHANGED to NOTIFY_FAVICON_CHANGED and it is notified ANY time a favicon changes. I'm mildly concerned about the extra notifications, but without having history know about starred it's the best I can do for now. . Autocomplete (specifically URLDatabase::AutocompleteForPrefix) previously sorted by starred. It can no longer do this. I don't think I can get this functionality back:( Luckily it only mattered if you had a starred and non-starred URL with the same type count that matched a query. Probably pretty rare. What's left: . Fix up HistoryContentsProvider to query for starred entries titles. . Clean up the delete all case. I basically just made it compile; it can be greatly simplified. . Rename BookmarkBarModel to BookmarksModel. BUG=1256202 TEST=this is a huge change to bookmarks. Thanfully it's pretty well covered by tests, none-the-less make sure you exercise bookmarks pretty heavily to make sure nothing is busted. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1153 0039d316-1c4b-4281-b951-d872f2087c98
* A set of tests to exercise chrome menus as well as parts of bookmarksky@google.com2008-08-111-14/+11
| | | | | | | | | | | | bar view. These are disabled until we straighten out the buildbot that is always logged in. BUG=1318922 TEST=this is just a bunch of tests. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@654 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-261-0/+716
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 02:31:56 +0000