summaryrefslogtreecommitdiffstats
path: root/chrome/browser/bookmarks
Commit message (Collapse)AuthorAgeFilesLines
* Stop static_cast<StringValue*>'ing from TYPE_STRING values.kinaba@chromium.org2013-01-291-3/+1
| | | | | | | | | | | | Rationale: - No need to downcast; GetAsString() is a method of the Value root class. - The cast may be illegal; internal::JSONStringValue, not inheriting StringValue, has TYPE_STRING as well. BUG=none Review URL: https://chromiumcodereview.appspot.com/12039084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179233 0039d316-1c4b-4281-b951-d872f2087c98
* history: Rename history.h to history_service.htfarina@chromium.org2013-01-256-6/+6
| | | | | | | | | | | | | history.h contains HistoryService class as its main class, so rename the file to match with the class name. BUG=169591 R=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/12036069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178753 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Add unit tests for bookmark_utils::GetParentForNewNodes() function.tfarina@chromium.org2013-01-251-0/+39
| | | | | | | | | | BUG=170296 TEST=unit_tests --gtest_filter=BookmarkUtilsTest.GetParentForNewNodes R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/12035069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178745 0039d316-1c4b-4281-b951-d872f2087c98
* Convert gfx::Image::Image(const SkBitmap&) and ↵pkotwicz@chromium.org2013-01-231-1/+2
| | | | | | | | | | gfx::ImageSkia::ImageSkia(const SkBitmap&) to gfx::Image::CreateFrom1xBitmap(const SkBitmap&) and gfx::ImageSkia::CreateFrom1xBitmap(const SkBitmap&) respectively Hopefully these changes will make the constructors / factory methods less confusing and prevent bugs as a result of confusion about what the constructors do. Review URL: https://chromiumcodereview.appspot.com/11970013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178408 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Forward declare some classes in header files when possible.tfarina@chromium.org2013-01-214-3/+8
| | | | | | | | | BUG=144783 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11959042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177885 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: profile_path is always std::string on MacOSX.tfarina@chromium.org2013-01-173-5/+7
| | | | | | | | | | | | | But we can just pass FilePath instead of taking FilePath::StringType, which is even taken by value, and change it to const-reference. That also allow us to forward declare FilePath in bookmark_pasteboard_helper_mac.h R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11838002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177467 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: GetNameForURL() function is only used by gtk.tfarina@chromium.org2013-01-163-16/+2
| | | | | | | | | | | | So, move it to c/b/ui/gtk/bookmarks. Where it's more appropriate. BUG=144783 R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11827058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177137 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Break the dependency on c/b/bookmarks from favicon.tfarina@chromium.org2013-01-151-0/+8
| | | | | | | | | | BUG=146851,144783 R=joi@chromium.org,sky@chromium.org TBR=sky@chromium.org Review URL: https://codereview.chromium.org/11852024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176887 0039d316-1c4b-4281-b951-d872f2087c98
* fix crash bug in BookmarkEditorView.yoichio@chromium.org2013-01-152-3/+38
| | | | | | | | | | This is caused when BookmarkEditorView shows and BookmarkManager edits a folder targeted by BookmarkEditorView. BUG=167385 Review URL: https://chromiumcodereview.appspot.com/11776021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176873 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Update the pref_service includes.tfarina@chromium.org2013-01-154-8/+4
| | | | | | | | | | | | | | We just use PrefServiceSyncable, so just include the corresponding include for it, instead of including pref_service.h which will also include pref_service_simple.h. BUG=144783 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11821052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176813 0039d316-1c4b-4281-b951-d872f2087c98
* Record metrics for slow startupsjeremy@chromium.org2013-01-151-0/+3
| | | | | | | | | | | | | | | * Add a mechanism to collect duration of various operations for slow startups (defined as taking >= 10s). * Move collection of Startup.BrowserMessageLoopStartTimeFromMainEntry metric to startup_metric_utils.cc. * Change bucketing of Startup.BrowserMessageLoopStartTimeFromMainEntry from 0-5min instead of from 0-1 hour to improve granularity. * Collect metrics for major operations in Safe Browsing startup. BUG=160927 TEST=None Review URL: https://chromiumcodereview.appspot.com/11785014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176808 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Replace history_database.h include by url_database.htfarina@chromium.org2012-12-303-3/+3
| | | | | | | | | | | | | We aren't using HistoryDatabase so we don't need to include history_database.h, what we use is URLDatabase so just include url_database.h for it. BUG=144783 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11666028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174780 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Remove unused includes from bookmark_model_unittest.cctfarina@chromium.org2012-12-261-8/+2
| | | | | | | | | | BUG=144783 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11663019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174616 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Remove many entries from DEPS whitelist.tfarina@chromium.org2012-12-241-6/+0
| | | | | | | | | | | | These were fixed with the recent move of bookmark extension code out of here. BUG=144783 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11669014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174589 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Forward declare FaviconBitmapResult in bookmark_html_writer.htfarina@chromium.org2012-12-223-10/+14
| | | | | | | | | | BUG=144783 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11624028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174535 0039d316-1c4b-4281-b951-d872f2087c98
* Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.joi@chromium.org2012-12-226-14/+16
| | | | | | | | | | | | | | | | | | | | | The first two (PrefServiceSimple is a subclass of PrefService) know nothing about sync or any Chrome or content concepts. The third (PrefServiceSyncable, a separate subclass of PrefService) knows about sync and requires users to choose whether each individual preference is syncable or not when it is registered. BrowserProcess::local_state() is a PrefServiceSimple after this change, and Profile::prefs() is a PrefServiceSyncable. COLLABORATOR=kaiwang@chromium.org TBR=ben@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11570009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174531 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Forward declare FaviconImageResult in bookmark_model.htfarina@chromium.org2012-12-215-3/+10
| | | | | | | | | | BUG=144783 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11647026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174295 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Get rid of |was_bookmarked| parameter from ↵tfarina@chromium.org2012-12-202-11/+6
| | | | | | | | | | | | | BookmarkModel::AddNode() function. This parameter seems to be unused, so we can kill it now. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11607010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174175 0039d316-1c4b-4281-b951-d872f2087c98
* Move BookmarkManagerAPI to c/b/e/apirdevlin.cronin@chromium.org2012-12-194-790/+0
| | | | | | | | | | | Remove the BookmarkManagerAPI from c/b/bookmarks, and remove the last of the c/b/extensions/ files from the bookmarks/ DEPS. BUG=101244 Review URL: https://chromiumcodereview.appspot.com/11516010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174018 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Move num_urls_before_prompting into ui/bookmarks/ directory.tfarina@chromium.org2012-12-192-9/+0
| | | | | | | | | | | | | This variable is only used by c/b/ui/, and thus makes more sense for it to live under c/b/ui/bookmarks. Also rename it to num_bookmark_urls_before_prompting because now it's declared/defined under chrome namespace. BUG=144783 R=sky@chromium.org Review URL: https://codereview.chromium.org/11608002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173920 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Clean up the public API of BookmarkTabHelper.tfarina@chromium.org2012-12-171-5/+7
| | | | | | | | | R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11569033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173481 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a new folder/url to the BMB via right-click insert it at the location ↵yoichio@chromium.org2012-12-171-2/+6
| | | | | | | | | | | clicked BUG=82610 Review URL: https://chromiumcodereview.appspot.com/11567003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173431 0039d316-1c4b-4281-b951-d872f2087c98
* Make BookmarkAPI a PKSrdevlin.cronin@chromium.org2012-12-1611-1720/+24
| | | | | | | | | | | | | | Move BookmarksExtensionEventRouter and related to c/b/e/api/bookmark. Create BookmarkAPI, a PKS for Bookmark. This introduces a temporary new dependency for BookmarkManager API. This is removed here: https://codereview.chromium.org/11516010/ BUG=159265, 101244 TBR=ben@chromium.org for gypi Review URL: https://chromiumcodereview.appspot.com/11316223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173358 0039d316-1c4b-4281-b951-d872f2087c98
* Remove straggling TabContents references.avi@chromium.org2012-12-141-1/+1
| | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://codereview.chromium.org/11577020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173207 0039d316-1c4b-4281-b951-d872f2087c98
* Disable 6 ExtensionApiTests on win asandgrogan@chromium.org2012-12-131-1/+7
| | | | | | | | | | BUG=166026 R=achuith@chromium.org TBR=sky@chromium.org Review URL: https://codereview.chromium.org/11574017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172992 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Make BookmarkModel not send notifications through ↵tfarina@chromium.org2012-12-092-94/+7
| | | | | | | | | | | | | | | | | | | content::NotificationService. The lack of type safety and the endless dispatching by notification ID makes it a pretty bad interface. So NotificationService is considered pretty evil and should be used in less modules, not more. This removes the chrome::NOTIFICATION_URLS_STARRED notification from BookmarkModel and make the clients listen to BookmarkModel changes through BaseBookmarkModelObserver which is clearer. BUG=144783 R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11450002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172015 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Remove unused BookmarkDropInfo API.tfarina@chromium.org2012-12-072-148/+0
| | | | | | | | | BUG=144783 R=sky@chromium.org Review URL: https://codereview.chromium.org/11453011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171776 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated extension EventRouter APIs.mpcomplete@chromium.org2012-12-072-5/+5
| | | | | | | | | | | BUG=163246 TBR=tommi@chromium.org TBR=sky@chromium.org TBR=dmazzoni@chromium.org Review URL: https://chromiumcodereview.appspot.com/11440004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171719 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some FaviconService functions to use New CancelableTaskTrackerkaiwang@chromium.org2012-12-074-38/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL converts: FaviconService::GetFaviconImageForURL FaviconService::GetRawFaviconForURL FaviconService::GetFaviconForURL ---------- They depends on --------- HistoryService::GetFaviconsForURL ---------- which depends on -------- HistoryBackend::GetFaviconsForURL So please review above changes first. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ FaviconService::GetFaviconImageForURL ---------- is used by -------------- bookmarks/bookmark_model.cc ui/intents/web_intent_icon_loader.cc ui/cocoa/history_menu_bridge.mm ui/toolbar/recent_tabs_sub_menu_model.cc ui/toolbar/back_forward_menu_model.cc ui/webui/ntp/app_launcher_handler.cc jumplist_win.cc FaviconService::GetRawFaviconForURL ---------- is used by -------------- android/provider/chrome_browser_provider.cc bookmarks/bookmark_html_writer.cc sync/glue/session_model_associator.cc ui/webui/extensions/extension_icon_source.cc ui/webui/favicon_source.cc ui/webui/ntp/android/bookmarks_handler.cc ui/webui/ntp/favicon_webui_handler.cc FaviconService::GetFaviconForURL ---------- is used by -------------- favicon/favicon_handler.h BUG=155883 Review URL: https://chromiumcodereview.appspot.com/11421188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171675 0039d316-1c4b-4281-b951-d872f2087c98
* Decouple IsMetroProcess() calls, introducing IsSingleWindowMetroMode().gab@chromium.org2012-12-061-2/+2
| | | | | | | | | | | | | | | | Many things were calling IsMetroProcess() when the intent was really to turn things ON/OFF for Metro Chrome, this does not apply to Metro Ash however. Details of how this has been decoupled can be found at https://docs.google.com/spreadsheet/ccc?key=0AtwXJ4IPPZBAdEdaWUpLYk9IM3I1bTJleFJobXN3Z2c (more decoupling will be needed later and has been listed in separate columns on this spreadsheet; however for now this CL only applies the first column). Also introduces win8_util where some other win8-specific things currently in base should eventually also be refactored into. BUG=151718 TEST=This makes a bunch of things just work now in Metro Ash :). Review URL: https://chromiumcodereview.appspot.com/11411286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171366 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Break the dependency in ui/cocoa.tfarina@chromium.org2012-12-053-165/+0
| | | | | | | | | | BUG=144783 R=sky@chromium.org,mrossetti@chromium.org Review URL: https://chromiumcodereview.appspot.com/11428161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171221 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark: change Move() with no effect to keep the folder timestamp.kinaba@chromium.org2012-12-052-2/+18
| | | | | | | | | | | | Bookmark Sync may try to Move an entry to the location where it already is placed. Updating the folder's timestamp with such no-op moves unwillingly disorders the "recently used" list of folders; it should better be avoided. BUG=162764 Review URL: https://chromiumcodereview.appspot.com/11411346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171134 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeOS: Show Google Drive folder in bookmark import file chooser.kinaba@chromium.org2012-11-301-1/+4
| | | | | | | | | | | | | | Drive folder is hidden chooser by default and whilelisted for "working" cases. I verified manually it is working for bookmark import. Exporting is currently worked on in Drive side (see the issue tracker). BUG=161715 TEST=about:bookmarks> Organize> import bookmarks from HTML file. Review URL: https://chromiumcodereview.appspot.com/11413177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170364 0039d316-1c4b-4281-b951-d872f2087c98
* Sync the bookmark's icon URL.pkotwicz@chromium.org2012-11-302-0/+14
| | | | | | | | | BUG=160726 Test=TwoClientBookmarksSyncTest.* Review URL: https://chromiumcodereview.appspot.com/11428004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170326 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Remove more entries from DEPS whitelist.tfarina@chromium.org2012-11-291-2/+0
| | | | | | | | | | BUG=144783 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11434036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170296 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Pass BrowserContext to ToggleWhenVisible() function.tfarina@chromium.org2012-11-292-13/+0
| | | | | | | | | | | | | | | | We are switching away from Profile, and content::BrowserContext is preferred over it. This patch was moves it to ui/bookmarks, because it's only used by c/b/ui, and renames it to ToggleBookmarkBarWhenVisible() so it's more clear what is being toggled for the consumers. BUG=144783 R=sky@chromium.org Review URL: https://codereview.chromium.org/11411228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170167 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Pass BrowserContext to BookmarkIndex.tfarina@chromium.org2012-11-283-9/+13
| | | | | | | | | | | | We are switching away from Profile, and content::BrowserContext is preferred over it. BUG=144783 R=sky@chromium.org Review URL: https://codereview.chromium.org/11411225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169974 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Pass BrowserContext to BookmarkDropOperation() function.tfarina@chromium.org2012-11-262-3/+9
| | | | | | | | | | | | | We are switching away from Profile, and content::BrowserContext is preferred over it. BUG=144783 R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11280123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169400 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Remove gtk_custom_drag.h entry from DEPS whitelist.tfarina@chromium.org2012-11-201-1/+0
| | | | | | | | | | BUG=144783 R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11421002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168872 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Remove file_changed() accessor from BookmarkModel API.tfarina@chromium.org2012-11-202-11/+1
| | | | | | | | | | | | The |file_changed_| data member is assigned but never used. Nor is the getter accessor. Let's remove them altogether, since they aren't used anymore. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11414070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168682 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Do not use Value::Create* functions.tfarina@chromium.org2012-11-182-4/+4
| | | | | | | | | | BUG=160586 R=sky@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11413017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168477 0039d316-1c4b-4281-b951-d872f2087c98
* chrome/browser: Update calls from RunAllPending() to RunUntilIdle().tfarina@chromium.org2012-11-172-3/+3
| | | | | | | | | | | | RunAllPending() is deprecated and we should switch to RunUntilIdle(). BUG=131220 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/11413050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168416 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_temp_dir from base to base/filesbrettw@chromium.org2012-11-161-2/+2
| | | | | | | | | | Also add to base namespace. BUG= Review URL: https://codereview.chromium.org/11359217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168281 0039d316-1c4b-4281-b951-d872f2087c98
* This patch changes participation condition of bookmark prompt experiment to:yosin@chromium.org2012-11-161-14/+1
| | | | | | | | | | | | | | | | | - 1% of new users on Canary channel - One month rather than using variations service. Checking new user, aka new installation, is as same as https://chromiumcodereview.appspot.com/11363062 We'll change the start date for stable channel once it is fixed. BUG=160151 Review URL: https://chromiumcodereview.appspot.com/11412002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168170 0039d316-1c4b-4281-b951-d872f2087c98
* Moved JsonPrefStore to use SequencedWorkerPool instead of FILE thread. The ↵zelidrag@chromium.org2012-11-083-10/+24
| | | | | | | | | | | pool also ensures that the same file requests are written in order received and that they block on shutdown. BUG=153367 TEST=existing unit/browser tests Review URL: https://codereview.chromium.org/11027070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166603 0039d316-1c4b-4281-b951-d872f2087c98
* net: Implement canceling of all async operations in FileStream.paivanof@gmail.com2012-11-061-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Canceling of async operations allows to not wait for their completion in FileStream's destructor. Other related changes include: - Got rid of FileStream::Close() and FileStream::CloseSync() methods because reuse of FileStream object doesn't make much sense, it should be destroyed instead. - Changed FileStream to always acquire ownership of the PlatformFile it was given. Fixed usages of FileStream where no ownership was assumed, introduced new helper functions in base/platform_file.h on the way. - FileStream's destructor now always closes the file. If file was opened with PLATFORM_FILE_ASYNC then actual closing is done asynchronously, destructor doesn't wait for that and returns immediately. When file was opened without PLATFORM_FILE_ASYNC closing is done synchronously and the thread doing that should be allowed to do IO operations. - Implementation of FileStream is refactored. FileStream is now just a wrapper around internal object that does all actual work and that can be easily orphaned in the destructor to not block on the actual file descriptor closing. All platform-independent code is extracted into a special file and amount of platform-dependent code is minimized. BUG=115067, 112474 TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/10701050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166091 0039d316-1c4b-4281-b951-d872f2087c98
* Coalesce event router Init calls into their constructors.yoz@chromium.org2012-11-052-6/+1
| | | | | | | | | BUG=159265 Review URL: https://chromiumcodereview.appspot.com/11366074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166066 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Implement DragBookmarks() in the ui specific directories.tfarina@chromium.org2012-10-311-56/+1
| | | | | | | | | | | | We need to do this in order to get rid of some c/b/ui deps from the shared bookmark_utils.cc file and that will allow us to do that. BUG=144783 R=sky@chromium.org Review URL: https://codereview.chromium.org/11338003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165147 0039d316-1c4b-4281-b951-d872f2087c98
* New feature: Bookmark Prompt Finch Experimentyosin@chromium.org2012-10-312-0/+100
| | | | | | | | | | | | | | | | | | | | | | | | When user is enrolled "Bookmark Prompt" field test. Chrome will show bookmark prompt bubble anchored by action box button, e.g. "+" mark, in location bar if user has visited currently displayed page frequently, e.g. user visited the page many times. Design Doc: https://docs.google.com/a/google.com/document/d/1M99Hg1jgkK1GCYywwxcYBx-V_nwVf0eh5PeBMkkdErQ/edit# Note: Linux and Mac UI aren't supported. There are only stubs. This is all in one patch except for GTK and Mac UI. We have following components to implement bookmark prompt - BookmarkPromptPrefs (in this patch) - BookmarkPromptController (in this patch) - BookmarkPrompt UI http://codereview.chromium.org/11273030/ - BookmarkCurrentPageFromStart() - new command, IDC_BOOKMARK_PAGE_FROM_STAR, doing as same as BookmarkCurrentPage() except for recording metrics BUG=144586 R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11028114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165119 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetExtensionEventRouter calls and replace with PKSF calls through the ↵mirandac@chromium.org2012-10-293-7/+11
| | | | | | | | | | | ExtensionSystem. Extension services were made into ProfileKeyedServices a while ago; this replaces all the deprecated calls that ran directly through the Profile object. BUG= http://code.google.com/p/chromium/issues/detail?id=104095 Review URL: https://chromiumcodereview.appspot.com/11232066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164697 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 12:33:18 +0000