| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
| |
net::CancelableCompletionClosure.
BUG=none
TEST=none
R=ajwong@chromium.org
Review URL: http://codereview.chromium.org/8662047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reenable PrerenderBrowserTest.NavigateToPrerenderedPageWhenDevToolsAttached and
DevToolsSanityTest.TestReattachAfterCrash The problem was fixed in WebKit r101176.
BUG=105433
TEST=
Review URL: http://codereview.chromium.org/8720004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/8715001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pass/flaky
as the reason of their failure was fixed in WebKit r101047
BUG=89845,100538
TEST=yes, it is!
Review URL: http://codereview.chromium.org/8700005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
content namespace.
BUG=98716
R=jam@chromium.org
Review URL: http://codereview.chromium.org/8676032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105433
TEST=None
Review URL: http://codereview.chromium.org/8702013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DevTools remote debugging protocol supersedes the legacy protocol and old implementation should be removed.
BUG=104625
TEST=Existing tests
Review URL: http://codereview.chromium.org/8635005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
platforms, due to timeouts
BUG=100538,89845
TBR=adamk@chromium.org
Review URL: http://codereview.chromium.org/8681003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=adamk@chromium.org
BUG=100538,89845
TEST=interactive_ui_tests on chromeos bot should pass.
Review URL: http://codereview.chromium.org/8678003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mark as always-failing two already-flaky inspector tests after WebKit r100991.
BUG=89845,100538
TBR=koz
Review URL: http://codereview.chromium.org/8642003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104625
TEST=Existing tests
Review URL: http://codereview.chromium.org/8636011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 111135
BUG=
TEST=
Review URL: http://codereview.chromium.org/8636010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Existing tests
Review URL: http://codereview.chromium.org/8634006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also disable failing DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh
BUG=104986
TBR=adamk
Review URL: http://codereview.chromium.org/8616001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8612007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98716
Review URL: http://codereview.chromium.org/8470006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interface is implemented by the RenderProcessHostImpl class which lives in content\browser\renderer_host\render_process_host_impl.cc/.h. The RenderProcessHostImpl class is a consolidation of the RenderProcessHost and BrowserRenderProcessHost classes.
The RenderProcessHost public interface was created from the now deleted RenderProcessHost class defined in content\browser\renderer_host\render_process_host.h.
Additional methods have been added to the interface to ensure that it works correctly with the MockRenderProcessHost class used by unit tests. I had to implement a number of overrides in the MockRenderProcessHost class to ensure that tests work correctly. This was because of assumptions in the tests that the MockRPH class was a real RPH which it was till now.
Added a TODO for the methods which could potentially be removed from this interface. Will revisit that in a subsequent CL.
BUG=98716
TEST=No change in functionality. Hopefully it all compiles and works.
Review URL: http://codereview.chromium.org/8515027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8566028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Rename shell_dialogs.* to select_file_dialog.*
* Rename file_manager_dialog.* to select_file_dialog_webui.*
* Also rename win/mac/aura/gtk/kde variants.
No functional changes.
BUG=104155
TEST=compiles
Review URL: http://codereview.chromium.org/8555016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the initializer list construct = {0} allows the object to be linker initialized.
Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design.
Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile)
BUG=94925
TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward.
TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org
Review URL: http://codereview.chromium.org/8491043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plumbing.
This depends on WebKit change: https://bugs.webkit.org/show_bug.cgi?id=71842
Also, sprinkle OVERRIDE all over devtools_client.h.
BUG=44350
TEST=Open DevTools in undocked mode on the Mac. Drag the window by the empty space in the toolbar. The window should move.
Review URL: http://codereview.chromium.org/8503022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=101952
Review URL: http://codereview.chromium.org/8506011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=101952
TEST=DevToolsSanityTest.TestReattachAfterCrash
Review URL: http://codereview.chromium.org/8503007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101600,94925
TEST=none
Review URL: http://codereview.chromium.org/8478021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make ExtensionServiceBackend go away, as it's only used for installing unpacked extensions. Tear this out into UnpackedInstaller task.
- Pull out LoadAllExtensions / LoadInstalledExtension into InstalledExtensionLoader task.
- Break out component extensions to be handled by ComponentLoader.
Coming soon: a unit test for InstalledExtensionLoader.
BUG=97883
TEST=existing tests + InstalledExtensionLoaderUnittest
Review URL: http://codereview.chromium.org/8417012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8423040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=owners
BUG=98716
Review URL: http://codereview.chromium.org/8437002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only content/ now has the ability to create BrowserThread objects,
with the exception that tests can create the
content::TestBrowserThread subclass, and (temporarily) code in chrome/
can create the DeprecatedBrowserThread subclass.
A follow-up change will make content/ take care of its own thread
creation, remove DeprecatedBrowserThread, and move all state and
non-trivial constructors from BrowserThread down to BrowserThreadImpl.
Also moved BrowserProcessSubThread into content/ namespace. As part
of follow-up cleanup, chrome/ will stop using this class.
BUG=98716
TEST=existing
Review URL: http://codereview.chromium.org/8392042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Since dedicated workers moved in-process, IPC-related code for them is unused.
This is the first round of clean-up
Review URL: http://codereview.chromium.org/8399007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Windows.
BUG=100538
TEST=green tree
Review URL: http://codereview.chromium.org/8396051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/8375009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it will always notify worker service observers even if there is no corresponding WorkerInstance in WorkerProcessHost::instances_ list(the instance can be removed when WorkerMessageFilter is closed).
WorkerDevToolsManager::InspectedWorkersList has been merged into WorkerDevToolsManager.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8364008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeRenderViewHostObserver needs the value of render_view_host when cleaning
up, but the user-after-free fix made render_view_host() always NULL in the dtor.
The previous fix was http://codereview.chromium.org/8354034/
TBR=jam@chromium.org
TEST=asan bots are happy
Review URL: http://codereview.chromium.org/8352049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
callers to use it. Move the implementation to content/browser. Stop creating it in all child processes since it's only used in the browser.
BUG=98716
Review URL: http://codereview.chromium.org/8342048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
window_container_type.h as well since it is included by
content_browser_client.h
BUG=98716
TEST=it builds + existing tests
Review URL: http://codereview.chromium.org/8346017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization
Now that http://trac.webkit.org/changeset/97613 is rolled the test should be
steadily passing.
BUG=100538
TEST=WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization
TBR=pfeldman
Review URL: http://codereview.chromium.org/8346031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
content/public/browser.
This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header.
BUG=98716
TBR=joi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100488
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8315005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=69719
TEST=DevToolsSanityTest.TestPause*
TBR=pfeldman
Review URL: http://codereview.chromium.org/8244006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100538
TEST=WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization
TBR=pfeldman
Review URL: http://codereview.chromium.org/8314024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit change http://trac.webkit.org/changeset/97258 should have fixed
it in debug mode.
BUG=89845
TEST=WorkerDevToolsSanityTest.InspectSharedWorker
TBR=pfeldman
Review URL: http://codereview.chromium.org/8245008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100538
TEST=WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization
TBR=pfeldman
Review URL: http://codereview.chromium.org/8313020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added a test that navigates to a page which launches a shared worker, opens devtools for the worker, terminates the worker and reloads the page to recreate the worker. After that the test checks that debugger is paused on the debugger statement(which is the first one) in the reloaded worker.
BUG=None
TEST=WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization
Review URL: http://codereview.chromium.org/8208012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=99016
TEST=Click a link to a slow view-source: URL.
Review URL: http://codereview.chromium.org/8224023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
files, I've also updated it to use the enum naming convention in the Content API.
BUG=98716
Review URL: http://codereview.chromium.org/8253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
To be able to debug shared workers initialization, devtools front-end needs to attach very early, before first statement of the worker script is executed. To achieve this on the IO thread we keep a list of shared workers for which devtools front-end was opened and not closed yet. If such worker is destroyed we store its URL and name in the pending workers list and once a new worker is created again we tell it to pause its worker context on start and wait for explicit notification from the devtools client or resume message(in case we learn that the client has already closed on the UI thread). After pause message was sent to the worker being created we put corresponding data to the paused_workers_ list and post reattach task to the UI thread which should result in reattach message to the new worker if the front-end still exists, otherwise when the worker data is removed from the paused_workers_ list we will send resume message and worker will continue to operate as usual.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8216008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
namespace. I've also renamed the value names to match the style that we use in the WebKit API (i.e. all values in an enum start with the enum's name) since it's more readable. As we move other enums to public we should switch them over as well.
BUG=98716
Review URL: http://codereview.chromium.org/8220024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In case of worker devtools agent host we will need to know
whether a client is attached to it to update corresponding map on the IO thread.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8117004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
inspected RVH doesn't change
BUG=98210
TEST=DevToolsSanityTest.TestConsoleOnNavigateBack
Review URL: http://codereview.chromium.org/8050011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7980035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102264 0039d316-1c4b-4281-b951-d872f2087c98
|