summaryrefslogtreecommitdiffstats
path: root/chrome/browser/debugger
Commit message (Collapse)AuthorAgeFilesLines
* DevTools: rename debugger/ to devtools/, move DevTools files into ↵pfeldman@chromium.org2012-12-1913-2358/+0
| | | | | | | | | content/renderer/devtools. Review URL: https://codereview.chromium.org/11630004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173903 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r173891 - "DevTools: rename debugger/ to devtools/, move DevTools ↵mnissler@chromium.org2012-12-1913-0/+2358
| | | | | | | | | | | | | | | | | | | | files into content/renderer/devtools." DevToolsManagerTest.ForwardMessageToClient: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests%20x64&number=29428 http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Aura&number=304 http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Clang%20%28dbg%29&number=37637 http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tests%20%281%29&number=17804 http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASAN%20Tests%20%283%29&number=1107 BUG=None TEST=Tree becomes greener. TBR=pfeldman@chromium.org Review URL: https://codereview.chromium.org/11645015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173893 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: rename debugger/ to devtools/, move DevTools files into ↵pfeldman@chromium.org2012-12-1913-2358/+0
| | | | | | | | content/renderer/devtools. Review URL: https://codereview.chromium.org/11630004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173891 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents includes.avi@chromium.org2012-12-141-1/+0
| | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://codereview.chromium.org/11570024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173206 0039d316-1c4b-4281-b951-d872f2087c98
* Increase suggested file name length limit up to 64 characters.eustas@chromium.org2012-12-121-2/+2
| | | | | | | | | BUG=165645 Review URL: https://chromiumcodereview.appspot.com/11555019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172595 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that the Inspect Element operation when performed on Windows 8 Metro ↵ananta@chromium.org2012-12-112-2/+36
| | | | | | | | | | | | | | | | ASH opens a docked dev tools window. Currently if this operation is performed on Windows 8 ASH we end up opening the Dev tools window in desktop mode which is incorrect. This happens because we attempt to find the inspected WebContents instance in the desktop browser list. Fix is to find the inspected webcontents in the desktop and the ASH browser lists as they can both be active concurrently for Windows 8. BUG=151718 R=sky Review URL: https://codereview.chromium.org/11519012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172360 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents from dev tools.avi@chromium.org2012-12-114-47/+40
| | | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/11489005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172216 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents from Cocoa code.avi@chromium.org2012-12-102-1/+2
| | | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/11493004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172067 0039d316-1c4b-4281-b951-d872f2087c98
* Introduces "CreateParams" for web contents, and add |parent| parameter in it.mukai@chromium.org2012-12-091-2/+2
| | | | | | | | | | BUG=155443 TEST=In Goobuntu, add logging of screen_info in RenderViewHost::CreateRenderView() temporarily and make sure the correct scale factor is chosen at boot. Review URL: https://chromiumcodereview.appspot.com/11361245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172008 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents from TabStripModel::DetachTabContentsAt.avi@chromium.org2012-12-051-1/+1
| | | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/11419298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171340 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetExtensionService calls and replace with PKSF calls through the ↵mirandac@chromium.org2012-11-302-3/+5
| | | | | | | | | | | | | ExtensionSystem. Extension services were made into ProfileKeyedServices a while ago; this replaces the deprecated calls that ran directly through the Profile object. This is about half of the total GetExtensionService calls in the codebase, but this CL is already ridiculously large. BUG= http://code.google.com/p/chromium/issues/detail?id=104095 Review URL: https://chromiumcodereview.appspot.com/11365181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170497 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents from TabStripModel::AddTabContents.avi@chromium.org2012-11-291-2/+2
| | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://codereview.chromium.org/11415179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170242 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant call to DevToolsWindow::UpdateFrontendDockSide()tapted@chromium.org2012-11-281-1/+0
| | | | | | | | | | | | | | | | This redundant call in Show will cause errors like "Uncaught ReferenceError: InspectorFrontendAPI is not defined" in the case DevTools has not loaded yet. In the case that it is loaded, DoAction will call the function, and when it isn't loaded the observer will call DoAction. BUG=162799 R=pfeldman@chromium.org TEST=covered by browser_tests, e.g. ChromeRenderProcessHostTest.DevToolsOnSelfInOwnProcess Review URL: https://chromiumcodereview.appspot.com/11280180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169941 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: do not access tab contents after WebContentsImplDestroyed is ↵pfeldman@chromium.org2012-11-222-37/+29
| | | | | | | | | | | dispatched. BUG=161961 Review URL: https://chromiumcodereview.appspot.com/11308123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169253 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents from BrowserWindow and website settings.avi@chromium.org2012-11-211-1/+1
| | | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/11413102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169085 0039d316-1c4b-4281-b951-d872f2087c98
* Remove tabstrip wrappers in browser_tabstrip.avi@chromium.org2012-11-152-4/+6
| | | | | | | | | | BUG=none TEST=no functional change Review URL: https://chromiumcodereview.appspot.com/11364239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168076 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents from chrome::AddSelectedTabWithURL.avi@chromium.org2012-11-151-2/+2
| | | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/11312249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167842 0039d316-1c4b-4281-b951-d872f2087c98
* Triggering InspectElement from context menu over a guest will open guest's ↵lazyboy@chromium.org2012-11-141-1/+1
| | | | | | | | | | | | | | devtools with correct element highlighted. BUG=140329 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167486 Relanding after linux_clang dbg bot fix. Review URL: https://chromiumcodereview.appspot.com/11362016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167744 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this to fix the compile failures on linux clang. please reland ↵ananta@chromium.org2012-11-131-1/+1
| | | | | | | | | | | | | | | after fixing. Revert 167486 - Triggering InspectElement from context menu over a guest will open guest's devtools with correct element highlighted. BUG=140329 Review URL: https://chromiumcodereview.appspot.com/11362016 TBR=lazyboy@chromium.org Review URL: https://chromiumcodereview.appspot.com/11275300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167506 0039d316-1c4b-4281-b951-d872f2087c98
* Triggering InspectElement from context menu over a guest will open guest's ↵lazyboy@chromium.org2012-11-131-1/+1
| | | | | | | | | | devtools with correct element highlighted. BUG=140329 Review URL: https://chromiumcodereview.appspot.com/11362016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167486 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: json/new fails when there are no windows open on ChromeOSpfeldman@chromium.org2012-11-123-3/+12
| | | | | | | | | BUG=159680 Review URL: https://chromiumcodereview.appspot.com/11362185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167154 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: [remote debugging] emit Inspector.detached protocol message upon ↵pfeldman@chromium.org2012-11-021-1/+1
| | | | | | | | | connectin termination. BUG=129539 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165656 0039d316-1c4b-4281-b951-d872f2087c98
* Add method to load resources without scaleoshima@chromium.org2012-11-011-3/+1
| | | | | | | | | | | | | | | This removes a lot of necessary reference to SCALE_FACTOR_NONE, and eliminate layout.h I'll cleanup ContentClient in separate CL. BUG=156569 TEST=none. no functional change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165444 Review URL: https://chromiumcodereview.appspot.com/11341003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165500 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r165444 "Add method to load resources without scale"oshima@chromium.org2012-11-011-1/+3
| | | | | | | | | | TBR=oshima@chromium.org BUG=none TEST=none Review URL: https://codereview.chromium.org/11360041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165445 0039d316-1c4b-4281-b951-d872f2087c98
* Add method to load resources without scaleoshima@chromium.org2012-11-011-3/+1
| | | | | | | | | | | | | This removes a lot of necessary reference to SCALE_FACTOR_NONE, and eliminate layout.h I'll cleanup ContentClient in separate CL. BUG=156569 TEST=none. no functional change. Review URL: https://chromiumcodereview.appspot.com/11341003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165444 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: clean up after the dock-side refactoring (was a 2-side patch).pfeldman@chromium.org2012-10-301-5/+1
| | | | | | Review URL: https://chromiumcodereview.appspot.com/11310003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164902 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: “Dock to right” broken after turning a tab into a window of ↵pfeldman@chromium.org2012-10-262-4/+81
| | | | | | | | | | | | its own. BUG=122772 TBR=pkasting Review URL: https://codereview.chromium.org/11272015/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164315 0039d316-1c4b-4281-b951-d872f2087c98
* Moved GetDiscoveryPageHTML call on UI thread.vsevik@chromium.org2012-10-241-5/+1
| | | | | | | | | BUG=157323 Review URL: https://chromiumcodereview.appspot.com/11276002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163881 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Profile->GetExtensionProcessManager calls; replace with PKSF calls ↵mirandac@chromium.org2012-10-241-1/+3
| | | | | | | | | | through the ExtensionSystem. Extension services were made into ProfileKeyedServices a while ago; this replaces all the deprecated calls that ran directly through the Profile object. BUG=104095 Review URL: https://chromiumcodereview.appspot.com/11246003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163846 0039d316-1c4b-4281-b951-d872f2087c98
* Reenbles DevToolsSanityTest.TestReattachAfterCrash.erg@chromium.org2012-10-231-2/+1
| | | | | | | | | | | | | This was disabled in r163152 to fix a problem caused by r163108, but was fixed by r163309. BUG=156985 TBR=yurys Review URL: https://chromiumcodereview.appspot.com/11235063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163696 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled DevToolsSanityTest.TestReattachAfterCrash.marja@chromium.org2012-10-201-1/+2
| | | | | | | | | | TBR=erg@chromium.org BUG=156985 NOTRY=true Review URL: https://codereview.chromium.org/11231027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163152 0039d316-1c4b-4281-b951-d872f2087c98
* [Coverity] Remove dead codegroby@chromium.org2012-10-201-9/+8
| | | | | | | | | | | | CID=106361 BUG=none R=pfeldman@chromium.org Review URL: https://chromiumcodereview.appspot.com/11220004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163143 0039d316-1c4b-4281-b951-d872f2087c98
* Follow up to 162982, fixing ViewIDTest.Basic on mac.pfeldman@chromium.org2012-10-192-8/+29
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162987 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: merge is_docked and dock_side into single dock_side state.pfeldman@chromium.org2012-10-192-99/+131
| | | | | | | | | As of today, we manage devtools window state in a weird way: it can be either docked or undocked, and while docked it can attach to bottom or to the right. These two levels of setting makes it hard to manage code, we'd like devtools window to have enum of equal states: bottom, right, undocked (so far). This change makes it happen. Review URL: https://chromiumcodereview.appspot.com/11189060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162982 0039d316-1c4b-4281-b951-d872f2087c98
* Override WebContentsFocused in DevToolsWindowcem.kocagil@gmail.com2012-10-122-0/+11
| | | | | | | | | | BUG=142730 TEST=Open a page, click somewhere in the page, hit F12 repeatedly. Devtools window should correctly open/close every time you hit F12. Review URL: https://chromiumcodereview.appspot.com/10993063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161635 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable passing tests.vsevik@chromium.org2012-10-121-14/+3
| | | | | | | | | BUG=118165 Review URL: https://chromiumcodereview.appspot.com/11117019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161576 0039d316-1c4b-4281-b951-d872f2087c98
* Reenabled DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefreshvsevik@chromium.org2012-10-111-9/+1
| | | | | | | | | BUG=141849 Review URL: https://chromiumcodereview.appspot.com/11093070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161332 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: [remote debugging] introduce json/new and json/close for creating ↵pfeldman@chromium.org2012-10-102-4/+18
| | | | | | | | and closing the tabs. Review URL: https://chromiumcodereview.appspot.com/11033046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161126 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools [remote debugging]: serve devtools front-end files from the bundle, ↵pfeldman@chromium.org2012-09-273-12/+12
| | | | | | | | never redirect to chrome-devtools://. Review URL: https://chromiumcodereview.appspot.com/10986050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159042 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: request page thumbnails from the devtools handler delegate, do not ↵pfeldman@chromium.org2012-09-272-0/+19
| | | | | | | | redirect to chrome://thumb. Review URL: https://chromiumcodereview.appspot.com/10985041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158982 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: provide the debugger detach reason in chrome.debugger.onDetach ↵pfeldman@chromium.org2012-09-201-0/+2
| | | | | | | | | | | extension API. BUG=129539 Review URL: https://chromiumcodereview.appspot.com/10947037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157754 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable DevToolsSanityTest.TestReattachAfterCrashyurys@chromium.org2012-09-171-4/+0
| | | | | | | | | | | | | The test should be passing consistently after http://src.chromium.org/viewvc/chrome?view=rev&revision=155982 BUG=103539,106526 Review URL: https://chromiumcodereview.appspot.com/10909262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157109 0039d316-1c4b-4281-b951-d872f2087c98
* Switch SessionTabHelper to use WebContentsUserData.avi@chromium.org2012-09-121-2/+3
| | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10928096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156292 0039d316-1c4b-4281-b951-d872f2087c98
* Pass result of blockage across content API when new tab blocked. This change ↵tsepez@chromium.org2012-09-072-3/+6
| | | | | | | | | | allows the proper blockage of foreground tabs created without user-gestures for rel=noreferrer links. BUG=118317 Review URL: https://chromiumcodereview.appspot.com/10868116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155535 0039d316-1c4b-4281-b951-d872f2087c98
* First part of PAGE_TRANSITION_START_PAGE cleanup.rogerta@chromium.org2012-09-051-2/+2
| | | | | | | | | | | | | | | | | | I replaced START_PAGE with AUTO_TOPLEVEL because that more accurately describes how its being used in the code. In a followed CL I will add specific support for startup pages, which was the original intention of START_PAGE. This CL is basically a large search and replace and does not change the behaviour of the code. BUG=144002 TEST=No user visible change Review URL: https://chromiumcodereview.appspot.com/10897034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155047 0039d316-1c4b-4281-b951-d872f2087c98
* Close detached DevTools window (rather than open a new instance) when it ↵apavlov@chromium.org2012-09-034-26/+43
| | | | | | | | | | | | receives an F12 keypress BUG=139581 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10823233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154694 0039d316-1c4b-4281-b951-d872f2087c98
* RestoreTabHelper > SessionTabHelper, move more session stuff into it.avi@chromium.org2012-08-301-2/+2
| | | | | | | | | | BUG=107201 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10891044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154186 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome/browser/debugger/OWNERSthakis@chromium.org2012-08-301-0/+3
| | | | | | | | | BUG=none NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10919009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154163 0039d316-1c4b-4281-b951-d872f2087c98
* Move SessionStorageNamespace entirely into NavigationController and support ↵ajwong@chromium.org2012-08-131-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | StoragePartitions. Previously, WebContents, NavigationController, and RenderViewHost all exposed APIs that allowed one to retrieve the SessionStorageNamespace associated with them. This is confusing because there were too many ways to access the object. After this change, the SessionStorageNamespace is only exposed by the NavigationController. Conceptually a SessionStorageNamespace belongs to a WebContents but we store it in NavigationController because on tab duplication, the NavigationController becomes the authoritative state of the tab. Also, to support StoragePartitions, the NavigationController now maintains a map of partition_id -> SessionStorageNamespace. Someone requesting a SessionStorageNamespace must either know which StoragePartition they are coming from, or which child process they are acting on behalf of. This change also changes the way TabContents and WebContents are created. 1) We now have explicitly separate creation methods for prepopulating with SessionStorage and creating with an opener. 2) Some of the WebContentImpl construct has been moved into an Init() function to avoid accidental calls to virtual functions by subobjects. TBR-ing all the directories where I just remove a NULL. TBR=sky,stevenjb,dominich,brettw,satorux,kalman BUG=85121 Review URL: https://chromiumcodereview.appspot.com/10831116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151379 0039d316-1c4b-4281-b951-d872f2087c98
* Mark DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh ↵asvitkine@chromium.org2012-08-101-1/+9
| | | | | | | | | | flaky on Windows. TBR=rlarocque@chromium.org BUG=141849 Review URL: https://chromiumcodereview.appspot.com/10828254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151027 0039d316-1c4b-4281-b951-d872f2087c98