summaryrefslogtreecommitdiffstats
path: root/chrome/browser/enumerate_modules_model_win.cc
Commit message (Collapse)AuthorAgeFilesLines
* Remove two deprecated methods from base::Versionisherman@chromium.org2012-07-111-13/+10
| | | | | | | | | | BUG=none TEST=none TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146157 0039d316-1c4b-4281-b951-d872f2087c98
* Add another instance of a problematic DLL (different location) to the ↵finnur@chromium.org2012-06-121-2/+5
| | | | | | | | | | about:conflicts blacklist. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10546096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141651 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to IWYU for files that previously were getting a bunch ofjoi@chromium.org2011-12-011-0/+1
| | | | | | | | | | | header files via io_thread.h or browser_thread.h TBR=owners (previously approved on codereview 8477004) BUG=98716 Review URL: http://codereview.chromium.org/8746023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112455 0039d316-1c4b-4281-b951-d872f2087c98
* A few more base::Bind migrations.csilv@chromium.org2011-11-241-6/+5
| | | | | | | BUG=none Review URL: http://codereview.chromium.org/8680016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111484 0039d316-1c4b-4281-b951-d872f2087c98
* Move BrowserThread to content namespace.joi@chromium.org2011-11-021-0/+2
| | | | | | | | | TBR=owners BUG=98716 Review URL: http://codereview.chromium.org/8437002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
* Make NotificationService an interface in the content namespace, and switch ↵jam@chromium.org2011-10-191-7/+7
| | | | | | | | | callers to use it. Move the implementation to content/browser. Stop creating it in all child processes since it's only used in the browser. BUG=98716 Review URL: http://codereview.chromium.org/8342048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106403 0039d316-1c4b-4281-b951-d872f2087c98
* Move NotificationObserver, NotificationSource, and NotificationDetails to ↵jam@chromium.org2011-10-191-3/+3
| | | | | | | | | | | content/public/browser. This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header. BUG=98716 TBR=joi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
* Update base/timer.h code to pass through Location from call sites. (reland) ↵jbates@chromium.org2011-09-021-1/+1
| | | | | | | | original CL w/LGTMs: http://codereview.chromium.org/7812036/ Review URL: http://codereview.chromium.org/7824041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99409 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Currently, base/timer.cc calls PostTask with FROM_HERE as the Location,mattm@chromium.org2011-09-021-1/+1
| | | | | | | | | | | | so the original code that created the delayed callback is lost." This reverts commit 4cf5cf73d319b69c32ad30af8954235755856455. (r99284) TBR=jbates@chromium.org Review URL: http://codereview.chromium.org/7825026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99290 0039d316-1c4b-4281-b951-d872f2087c98
* Currently, base/timer.cc calls PostTask with FROM_HERE as the Location, so ↵jbates@chromium.org2011-09-021-1/+1
| | | | | | | | | | the original code that created the delayed callback is lost. This change adds a tracked_objects::Location parameter to the APIs in base/timer.h so we can trace the PostTask callbacks. The other files are touched to add the FROM_HERE Location parameter. Review URL: http://codereview.chromium.org/7812036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99284 0039d316-1c4b-4281-b951-d872f2087c98
* Add 5 new dlls to the chrome://conflicts blacklist after consulting the list ↵finnur@chromium.org2011-08-221-1/+16
| | | | | | | | | | of top 3rd party crashers. BUG=None TEST=None Review URL: http://codereview.chromium.org/7691005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97616 0039d316-1c4b-4281-b951-d872f2087c98
* Moving notification types which are chrome specific to a new header file ↵ananta@chromium.org2011-07-101-3/+4
| | | | | | | | | | | | | chrome_notification_types.h. This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END which defines the end of the enum used by content to define notification types. The notificaton_type.h file in content\common has been renamed to content_notification_types.h BUG=76698 Review URL: http://codereview.chromium.org/7327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove WideToUpper/WideToLowerevan@chromium.org2011-05-101-1/+1
| | | | | | | | | | | Also fix two instances of passing a single-char array to a function that expects a string (we must NUL-terminate the array). BUG=23581 Review URL: http://codereview.chromium.org/7000005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84855 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: split the directory listing parser test and re-enable it on TSan botsphajdan.jr@chromium.org2011-05-061-3/+4
| | | | | | | | | | | | | | The test was disabled on TSan bots becuase it was taking too much time. This change converts one huge test which parses ~30 directory listings to ~30 separate test cases. This change also moves ToLower/ToUpper from ui/base/l10n_util to base/i18n/case_conversion so that they can be used in net/ftp. BUG=79022 Review URL: http://codereview.chromium.org/6905027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84413 0039d316-1c4b-4281-b951-d872f2087c98
* Trusteer's rooksdol.dll version 3.5.1008.40 is said to fix the browser ↵finnur@chromium.org2011-04-271-1/+1
| | | | | | | | | | crashes experienced by some users. BUG=80552 TEST=about:conflicts should not complain about Trusteer version 3.5.1008.40 or above. Review URL: http://codereview.chromium.org/6880202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83138 0039d316-1c4b-4281-b951-d872f2087c98
* Move crypto files out of base, to a top level directory.rvargas@google.com2011-04-141-2/+2
| | | | | | | | | | | | | src/crypto is now an independent project that contains our cryptographic primitives (except md5 and sha1). This removes the base dependency from nss, openssl and sqlite. BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6805019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81611 0039d316-1c4b-4281-b951-d872f2087c98
* Now that we have Help Center redirects in place we can point users to them.finnur@chromium.org2011-04-121-4/+4
| | | | | | | | | TBR=huanr BUG=67897 TEST=This should be tested at the same time (and using the same instructions) as for my previous blacklist change (contact me for details). Review URL: http://codereview.chromium.org/6820064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81241 0039d316-1c4b-4281-b951-d872f2087c98
* After reviewing the frequency list for 3rd party crashers there are a fewfinnur@chromium.org2011-04-081-11/+68
| | | | | | | | | | | | | new items to add to the about:conflicts list. Also changed it so that the conflicts badge gets removed once you open the wrench menu. BUG=67897 TEST=Please contact me for details, it is a bit involved. Review URL: http://codereview.chromium.org/6804011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80923 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-081-1/+1
| | | | | | | | | | | First part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6649001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77330 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize ModuleEnumerator member.finnur@chromium.org2011-02-111-1/+2
| | | | | | | | | | BUG=None TEST=None CID=14206 Review URL: http://codereview.chromium.org/6482027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74596 0039d316-1c4b-4281-b951-d872f2087c98
* Cross-platform CL to remove app/win/win_util.h&cc and related work.msw@chromium.org2011-02-031-2/+16
| | | | | | | | | | | | | | | | | | | | See Issue 70141 for the full move details; see my inline review comments. Changes significantly different from or beyond those prescribed by the bug: *Consolidated a lot of GrabWindowSnapshot code. *Moved EnsureRectIsVisibleInRect to views::internal namespace for test access. *Moved app/win/win_util_unittest.cc to views/window/window_win_unittest.h *Named ui/base/message_box_win.h instead of ui/base/message_box.h *Made WindowWin::GetWindowTitleFont static; needed in static contexts. *Denoted WindowWin::FrameTypeChanged as a Window override, moved code. *Moved TestGrabWindowSnapshot into new file: chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm BUG=70141 TEST=none Review URL: http://codereview.chromium.org/6386009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73589 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to ui/baseben@chromium.org2011-01-211-1/+1
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
* Add base:: to fix the buildbrettw@chromium.org2011-01-211-1/+1
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6360010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72109 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing base::lock usage.brettw@chromium.org2011-01-211-1/+1
| | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6336010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72108 0039d316-1c4b-4281-b951-d872f2087c98
* Regkey functions return error code instead of boolamit@chromium.org2011-01-191-2/+2
| | | | | | | | | | | | | | | | | | | | | | Change the Regkey helper to consistently use and return LONG instead of bool. Fix RegKey usage all over the code base and get rid of workarounds due to lack of return value. Reviewers: brettw: everything (skip parts for other reviewers if you wish) robertshield,grt: chrome_frame, installer siggi: ceee BUG=none TEST=covered by existing tests Review URL: http://codereview.chromium.org/6090006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71768 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Remove base/scoped_handle_win.h."tfarina@chromium.org2011-01-091-3/+3
| | | | | | | | | | | | | | | Fixed the problem with rlz library. Now should be fine to land this again. This reverts commit 3620d9501af7bff688862c54fdd60f7eb41797f3. Original Review URL: http://codereview.chromium.org/6126002/ BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70861 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the histogram counters for about:conflicts get uploaded.finnur@chromium.org2011-01-091-16/+18
| | | | | | | | | BUG=51105 TEST=None Review URL: http://codereview.chromium.org/6098009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70860 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove base/scoped_handle_win.h stub and fix up all callers to use ↵thakis@chromium.org2011-01-071-3/+3
| | | | | | | | | | the new location and namespace." This reverts r 70795, it broke the build. TBR=vandebo git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70802 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/scoped_handle_win.h stub and fix up all callers to use the new ↵tfarina@chromium.org2011-01-071-3/+3
| | | | | | | | | | | location and namespace. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6126002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70795 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we don't trigger the incompatibility badge if the flag is turned ↵finnur@chromium.org2011-01-071-11/+20
| | | | | | | | | | | | | off when the user navigates to about:conflicts and finds a conflict. Also, record an event when we show the incompatibilities badge to the user so we can find out how often this occurs in the field. BUG=None TEST=None Review URL: http://codereview.chromium.org/6061011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70751 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate about:conflicts with --diagnosticsfinnur@chromium.org2011-01-061-62/+87
| | | | | | | | | | | | | | | | | This should enable the user to find conflicting dlls that are crashing Chrome on startup. This changelist introduces a limited_mode for scanning, since the diagnostics tests run without the help of many Chrome services, so we can't use the File thread for asynchronous scanning or the notification system. Also changed the scanning so that if no signature/description is given in the blacklist, then we mark the DLL as a confirmed match if the name and the location match (before we used to match it as a 'suspected' match). A very sizable chunk of the blacklist is malware, which has no signature, so this gives us the ability to trigger the wrench badge on finding malware (that part remains opt-in through about:flags). Also added failure count to diagnostics output (sometimes the error scrolls off screen, so having a note at the bottom helps). BUG=51105 TEST=All diagnostics tests run as part of the unit tests. Review URL: http://codereview.chromium.org/6098004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70600 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from l10n_util. Part 5.avi@chromium.org2011-01-051-4/+4
| | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6023012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70530 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/win_util to app/win and fix the namespace usage.brettw@google.com2010-12-311-2/+2
| | | | | | | | | | | | | | Split out the two classes: ScopedComInitializer and ScopedCOMem (which I renamed) to separate files. I removed the win_util_path file which had one function in it and moved the function to win_util. Somehow, this was getting picked up by the nacl64 build and the call in sandbox_policy was then not being defined. I just implemented the function in-plcae since it's just a simple wrapper around a Windows API call. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6013009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70343 0039d316-1c4b-4281-b951-d872f2087c98
* base/version: remove wstring versionevan@chromium.org2010-12-231-1/+1
| | | | | | | | | | | And fix callers. BUG=23581 TEST=trybots Review URL: http://codereview.chromium.org/5848005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70098 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69490 - base/version: remove wstring versionsanjeevr@chromium.org2010-12-171-1/+1
| | | | | | | | | | | | | | And fix callers. BUG=23581 TEST=trybots Review URL: http://codereview.chromium.org/5848005 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/5905006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69491 0039d316-1c4b-4281-b951-d872f2087c98
* base/version: remove wstring versionevan@chromium.org2010-12-171-1/+1
| | | | | | | | | | | And fix callers. BUG=23581 TEST=trybots Review URL: http://codereview.chromium.org/5848005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69490 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem with %temp% paths not collapsing correctly.finnur@chromium.org2010-12-161-22/+27
| | | | | | | | | | | | | Also update the blacklist so that modules that are not suspected malware don't get linked to the Help Center (the Help Center will only have a malware article to being with). BUG=66885 TEST=Covered by unit test. Review URL: http://codereview.chromium.org/5894001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69385 0039d316-1c4b-4281-b951-d872f2087c98
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-131-0/+5
| | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5685007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68982 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68932 - Make members of Singleton<T> private and only visible to the ↵satish@chromium.org2010-12-111-5/+0
| | | | | | | | | | | | | | | | | | singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 TBR=satish@chromium.org Review URL: http://codereview.chromium.org/5721005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68936 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-111-0/+5
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68932 0039d316-1c4b-4281-b951-d872f2087c98
* Update the blacklist to reflect latests statistics.finnur@chromium.org2010-12-081-23/+111
| | | | | | | | | | | Also change the URL as per Support. BUG=51105 TEST=None Review URL: http://codereview.chromium.org/5629005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68656 0039d316-1c4b-4281-b951-d872f2087c98
* EnumerateModules: Address UI review comments.finnur@chromium.org2010-11-291-24/+31
| | | | | | | | | | | | | | | | | | | | | | | | Make it a simple list with columns. Sort by status (conflicts at the top), then by location and module name. Also, convert the type of DLL to an enum so we can dedup the list (and for non-loaded DLLs show that they are not loaded yet, but are of type: Shell Extension / WinSock. Make sure lower bound version specified on the blacklist is inclusive (first version that broke) and the higher bound version is exclusive (first version that worked). This allows us to pointpoint exactly when the failure started and when the fix was introduced, instead of doing 0.9999 shenanigans. Specify an upper bound for the idmmbc.dll conflict, since Henry's outreach produced a fix in version 6.03 of the download manager. BUG=51105 TEST=Unit test Review URL: http://codereview.chromium.org/5278012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67598 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the test DLLs from the blacklist.finnur@chromium.org2010-11-261-8/+0
| | | | | | | | | | | | Demo is done. TBR=huanr BUG=51105 TEST=None Review URL: http://codereview.chromium.org/5307004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67446 0039d316-1c4b-4281-b951-d872f2087c98
* Readd two dlls to the blacklist for demonstration purposes.finnur@chromium.org2010-11-241-3/+11
| | | | | | | | | | | | To be removed shortly. TBR=huanr BUG=None TEST=None Review URL: http://codereview.chromium.org/5310004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67266 0039d316-1c4b-4281-b951-d872f2087c98
* Polish the Enumerate Modules implementation a bit.finnur@chromium.org2010-11-201-4/+72
| | | | | | | | | | | | | 1) De-dup the registered DLLs since a lot of the same DLLs will be registered multiple times, ie. mswsock.dll 2) Every module loaded from a %temp% dir should be viewed as suspicious. 3) Add some histogram counters (xml changes coming in a followup CL). BUG=http://crbug.com/51105 TEST=None Review URL: http://codereview.chromium.org/5183007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66880 0039d316-1c4b-4281-b951-d872f2087c98
* Add registered shell extensions to enumerated module list on about:conflicts.finnur@chromium.org2010-11-191-30/+90
| | | | | | | | | BUG=51105 TEST=None Review URL: http://codereview.chromium.org/5092007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66756 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DLLs from the module enumerator blacklist that were only there for ↵finnur@chromium.org2010-11-131-13/+6
| | | | | | | | | | | | | demonstating the feature. Also fixed some lint issues. BUG=None TEST=None Review URL: http://codereview.chromium.org/4855004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66052 0039d316-1c4b-4281-b951-d872f2087c98
* First cut of the about:conflicts page, listing all DLLs loaded in the Chrome ↵finnur@chromium.org2010-11-081-0/+626
process. BUG=http://crbug.com/51105, http://crbug.com/57239 TEST=Unit tests included. Review URL: http://codereview.chromium.org/4524002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65366 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-23 16:49:35 +0000