| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When chrome.tabs.onupdated is fired, we get tab values for second parameter
(which privacy sensitive values are already scrubed).
That means we can just get changed value from it.
So just pass changed property name(std::set<>) only instead of property
key-value(base::DictionaryValue).
BUG=582484
TEST=browser_tests --gtest_filter=ExtensionApiTest.*
Review URL: https://codereview.chromium.org/1639253009
Cr-Commit-Position: refs/heads/master@{#374345}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL:
- Removes weird OnFaviconAvailable() behavior if gfx::Image is empty.
- Merges: FaviconDriver::SetActiveFaviconValidity()
FaviconDriver::SetActiveFaviconURL()
FaviconDriver::SetActiveFaviconImage()
- Merges FaviconDriverObserver::OnFaviconAvailable() and
FaviconDriverObserver::OnFaviconUpdated().
BUG=542057
Review URL: https://codereview.chromium.org/1407353012
Cr-Commit-Position: refs/heads/master@{#361132}
|
|
|
|
|
|
|
|
|
|
|
| |
C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap.
BUG=554291
Review URL: https://codereview.chromium.org/1436753002
Cr-Commit-Position: refs/heads/master@{#359116}
|
|
|
|
|
|
|
|
|
|
|
|
| |
when document.title is updated, fire `chrome.tabs.onUpdated` with the
value of {title: 'updated_title'}.
BUG=458839
TEST=browser_tests --gtest_filter=ExtensionApiTest.TabsOnUpdated
Review URL: https://codereview.chromium.org/1413923002
Cr-Commit-Position: refs/heads/master@{#355851}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are a handful of places that attach a TabStripModelObserver to a
subset of Browsers. This patch consolidates that.
BUG=none
TEST=none
R=pkasting@chromium.org
Review URL: https://codereview.chromium.org/1400823003
Cr-Commit-Position: refs/heads/master@{#353532}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the last batch of trivial replacements of the form
DispatchEvent(kFooEvent) --> DispatchEvent(events::FOO_EVENT, kFooEvent).
The remaining 15 or so files are less trivial, but there are only 15.
BUG=503402
R=rdevlin.cronin@chromium.org, isherman@chromium.org
Review URL: https://codereview.chromium.org/1240913002
Cr-Commit-Position: refs/heads/master@{#339209}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
relevant
chrome.tabs.update will reject the audible property.
When the onUpdated event is triggered for the muted property, it sets cause
to "user", "capture", or the extension id that caused it
Note: Requires --enable-tab-audio-muting flag to be active (chrome://flags) in order to set a tab's muted state via c.t.update.
BUG=438903
Review URL: https://codereview.chromium.org/987583004
Cr-Commit-Position: refs/heads/master@{#337981}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert CreateForWebContents() and ShouldDisplayFavicon() from static
method into free functions and move them into the favicon namespace.
Port client code to use favicon::ContentFaviconDriver::FromWebContents()
to access the favicon::FaviconDriver and prefer to use the public base
class instead of favicon::ContentFaviconDriver.
Rename FaviconTabHelperTest to ContentFaviconDriverTest.
BUG=359569
TBR=jochen
Review URL: https://codereview.chromium.org/1075443003
Cr-Commit-Position: refs/heads/master@{#324639}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change notification NOTIFICATION_FAVICON_UPDATED into an event sent to
FaviconDriverObserver and change client code to be observers instead.
Pass the FaviconDriver to OnFaviconUpdated() event so that listeners can
find the content::WebContents corresponding to the event (as some of the
client code did listen to multiple content::WebContents).
BUG=362072
Review URL: https://codereview.chromium.org/1059743003
Cr-Commit-Position: refs/heads/master@{#324201}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL moves the three classes into components, namespace ui_zoom, and moves
their associated source files into components/ui/zoom so that
they can be used in non-chrome configurations.
BUG=none
TBR=willchan@chromium.org chrome/browser/profiles
TBR=fsamuel@chromium.org */web_view/*
TBR=estade@chromium.org chrome/browser/ui/autofill
TBR=pkasting@chromium.org chrome/browser/ui not covered above
TBR=dgozman@chromium.org chrome/browser/devtools
TBR=rsesek@chromium.org chrome/browser/browser_commands_unittest.cc
TBR=sky@chromium.org chrome/browser/renderer_preferences_util.cc
Review URL: https://codereview.chromium.org/769593003
Cr-Commit-Position: refs/heads/master@{#307470}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.
BUG=417463
TBR=mek@chromium.org
Review URL: https://codereview.chromium.org/666153002
Cr-Commit-Position: refs/heads/master@{#300474}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/624153002
Cr-Commit-Position: refs/heads/master@{#298134}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
API, as outlined in
https://docs.google.com/a/chromium.org/document/d/1sCZjx1J3_M2a02T8NXd-ufGKZDoBHI5Ixis1DaGLQCA/edit?usp=sharing.
Based on code from https://codereview.chromium.org/232773011/, with various
fixes and rebased against changes in https://codereview.chromium.org/287093002/
Depends on changes in https://codereview.chromium.org/302603012/
BUG=30583
Review URL: https://codereview.chromium.org/301733006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TestWebContentsView goes away since it's not needed anymore
BUG=304341
R=avi@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/262823006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=88666
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/120783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that its dependencies on Profile, ActivityLog, RuntimeAPI and
WebRequestAPI have been removed it can move into the extensions module.
This is part of the AppShell extensions refactoring project.
BUG=316367
TEST=compiles
R=yoz@chromium.org
TBR=mukai@chromium.org for mechanical file move in c/b/notifications, dmazzoni@chromium.org for mechanical file move in accessibility code
Review URL: https://codereview.chromium.org/78483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=compile
R=yoz
BUG=
Review URL: https://codereview.chromium.org/25308004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Move (and rename) c/b/e/browser_event_router -> c/b/e/api/tabs/tabs_event_router
Lazily initialize TabsEventRouter
Kill ExtensionService::InitEventRouters
BUG=165209
Review URL: https://chromiumcodereview.appspot.com/23724026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222660 0039d316-1c4b-4281-b951-d872f2087c98
|