| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This deletes the majority of the code supporting chrome://memory
pages. There's still a little bit more of follow-up work to clean up
memory_details*.cc files, but those will require some changes to logic
and thus is better to do them in a separate CL.
BUG=588790,25454
Review URL: https://codereview.chromium.org/1722493002
Cr-Commit-Position: refs/heads/master@{#382198}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.
BUG=436357
R=dcheng@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/1731483003
Cr-Commit-Position: refs/heads/master@{#377767}
|
|
|
|
|
|
|
|
|
| |
TBR=thakis@chromium.org
BUG=568486
Review URL: https://codereview.chromium.org/1705823002
Cr-Commit-Position: refs/heads/master@{#376151}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To improve component updates of PPAPI plugins, Chrome needs multiple zygotes.
This will allow the PPAPI zygote to be recreated when a plugin is updated.
This CL allows Chrome to maintain a zygote for each process type by having
each SandboxedProcessLauncherDelegate maintain a class which can communicate
with its respective zygote. This CL will be followed up with work to allow
customization of zygotes, which will give Chrome the improve component update
experience.
BUG=569191
Committed: https://crrev.com/3c1e16b490255119b6f70f94d1716645e897b185
Cr-Commit-Position: refs/heads/master@{#370488}
Review URL: https://codereview.chromium.org/1532423003
Cr-Commit-Position: refs/heads/master@{#371042}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #15 id:440001 of https://codereview.chromium.org/1532423003/ )
Reason for revert:
Revert "Have each SandboxedProcessLauncherDelegate maintain a zygote."
This reverts commit 3c1e16b490255119b6f70f94d1716645e897b185.
This broke the Site Isolation FYI bot failure:
https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/7700
To re-land the CL, that failure needs to be diagnosed and corrected.
Original issue's description:
> Have each SandboxedProcessLauncherDelegate maintain a zygote.
>
> To improve component updates of PPAPI plugins, Chrome needs multiple zygotes.
> This will allow the PPAPI zygote to be recreated when a plugin is updated.
> This CL allows Chrome to maintain a zygote for each process type by having
> each SandboxedProcessLauncherDelegate maintain a class which can communicate
> with its respective zygote. This CL will be followed up with work to allow
> customization of zygotes, which will give Chrome the improve component update
> experience.
>
> BUG=569191
>
> Committed: https://crrev.com/3c1e16b490255119b6f70f94d1716645e897b185
> Cr-Commit-Position: refs/heads/master@{#370488}
TBR=mdempsky@chromium.org,thestig@chromium.org,avi@chromium.org,mseaborn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=569191
Review URL: https://codereview.chromium.org/1617213002
Cr-Commit-Position: refs/heads/master@{#370771}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To improve component updates of PPAPI plugins, Chrome needs multiple zygotes.
This will allow the PPAPI zygote to be recreated when a plugin is updated.
This CL allows Chrome to maintain a zygote for each process type by having
each SandboxedProcessLauncherDelegate maintain a class which can communicate
with its respective zygote. This CL will be followed up with work to allow
customization of zygotes, which will give Chrome the improve component update
experience.
BUG=569191
Review URL: https://codereview.chromium.org/1532423003
Cr-Commit-Position: refs/heads/master@{#370488}
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1550593002
Cr-Commit-Position: refs/heads/master@{#366879}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix possible O(n^4) worst case behavior (processes x widgets x
frames x siteinstances) for stats gathering.
- Show subframe-only processes in about:memory, which also causes them to
be reported in SiteIsolation.CurrentRendererProcessCount.
- Because SiteIsolation.CurrentRendererProcessCount is fixed, we need
a new family of metrics, SiteIsolation.IsolateNothing*, which simulates
the process-per-siteinstance process model. In tests, IsolateNothing
is expected to have the value that CurrentRenderProcessCount used to.
- Implement a more correct treatment of site isolation stats, which looks at
parent/child transitions and handles ProcessPerSite properly. This is
required for IsolateNothing to work correctly. Since options for
walking the frame tree outside of content are pretty limited, this uses
WebContents::ForEachFrame and (!) memoization.
- Eliminate WebContents::GetSitesInTab; move its about:blank logic into
the new frametree walking code in SiteDetails, which was the only caller.
BUG=454526,542909
TEST=browser_tests
Review URL: https://codereview.chromium.org/1406133002
Cr-Commit-Position: refs/heads/master@{#357178}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes a delegate interface between the RenderViewHost and the RenderWidgetHost, which will eventually be used for their communication.
This also allows the removal of the horrible terrible no-good RenderWidgetHost::IsRenderView().
BUG=542477
TEST=all green
Review URL: https://codereview.chromium.org/1411203010
Cr-Commit-Position: refs/heads/master@{#356286}
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first part of the separation of RenderViewHost and RenderWidgetHost. The separation of the Impls is yet to come.
BUG=478281
TEST=all green
Review URL: https://codereview.chromium.org/1392323003
Cr-Commit-Position: refs/heads/master@{#354258}
|
|
|
|
|
|
|
|
| |
Remove url:: variants. Add the 4-element version from url:: to base::
Review URL: https://codereview.chromium.org/1172753003
Cr-Commit-Position: refs/heads/master@{#333597}
|
|
|
|
|
|
|
|
|
|
| |
Instead, run it on the blocking pool with SKIP_ON_SHUTDOWN behavior.
BUG=474876
Review URL: https://codereview.chromium.org/1066193003
Cr-Commit-Position: refs/heads/master@{#324761}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior to this change, every time MetricsDetails is used, the code
would collect memory usage information from all running browsers,
even if the intention was to just get information about Chrome (e.g.
when logging Memory.* histograms).
On some platforms, like Mac, this was particularly expensive as
getting information about other processes involves running PS or
TOP as a sub-process. This would happen for all users opted-in
to UMA reporting shortly after start up and then periodically.
This CL adds a mode param to the implementation that specifies
whether the client is interested in metrics about all browsers or
just Chrome processes.
Also, this CL modernizes some of the related code - such as
using C++11 for loops and moving functions to the anonymous
namespace.
BUG=448834
Review URL: https://codereview.chromium.org/857063002
Cr-Commit-Position: refs/heads/master@{#312449}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves MetricsMemoryDetails (and MemoryGrowthTracker) to its
own file as well as moving the corresponding browser test.
This allows the base MemoryDetails class to be simplified, as it now
needs to do a lot less. Also, disables logging of these histograms
from a couple places that use the MemoryDetails that didn't need to
log the histograms but were doing it anyways (with TODOs).
BUG=448834
Review URL: https://codereview.chromium.org/823533004
Cr-Commit-Position: refs/heads/master@{#312026}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function has been deprecated in favor of
ExtensionRegistry::enabled_extensions(). Some caller were
immediately calling ExtensionSet::GetByID() and so these callers have
been converted to ExtensionRegistry::GetExtensionById() instead.
Cleaning up usage of this deprecated function removes a number of
files which pull in ExtensionService that really only need to use
ExtensionRegistry.
BUG=
Review URL: https://codereview.chromium.org/709813004
Cr-Commit-Position: refs/heads/master@{#303742}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/696073002
Cr-Commit-Position: refs/heads/master@{#302966}
|
|
|
|
|
|
|
|
|
|
|
| |
generated_resources. (part 1)
BUG=401588
Review URL: https://codereview.chromium.org/469993006
Cr-Commit-Position: refs/heads/master@{#291367}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This time, figure out what IDS entries are in a .grd file + .grdp files.
Then look for files that have the associated #include, but does not use
any of those entries.
Review URL: https://codereview.chromium.org/468233004
Cr-Commit-Position: refs/heads/master@{#290111}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace
>
> Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is
> generally a NOP but will allow me to delete the other 4 variants in a followup
> (wanted to do that separately since that will require more review, since
> callsites will be changed in nontrivial ways).
>
> In some cases, LowerCaseEqualsASCII is called with a WebString, which no
> longer is implicitly converted. I added base::string16(...) around such
> calls to force the right conversion. It happened in these files:
> window_container_type.cc
> savable_resources.cc
> render_view_impl.cc
> blink_ax_tree_source.cc
> password_form_conversion_utils.cc
> translate_helper.cc
> chrome_render_view_observer.cc
> dom_serializer_browsertest.cc
>
> R=jamesr@chromium.org
>
> Review URL: https://codereview.chromium.org/448143008
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/474483002
Cr-Commit-Position: refs/heads/master@{#289320}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is
generally a NOP but will allow me to delete the other 4 variants in a followup
(wanted to do that separately since that will require more review, since
callsites will be changed in nontrivial ways).
In some cases, LowerCaseEqualsASCII is called with a WebString, which no
longer is implicitly converted. I added base::string16(...) around such
calls to force the right conversion. It happened in these files:
window_container_type.cc
savable_resources.cc
render_view_impl.cc
blink_ax_tree_source.cc
password_form_conversion_utils.cc
translate_helper.cc
chrome_render_view_observer.cc
dom_serializer_browsertest.cc
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/448143008
Cr-Commit-Position: refs/heads/master@{#289312}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
codes.
BUG=327256
Review URL: https://codereview.chromium.org/411283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=349436
Review URL: https://codereview.chromium.org/383903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=379659
Review URL: https://codereview.chromium.org/308963005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/329893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of https://chromiumcodereview.appspot.com/255693002/
Race conditions in Skia have been fixed.
BUG=322185
Review URL: https://codereview.chromium.org/286903021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/255693002/)
Reason for revert:
TSANv2 bot reports races on many many tests.
Original issue's description:
> Make SandboxIPCProcess a thread.
>
> BUG=322185
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267583
TBR=jln@chromium.org,piman@chromium.org,jorgelo@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=322185
Review URL: https://codereview.chromium.org/261783008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=322185
Review URL: https://codereview.chromium.org/255693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=137297
R=yoz@chromium.org
Review URL: https://codereview.chromium.org/238263004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Any UpdateRects coming from a renderer will have their bitmap contents ignored. Some things may still be named a bit oddly after this patch, and can be cleaned up later.
BUG=362164
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/233223005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to remove more ExtensionService dependencies, which we need
to do because app_shell doesn't have an ExtensionService.
BUG=334706
TEST=existing unit_tests, browser_tests
TBR=sky@chromium.org for mechanical changes across the non-extensions bits of chrome/browser/
Review URL: https://codereview.chromium.org/139943005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
namespace.
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/106543008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: https://codereview.chromium.org/108123004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Adds the base:: qualifier to more instances of string16 in chrome/browser.
BUG=
Review URL: https://codereview.chromium.org/104043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=298586
R=cdn@chromium.org, miket@chromium.org, sky@chromium.org
TBR=cdn@chromium.org
Review URL: https://codereview.chromium.org/15239002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland of https://codereview.chromium.org/62713003/ - the original patch broke the Google Chrome OS official builder due to a missing dependency on the extensions api target in extensions/extensions.gyp.
* Move c/b/extensions/extension_process_manager.h to
extensions/browser/process_manager.h
* Rename ExtensionsProcessManager to ProcessManager
* Place it in the "extensions" namespace
BUG=313481
TEST=browser_tests, unit_tests
TBR=miket@chromium.org
Review URL: https://codereview.chromium.org/67253003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Compile error, runtime.h has moved?
> Move ExtensionProcessManager to src/extensions, part 4
>
> * Move c/b/extensions/extension_process_manager.h to
> extensions/browser/process_manager.h
> * Rename ExtensionsProcessManager to ProcessManager
> * Place it in the "extensions" namespace
>
> BUG=313481
> TEST=browser_tests, unit_tests
> R=miket@chromium.org
> TBR=sky@chromium.org for mechanical header file move affecting chrome/browser/
>
> Review URL: https://codereview.chromium.org/62713003
TBR=jamescook@chromium.org
Review URL: https://codereview.chromium.org/66213006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move c/b/extensions/extension_process_manager.h to
extensions/browser/process_manager.h
* Rename ExtensionsProcessManager to ProcessManager
* Place it in the "extensions" namespace
BUG=313481
TEST=browser_tests, unit_tests
R=miket@chromium.org
TBR=sky@chromium.org for mechanical header file move affecting chrome/browser/
Review URL: https://codereview.chromium.org/62713003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/23841002/ temporariliy breaks frame tree
accounting logic for tip of tree. Disable this UMA stat until frame
tree accounting is fixed to avoid polluting the data.
BUG=245126
R=creis@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/24980004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderWidgetHost::GetRenderWidgetHosts() and GetAllRenderWidgetHosts() returns a
list of RenderWidgetHost's. The caller can then perform some operation that leads
to some of the RenderWidgetHosts in the list being destroyed, leading to reading
from freed memory, when iterating over the list. So instead of sending a list,
introduce RenderWidgetHostIterator, which allows safely iterating over the list
of hosts.
BUG=285307
R=ajwong@chromium.org, creis@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/23453038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reside) and rename it to SwapInfo.
This only moves code and adds no new functionality.
This uses ScopedAllowIO. Since this is perfmon code to /proc, we have deemed that IO is acceptable.
BUG=236763
R=darin@chromium.org, nduca@chromium.org
Review URL: https://codereview.chromium.org/22780002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was whitespace (a newline) in the swap info files so
we were always behaving as if no swap had ever happened.
Also, the numreads and numwrites needed larger maximum values
and buckets.
BUG=260484
TEST=None
R=jam@chromium.org
Review URL: https://codereview.chromium.org/21374005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=242290
R=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19631004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260484
TEST=None
R=jam@chromium.org, jar@chromium.org
Review URL: https://codereview.chromium.org/19572011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260484
TEST=None
R=brettw@chromium.org, jam@chromium.org, jar@chromium.org
Review URL: https://codereview.chromium.org/19267012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeProcessType defines the NaCl broker and loader processes, and they should be moved with the rest of NaCl code.
Many files include chrome_process_type.h when they should really include content/public/common/process_type.h. Since chrome_process_type.h was removed, these files were modified to include process_type.h from content.
This is part of an effort to componentize NaCl code.
BUG=244791
Review URL: https://chromiumcodereview.appspot.com/17419009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=248160
Review URL: https://chromiumcodereview.appspot.com/16431010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Requires adding the committed URL to each FrameTreeNode and exposing the
ShouldUseProcessPerSite function outside content.
BUG=248299
Review URL: https://chromiumcodereview.appspot.com/16599016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15897014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16561007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=162530
Review URL: https://codereview.chromium.org/13375017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191650 0039d316-1c4b-4281-b951-d872f2087c98
|