summaryrefslogtreecommitdiffstats
path: root/chrome/browser/sidebar
Commit message (Collapse)AuthorAgeFilesLines
* Re-land r84928: Move EFD to ExtensionTabHelper.aa@chromium.org2011-05-131-13/+1
| | | | | | | BUG=80308 TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85242 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Re-land r84928: Move ExtensionFunctionDispatcher to"aa@chromium.org2011-05-121-1/+13
| | | | | | | | | | Breaks installation on webstore. This reverts commit 73ad030f2c57a444b81351b2a1cd8546a6dbddc8. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85084 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r84928: Move ExtensionFunctionDispatcher toaa@chromium.org2011-05-111-13/+1
| | | | | | | | | | ExtensionTabHelper. This reverts commit 89a6b9d9232949a01b8263779fa819ed4d5b3089. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85076 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Looks like this introduced leaks in sync ui tests. Sigh.""aa@chromium.org2011-05-111-1/+13
| | | | | | | | This reverts commit cb8e078c2e7bebf0604871ec0bda69ceac3734d2. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85058 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Looks like this introduced leaks in sync ui tests. Sigh."aa@chromium.org2011-05-111-13/+1
| | | | | | | | This reverts commit 471e46f5060ce0fd9413b0bc5ffbe78a2e4c7d02. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85032 0039d316-1c4b-4281-b951-d872f2087c98
* Looks like this introduced leaks in sync ui tests. Sigh.aa@chromium.org2011-05-111-1/+13
| | | | | | | | | | | | | | | | | | Revert "Move ExtensionFunctionDispatcher to ExtensionTabHelper. This" This reverts commit 4f08bad13a0cb2e40835869a9a7d9edb16a5be9a. Revert "Fix clang warning." This reverts commit 1663f72a9360677aad91a9417b44afd03a41181f. Revert "Fix chrome os" This reverts commit 1abb1afe1b78de4bc92a82fdd1e266166bc74707. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84941 0039d316-1c4b-4281-b951-d872f2087c98
* Move ExtensionFunctionDispatcher to ExtensionTabHelper. Thisaa@chromium.org2011-05-111-13/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | sets the stage for us to expose certain extension functions to content scripts and normal web pages. This required two major structural changes: 1. Made EFD stateless, except for the pointer to its delegate. This is important to gracefully handle the case of a RVH navigating between different extensions or even to normal web content. Especially in the case of TabContents, where the entire RVH can be torn down and replaced during navigation. 2. Centralize all per-(extension, RVH) setup in ChromeContentBrowserClient::RenderViewCreated(). In particular, responsibility for enabling extension bindings was very spread out before, making it hard to follow when exactly they were enabled. BUG=80308 Review URL: http://codereview.chromium.org/6927076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84928 0039d316-1c4b-4281-b951-d872f2087c98
* Don't hold the installed app in BrowserProcessRenderHost, since that's in ↵jam@chromium.org2011-04-231-3/+5
| | | | | | | | content layer now. ExtensionService keeps a map from renderer child ids to installed extensions instead. Review URL: http://codereview.chromium.org/6880089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82797 0039d316-1c4b-4281-b951-d872f2087c98
* Move BrowserRenderProcessHost to content. It should have been moved earlier.jam@chromium.org2011-04-191-1/+1
| | | | | | Review URL: http://codereview.chromium.org/6877019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82037 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the last Chrome dependencies from renderer, and enforce no more ↵jam@chromium.org2011-04-181-1/+1
| | | | | | | | includes through DEPS. I also added DEPS checking for gpu/plugin/worker directories as well. I moved the Chrome specific browser tests to the chrome directory, and removed render_widget_unittest since it didn't seem to be testing much (there are tests that test it much more fully). I had to move bindings_policy.h, which ideally would be split into separate pieces so that the content layer only has to know about the content bindings. Given that it's basically an enum, I moved the whole file now since it's used in a lot of places, and the value of turning on DEPS checking is really high. Review URL: http://codereview.chromium.org/6874038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81924 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the TabContentsDelegate::ToolbarSizeChanged() method as no one was ↵pkasting@chromium.org2011-04-151-1/+0
| | | | | | | | | | using it. Rename BrowserWindow::SelectedTabToolbarSizeChanged() to ToolbarSizeChanged() as there are no per-tab toolbars since we made the DownloadShelf per-window a while ago. BUG=none TEST=none Review URL: http://codereview.chromium.org/6870002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81834 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Update a bunch of files to the new location of browser_window.h. ↵tfarina@chromium.org2011-04-091-1/+1
| | | | | | | | | | | | | | | | | Part 1/1. (Note: This was a TODO for beng). Also remove browser_window.h stub file as all the includes to it were already updated. BUG=None TEST=None R=avi@chromium.org Review URL: http://codereview.chromium.org/6820015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81038 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-283-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for partitioning cookies for isolated apps.creis@google.com2011-03-151-0/+7
| | | | | | | | | | | | | | | | This CL adds experimental support for letting installed apps request isolated storage in their manifest. An isolated app will have its own cookie store that is not shared with other apps or normal pages, even if they share an origin. The feature is currently behind a --enable-experimental-app-manifests flag. BUG=69335 TEST=ExtensionManifestTest.IsolatedApps TEST=IsolatedAppApiTest.CookieIsolation* Review URL: http://codereview.chromium.org/6201005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78301 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some coverity defects (mostly pass by value).estade@chromium.org2011-03-112-2/+2
| | | | | | | | | | CID=15414,15415,15413,15412,15402,14582,13684,12723,15407,14785,14511,13975,13647,11655,10891,9103,8402,8394,10924,8497,others BUG=none TEST=trybots Review URL: http://codereview.chromium.org/6665012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77740 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-092-5/+5
| | | | | | | | | | | Third part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6650020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77458 0039d316-1c4b-4281-b951-d872f2087c98
* Update the includes to the old tab_contents.hjam@chromium.org2011-03-022-2/+2
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6596103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76552 0039d316-1c4b-4281-b951-d872f2087c98
* Update more includes that were pointing to the old locations.jam@chromium.org2011-03-021-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6598086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76512 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of temporary render_view_host.h.jam@chromium.org2011-03-021-5/+5
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6598084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76477 0039d316-1c4b-4281-b951-d872f2087c98
* Move bookmark star from TabContents to TabContentsWrapper.avi@chromium.org2011-02-041-2/+1
| | | | | | | | | BUG=71097 TEST=Hammer on bookmark star on all platforms. Nothing should crash, break, or have any user-visible change. Review URL: http://codereview.chromium.org/6334066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73836 0039d316-1c4b-4281-b951-d872f2087c98
* Only allow extension pages to be displayed in the sidebar to be consistentalekseys@chromium.org2011-01-252-9/+9
| | | | | | | | | | | | | | | | | | | | | with the rest of the extension system. Change extension manifest "sidebar" section and sidebar API accordingly: "sidebar": { "default_icon": "", "default_page": "", "default_title": "" } chrome.experimental.sidebar.navigate({tabId: ..., path: ...}) BUG=51084 TEST=browser_tests::Sidebar.*, unit_tests::ExtensionManifestTest.Sidebar Review URL: http://codereview.chromium.org/6378009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72514 0039d316-1c4b-4281-b951-d872f2087c98
* Add "sidebar" section to extension manifest:alekseys@chromium.org2011-01-205-17/+133
| | | | | | | | | | | | | | | | | "sidebar": { "default_url": "", "default_title": "", "default_icon": "" } Allow extension to access experimental.sidebar API only in presence of this section. BUG=51084 TEST=unit_tests, ExtensionManifestTest.Sidebar Review URL: http://codereview.chromium.org/6321006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71993 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded chrome/browser/prefs/pref_service.h usage.thestig@chromium.org2011-01-151-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6335001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71547 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of pref_names.hthestig@chromium.org2011-01-131-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6122006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71283 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the stubbed out headers in chrome/browser/views.msw@chromium.org2011-01-101-2/+2
| | | | | | | | | | | | | | | | | Update references to use headers in chrome/browser/ui/views. Update copyright dates in affected files. /chrome/browser/ui/views/constrained_html_delegate_win.cc Add space before 'private' label (presubmit warning) /chrome/browser/ui/views/toolbar_view.cc Add space before 'cleanup' label (presubmit warning) BUG=69082 TEST=Compiling... Review URL: http://codereview.chromium.org/6204002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70965 0039d316-1c4b-4281-b951-d872f2087c98
* Plumbing load progress notifications to the TabContents.jcivelli@chromium.org2010-12-161-1/+0
| | | | | | | | | | | Also restoring the implementation of RenderView::SetReportLoadProgressEnabled that somehow went away when I synced before committing my previous CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/5925004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69461 0039d316-1c4b-4281-b951-d872f2087c98
* Even more virtual method deinlining.erg@google.com2010-12-132-1/+6
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5741001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69041 0039d316-1c4b-4281-b951-d872f2087c98
* interactive_ui_tests, SidebarTest.SidebarNavigate test fixed:alekseys@chromium.org2010-12-091-10/+4
| | | | | | | | | | | | - test HTTP server was never started, starting it now; - added missing test resource, simple_page.html; BUG=57964 TEST=interactive_ui_tests, SidebarTest.SidebarNavigate should not hang Review URL: http://codereview.chromium.org/5736001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68782 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-021-1/+1
| | | | | | | | | | | | | | | file_path_watcher into subdir profile* into profiles/ subdir login* into ui/login visitedlink* into subdir BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix a bad override.jhawkins@chromium.org2010-11-191-1/+1
| | | | | | | | | | | | | I tried to fix this before, but accidentally left off the const pointer parameter. CID=13619 BUG=none TEST=none Review URL: http://codereview.chromium.org/5129003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66725 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Include browser.h -> ui/browser.h [Part 2].jhawkins@chromium.org2010-11-161-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5046002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66229 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix bad overrides.jhawkins@chromium.org2010-11-061-1/+1
| | | | | | | | | | CID=12682,13411 BUG=none TEST=none Review URL: http://codereview.chromium.org/4549003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65301 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: More dtor deinlining. (Can almost see the end!)erg@google.com2010-10-222-12/+12
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3962004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63527 0039d316-1c4b-4281-b951-d872f2087c98
* Disable test SidebarTest.SidebarNavigate as it times out on windows.satish@chromium.org2010-10-051-1/+7
| | | | | | | | BUG=57964 TEST=none TBR=brettw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61505 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SessionStoragejorlow@chromium.org2010-09-141-1/+1
| | | | | | | | | | | | | | | Apparently the session storage code was pretty horribly broken. It didn't correctly handle tabs being restored, didn't have the proper lifetime (this was the issue exposed in the bug), and had many leaks. To fix this, things had to be plumbed fairly differently. We need to pass session storage in on TabContents creation to ensure that the first RenderView will have the correct session storage id. When closing a tab, we need to save the session storage with the restoration service. When restoring a tab, we pass it back into the tab contents class. When duplicating a tab, we clone the storage. Lifetimes are now handled by standard reference counting code. A SessionStorageNamespace object wraps an ID. When it's instantiated, it allocates an ID. When it's destroyed, it deletes the ID. IDs make this process very lightweight (the heavyweight stuff is allocated on first use of SessionStorage) and it seperates the more complex lifetimes of SessionStorage namespaces (where less deterministic shutdown is more tollerable) from the LocalStorage namespace which needs to shutdown very precisely. BUG=52393 TEST=Set some variable on session storage; close the tab; re-open the tab; the variable should still be set. You can also run through the repro steps in the bug. Review URL: http://codereview.chromium.org/3325012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59350 0039d316-1c4b-4281-b951-d872f2087c98
* Unify sidebar identification in the chrome.experimental.sidebar extension ↵aa@chromium.org2010-08-313-12/+4
| | | | | | | | | | | | API implementation. BUG=51084 TEST=Run interactive_ui_tests and browser_tests. Review URL: http://codereview.chromium.org/3212005 Patch from Aleksey Shlyapnikov <alekseys@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57965 0039d316-1c4b-4281-b951-d872f2087c98
* Move prefs-related files under chrome/browser/ into a prefs/ subdir.evan@chromium.org2010-08-261-1/+1
| | | | | | | | | | | | Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding a previous CL (I fixed the ChromeOS build):jcivelli@chromium.org2010-08-231-0/+1
| | | | | | | | | | | | | | | Making window.focus()/blur() work only when there is a user gesture. Also making window.focus() select tab if it is not visible. The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed). TBR=darin,sky BUG=29643,52346 TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab. Review URL: http://codereview.chromium.org/3174030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57124 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 57094 - Making window.focus()/blur() work only when there is a user ↵jcivelli@chromium.org2010-08-231-1/+0
| | | | | | | | | | | | | | | | | gesture. Also making window.focus() select tab if it is not visible. The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed). BUG=29643,52346 TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab. Review URL: http://codereview.chromium.org/3156016 TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/3201008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57105 0039d316-1c4b-4281-b951-d872f2087c98
* Making window.focus()/blur() work only when there is a user gesture.jcivelli@chromium.org2010-08-231-0/+1
| | | | | | | | | | | | Also making window.focus() select tab if it is not visible. The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed). BUG=29643,52346 TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab. Review URL: http://codereview.chromium.org/3156016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57094 0039d316-1c4b-4281-b951-d872f2087c98
* FBTB: Remove unneeded #includes of base/ref_counted.h and base/string16.h in ↵viettrungluu@chromium.org2010-08-201-1/+0
| | | | | | | | | | | src/chrome. BUG=23581 TEST=builds Review URL: http://codereview.chromium.org/3181028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56874 0039d316-1c4b-4281-b951-d872f2087c98
* Initial version of chrome.experimental.sidebar extension API. brettw@chromium.org2010-08-195-0/+870
BUG=51084 TEST=Run interactive_ui_tests and browser_tests. New: - sidebar Extension API (design doc: https://docs.google.com/a/google.com/Doc?docid=0AV4Qg3xyZ8RQZGZtbWIydDJfNWc0eHJtbmRm&hl=en); - Sidebar panel in Chrome browser view; Original review=http://codereview.chromium.org/2836040/show Patch by alekseys@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56716 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-30 01:02:56 +0000