summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui
Commit message (Collapse)AuthorAgeFilesLines
* Disable some panel testsjam@chromium.org2011-12-211-2/+4
| | | | | | | | BUG=108357 TBR=jennb Review URL: http://codereview.chromium.org/9020032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115431 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 115346. The change didn't break anything, the test was faulty. Will ↵jam@chromium.org2011-12-2149-158/+162
| | | | | | | | | | | | | | | | | | | | disable in a followup. - Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 TBR=thakis@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115428 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor a couple tab helpers so they aren't dependent on TabContentsWrapper,mpcomplete@chromium.org2011-12-214-18/+24
| | | | | | | | | | | | | | so they also can be used by ExtensionHost. I did this for RestoreTabHelper too, but realized it wasn't a great fit for ExtensionHost. It still seemed like a good decoupling, so I kept the refactor. BUG=84146 TEST=no Review URL: http://codereview.chromium.org/9007034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115411 0039d316-1c4b-4281-b951-d872f2087c98
* Allow keyboard shortcuts on interstitial pages.mattm@chromium.org2011-12-212-2/+75
| | | | | | | | | | BUG=98430 TEST=open https URL with invalid cert or URL on safebrowsing list, try to use keyboard shortcuts on interstitial page (ctrl-w, ctrl-t, etc). Print, save, view-source should be disabled. Review URL: http://codereview.chromium.org/8430023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115409 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity; Fixing pass by value bugs.dpapad@chromium.org2011-12-211-1/+1
| | | | | | | | | | | CID=101466, 101464, 101494, 101495, 101496, 101497 BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/8956046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115399 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Remove includes of base.bind in header files.jhawkins@chromium.org2011-12-212-6/+7
| | | | | | | | | | BUG=none TEST=none R=ajwong Review URL: http://codereview.chromium.org/8956019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115398 0039d316-1c4b-4281-b951-d872f2087c98
* Delete meabodenha@chromium.org2011-12-215-124/+171
| | | | | | | | | | | | | | Localize Google Cloud Print in strings. Change UI interaction points to reference connector instead of proxy. Fix strings for connector in options to be more clearly about the connector. BUG=107252,107592 TEST= Review URL: http://codereview.chromium.org/8936013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115396 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 115379 - Aura: Fix maximized windows not restoring properly.dmazzoni@chromium.org2011-12-213-42/+2
| | | | | | | | | | | | | | | We needed to handle the case that the restored bounds are identical to the maximized bounds, by forcing a Layout() when the show state changes. BUG=108073 TEST=manual, you can maximize and restore windows under Aura Review URL: http://codereview.chromium.org/9006029 TBR=jamescook@chromium.org Review URL: http://codereview.chromium.org/8999022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115387 0039d316-1c4b-4281-b951-d872f2087c98
* Rename IntentsHost -> WebIntentsDispatcher and IntentsDispatcher -> ↵gbillock@chromium.org2011-12-215-28/+31
| | | | | | | | | | | | | WebIntentsHost. R=jhawkins@chromium.org,jam@chromium.org BUG=104980 TEST=WebIntentPickerControllerBrowsertest Review URL: http://codereview.chromium.org/8934011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115385 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new ctor to CanvasSkia that takes a const SkBitmap&.tfarina@chromium.org2011-12-213-10/+3
| | | | | | | | | | BUG=100898 R=pkasting@chromium.org TBR=ben@chromium.org Review URL: http://codereview.chromium.org/9006001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115384 0039d316-1c4b-4281-b951-d872f2087c98
* Aura: Fix maximized windows not restoring properly.jamescook@chromium.org2011-12-213-2/+42
| | | | | | | | | | | | We needed to handle the case that the restored bounds are identical to the maximized bounds, by forcing a Layout() when the show state changes. BUG=108073 TEST=manual, you can maximize and restore windows under Aura Review URL: http://codereview.chromium.org/9006029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115379 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix the 10.6 SDK build that was broken by r115270.rsesek@chromium.org2011-12-211-1/+2
| | | | | | | | | BUG=none TEST=Compile with mac_sdk=10.6 Review URL: http://codereview.chromium.org/9021023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115352 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_teststhakis@chromium.org2011-12-2149-162/+158
| | | | | | | | | | | | | | | | on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115346 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Prevent NULL dereference of |active_plugin| in ↵thestig@chromium.org2011-12-211-1/+3
| | | | | | | | | | | | PluginsDOMHandler::PluginsLoaded(). CID=101665 BUG=none TEST=none Review URL: http://codereview.chromium.org/9015001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115340 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 115297 - Add overflow indicator count on Windows.peter@chromium.org2011-12-2113-860/+46
| | | | | | | | | | | | | | | Broke compilation on "Linux ChromiumOS Builder (Aura dbg)" BUG=none TEST=none Review URL: http://codereview.chromium.org/8953040 TBR=jianli@chromium.org Review URL: http://codereview.chromium.org/8949035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115301 0039d316-1c4b-4281-b951-d872f2087c98
* Add overflow indicator count on Windows.jianli@chromium.org2011-12-2113-46/+860
| | | | | | | | | | BUG=none TEST=new tests Review URL: http://codereview.chromium.org/8953040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115297 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary DCHECK in panels. binji@chromium.org2011-12-211-1/+0
| | | | | | | | | | CID=102716 TEST=none Review URL: http://codereview.chromium.org/8965051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115288 0039d316-1c4b-4281-b951-d872f2087c98
* Moved all options2 files to the options2 namespace.binji@chromium.org2011-12-21111-385/+700
| | | | | | | | | | | Reland of http://codereview.chromium.org/8947010 BUG=100885 TEST=everything compiles Review URL: http://codereview.chromium.org/8999008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115281 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::view() to GetView() and put it in the WebContents interface.jam@chromium.org2011-12-2132-48/+48
| | | | | | | | BUG=98716 TBR=tburkard Review URL: http://codereview.chromium.org/8999005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115278 0039d316-1c4b-4281-b951-d872f2087c98
* add open sans font to the repo and use it for uber extensionsestade@chromium.org2011-12-211-0/+2
| | | | | | | | | BUG=100885 TEST=none Review URL: http://codereview.chromium.org/9006037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115277 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::controller() to GetController and put it into the ↵jam@chromium.org2011-12-2149-158/+162
| | | | | | | | | | WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115276 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Apps on the NTP failing to display.csharp@chromium.org2011-12-211-2/+2
| | | | | | | | | | | | | | This fixes the case where an app that we wish to display on the NTP has an invalid page index value, as well as adding the chrome web store app to the ordinal index (so that it gets a valid index value). BUG=107440 TEST=Users should be able to launch chrome and navigate to the apps panel on the NTP Review URL: http://codereview.chromium.org/8961016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115275 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'running glint' animation to 'draw attention' state of Panels on Mac.dimich@chromium.org2011-12-212-1/+108
| | | | | | | | | Experimental feature, to adjust later. The motivation is to increase visibility and ability to actually 'draw attention'. Simply changing the color of a static object is often missed by the users. Review URL: http://codereview.chromium.org/9008026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115270 0039d316-1c4b-4281-b951-d872f2087c98
* Move some SkColor constants from ResourceBundle to BrowserFrameView.tfarina@chromium.org2011-12-212-10/+18
| | | | | | | | | | NOTE: This is a TODO for beng@. R=ben@chromium.org Review URL: http://codereview.chromium.org/8992024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115263 0039d316-1c4b-4281-b951-d872f2087c98
* Create an API around PluginService and use it from Chrome.jam@chromium.org2011-12-219-9/+25
| | | | | | | BUG=98716 Review URL: http://codereview.chromium.org/9006036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115259 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Panels DCHECK when hovering over a minimized panel.jennb@chromium.org2011-12-211-2/+3
| | | | | | | | | | BUG=None TEST=hover over minimized panel, see title bar go up and down without crash Review URL: http://codereview.chromium.org/8992033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115256 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix a potential NULL dereference.thestig@chromium.org2011-12-211-1/+2
| | | | | | | | | | CID=102478 BUG=none TEST=none Review URL: http://codereview.chromium.org/9006019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115249 0039d316-1c4b-4281-b951-d872f2087c98
* [coverity] Eliminate potential null-dereference errors.csilv@chromium.org2011-12-211-5/+6
| | | | | | | | CID=14470,17698 BUG=none Review URL: http://codereview.chromium.org/9005023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115244 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2011-12-213-3/+7
| | | | | | | | | | | | | CID=6462,16392,16996,17268,100987,101018,102401,102417,102476,102484,102513 102546,102552,102567,102617,102674,102677,102678,102679,102681,102685, 102714,102750,102751,102781 BUG=none TEST=none R=groby Review URL: http://codereview.chromium.org/9005015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115234 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 115227 - Coverity: Initialize member variables.jhawkins@chromium.org2011-12-213-7/+3
| | | | | | | | | | | | | | | | CID=6462,16392,16996,17268,100987,101018,102401,102417,102476,102484,102513 102546,102552,102567,102617,102674,102677,102678,102679,102681,102685, 102714,102750,102751,102781 BUG=none TEST=none R=groby Review URL: http://codereview.chromium.org/9005015 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/8965062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115228 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2011-12-203-3/+7
| | | | | | | | | | | | | CID=6462,16392,16996,17268,100987,101018,102401,102417,102476,102484,102513 102546,102552,102567,102617,102674,102677,102678,102679,102681,102685, 102714,102750,102751,102781 BUG=none TEST=none R=groby Review URL: http://codereview.chromium.org/9005015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115227 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2011-12-202-3/+5
| | | | | | | | | | | | | CID=100356,100360,100368,100373,100374,100562,101529,101530,101536,101541, 101542,101595,101630,101685,101687,101689,101776,101812,101813,101854, 101861,101862,101871,101883,101886,101887,102034 BUG=none TEST=none R=binji Review URL: http://codereview.chromium.org/8965054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115225 0039d316-1c4b-4281-b951-d872f2087c98
* [Coverity] Fix pass by value for relatively large values.dbeam@chromium.org2011-12-202-4/+4
| | | | | | | | | | CID=101480 R=jhawkins@chromium.org Review URL: http://codereview.chromium.org/9004029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115224 0039d316-1c4b-4281-b951-d872f2087c98
* Change PanelSlideAnimation to derive from LinearAnimation instead of ↵prasadt@chromium.org2011-12-208-24/+43
| | | | | | | | | | | | | | | | | | | SlideAnimation. This fixes the following issues: - SlideAnimation is a reversible animation and thus not the right one for our purposes. - In PanelSlideAnimation we do our own computation of progress. By deriving from SlideAnimation we're applying our computations on top of Tween::EASE_OUT values instead of simple linear progress. In other words, the code does not currently match the intent. BUG=106887 TEST=Minimize animation should look different. Review URL: http://codereview.chromium.org/9006004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115222 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: change remove button to trash iconestade@chromium.org2011-12-201-0/+3
| | | | | | | | | | | this also moves reusable CSS and HTML into shared/ so more places can continue using the trash code. BUG=107323 TEST=manual Review URL: http://codereview.chromium.org/9005003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115218 0039d316-1c4b-4281-b951-d872f2087c98
* Move TabContentsDelegate to content/public/browser and put it in the content ↵tfarina@chromium.org2011-12-2027-61/+65
| | | | | | | | | | | | | | namespace. - Rename TabContentsDelegate to WebContentsDelegate and move it to web_contents_delegate.* BUG=98716,105875 R=jam@chromium.org TBR=avi@chromium.org Review URL: http://codereview.chromium.org/9008013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115213 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Copy/Paste from Omnibox should restore http://varunjain@chromium.org2011-12-202-0/+44
| | | | | | | | | | BUG=104333 TEST=none Review URL: http://codereview.chromium.org/8996015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115207 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::render_view_host() to GetRenderViewHost and put it into ↵jam@chromium.org2011-12-2046-122/+119
| | | | | | | | | the WebContents interface. BUG=98716 Review URL: http://codereview.chromium.org/9007026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115200 0039d316-1c4b-4281-b951-d872f2087c98
* Rename touchpad_settings.* to input_device_settings.*achuith@chromium.org2011-12-202-2/+2
| | | | | | | | | BUG=chromium-os:22305 TEST=compiles. Review URL: http://codereview.chromium.org/9004033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115199 0039d316-1c4b-4281-b951-d872f2087c98
* Add HTTP pipelining to net-internals:simonjam@chromium.org2011-12-201-0/+59
| | | | | | | | | | | | | | | - Make HttpPipelinedConnection its own NetLog::Source - Report when pipelines are constructed and deleted - Report pipelining feedback - Add a HTTP Pipelining tab with status, active pipelines, and known hosts. BUG=None TEST=chrome://net-internals Review URL: http://codereview.chromium.org/8947012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115197 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ui::EventFlags mouse flags to be more sensibledhollowa@chromium.org2011-12-208-36/+36
| | | | | | | | | | | | | | | | Changes EF_(LEFT|MIDDLE|RIGHT)_BUTTON_DOWN to EF_(LEF|MIDDLE|RIGHT)_MOUSE_BUTTON since these are not specific to "down" button events. This is follow up from review http://codereview.chromium.org/8953037 BUG=none TEST=Compiles. R=ben@chromium.org Review URL: http://codereview.chromium.org/9007016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115188 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tab click/tooltip to utilize the correct tabadinardi@chromium.org2011-12-206-19/+207
| | | | | | | | | | | | | | | | | | | | Clicking on the overlapping tab area will now activate the highlighted tab (instead of either one). The tooltip displayed in the overlapping area will be the title of the tab which is highlighted. This is achieved by moving the tool tip regions out of the overlapping tabs and in to the tab strip. Overlapping NSViews & tool tips are apparently buggy in Cocoa. BUG=21911 TEST=Hover/click on overlapping areas in the tab strip and see that the correct tab is activated / title is shown. Review URL: http://codereview.chromium.org/8912013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115186 0039d316-1c4b-4281-b951-d872f2087c98
* Really forward declare FullscreenController in browser.htfarina@chromium.org2011-12-203-19/+19
| | | | | | | | | | | | This is a follow up to crrev.com/110886 BUG=100682 R=pkasting@chromium.org TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/9008003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115184 0039d316-1c4b-4281-b951-d872f2087c98
* Shell related switches -> aura shell switches.ben@chromium.org2011-12-203-9/+9
| | | | | | | | | | | | Aura client window properties->client namespace. Move WindowType to client. BUG=none TEST=existing automation TBR=sky Review URL: http://codereview.chromium.org/8968022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115182 0039d316-1c4b-4281-b951-d872f2087c98
* [Coverity] fix REVERSE_INULLs in chrome/browser/ui/webui/about_ui.ccdbeam@chromium.org2011-12-201-4/+7
| | | | | | | | | | | CID=102550 CID=102554 R=binji@chromium.org Review URL: http://codereview.chromium.org/8956036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115180 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114953 (breaks cros font sizes, etc.) - specify locale-dependent font ↵msw@chromium.org2011-12-201-1/+1
| | | | | | | | | | | | | | list for UI on ChromeOS, so that those fonts have higher priority over the fallback fonts Pango picks up. BUG=103860 TEST=build aura, start chromium in 'ar' locale. type in Arabic and check the Arabic text's shapes. remove IDS_UI_FONT_FAMILY_CROS from 'ar' resource file, build aura again, start chromium in 'ar', type in Arabic and the Arabic text's shapes should be different. Review URL: http://codereview.chromium.org/8770034 TBR=xji@chromium.org Review URL: http://codereview.chromium.org/9007028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115179 0039d316-1c4b-4281-b951-d872f2087c98
* Rename DownloadItem::BrowserContext to GetBrowserContext, to match other ↵jam@chromium.org2011-12-201-4/+4
| | | | | | | | getters in interfaces. This also comes up because without the Get, we have a redundant "content::" in the interface. Review URL: http://codereview.chromium.org/9006013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115169 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Show navigational history in the History menu, rather than most visited.rsesek@chromium.org2011-12-204-46/+47
| | | | | | | | | | | | | | XIB changes: * Move visited below recently closed. * Update menu item tags to match .h. BUG=62111 TEST=Navigate to three sites and they all appear in the History menu under "Recently Visited". Selecting one navigates to that site. Review URL: http://codereview.chromium.org/9005012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115167 0039d316-1c4b-4281-b951-d872f2087c98
* Move UMA logging from sync_setup_handler to sync_setup_flowrsimha@chromium.org2011-12-203-257/+0
| | | | | | | | | | | | | | | | | | | | | | During sync setup, we do UMA logging for the choices made by a user during configuration, to glean data on what types were enabled, whether a passphrase was entered, etc. This logging is currently being done in sync_setup_handler. It turns out that when a user signs in via the sync promo, the code path that follows bypasses sync_setup_handler and directly calls into the OnUserConfigured API in sync_setup_flow. Therefore, it makes sense to do UMA logging there, so that sign ins due to the promo are also logged. This patch moves around the UMA logging so that promo sign ins are included. BUG=107928 TEST=sign in to chrome via the sync promo and via the preferences ui; look at histograms. Review URL: http://codereview.chromium.org/8962008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115153 0039d316-1c4b-4281-b951-d872f2087c98
* Add button to about:net-internals to stop capturing events.mmenke@chromium.org2011-12-201-1/+6
| | | | | | | | | | | | Also move a couple buttons up to the status view at the top and split off the status view into its own files. BUG=106855 TEST=NetInternalsTest.NetInternalsStopCapturing Review URL: http://codereview.chromium.org/8974018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115143 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-04-02 10:47:22 +0000