| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:1 of https://codereview.chromium.org/1818423003/ )
Reason for revert:
Reland original patch, it was not the cause
Original issue's description:
> Revert of Remove configuration policy from chrome build files. (patchset #4 id:60001 of https://codereview.chromium.org/1798273002/ )
>
> Reason for revert:
> Speculative revert: could have caused the Win8 GN build failures. See crbug.com/597032
>
> Original issue's description:
> > Remove configuration policy from chrome build files.
> >
> > The define was removed from src/chrome source files in https://codereview.chromium.org/1786263002/, this patch only touches the build files in src/chrome. Build updates outside of this directory will be updated in subsequent passes.
> >
> > BUG=594261
> >
> > Committed: https://crrev.com/db234c06ff6c308520594591fa54f80b08411888
> > Cr-Commit-Position: refs/heads/master@{#382614}
>
> TBR=atwilson@chromium.org,brettw@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=594261
>
> Committed: https://crrev.com/e742862f9555579e3239d9658766081ac4729e92
> Cr-Commit-Position: refs/heads/master@{#382681}
TBR=atwilson@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=594261
Review URL: https://codereview.chromium.org/1825603003
Cr-Commit-Position: refs/heads/master@{#382689}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:60001 of https://codereview.chromium.org/1798273002/ )
Reason for revert:
Speculative revert: could have caused the Win8 GN build failures. See crbug.com/597032
Original issue's description:
> Remove configuration policy from chrome build files.
>
> The define was removed from src/chrome source files in https://codereview.chromium.org/1786263002/, this patch only touches the build files in src/chrome. Build updates outside of this directory will be updated in subsequent passes.
>
> BUG=594261
>
> Committed: https://crrev.com/db234c06ff6c308520594591fa54f80b08411888
> Cr-Commit-Position: refs/heads/master@{#382614}
TBR=atwilson@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=594261
Review URL: https://codereview.chromium.org/1818423003
Cr-Commit-Position: refs/heads/master@{#382681}
|
|
|
|
|
|
|
|
|
|
| |
The define was removed from src/chrome source files in https://codereview.chromium.org/1786263002/, this patch only touches the build files in src/chrome. Build updates outside of this directory will be updated in subsequent passes.
BUG=594261
Review URL: https://codereview.chromium.org/1798273002
Cr-Commit-Position: refs/heads/master@{#382614}
|
|
|
|
|
|
|
|
| |
BUG=595168
Review URL: https://codereview.chromium.org/1806723003
Cr-Commit-Position: refs/heads/master@{#381591}
|
|
|
|
|
|
|
|
|
|
|
|
| |
easyUnlockProximityRequired might still be used by someone, but it looks like
the rest of this API can be removed.
BUG=593166
TBR=erg@chromium.org (profiles/ pref change reviewed by gab@)
Review URL: https://codereview.chromium.org/1776373002
Cr-Commit-Position: refs/heads/master@{#381278}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ActiveScriptController will control more than just active scripts (e.g.,
webRequests), so calling it that doesn't really make sense. Rename to
ExtensionActionExecutor.
BUG=
Review URL: https://codereview.chromium.org/1804753002
Cr-Commit-Position: refs/heads/master@{#381276}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL migrates the dependency of the ProcessesAPIs to the new task manager
implementation.
The API of the process info has been fixed, since processes don't have titles, instead we added a list of tasks running in that process, with their titles and optional tab IDs.
BUG=525201,591581
TEST=browser_tests --gtest_filter=ProcessesApiTest.*
Review URL: https://codereview.chromium.org/1584473004
Cr-Commit-Position: refs/heads/master@{#380696}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Converts defining the chrome.processes API from JSON to IDL. This is the first step
in migrating the API to the new task manager.
BUG=525201,346990
TEST=browser_tests --gtest_filter=ProcessesApiTest.*
Review URL: https://codereview.chromium.org/1716403002
Cr-Commit-Position: refs/heads/master@{#378855}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The chrome.location API has been enabled on dev-channel only for 2.5+ years. It's
time for it to go. Extensions should use open-web alternatives to get the
location.
BUG=586560
Review URL: https://codereview.chromium.org/1736423002
Cr-Commit-Position: refs/heads/master@{#378819}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It moves from c/b/apps as it can be reused more generally across
//chrome/browser. It works with the new KeepAliveRegistry which is
the class keeping all the relevant information in an accessible place.
This patch also reuses ScopedKeepAlive instead of
c/b/ui/views/AutoKeepAlive
BUG=587926
Review URL: https://codereview.chromium.org/1708343002
Cr-Commit-Position: refs/heads/master@{#377913}
|
|
|
|
|
|
|
|
| |
BUG=588189
Review URL: https://codereview.chromium.org/1688333002
Cr-Commit-Position: refs/heads/master@{#377720}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The change introduces a "include_directories" entry in the manifest
file for file_handlers. In case the value is true, the file handler
becomes a generic handler and adds the given extension to the right
click menu.
BUG=415897
R=mtomasz@chromium.org
Review URL: https://codereview.chromium.org/1407473003
Cr-Commit-Position: refs/heads/master@{#377467}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=586142
TEST=Dragged Arc app icon from app laucher to shelf. It is
icon appear on shelf toolbar. Enable/Disable Android
apps in Chrome::Settings. Icons in shelf updated
accordingly state of ARC.
TEST=extended unit_tests
Review URL: https://codereview.chromium.org/1689963002
Cr-Commit-Position: refs/heads/master@{#376343}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=585324
TEST=Manually tested with different combination of signed
profiles and ARC optin state. OptIn dialog does not
show multiply profile and auth code can be fetched.
Once fetched authority code remains in cookies and
can be used on next signin.
Review URL: https://codereview.chromium.org/1681813003
Cr-Commit-Position: refs/heads/master@{#375775}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With click-to-script turned on, webRequest needs to respect tab-specific
permissions so that when the user grants access to a tab, the extension can
operate on it. In order to do this, we also need access to the tab id on the
IO thread.
Add the tab id to the ExtensionApiFrameIdMap, and check for it in the webRequest
api. For now, don't do anything if the frame isn't cached - that'll come later.
This also doesn't hook webRequest into requesting permissions - that's next.
BUG=460306
Review URL: https://codereview.chromium.org/1687913002
Cr-Commit-Position: refs/heads/master@{#375036}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Was only required for different |HostDesktopType|s which are being
removed.
R=benwells@chromium.org
BUG=558054
Review URL: https://codereview.chromium.org/1682183002
Cr-Commit-Position: refs/heads/master@{#374789}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Those resources are used by ToolbarModelImpl so move them to
//components in order to allow sharing the code with iOS too.
Upstream iOS specific images for IDR_OMNIBOX_HTTPS_{VALID,INVALID}
(they are different from other platforms).
TBR=sky@chromium.org
BUG=582921
Review URL: https://codereview.chromium.org/1651843003
Cr-Commit-Position: refs/heads/master@{#373205}
|
|
|
|
|
|
|
|
| |
BUG=NONE
Review URL: https://codereview.chromium.org/1551423003
Cr-Commit-Position: refs/heads/master@{#372106}
|
|
|
|
|
|
|
|
| |
BUG=580184
Review URL: https://codereview.chromium.org/1630513002
Cr-Commit-Position: refs/heads/master@{#371259}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is enabled.
Existing Cast extension users will see the Cast component action in the toolbar. Media Router users who later install the Cast extension will have the extension auto-unloaded and the component action added to the toolbar.
Adds MIGRATED_TO_COMPONENT extension unload reason, to track when the Cast extension was unloaded because the Media Router was enabled.
Note that there are two public Cast extensions and this design handles both.
BUG=537289
TESTING=Unit tests and manual tests of extension install flows with MR enabled and disabled
Review URL: https://codereview.chromium.org/1368303003
Cr-Commit-Position: refs/heads/master@{#369217}
|
|
|
|
|
|
|
|
|
|
|
| |
As Chrome desktop needs not to provide system level IME switching UI, the InputImeEventRouter and InputImeAPI related functions are different on Chrome OS and non Chrome OS. Thus, class extensions::InputImeEventRouterBase is added to reuse the common codes, and implementation of InputImeAPI functions are divided into input_ime_api_chromos.cc/input_ime_api_nonchromeos.cc.
BUG=517773
TEST=Verified bug not repro on local build.
Review URL: https://codereview.chromium.org/1570723002
Cr-Commit-Position: refs/heads/master@{#368784}
|
|
|
|
|
|
|
|
| |
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1554563002
Cr-Commit-Position: refs/heads/master@{#367872}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/1482643002/ )
Reason for revert:
We dont need to support Aura Android at current stage. Revert related code.
Original issue's description:
> Exclude some extension apis for Aura Android
>
> Extension is not supported for Aura Android yet. So exclude some of them
> to avoid pull unnecessary dependancy.
>
> BUG=548797
>
> Committed: https://crrev.com/72e623ac3ef6cdc9d2323361eebe6f6a320a4b93
> Cr-Commit-Position: refs/heads/master@{#362978}
TBR=finnur@chromium.org,mfomitchev@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=548797
Review URL: https://codereview.chromium.org/1558263002
Cr-Commit-Position: refs/heads/master@{#367602}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this change, we only show one error item at a time.
In order to show multiple items in the menu, we need to generate different
menu item ids for them (opposed to static IDC_EXTERNAL_EXTENSION_ALERT).
ExtensionDisabledUI already had support for this and I've refactored the code to
make menu item generation code also available to the install error classes:
ExternalInstall{Menu,Bubble}Alert.
This CL extracted from windows registry observer to install extension change:
http://crrev.com/1516103005.
BUG=
Review URL: https://codereview.chromium.org/1524383002
Cr-Commit-Position: refs/heads/master@{#367469}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome.input.ime.* APIs on windows and linux.
See the step 1 in: https://codereview.chromium.org/1403543004/
See the step 2 in: https://codereview.chromium.org/1419593002/
Main changes:
1. Update the entry in _permission_features.json and gypi file to make IME APIs accessible under chromeos, windows and linux platforms.
2. Add "platforms" attribute in input_ime.json, to reuse the ChromeOS APIs: chrome.input.ime.setComposition, .commitText, .sendKeyEvents, .keyEventHandled, .deleteSurroundingText, .onFocus, onBlur, .onKeyEvent, .onReset, .onDeactivated;
And keep other APIs ChromeOS only: chrome.input.ime.clearComposition, .hideInputView, .setCandidateWindowProperties, setCandidates, .setCursorPosition, .setMenumItems, updateMenuItems, .onActivate, .onInputContexUpdate, .onCandidateClicked, onMenuItemActivated, onSurroundingTextChanged.
3. Add flag "enable-input-ime-api" to enable chrome.input.ime API on Linux and Win.
Update input_ime_api.cc as API implementation on Linux and Win.
And add two kinds of errors: kErrorAPINotImplemented/ kErrorAPIDisabled to indicate whether this API is disabled.
4. Add new file input_ime_api_chromeos.cc for chromeos specific
implementation of the input_ime API.
BUG=517773
TEST=No compiling errors.
Review URL: https://codereview.chromium.org/1418643007
Cr-Commit-Position: refs/heads/master@{#363975}
|
|
|
|
|
|
|
|
| |
BUG=517735
Review URL: https://codereview.chromium.org/1497193002
Cr-Commit-Position: refs/heads/master@{#363918}
|
|
|
|
|
|
|
|
|
|
|
| |
Extension is not supported for Aura Android yet. So exclude some of them
to avoid pull unnecessary dependancy.
BUG=548797
Review URL: https://codereview.chromium.org/1482643002
Cr-Commit-Position: refs/heads/master@{#362978}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Reland of https://codereview.chromium.org/1475513006/
Reland of https://codereview.chromium.org/1458653002/
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/1469383005
Cr-Commit-Position: refs/heads/master@{#361854}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:20001 of https://codereview.chromium.org/1475513006/ )
Reason for revert:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/69779/steps/compile/logs/stdio
Original issue's description:
> New build flag system, convert Google Now flag
>
> This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
>
> Converts Google Now to use this and remove the global google now define and grit define.
>
> Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
>
> Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
>
> Reland of https://codereview.chromium.org/1458653002/
> TBR=mark@chromium.org
>
> Committed: https://crrev.com/cbc1cd295bc85219ad89326457cd7f5cf003d41c
> Cr-Commit-Position: refs/heads/master@{#361741}
TBR=mark@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1480693003
Cr-Commit-Position: refs/heads/master@{#361749}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Reland of https://codereview.chromium.org/1458653002/
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/1475513006
Cr-Commit-Position: refs/heads/master@{#361741}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:260001 of https://codereview.chromium.org/1458653002/ )
Reason for revert:
This seems to have broken webkit builders: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/94668
Original issue's description:
> New build flag system, convert Google Now flag
>
> This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
>
> Converts Google Now to use this and remove the global google now define and grit define.
>
> Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
>
> Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
>
> Committed: https://crrev.com/3118dde528359280fa0cb3c6fc5b6323e834c514
> Cr-Commit-Position: refs/heads/master@{#361527}
TBR=mark@chromium.org,spang@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1475883002
Cr-Commit-Position: refs/heads/master@{#361541}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Review URL: https://codereview.chromium.org/1458653002
Cr-Commit-Position: refs/heads/master@{#361527}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL does a refactoring of the dependencies and do not change any
behavior. The diff between the ninja files is presented in link:
http://pastebin.com/aG6eq5cb.
The test_support_gpu.gypi included allocator.gyp for no reason, and the
only other target that uses this file is content_browsertests, which
already includes allocatpor.gyp with same conditions. So, removing
this dependency here.
target:browser_ui - depends on allocator.gyp in windows
targets that depend on browser_ui:
chrome_android_core: not used in windows
Dependency on allocator.gyp exists already for:
All, browser (explained below)
target:browser - depends on allocator.gyp in windows
targets that depend on browser:
chrome_android_core: only android
chromevox_tests: added dependency to allocator.gyp for windows
Dependency on allocator.gyp exists already for:
All, interactive_ui_tests, browser_tests, performance_browser_tests
chrome_main_dll, chrome_initial, unit_tests, chrome_app_unittests
test_support_sync_integration's executables:
sync_integration_tests, browser_tests, sync_performance_tests
test_support_common's executables:
interactive_ui_tests, browser_tests, performance_browser_tests
test_support_unit's executables:
unit_tests
target:renderer - depends and exports dependency on allocator.gyp in
windows
targets that depend on renderer:
chrome_android_core: not used in windows
chromevox_tests: added dependency to allocator.gyp for windows
chrome_child_dll - added dependency.
Dependency on allocator.gyp exists already for:
interactive_ui_tests, browser_tests, performance_browser_tests
sync_integration_tests, chrome_main_dll, chrome_initial, unit_tests
chrome_app_unittests
test_support_common - explained earlier.
target:browser_extensions - depends on allocator.gyp in windows
targets that depend on browser_extensions:
apps - browser (explained above)
browser_ui (explained above)
browser_chromeos
browser (explained above)
browser_tests
apps - browser (explained above)
target:web_cache_browser - depends on allocator.gyp in windows
All the targets that depend on web_cache_browser already have
dependency on allocator.gyp:
browser*, components_unittests
extensions_browser
extensions_unittests, browser_extensions*, apps*
media_router
browser_ui*, browser*, native_app_window - browser_ui*
javascript_dialog_extensions_client - browser_ui*
media_router_test_support
browser_tests, test_support_unit*, unit_tests
app_shell_lib
extensions_browsertests, app_shell, app_shell_unittests
extensions_test_support
extensions_unittests, extensions_browsertests, app_shell_unittests
test_support_common*
* - see previous sections for why it is fine for the target to not
depend on allocator.gyp
BUG=
Review URL: https://codereview.chromium.org/1462853002
Cr-Commit-Position: refs/heads/master@{#361381}
|
|
|
|
|
|
|
|
| |
BUG=548797
Review URL: https://codereview.chromium.org/1434663004
Cr-Commit-Position: refs/heads/master@{#360457}
|
|
|
|
|
|
|
|
|
|
|
| |
Code move only, no changes in logic.
PrivetV3ContextGetter is going to be used by gcd_private API
BUG=551631
Review URL: https://codereview.chromium.org/1435743004
Cr-Commit-Position: refs/heads/master@{#359209}
|
|
|
|
|
|
|
|
|
|
| |
This is only place where it should be used.
BUG=551631
Review URL: https://codereview.chromium.org/1427353002
Cr-Commit-Position: refs/heads/master@{#359026}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's confusing to have ExtensionMessageBubbleController have both a delegate
(with subclasses) and be subclassed itself. Remove the subclasses of
ExtensionMessageBubbleController (except tests), and have the delegates
determine the behavior.
BUG=
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/1424723004
Cr-Commit-Position: refs/heads/master@{#358198}
|
|
|
|
|
|
|
|
|
| |
We're no longer looking to add this functionality so remove the code.
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1416943002
Cr-Commit-Position: refs/heads/master@{#356879}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is another piece of work towards implementing differential
extensions update and share autoupdate code with the chrome components
system. It adds code to the extensions/browser directory that makes use
of the common autoupdate code via the update_client::UpdateClient class
to send update checks to the server, download a full .crx or
differential update, and hand back an unpacked directory with the
contents of the new extension version.
This CL does not yet add any code in chrome/ that actually uses these
new capabilities; that will be in a forthcoming CL.
BUG=490418
Review URL: https://codereview.chromium.org/1362043005
Cr-Commit-Position: refs/heads/master@{#354370}
|
|
|
|
|
|
|
|
|
|
| |
Click-to-script allows users to withhold all-hosts and all-hosts-like
permissions, but the code to do this is pretty staggered. Consolidate more of
it into a single class
Review URL: https://codereview.chromium.org/1397443011
Cr-Commit-Position: refs/heads/master@{#354271}
|
|
|
|
|
|
|
|
|
|
| |
Test code can still do this.
BUG=517735
Review URL: https://codereview.chromium.org/1395043002
Cr-Commit-Position: refs/heads/master@{#353904}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions::OffscreenPresentation and OffscreenPresentationsOwner were
originally intended to be used only for a private extension API called
by the Chrome Media Router extension. Since then, the stakeholders have
decided to issue a full publicly-visible off-screen tab extension API
(this landed about a week ago). This change simply renames two classes
and modifies some code comments to reflect their new larger-scoped
purpose.
BUG=480890
Review URL: https://codereview.chromium.org/1401473004
Cr-Commit-Position: refs/heads/master@{#353643}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move content specific stuff to content subdir.
KeyboardControllerProxy -> KeyboardUI
Restructure targets.
R=sky@chromium.org
http://crbug.com/332504
Review URL: https://codereview.chromium.org/1392713002
Cr-Commit-Position: refs/heads/master@{#353441}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The connection manager observe the connection events and dispatches them
to the JS API. The BLE connections are managed using the ApiResourceManager.
The EasyUnlockPrivateConnection is a wrapper for a
proximity_auth::Connection, and its lifetime is managed by the
ApiResourceManager.
BUG=528274
Review URL: https://codereview.chromium.org/1333343002
Cr-Commit-Position: refs/heads/master@{#349650}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ContentPredicateEvaluator interfaces
Creates interfaces for predicates and evaluators responsible for
tracking predicate state and evaluating predicates. Devolves predicate
state tracking from ChromeContentRulesRegistry to the relevant evaluator
subclasses, and extracts all the relevant interface functions from the
evaluator subclasses so that ChromeContentRulesRegistry operates only on
abstract types.
This is in support of steps 6-8 in the associated bug. No functional
change is intended.
BUG=492946
Review URL: https://codereview.chromium.org/1315233008
Cr-Commit-Position: refs/heads/master@{#349552}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This common API will allow the deduplication of several existing
getStrings APIs. This CL also replaces the existing
chrome.identityPrivate.getStrings API with the common API.
BUG=529546
NOPRESUBMIT=true
(Disabling to allow a rename in the histogram enum)
Review URL: https://codereview.chromium.org/1319293004
Cr-Commit-Position: refs/heads/master@{#349341}
|
|
|
|
|
|
|
|
|
|
|
| |
Nothing in chrome/ seems to be including from third_party/libevent.
BUG=None
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1334723003
Cr-Commit-Position: refs/heads/master@{#348414}
|
|
|
|
|
|
|
|
| |
BUG=514575
Review URL: https://codereview.chromium.org/1232553003
Cr-Commit-Position: refs/heads/master@{#347916}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
'registerAdvertisment' which is part of bluetoothLowEnergy will now
only work on auto-launched apps in kiosk mode. Since implementing
that change adds a dependency on chromeos::KioskAppManager we move
the API to chrome/
BUG=528066
Review URL: https://codereview.chromium.org/1315193018
Cr-Commit-Position: refs/heads/master@{#347558}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the native CryptAuth functionality in place, we can use the unlock keys
synced natively from Smart Lock rather than synced in the Chrome app.
The chrome.easyUnlockPrivate.getUnlockKey and
chrome.easyUnlockPrivate.getPermitAccess APIs will be overridden if the
kEnableBluetoothLowEnergyDiscovery switch is set.
BUG=512230
TEST=manual and unit test
Committed: https://crrev.com/f9d111d53cbdb4f4f8d65becc804c08db676a9ac
Cr-Commit-Position: refs/heads/master@{#346771}
Review URL: https://codereview.chromium.org/1318633002
Cr-Commit-Position: refs/heads/master@{#346995}
|