| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
It turned out that msftedit.dll is not available on some user environment. This patch set shows a warning dialog so that a user who is affected can work around this issue.
BUG=161034
TEST=Manually done on Windows 7.
Review URL: https://chromiumcodereview.appspot.com/11308112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
components/web_contents_delegate_android
Moving files, change namespace from content to components,
added/updated DEPS files, and fix builds
BUG=169312
Review URL: https://chromiumcodereview.appspot.com/11823046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are still some TODOs, but the basic mouse-based functionality is implemented.
As additional context: The stable version of the Autofill popup UI is currently implemented in the renderer process -- actually, as part of WebKit. It's implemented (cross-platform) as a heavily styled version of the <select> popup that we use on non-Mac platforms. This CL implements this same popup as a native UI, to reach parity with GTK and Views.
BUG=51644
Review URL: https://chromiumcodereview.appspot.com/11740033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds to AutofillDialogController:
- bool invoked_from_same_origin_;
- whether the top frame's origin matches the invoking frame's origin
- bool TransmissionWillBeSecure() const;
- whether the transmission of this data would (in theory) be secure
Adds the new file autofill_dialog_types.{h,cc} with all the simple structs/typedefs/classes and adds the class:
- DialogNotification, a simple struct for any type of notifications
- members:
- type (e.g. SECURITY_WARNING)
- display_text, text shown to user)
- GetBackgroundColor(), gets a background color for this type of notification
Adds to AutofillDialogView:
- UpdateNotificationArea() to the interface.
Adds to AutofillDialogViews:
- a bare bones notification area in the UI to show these notifications
- an implementation of UpdateNotificationArea()
Removes:
- stuff that's not in scope at the moment in the mocks
- SiteLabel(), not used anymore
- IntroText(), wasn't used anywhere
- GetIntroTextParts(), hopefully not used again
BUG=168685,163508
Review URL: https://codereview.chromium.org/11831002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
adding a method that creators can call to set a callback to filter requests.
BUG=169170
Review URL: https://codereview.chromium.org/11852005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change the omnibox popup draws a shadow at the bottom.
This is the Mac versoin of the ChromeOS CL:
https://codereview.chromium.org/11576042/
New with shadow: http://i.imgur.com/pkL38.png
Old, without shadow: http://i.imgur.com/k3r2t.png
BUG=162993
Review URL: https://chromiumcodereview.appspot.com/11821043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=168232
Review URL: https://chromiumcodereview.appspot.com/11744021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OS=="mac".
Moves ui/app_list code specific to toolkit-views to ui/app_list/views.
Update gyp[i], include guards, #includes for moved files.
Seed chrome/browser/ui/cocoa/app_list and ui/app_list/cocoa with a
skeleton Cocoa UI.
BUG=138633
TEST=Mostly build changes. Functionality of AppLauncher on ChromeOS
and Windows should be unchanged.
On OSX, without chrome running, `Chromium.app/Contents/MacOS/Chromium --show-app-list`
should show a borderless gray window for 1 second (note: this is for
testing only -- OSX needs a different approach for IPC).
Review URL: https://chromiumcodereview.appspot.com/11784034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- One for AppListControllerDelegate class.
- Other for the AppList - Init/Show functions.
R=xiyuan@chromium.org
TBR=sky@chromium.org # for trivial include updates
Review URL: https://codereview.chromium.org/11834002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to facilitate the move to MessageCenterNotificationManager, we
need to be able to determine when message_center.gyp is being included
in the build. This change defines ENABLE_MESSAGE_CENTER which can be
used for conditional compilation.
r=stevenjb@chromium.org
TBR=ben@chromium.org
BUG=168605
Review URL: https://chromiumcodereview.appspot.com/11791004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(SystemMenuModelBuilder) and makes BrowserFrame implementation use
it. BrowserFrame also provides support for showing the system menu via
views::MenuRunner. This is used everywhere but BrowserFrameWin and
BrowserDesktolpRootWindowHostWin. Both of these use the system menu.
BUG=none
TEST=make sure system menu (right click above tab strip) works on
windows and chromeos.
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11819008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=164772
R=pkasting@chromium.org,sail@chromium.org
TBR=ben@chromium.org # for file additions to gyp files
Review URL: https://codereview.chromium.org/11773025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extract the code from AppLauncherHandler into a ExtensionEnableFlow so that it
can be reused by app list and launcher bar.
BUG=157996
TEST=No change. Wait until app list/launcher code changes land to test.
R=estade@chromium.org,benwells@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11644077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
infobar delegate classes. Make constructors as private as possible.
This has several purposes:
* By preventing direct instantiation, it prevents callers from leaking if they create an infobar and don't add it to an InfoBarService.
* By moving decision-making about when to show infobars into these Create() functions, there's a pattern for where such code should go, and caller code becomes simpler and easier to read.
* The two bullets above together mean that for infobars which should only be displayed in certain circumstances, code can't accidentally bypass the decision logic.
* It enables us to eliminate a common InfoBarService* temp on the caller side since the caller no longer needs to both pass the pointer to the infobar _and_ call AddInfoBar() on the pointer. This was also a somewhat redundant-looking pattern.
* It makes it easier to change the ownership model for infobars in the future by limiting the affected callsites to only the Create() functions.
Note that right now, this still feels pretty redundant since we pass all the same args to Create() functions as constructors most times. In the new ownership model constructors will no longer need to take InfoBarService*s, which will make this better.
Additionally, this makes AddInfoBar()/ReplaceInfoBar() take scoped_ptr<>s to indicate they're receiving ownership. This sort of change is easy to make since we only need change the create functions.
This change also has a functional effect: it eliminates some cases where we tried to only show infobars when no other infobars were already showing (discussed and approved by Glen).
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11644059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change comboboxes to dropdown menus, per the latest mocks. Allow users to switch between manual entry and pre-fill modes.
lots of TODOs, but this seems like a good stopping point.
BUG=157270,157273
Review URL: https://chromiumcodereview.appspot.com/11743036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to chrome/browser/ui/sync/ (alongside the rest of the one_click_signin_xxx files).
BUG=none
TEST=none
TBR=sky
Review URL: https://codereview.chromium.org/11744015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And switch to the existing AlternateNavInfoBar[Delegate] classes.
BUG=164772
R=pkasting@chromium.org
TBR=ben@chromium.org
NOTRY=True # ios_dbg_simulator seems to be broken in lkgm?
Review URL: https://codereview.chromium.org/11721003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=168168,78283
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11742028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=150316
Review URL: https://chromiumcodereview.appspot.com/11743011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
object, and add it to gyp files on Windows.
TBR=sky@chromium.org
R=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11684003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/ui/views/location_bar/location_bar_view.cc
This CL systematizes location bar decoration layout. Decorations now simply need to be added to one of two lists (left and right-hand side).
The CL has been manually/visually tested in various configurations:
- With/without the action box
- With/without instant extended
- With/without touch optimized UI
The refactoring also solves a few minor bugs.
BUG=163820,166994,166997,167004
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11648024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=160500
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174450
Review URL: https://chromiumcodereview.appspot.com/11515005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebContentsModalDialog types (part 2). See https://codereview.chromium.org/11647017/ for part 1.
This performs the actual class/filename renames.
No functional changes are intended in this CL.
R=sky@chromium.org
BUG=157161
Review URL: https://chromiumcodereview.appspot.com/11633052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11697004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
start-up"
This broke browser_tests on win_rel. Please see the tryjob results in original CL.
TBR=caitkp@chromium.org
BUG=160500
TEST=none
Review URL: https://codereview.chromium.org/11659021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=160500
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11515005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ListSelectionModel. I plan on using it in TableView. I would have
liked to rename to SelectionModel, but there is already such a class
in ui/gfx.
BUG=none
TEST=none
R=sadrul@chromium.org
TBR=aa@chromium.org, avi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11618047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
only works for Billing data. Lots of TODOs still, but basic functionality is there.
also moved AutofillPopupDelegate to browser/ui/autofill/
BUG=164966
Review URL: https://codereview.chromium.org/11593025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is only an intermediate CL - trying to keep the CL's in a handle-able size.
The new features of the Launcher behavior are:
- Group running programs (V1, V2, Browsers) under existing launcher application icons.
- When a V2 app gets started and it is not pinned to the launcher, it will be added for it's lifetime to the launcher (and disappear after the last incarnation goes away).
- Each shown launcher entry can ...
+ .. show a context menu (right click) which can e.g. close all applications of that type.
+ .. activate or create such a type upon first click.
+ .. produce a list of running "apps" upon click when one of the applications has already a focus. [more to come]
+ .. [maybe] produce a fancy hover menu. (at the moment it produces the bubble help)
- The list of apps (as described above) contains ...
+ .. The name of the app itself.
+ .. For each running instance the favicon & the title & (not yet implemented:) an icon for incognito.
- The new features are behind a flag.
The full specification can be seen here:
https://docs.google.com/a/google.com/document/d/1i39rO8uERWwTvV0e0TDtelgGjzU9Wj5L6CldMl9y6lE/edit
This is the second CL for these new features, however there are still several things missing which will be addressed in more CL's:
- More unit tests (activation state tracking, V2 apps)
- The "eye candy menus" (mocks are still missing) ..
+ .. including incognito marker
+ .. a definition how the menus get sorted
+ .. the open question about click or hover menus
+ .. touch integration
- The browser icon should be movable as well
- Rip out old classes and unused complexity - which can only be done after the flag gets removed: At the moment, the changes are trying to stay within the existing architecture to make it possible to switch with a flag.
BUG=164438, 145410
Review URL: https://chromiumcodereview.appspot.com/11552028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Saves 140k in the final shared library (libchromeview.so)
- Fixes all plugin related link errors during component build of
content_shell_apk
BUG=158821, 162667
Review URL: https://chromiumcodereview.appspot.com/11615002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The intra-collection dragging logic that used to reside in DetachedPanelCollection and DockedPanelCollection has been moved to DockedPanelDragHandler and DetachedPanelDragHandler. The inter-collection dragging logic that used to reside in PanelDragController has been moved to DetachingDragHandler. Now PanelDragController is responsible for all the drags and it will figure out which drag handler to call in order to handle different kind of drags: dragging docked/detached panels, detaching, reattaching and future stacking and snapping.
TBR=thakis@chromium.org
BUG=none
TEST=existsing tests due to no new functionality
Review URL: https://chromiumcodereview.appspot.com/11475051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is almost just a dummy class.
BUG=none
TEST=none
TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11446052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
disabled or unavailable.
BUG=159289,142788,134946
Review URL: https://chromiumcodereview.appspot.com/11555033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove the "Flash camera and microphone" section from the content settings dialog;
- Add two links to the "Media" section to point to the Flash global and site-specific cam/mic settings. These links are not showed if the Flash settings are the same as the Chrome media settings.
TEST=manual + a new unittest.
BUG=159402
Review URL: https://chromiumcodereview.appspot.com/11553014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/11578032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This necessitated the relocation of the previous chrome::GrabWindowSnapshot code
to ui/snapshot, which has been turned into it's own component to avoid circular dependencies with aura.
A new variant of GrabWindowSnapshot, GrabViewSnapshot, has been added as well to facilitate easier usage by views. chrome::GrabWindowSnapshotForUser was left in place to accomodate existing calls
to the API, but now calls up to the ui/snapshot code.
This is a subset of the prior CL 11362023, which has been broken apart to facilitate easier reviews
BUG=157479
Review URL: https://chromiumcodereview.appspot.com/11399002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The legacy constrained window API has been removed. It's now safe to remove the "2" from the new constrained window API.
BUG=
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11568041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This code is disabled and safe to delete.
BUG=
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11567048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In r171176 I made the certificate selector dialog window modal. By popular demand we're going back to tab modal.
Instead of bringing back the legacy constrained window API I'm adding support for system dialogs to the new API. My implementation is very simple. All handling of the system dialog is done by a |ConstrainedWindowSystemSheetDelegate| delegate. The constrained window API only hides or unhides it as necessary.
BUG=140558
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11485020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=158086
Review URL: https://chromiumcodereview.appspot.com/11538011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before:
AutofillPopupViewViews extends AutofillPopupView
AutofillExternalDelegateViews extends AutofillExternalDelegate, and owns AutofillPopupViewViews
After:
AutofillPopupController owns AutofillPopupViewViews which implements AutofillPopupView interface
AutofillExternalDelegate implements AutofillPopupDelegate, and creates / interacts with AutofillPopupController (no platform subclasses for AutofillExternalDelegate)
no dependency of AutofillPopupView and subclasses on content/
BUG=164966
Review URL: https://codereview.chromium.org/11446077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=157161
Review URL: https://chromiumcodereview.appspot.com/11457006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=164672
Review URL: https://chromiumcodereview.appspot.com/11466005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
contains the changes related to the infobar.
The new design for the media infobar included in this patch:
# Use the confirm infobar for media, this will make the media infobar be consistent with other infobars in chrome like Geolocation.
# Remove the devices array in the media_stream_request since the infobar does not have a device dropdown any more.
# "Allow" will be sticky by default.
# Start using the device selection UI in the content settings.
Note, "Deny" is not sticky in this patch, it can't be done since the media code in content settings needs a big refactoring to handle the exceptions properly. It will be addressed in another CL.
BUG=163895
TEST=content_unittests, pyauto webrtc functional tests.
and manual tests like:
select a device via content setting media
go to https://webrtc-demos.appspot.com/html/pc1.html, and make a call.
Review URL: https://chromiumcodereview.appspot.com/11434084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The lack of type safety and the endless dispatching by
notification ID makes it a pretty bad interface.
So NotificationService is considered pretty evil and should be used in less
modules, not more.
This removes the chrome::NOTIFICATION_BOOKMARK_BUBBLE_SHOWN and chrome::NOTIFICATION_BOOKMARK_BUBBLE_HIDDEN notifications and adds a BookmarkBubbleViewDelegate interface to send those notifications instead.
BUG=144783
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11527011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Mac implementation of the password generation
(http://dev.chromium.org/developers/design-documents/password-generation).
Screenshot - http://oi49.tinypic.com/kcchz6.jpg
Windows UI (for comparison) - http://oi45.tinypic.com/51eauw.jpg
BUG=120776
Review URL: https://chromiumcodereview.appspot.com/11416047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The CL creates the top-level structure for showing Google Now cards in Chrome via Chrome Notifications.
The implementation lives behind -enable-google-now-integration flag.
BUG=164227
Review URL: https://chromiumcodereview.appspot.com/11412291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=thakis@chromium.org
BUG=none
TEST=existing tests due to no functionality change
Review URL: https://chromiumcodereview.appspot.com/11451025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new instant extended UI has its own UI to show omnibox results. This CL hides the normal Mac omnibox popup.
Note, after several hours of trying I gave up writing tests for this. The entire omnibox seems untestable. The only tests we have are in omnibox_view_browsertest.cc but they all seem disabled anyways.
BUG=164317
Review URL: https://chromiumcodereview.appspot.com/11438004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=125846
TEST=navigate to chrome://crash or open the Task Manager and end some process.
Both should work fine as before, no regressions
R=erg@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11316273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171471 0039d316-1c4b-4281-b951-d872f2087c98
|