| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This patch added code to display a chooser UI on Android for WebUsb.
BUG=591735
Review URL: https://codereview.chromium.org/1739523002
Cr-Commit-Position: refs/heads/master@{#383351}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an extension wants to inject scripts at document start or use webRequest,
it needs to act on the page before the page completes loading. This is a problem
with click-to-script, which makes extensions wait for user action. For now,
add a bubble that prompts the user to refresh the page in order to allow the
extension to run on the page if the user triggers it and it had blocked actions
that need to run at document_start.
BUG=460306
Review URL: https://codereview.chromium.org/1809813002
Cr-Commit-Position: refs/heads/master@{#382981}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:1 of https://codereview.chromium.org/1818423003/ )
Reason for revert:
Reland original patch, it was not the cause
Original issue's description:
> Revert of Remove configuration policy from chrome build files. (patchset #4 id:60001 of https://codereview.chromium.org/1798273002/ )
>
> Reason for revert:
> Speculative revert: could have caused the Win8 GN build failures. See crbug.com/597032
>
> Original issue's description:
> > Remove configuration policy from chrome build files.
> >
> > The define was removed from src/chrome source files in https://codereview.chromium.org/1786263002/, this patch only touches the build files in src/chrome. Build updates outside of this directory will be updated in subsequent passes.
> >
> > BUG=594261
> >
> > Committed: https://crrev.com/db234c06ff6c308520594591fa54f80b08411888
> > Cr-Commit-Position: refs/heads/master@{#382614}
>
> TBR=atwilson@chromium.org,brettw@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=594261
>
> Committed: https://crrev.com/e742862f9555579e3239d9658766081ac4729e92
> Cr-Commit-Position: refs/heads/master@{#382681}
TBR=atwilson@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=594261
Review URL: https://codereview.chromium.org/1825603003
Cr-Commit-Position: refs/heads/master@{#382689}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:60001 of https://codereview.chromium.org/1798273002/ )
Reason for revert:
Speculative revert: could have caused the Win8 GN build failures. See crbug.com/597032
Original issue's description:
> Remove configuration policy from chrome build files.
>
> The define was removed from src/chrome source files in https://codereview.chromium.org/1786263002/, this patch only touches the build files in src/chrome. Build updates outside of this directory will be updated in subsequent passes.
>
> BUG=594261
>
> Committed: https://crrev.com/db234c06ff6c308520594591fa54f80b08411888
> Cr-Commit-Position: refs/heads/master@{#382614}
TBR=atwilson@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=594261
Review URL: https://codereview.chromium.org/1818423003
Cr-Commit-Position: refs/heads/master@{#382681}
|
|
|
|
|
|
|
|
|
| |
R=dpapad@chromium.org
BUG=595779
Review URL: https://codereview.chromium.org/1814703004
Cr-Commit-Position: refs/heads/master@{#382637}
|
|
|
|
|
|
|
|
|
|
| |
The define was removed from src/chrome source files in https://codereview.chromium.org/1786263002/, this patch only touches the build files in src/chrome. Build updates outside of this directory will be updated in subsequent passes.
BUG=594261
Review URL: https://codereview.chromium.org/1798273002
Cr-Commit-Position: refs/heads/master@{#382614}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This deletes the majority of the code supporting chrome://memory
pages. There's still a little bit more of follow-up work to clean up
memory_details*.cc files, but those will require some changes to logic
and thus is better to do them in a separate CL.
BUG=588790,25454
Review URL: https://codereview.chromium.org/1722493002
Cr-Commit-Position: refs/heads/master@{#382198}
|
|
|
|
|
|
|
|
|
|
|
| |
Good riddance!
R=sky@chromium.org
BUG=558054
Review URL: https://codereview.chromium.org/1806813002
Cr-Commit-Position: refs/heads/master@{#382049}
|
|
|
|
|
|
|
|
|
|
| |
Part 2: Convert the site_list and site_settings_category.
BUG=543635
Review URL: https://codereview.chromium.org/1716253002
Cr-Commit-Position: refs/heads/master@{#381941}
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=595534
TEST=On device pin Arc app in shelf. Pin persistent across reboots
and order is kept. App is started once clicked on pinned item.
Uninstall app and pin is removed.
TEST=Extended unit_tests passes
Review URL: https://codereview.chromium.org/1808963002
Cr-Commit-Position: refs/heads/master@{#381806}
|
|
|
|
|
|
|
|
|
|
|
| |
//src/chrome code have not used auto_login_parser since r344922 ~half a
year ago. Remove the dependency.
BUG=
Review URL: https://codereview.chromium.org/1805923003
Cr-Commit-Position: refs/heads/master@{#381703}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL unpolymerizes the site engagement WebUI so it can be re-enabled
on Android where Polymer is not available for WebUI.
BUG=524857
Review URL: https://codereview.chromium.org/1758573002
Cr-Commit-Position: refs/heads/master@{#380939}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, move from class + static methods to simply namespaced methods.
Doesn't make much sense to have a static only class with more code and
longer identifiers, but I could be convinced if there's a reason.
R=dpapad@chromium.org
BUG=546844
Review URL: https://codereview.chromium.org/1789543003
Cr-Commit-Position: refs/heads/master@{#380765}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is because both:
* a 1-to-1 file-to-class model in more common in Chromium
* it's not clear that md_settings_ui.h bring in SettingsPageUIHandler
nor that it's a useful #include
R=dpapad@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/1778663007
Cr-Commit-Position: refs/heads/master@{#380667}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On windows GetLocalProcessWindowAtPoint can trigger a capture loss,
which can delete the TabDragController and lead to
use-after-free. This patch adds logic to deal with being deleted from
GetLocalProcessWindowAtPoint.
BUG=592850
TEST=covered by test
R=jonross@chromium.org
Review URL: https://codereview.chromium.org/1784903002
Cr-Commit-Position: refs/heads/master@{#380483}
|
|
|
|
|
|
|
|
| |
BUG=585312
Review URL: https://codereview.chromium.org/1759453002
Cr-Commit-Position: refs/heads/master@{#380411}
|
|
|
|
|
|
|
|
|
|
|
| |
- NewTabPageSyncHandler, none of who's messages are still used
- Obsolete statistics
BUG=329637
Review URL: https://codereview.chromium.org/1725363006
Cr-Commit-Position: refs/heads/master@{#380119}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Still need to:
* take an action when "Change proxy settings" is tapped
* show a "Restart" button for hardware acceleration to take effect
* write tests?
R=stevenjb@chromium.org
BUG=546844
Review URL: https://codereview.chromium.org/1775803002
Cr-Commit-Position: refs/heads/master@{#380059}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's a generic ToolbarActionsBarBubbleDelegate, but the view for the bubble
was linked to the ExtensionIconSurfacingBubble. There's no reason it has to be,
and this can be re-used for other bubbles that dangle off the toolbar. Make the
view more abstract (we already do this on mac), and add a few more tests for it.
Next step will be to use this in click-to-script work.
BUG=460306
Review URL: https://codereview.chromium.org/1771033002
Cr-Commit-Position: refs/heads/master@{#379936}
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Unify OobeDisplay::Screen and OobeUI::kScreen* into a new type-safe enum, OobeScreen, with static methods to convert to/from strings.
- Remove OobeDisplay class entirely, since it was only subclassed by OobeUI.
- Added ShowScreen and GetCurrentScreen to BaseScreenHandler, which unifies some duplicated methods.
BUG=539815
Review URL: https://codereview.chromium.org/1415203002
Cr-Commit-Position: refs/heads/master@{#379917}
|
|
|
|
|
|
|
|
| |
BUG=585673
Review URL: https://codereview.chromium.org/1680773006
Cr-Commit-Position: refs/heads/master@{#379889}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1757703002
Cr-Commit-Position: refs/heads/master@{#379869}
|
|
|
|
|
|
|
|
| |
BUG=547073
Review URL: https://codereview.chromium.org/1752603002
Cr-Commit-Position: refs/heads/master@{#379723}
|
|
|
|
|
|
|
|
|
| |
R=estade@chromium.org
BUG=591225
Review URL: https://codereview.chromium.org/1757673002
Cr-Commit-Position: refs/heads/master@{#379115}
|
|
|
|
|
|
|
|
|
|
| |
Part 1 of https://codereview.chromium.org/1630903002/
BUG=563722
Review URL: https://codereview.chromium.org/1716163005
Cr-Commit-Position: refs/heads/master@{#379058}
|
|
|
|
|
|
|
|
|
|
|
| |
screenshot: http://i.imgur.com/guvcgOi.png
BUG=546834
TEST=CrSettingsDevicePageTest
Review URL: https://codereview.chromium.org/1753653002
Cr-Commit-Position: refs/heads/master@{#378912}
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=590382
TEST=Extended unit_tests passes
TEST=Tested manually on device. Arc apps appear in search results.
App icon reflects Arc bridge state (enable/disable), app can
be launched by clicking icon in search. Context menu exists.
Review URL: https://codereview.chromium.org/1743633004
Cr-Commit-Position: refs/heads/master@{#378670}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch ports the Options C++ handler and strings over to Settings.
It's pretty much a straight-port.
BUG=563721
Review URL: https://codereview.chromium.org/1748973002
Cr-Commit-Position: refs/heads/master@{#378622}
|
|
|
|
|
|
|
|
|
|
|
|
| |
basic_page.html already conditionally includes the .html for non-CrOS
only, so there's no need for the backing C++ on CrOS.
BUG=536295
R=dschuyler@chromium.org
Review URL: https://codereview.chromium.org/1753773002
Cr-Commit-Position: refs/heads/master@{#378465}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch changed ChooserBubbleDelegate class name to
ChooserBubbleController since it better reflects the class's
responsibilities and clarifies the roles of the class.
BUG=492204, 588933
Review URL: https://codereview.chromium.org/1724183005
Cr-Commit-Position: refs/heads/master@{#377989}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=584691
TEST=Extended menu unit_tests. Tested on device, Activate menu
is disabled when bridge is not active and enabled when bridge
is active. Items are pinnable via context menu. Clicking on
Activate button either brings app to foreground either launches
it.
Review URL: https://codereview.chromium.org/1740043002
Cr-Commit-Position: refs/heads/master@{#377964}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It moves from c/b/apps as it can be reused more generally across
//chrome/browser. It works with the new KeepAliveRegistry which is
the class keeping all the relevant information in an accessible place.
This patch also reuses ScopedKeepAlive instead of
c/b/ui/views/AutoKeepAlive
BUG=587926
Review URL: https://codereview.chromium.org/1708343002
Cr-Commit-Position: refs/heads/master@{#377913}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL contains implementation of the Update password infobar:
1.For confirmation from the user that he/she changed password in case when the user has only one credentials for current site. In case saved credentials have a username we present the user with that username in the infobar message and ask is the user what to update password which is corresponding to this username. In case there is no username saved, we're asking user if saved password for this site should be updated or not.
2.For selecting by user which credentials should be updated after change password form submission in case when the user has more than one credentials and we have no clue which credentials is correct. It contains a selector with a list of all credentials for current site.
Mocks: https://folio.googleplex.com/chrome-ux/mocks/321-password-manager/password%20update/mobile#%2Fpassword%20update%20-%20mobile.png%3Fbg=dkgray&c=show
BUG=564674
Review URL: https://codereview.chromium.org/1490193003
Cr-Commit-Position: refs/heads/master@{#377260}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cl implements the IME window according to the mocks per
the API proposal: https://docs.google.com/document/d/1pqZO80ZOmgWzuQphf-uq5y967umcy7tqw5ETjuF19TU.
For the normal type of window, the titlebar is located at top.
For the follow-cursor type of window, the titlebar is located at left.
The IME window is in-activatable & always-on-top.
This cl is based on https://codereview.chromium.org/1717603004.
This cl leaves a couple of TODOs:
1) the createWindow API should not work when the IME extension is not
activated.
2) the follow-cursor window should be singleton, auto aligned with
the cursor or composition in the input field, and auto hide when cursor
or composition is not available.
3) the createWindow API should return JS 'window' object.
4) dragging support for the ime window.
BUG=517773
TEST=None
Review URL: https://codereview.chromium.org/1595313002
Cr-Commit-Position: refs/heads/master@{#376948}
|
|
|
|
|
|
|
|
|
|
|
| |
Following crrev.com/375929, Polymer is no longer available on Android. This
CL disables the MD history flag on Android, since it will no longer work.
BUG=425625
Review URL: https://codereview.chromium.org/1721603002
Cr-Commit-Position: refs/heads/master@{#376928}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This step removes the code and resources.
Next step drops all the "Md" prefixes.
R=asanka@chromium.org,asvitkine@chromium.org
BUG=528484
Review URL: https://codereview.chromium.org/1710083005
Cr-Commit-Position: refs/heads/master@{#376895}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use it
And isolate the FRAME_AVATAR_BUTTON #define to just the Mus browser
frame.
Currently lots of code around views browser frames is conditionally
compiled based on FRAME_AVATAR_BUTTON, and it isn't nice. It was added
in r344002 to allow some unnecessary build files to be excluded on
ChromeOS and was always meant to be temporary.
Previously FRAME_AVATAR_BUTTON was synonymous with "not ChromeOS". The
other browser frames do not need it because the Ash frame only compiles
on ChromeOS, and the Glass/Opaque frames never compile on ChromeOS. Mus
is the only frame that can compile both on ChromeOS and other platforms.
So remove it by moving the AvatarButtonManager out of the shared
BrowserNonClientFrameView base class, and into the subclasses that need
it.
The code to layout the profile switcher on a Mus frame was removed in
r373010 because it didn't compile. This CL adds back some simple layout
logic to test.
BUG=565989
Review URL: https://codereview.chromium.org/1700023002
Cr-Commit-Position: refs/heads/master@{#376377}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=586142
TEST=Dragged Arc app icon from app laucher to shelf. It is
icon appear on shelf toolbar. Enable/Disable Android
apps in Chrome::Settings. Icons in shelf updated
accordingly state of ARC.
TEST=extended unit_tests
Review URL: https://codereview.chromium.org/1689963002
Cr-Commit-Position: refs/heads/master@{#376343}
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/1680033004
Cr-Commit-Position: refs/heads/master@{#376017}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL removes the site engagement debug WebUI from Android since it
was the only WebUI using Polymer which causes some binary bloat.
BUG=470912,524857
Review URL: https://codereview.chromium.org/1680013002
Cr-Commit-Position: refs/heads/master@{#375751}
|
|
|
|
|
|
|
|
| |
BUG=550922
Review URL: https://codereview.chromium.org/1702583002
Cr-Commit-Position: refs/heads/master@{#375567}
|
|
|
|
|
|
|
|
| |
BUG=479359
Review URL: https://codereview.chromium.org/1664073002
Cr-Commit-Position: refs/heads/master@{#375206}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This additionally moves extension app context menu functionality
to its dedicated class.
BUG=584691
TEST=unit_test passes and no visual menu changes on devices.
Review URL: https://codereview.chromium.org/1673683002
Cr-Commit-Position: refs/heads/master@{#374696}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e6df3095c2ce24944ce3f6efa4e6e3d7c01ccad7.
The infobar UI will be replaced with dialog.
BUG=532876
TBR=dfalcantara@chromium.org
Review URL: https://codereview.chromium.org/1670673004
Cr-Commit-Position: refs/heads/master@{#374686}
|
|
|
|
|
|
|
|
|
|
|
| |
All users are on the new EDK now. This wipes out third_party/mojo,
updates all dependencies, and removes the use-new-edk flag.
BUG=None
Review URL: https://codereview.chromium.org/1676913002
Cr-Commit-Position: refs/heads/master@{#374631}
|
|
|
|
|
|
|
|
| |
BUG=582166
Review URL: https://codereview.chromium.org/1667333003
Cr-Commit-Position: refs/heads/master@{#374105}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=533004
TEST=
1. Enable the #enable-password-separated-signin-flow flags in chrome://flags and restart Chrome
2. In a non-signed in profile, open the User Menu and click "Sign In to Chrome"
3. The signin flow should open in a tab modal dialog
4. After entering valid credentials, the dialog should close and the Sync Confirmation dialog should be shown
Review URL: https://codereview.chromium.org/1604043004
Cr-Commit-Position: refs/heads/master@{#373653}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the file have no bad dependencies they can be moved into the
component. Fixes the #include for pref_service and grit generated files,
update the component DEPS.
Remove obsolete forward-declaration and add missing ones.
TBR=sky@chromium.org,mmenke@chromium.org,piman@chromium.org
BUG=582921
Review URL: https://codereview.chromium.org/1652153003
Cr-Commit-Position: refs/heads/master@{#373526}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Puts the new simplified fullscreen UI behind
chrome://flags/#simplified-fullscreen-ui on Mac.
It uses the toolkit-views UI, since it's already written and works
pretty well. Only few things need to be farmed out to the delegate
since the bubble can't assume its parent is a views::Widget.
Fixes a quirk where opacity-animating bubbles would briefly change
their bounds to have zero-height and back during construction. (We
complain about visible but zero-sized Widgets on Mac).
If this all works we can delete some ~700 lines of Cocoa code when
this simplified fullscreen UI is default on Mac.
BUG=352425
Review URL: https://codereview.chromium.org/1654723002
Cr-Commit-Position: refs/heads/master@{#373386}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add two methods to ToolbarModelDelegate to get the value of
Accept-Languages from the Profile and to call the method
FormattedStringWithEquvalentMeaning with an appropriate
classifier for the embedder.
TBR=sky@chromium.org
BUG=582921
Review URL: https://codereview.chromium.org/1656853002
Cr-Commit-Position: refs/heads/master@{#373221}
|