| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead we add a gyp file in third_party/google_toolbox_for_mac to build
the sources from third_party/GTM. This is the third and last patch in
this series.
BUG=299841
TEST=None
R=mark@chromium.org,ben@chromium.org
TBR=ben
Review URL: https://codereview.chromium.org/107933006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the Mac code has a dummy InfoBar implementation that it unused.
This code replaces that with the cross platform implementation.
Using the cross platform implementation means:
- animation is now driven by the cross platform code
- layout is now controlled by InfoBarContainer
- InfoBarDelegate is now owned by InfoBar
BUG=62154
TEST=
TBR=thakis
Review URL: https://chromiumcodereview.appspot.com/23338005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ActionBox is no more, and is unlikely to be coming back. This CL removes
old ActionBox code, associated resources, feature switch and extension
API.
BUG=234737
Review URL: https://chromiumcodereview.appspot.com/19695004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove ChromeToMobile service, factory, unittests, and UI.
Remove IDS_CHROME_TO_MOBILE* strings.
Remove IDC_CHROME_TO_MOBILE_PAGE and adjust IDC values.
Remove IDR_MOBILE and chrome/app/theme/*/mobile[_lit].png
Remove browser frame and location bar callers, consts.
Remove prefs::kChromeToMobileDeviceList from user profiles.
Add code in c/b/prefs/browser_prefs.cc to clear this value.
The UMA histograms will be removed in a related CL:
https://chromereviews.googleplex.com/9087014/
WontFix'ed issues related to this code, listed for future reference:
-Issue 120941: Chrome To Mobile: An error occured while sending the page.
-Issue 154709: Last selected mobile device not stored and automatically reselected
-Issue 154710: Ordering of mobile devices not consistent
-Issue 156843: Only acknowledge invalidation after device search is finished in ChromeToMobileService
-Issue 122183: Make ChromeToMobile API more testable, drop gmock.
BUG=260121
TEST=Dead user pref is cleared, no compile failures/crashes.
R=rfevang@chromium.org,battre@chromium.org,sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19256007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allows Cocoa UI code outside of chrome/browser to use it.
This is a precursor to http://crrev.com/18326006
BUG=138633
TEST=No functional changes.
Review URL: https://chromiumcodereview.appspot.com/18355002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows things outside of chrome/browser to use it.
The CL also moves the Cocoa-specific event_utils.h in chrome/browser to
ui/base/cocoa/cocoa_event_utils.h.
BUG=138633
TEST=No functional changes
Review URL: https://chromiumcodereview.appspot.com/15870006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was only one Windows-specific/first-run code path for this dialog to be shown, but the first run import should be always silent, and I've run first run many times and have never seen this dialog (the import is probably too fast) anyways.
jeffreyc@ gave the go to kill it at https://code.google.com/p/chromium/issues/detail?id=219419#c3
This is a precursor CL to https://codereview.chromium.org/12670013/
TBR=ben@chromium.org
BUG=219419
Review URL: https://chromiumcodereview.appspot.com/14322002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The wrench icon will no longer show status using a badge. Instead, the icon color will change to indicate status.
This CL adds a NSButton cell to draw the wrench button icon.
XIB changes:
* Change class of wrench button cell from ClickHoldButtonCell to WrenchToolbarButtonCell.
Screenshot: http://i.imgur.com/OfZA4uE.png
Video: https://docs.google.com/file/d/0B0Odde3V7EhWelB6ZEgwcE03ckk/edit?usp=sharing
BUG=180107
TEST=Ran Chrome with --simulate-upgrade. Verified that no badge was shown and that the wrench icon was colored.
Review URL: https://chromiumcodereview.appspot.com/13375016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome must show notification bar when screen capture API is used to capture
the screen. This CL reuses the notification bar that's currently used by
remoting host (see src/remoting/host/disconnect_window*). The new files are
mostly copy of the existing code in remoting (except different names).
The plan is to keep it temporarily and replace it with something better before
the API is enabled for everybody.
BUG=190156
Review URL: https://chromiumcodereview.appspot.com/12453019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui/base/cocoa.
HoverImageButton will be needed by ui/message_center, and ImageButtonCell
does not extract well from chrome/ because of a dependence on ThemeWindow.
BUG=179904
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12937008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB Changes: Deleted the BMB context menu entries in BookmarkBar.xib and BookmarkBarFolderWindow.xib.
BUG=181034
TEST=BMB context menus behave exactly as before.
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/12389060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL has only cosmetic changes. It's in service of a larger refactor.
Also:
+ Renames InstantModel* to InstantOverlayModel* to make it clear that
the model is meant only for the overlay, and not committed tabs that
Instant works with.
BUG=none
R=sky@chromium.org
TEST=none
Review URL: https://chromiumcodereview.appspot.com/12381078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Mac version of this Views CL:
https://codereview.chromium.org/11896021/
Currently the one click signin confirmation UI is implemented as a
bubble. This CL adds a tab modal dialog version of that UI.
Code common to the dialog and bubble has been moved to a new OneClickSigninViewController class.
XIB Changes:
OneClickSigninBubble.xib:
* aligned the baseline of the text in the advanced link with the
text in the OK button.
* changed the file owner to be OneClickSigninViewController
OneClickSigninDialog.xib
* same as OneClickSigninBubble.xib except it uses constrained
window sytle controls
Screenshots:
Bubble: http://i.imgur.com/HmJqoQk.png
Dialog: http://i.imgur.com/gaY2cym.png
BUG=171330
TEST=
To show the bubble I performed the following steps;
- ran chrome with --use-client-login-signin-flow
- signed into gmail
- clicked "Ok Sync" in the infobar
Testing the dialog requires access to server side stuff that's not public yet. I asked rogerta@ for instructions.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181056
Review URL: https://codereview.chromium.org/12082088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Mac: One click signin dialog
>
> This is the Mac version of this Views CL:
> https://codereview.chromium.org/11896021/
>
> Currently the one click signin confirmation UI is implemented as a
> bubble. This CL adds a tab modal dialog version of that UI.
>
> Code common to the dialog and bubble has been moved to a new OneClickSigninViewController class.
>
> XIB Changes:
> OneClickSigninBubble.xib:
> * aligned the baseline of the text in the advanced link with the
> text in the OK button.
> * changed the file owner to be OneClickSigninViewController
> OneClickSigninDialog.xib
> * same as OneClickSigninBubble.xib except it uses constrained
> window sytle controls
>
> Screenshots:
> Bubble: http://i.imgur.com/HmJqoQk.png
> Dialog: http://i.imgur.com/gaY2cym.png
>
> BUG=171330
> TEST=
> To show the bubble I performed the following steps;
> - ran chrome with --use-client-login-signin-flow
> - signed into gmail
> - clicked "Ok Sync" in the infobar
> Testing the dialog requires access to server side stuff that's not public yet. I asked rogerta@ for instructions.
>
> Review URL: https://codereview.chromium.org/12082088
TBR=sail@chromium.org
Review URL: https://codereview.chromium.org/12213050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Mac version of this Views CL:
https://codereview.chromium.org/11896021/
Currently the one click signin confirmation UI is implemented as a
bubble. This CL adds a tab modal dialog version of that UI.
Code common to the dialog and bubble has been moved to a new OneClickSigninViewController class.
XIB Changes:
OneClickSigninBubble.xib:
* aligned the baseline of the text in the advanced link with the
text in the OK button.
* changed the file owner to be OneClickSigninViewController
OneClickSigninDialog.xib
* same as OneClickSigninBubble.xib except it uses constrained
window sytle controls
Screenshots:
Bubble: http://i.imgur.com/HmJqoQk.png
Dialog: http://i.imgur.com/gaY2cym.png
BUG=171330
TEST=
To show the bubble I performed the following steps;
- ran chrome with --use-client-login-signin-flow
- signed into gmail
- clicked "Ok Sync" in the infobar
Testing the dialog requires access to server side stuff that's not public yet. I asked rogerta@ for instructions.
Review URL: https://codereview.chromium.org/12082088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=164772
R=pkasting@chromium.org,sail@chromium.org
TBR=ben@chromium.org # for file additions to gyp files
Review URL: https://codereview.chromium.org/11773025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes:
* change the window and button classes to the constrained window variant
* updated margins to match spec
* updated font sizes to match spec
Screenshots:
* New: http://i.imgur.com/wquUv.png
* Old: http://i.imgur.com/EWmd1.png
* Spec: http://i.imgur.com/JXjzg.png
BUG=140550
TEST=Verified that all LoginPromptBrowserTest.* test passed.
Manually navigated to http://www.pagetutor.com/keeper/mystash/secretstuff.html. Verified that the dialog still worked.
Review URL: https://chromiumcodereview.appspot.com/11421045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes:
* Made all windows 468 pixels wide
* Moved controls to match mocks
* Added an outlet for the store link button
Mock: http://i.imgur.com/ruUmn.png
Screenshots of new UI:
Warnings: http://i.imgur.com/5urhd.png
No Warnings: http://i.imgur.com/UrHif.png
Inline: http://i.imgur.com/nrHWQ.png
Inline No Warnings: http://i.imgur.com/Mgbgs.png
Bundle: http://i.imgur.com/mexGe.png
Screenshots old original UI:
Warnings: http://i.imgur.com/nVqgA.png
No Warnings: http://i.imgur.com/fSkGb.png
Inline: http://i.imgur.com/S7gBE.png
Inline No Warnings: http://i.imgur.com/pJJdx.png
Bundle: http://i.imgur.com/7h7QO.png
BUG=155803
TBR=sky@chromium.org
TEST=
Warnings: Install extension from: https://chrome.google.com/webstore/detail/google-mail-checker/mihcahmgecmbnbcchbopgniflfhgnkff
No Warnings: https://chrome.google.com/webstore/detail/seo-analysis-with-seoptim/pplbjgemahdghhnelnlihpflpdkkmmgj
Inline: Navigate to https://www.google.com/chrome/intl/en/p/google-plus.html and add Google+ Notifications
Inline No Warnings: Same as above but instead add Google+ App
Bundle: Run Chrome with --apps-gallery-url="http://www.corp.google.com/" and navigate to http://www.corp.google.com/~jstritar/bundle.html
Review URL: https://chromiumcodereview.appspot.com/11275269
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=138118
Review URL: https://chromiumcodereview.appspot.com/11103042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes the following changes to the extension install prompt:
- the dialog is now displayed in a constrained window
- the UI has been updated to use the new constrained window UI
- the main UI is now a view that can be embedded in any window. This will be used by the web intents picker to embed the extension install prompt in the picker UI.
XIB changes:
- change all the xibs to use a view controller instead of a window controller
- change the buttons to use the new constrained window look
Screenshot: http://i.imgur.com/V0kKF.png
BUG=152010, 95455
TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11014012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also adds a PRESUBMIT check to enforce the policy described here:
http://dev.chromium.org/developers/design-documents/mac-xib-files
BUG=149763
TEST=Build chrome target on 10.6 with Xcode 3.2. Chromium.app launches and works.
TBR=mark@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10950010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This creates lists of XIB files that Chromium has. It also lays the groundwork
for editing XIB files on Xcode 4.4 by creating a fake project for working in
Xcode.
BUG=149763
TEST=No changes in build output.
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/10918254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157199 0039d316-1c4b-4281-b951-d872f2087c98
|