| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL sends reports from ChromeExpectCTReporter when CT policy
violations occur.
Implementation is behind --enable-expect-ct-reporting for now.
BUG=568806
Review URL: https://codereview.chromium.org/1824623003
Cr-Commit-Position: refs/heads/master@{#382755}
|
|
|
|
|
|
|
|
|
|
|
| |
of host_ports for which QUIC will be forced. A TCP job wouldn't even be
started for these origins.
R=rch@chromium.org, eroman@chromium.org,
Review URL: https://codereview.chromium.org/1808303005
Cr-Commit-Position: refs/heads/master@{#382370}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dead code now.
TBR=sky@chromium.org
R=gab@chromium.org, grt@chromium.org
BUG=558054
Review URL: https://codereview.chromium.org/1811853005
Cr-Commit-Position: refs/heads/master@{#382019}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Committed: https://crrev.com/dced4c771d25317d26a0f6e258c7b7f64d4e8eea
Cr-Commit-Position: refs/heads/master@{#379652}
Committed: https://crrev.com/740688bec5c66af00debe117b6d375ecd212e570
Cr-Commit-Position: refs/heads/master@{#381134}
Review URL: https://codereview.chromium.org/1699653002
Cr-Commit-Position: refs/heads/master@{#381791}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Material Design history flag (#enable-md-history) uses the old-style
UI with only an enable/disable button. It should have a drop-down with
"Default", "Enable", "Disable" like all new feature flags.
BUG=586340
Review URL: https://codereview.chromium.org/1766273002
Cr-Commit-Position: refs/heads/master@{#381662}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #8 id:140001 of https://codereview.chromium.org/1699653002/ )
Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=594921
Basically parts of http_stream_factory_impl_unittest.cc are only compiled if ENABLE_BIDIRECTIONAL_STREAM is a build flag and you haven't updated these parts of the file.
Original issue's description:
> Remove support forAlt-Svc/Alternate Protocol Probability
>
> Committed: https://crrev.com/dced4c771d25317d26a0f6e258c7b7f64d4e8eea
> Cr-Commit-Position: refs/heads/master@{#379652}
>
> Committed: https://crrev.com/740688bec5c66af00debe117b6d375ecd212e570
> Cr-Commit-Position: refs/heads/master@{#381134}
TBR=bnc@chromium.org,eroman@chromium.org,mef@chromium.org,rch@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1802893002
Cr-Commit-Position: refs/heads/master@{#381197}
|
|
|
|
|
|
|
|
|
| |
Committed: https://crrev.com/dced4c771d25317d26a0f6e258c7b7f64d4e8eea
Cr-Commit-Position: refs/heads/master@{#379652}
Review URL: https://codereview.chromium.org/1699653002
Cr-Commit-Position: refs/heads/master@{#381134}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're now at a point where we'd like to demo WebAssembly and have
developers try it out and break it. Having about:flags support makes
this easier.
Intent to implement: https://groups.google.com/forum/#!msg/v8-users/PInzACvS5I4/e2HflsbvCgAJ
Design: https://github.com/WebAssembly/design
Spec: https://github.com/WebAssembly/spec
Chrome status: https://www.chromestatus.com/features/5453022515691520
BUG=575167
R= cpu@chromium.org, asvitkine@chromium.org, titzer@chromium.org, bradnelson@chromium.org, seththompson@chromium.org
Review URL: https://codereview.chromium.org/1789633005
Cr-Commit-Position: refs/heads/master@{#380883}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #7 id:120001 of https://codereview.chromium.org/1699653002/ )
Reason for revert:
This appears to have broken the following bot: https://build.chromium.org/p/chromium.mac/builders/iOS_Device_%28ninja%29/builds/43364
Original issue's description:
> Remove support forAlt-Svc/Alternate Protocol Probability
>
> Committed: https://crrev.com/dced4c771d25317d26a0f6e258c7b7f64d4e8eea
> Cr-Commit-Position: refs/heads/master@{#379652}
TBR=bnc@chromium.org,eroman@chromium.org,mef@chromium.org,rch@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1773853003
Cr-Commit-Position: refs/heads/master@{#379658}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1699653002
Cr-Commit-Position: refs/heads/master@{#379652}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add a field trial for bucketing users into different prototypes.
The trial stores the herb flavor in a variations param.
* Consolidate Herb string checking into FeatureUtilities, which
checks whether VariationsAssociatedParams are active and
whether they're overridden by about:flags.
* Adds a "disabled" group to about:flags to explicitly disable the
experiment, users on about:flags now default to whatever they're
bucketed into.
* Stop toasting to the user that they need the restart Chrome for
cached experiment flags to take effect. Users won't understand
why this is relevant.
BUG=582539
Review URL: https://codereview.chromium.org/1716313002
Cr-Commit-Position: refs/heads/master@{#377454}
|
|
|
|
|
|
|
|
|
|
|
| |
This flags automatically opens DevTools for every browser tab,
including restored and opened for url arguments ones.
BUG=410958
Review URL: https://codereview.chromium.org/1691813003
Cr-Commit-Position: refs/heads/master@{#376916}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This step removes the code and resources.
Next step drops all the "Md" prefixes.
R=asanka@chromium.org,asvitkine@chromium.org
BUG=528484
Review URL: https://codereview.chromium.org/1710083005
Cr-Commit-Position: refs/heads/master@{#376895}
|
|
|
|
|
|
|
|
| |
BUG=587702
Review URL: https://codereview.chromium.org/1703403002
Cr-Commit-Position: refs/heads/master@{#376283}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is on by default on Linux, Windows and ChromeOS. To bring the feature
up on Mac we are trying the already-written toolkit-views UI rather than
Cocoa. Currently it's working on Mac behind --enable-simplified-fullscreen-ui
but since this is the first time we are running toolkit-views UI by-default
on Mac, we want to bring it up via an experiment.
BUG=586304
Review URL: https://codereview.chromium.org/1685043002
Cr-Commit-Position: refs/heads/master@{#375048}
|
|
|
|
|
|
|
|
|
|
|
| |
Error out if the param list contains the same fieldtrial,group
multiple times.
BUG=553514
Review URL: https://codereview.chromium.org/1682163004
Cr-Commit-Position: refs/heads/master@{#374700}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce --disable-http2 command line flag that does the exact same thing as
the broken --use-spdy one: disable SPDY/3.1 and HTTP/2. This will be accurately
named once SPDY/3.1 is deprecated.
Remove broken --use-spdy command line flag, which only did one thing: disable
SPDY/3.1 and HTTP/2. Also remove related IOThread::Globals and
IOSChromeIOThread::Globals members. This makes some flags only used in tests,
which are removed as follows:
Remove |forced_spdy_exclusions| from HttpNetworkSession::Params and
SpdySessionDependencies. Also remove HttpNetworkSession::HasSpdyExclusion().
Remove |initial_max_spdy_concurrent_streams| from HttpNetworkSession::Params and
SpdySessionDependencies. Also remove SpdySessionPool constructor argument,
member, and SpdySession constructor argument.
BUG=547781
Review URL: https://codereview.chromium.org/1668433002
Cr-Commit-Position: refs/heads/master@{#374374}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This embeds crashpad_handler into setup.exe and runs as crashpad_handler
when --type=crashpad-handler is specified on the command line. This
means there's a second copy of this code (in addition to chrome.exe).
Size impact on setup.exe:
setup.exe Release buildtype=Official before: 1,081,344 bytes
setup.exe Release buildtype=Official after: 1,126,912 bytes
= +45,568 bytes.
I don't think any *other* copies of this code will be needed for
Remoting, NaCl, etc. as they can run chrome.exe or setup.exe as the
handler.
Example report: crash/c144f8df1cd5e1ac
TBR=brettw@chromium.org
R=grt@chromium.org, mark@chromium.org
BUG=546288,565770, 569150
Review URL: https://codereview.chromium.org/1498733008
Cr-Commit-Position: refs/heads/master@{#373969}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set trusted SPDY proxy on per-profile basis if the profile
has DRP enabled, and if Chrome is part of the field trial.
Prior to this CL, it was possible to set the trusted SPDY
proxy only from command line switch.
Setting it on per-profile ensures that it is set only if
DRP is enabled (which is per-profile).
Setting it dynamically ensures that if there is a change in
DataReductionProxy config (e.g., the API tells Chrome to
connect to a different DRP server), then the SPDY session
to the different server has the trusted SPDY proxy set
correctly to the new server. Prior to this CL, trusted
SPDY proxy was set once at the time of Chrome start, and it
was not possible to change it.
Link to design doc: https://code.google.com/p/chromium/issues/detail?id=558682#c11
BUG=558682
Review URL: https://codereview.chromium.org/1547273003
Cr-Commit-Position: refs/heads/master@{#373442}
|
|
|
|
|
|
|
|
| |
BUG=467312
Review URL: https://codereview.chromium.org/1409323011
Cr-Commit-Position: refs/heads/master@{#373358}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add a flag to about:flags that's restricted to Dev and
lower that enables UI experiments.
* Cache the new native flags from about:flags inside of
SharedPreferences. This is necessary because we don't
have access to the native side early on when
ChromeLauncherActivity is triggered.
* Send VIEW Intents that don't have NEW_TASK or
NEW_DOCUMENT to Custom Tabs instead of Chrome proper.
BUG=582539
Review URL: https://codereview.chromium.org/1658723007
Cr-Commit-Position: refs/heads/master@{#373303}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The /prefetch:# argument that is currently added to the command line of
processes launched with content::StartSandboxedProcess is ignored by
Windows because # doesn't respect the [1, 8] constraint.
This CL ensures that a valid /prefetch:# argument is used for every
process launch (except when the feature is disabled by the PreRead
field trial).
BUG=577698
Review URL: https://codereview.chromium.org/1612663002
Cr-Commit-Position: refs/heads/master@{#373241}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current spellchecker behavior (on certain platforms) can switch between
single-language spellchecking and multi-lingual spellchecking based on a
#flag. There is also a checkbox to disable spellchecking globally but
only in single-language mode.
This CL removes the option to have single-language spellchecking (it forces
multi-lingual) but, of course, the user is free to have only a single
language listed in their list, and/or to enable it/them.
However, this CL preserves the ability to disable spellchecking globally, by
making the checkbox permanently visible.
BUG=579346
Review URL: https://codereview.chromium.org/1606243003
Cr-Commit-Position: refs/heads/master@{#372803}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a new method to SSLClientSocket to get the Token Binding from an SSL
connection where Token Binding was negotiated, and uses that to add the
Set-Token-Binding HTTP header (only when Token Binding was negotiated).
BUG=467312
Review URL: https://codereview.chromium.org/1378613004
Cr-Commit-Position: refs/heads/master@{#371347}
|
|
|
|
|
|
|
|
|
|
|
| |
On iOS, it is created in the ApplicationContextImpl.
BUG=576772
R=rohitrao@chromium.org,sdefresne@chromium.org
Review URL: https://codereview.chromium.org/1578283002
Cr-Commit-Position: refs/heads/master@{#369750}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of repeating the same string literal multiple times, use a
constant switches::kWatcherProcess.
In an upcoming CL, this constant will also be used by a function
returning the /prefetch switch to use for a given process type.
BUG=577698
Review URL: https://codereview.chromium.org/1585203003
Cr-Commit-Position: refs/heads/master@{#369531}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=576402
Committed: https://crrev.com/1ad82bbc44d87669926c9cffe2ba77564df420a3
Cr-Commit-Position: refs/heads/master@{#368810}
Review URL: https://codereview.chromium.org/1580583002
Cr-Commit-Position: refs/heads/master@{#369291}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implementation behind the enable-native-notifications chrome://flags
Conceptually based on a previous attempt.
(https://codereview.chromium.org/224183002) but now using the same
interface android uses.
System and extensions notifications remain implemented through chrome
toasts.
There are a few things missing that will come in future CLs, most notably
Buttons
Auto dimsissal (i.e all notifications requireInteraction)
Sounds
BUG=571056
Review URL: https://codereview.chromium.org/1509923002
Cr-Commit-Position: refs/heads/master@{#369255}
|
|
|
|
|
|
|
|
| |
BUG=566085
Review URL: https://codereview.chromium.org/1577883003
Cr-Commit-Position: refs/heads/master@{#369077}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1580583002/ )
Reason for revert:
Speculative revert for Android Cronet bots failure (CronetTestInstrumentation)
Original issue's description:
> Add a whitelist for QUIC hosts.
>
> BUG=576402
>
> Committed: https://crrev.com/1ad82bbc44d87669926c9cffe2ba77564df420a3
> Cr-Commit-Position: refs/heads/master@{#368810}
TBR=agl@chromium.org,rsleevi@chromium.org,rch@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=576402
Review URL: https://codereview.chromium.org/1574423003
Cr-Commit-Position: refs/heads/master@{#369050}
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the flag that would enable animation of reader mode. Since
animation now is the intended behavior, the flag is no longer needed.
BUG=
Review URL: https://codereview.chromium.org/1571993002
Cr-Commit-Position: refs/heads/master@{#368915}
|
|
|
|
|
|
|
|
| |
BUG=576402
Review URL: https://codereview.chromium.org/1580583002
Cr-Commit-Position: refs/heads/master@{#368810}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac hasn't migrated to the new task manager yet, and the network bytes
code checks the switch to determine which task manager to forward the
bytes data to. Hence, on Macs, the switch check should be skipped.
BUG=548380
Review URL: https://codereview.chromium.org/1568953002
Cr-Commit-Position: refs/heads/master@{#368656}
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a component, the SecurityStateModel logic can be reused on iOS, so
that we use consistent logic and definitions to describe a page's
overall security status for UI on all platforms.
BUG=515071
Review URL: https://codereview.chromium.org/1539043002
Cr-Commit-Position: refs/heads/master@{#368636}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a flag and field trial group enabling app banners to use
the site engagement service for triggering. This allows banners to be
triggered based on broader criteria than simply navigations.
An additional UMA histogram is also added to compare the time from when
an origin was first recorded as visited by the app banner system until
the time when a banner should be shown.
This CL revealed a bug in the testing for the site engagement service,
where the service would be NULL under some testing contexts. This
issue is fixed, and a new app banner settings helper test for site
engagement is added. Existing tests are refactored to properly reset
the app banner trigger system to its default values, ensuring that tests
can be run in different orders without failures.
Another bug is fixed where the SiteEngagementServiceFactory did not
have a dependency on the HistoryServiceFactory; this caused crashes
on the Android debug builder.
BUG=553858,569941
Committed: https://crrev.com/e85b17d58172be38e869624a9c60e7d918cd34dc
Cr-Commit-Position: refs/heads/master@{#365689}
Review URL: https://codereview.chromium.org/1413343008
Cr-Commit-Position: refs/heads/master@{#367796}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LocalizedError uses several switches that it conceptually "owns" (i.e., they
are fundamentally related to this class). This CL componentizes these switches
into //components/error_page in anticipation of componentizing
localized_error.*.
BUG=523362
Review URL: https://codereview.chromium.org/1539903002
Cr-Commit-Position: refs/heads/master@{#367506}
|
|
|
|
|
|
|
|
| |
BUG=566085
Review URL: https://codereview.chromium.org/1551743002
Cr-Commit-Position: refs/heads/master@{#367155}
|
|
|
|
|
|
|
|
| |
BUG=529962
Review URL: https://codereview.chromium.org/1512113002
Cr-Commit-Position: refs/heads/master@{#367025}
|
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=thakis@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1548153002
Cr-Commit-Position: refs/heads/master@{#366893}
|
|
|
|
|
|
|
|
|
| |
BUG=467808
TBR=isherman@chromium.org
Review URL: https://codereview.chromium.org/1541033002
Cr-Commit-Position: refs/heads/master@{#366517}
|
|
|
|
|
|
|
|
|
|
|
| |
extension protected behind a flag.
TBR=grunell@chromium.org
BUG=568169
Review URL: https://codereview.chromium.org/1530863002
Cr-Commit-Position: refs/heads/master@{#366258}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 9b52527c4d7542b4706b8fba945e8141346da098.
Reason: still breaks Android (dbg) bot: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/31923
BUG=553858
NOTRY=TRUE
TBR=benwells
Review URL: https://codereview.chromium.org/1530983004
Cr-Commit-Position: refs/heads/master@{#365765}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a flag and field trial group enabling app banners to use
the site engagement service for triggering. This allows banners to be
triggered based on broader criteria than simply navigations.
An additional UMA histogram is also added to compare the time from when
an origin was first recorded as visited by the app banner system until
the time when a banner should be shown.
This CL revealed a bug in the testing for the site engagement service,
where the service would be NULL under some testing contexts. This
issue is fixed, and a new app banner settings helper test for site
engagement is added. Existing tests are refactored to properly reset
the app banner trigger system to its default values, ensuring that tests
can be run in different orders without failures.
BUG=553858
Review URL: https://codereview.chromium.org/1413343008
Cr-Commit-Position: refs/heads/master@{#365689}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 3e7cdbf1b379398f5e1a710d22629fdf14df02cf.
Reason:
broke Android Tests (dbg) bot, see
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/31891
e.g. AppBannerSettingsHelperTest.SiteEngagementTrigger
BUG=553858
NOTRY=TRUE
TBR=dominickn@chromium.org, calamity@chromium.org, benwells@chromium.org, isherman@chromium.org
Review URL: https://codereview.chromium.org/1527973002
Cr-Commit-Position: refs/heads/master@{#365249}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a flag and field trial group enabling app banners to use
the site engagement service for triggering. This allows banners to be
triggered based on broader criteria than simply navigations.
An additional UMA histogram is also added to compare the time from when
an origin was first recorded as visited by the app banner system until
the time when a banner should be shown.
BUG=553858
Committed: https://crrev.com/936894045ed2aed9ee67b9c371a9eff94912c346
Cr-Commit-Position: refs/heads/master@{#363100}
Review URL: https://codereview.chromium.org/1413343008
Cr-Commit-Position: refs/heads/master@{#365227}
|
|
|
|
|
|
|
|
|
|
|
| |
Removes all the viewer code for the old design, the --enable-pdf-material-ui
flag, and the associated tests.
BUG=439114
Review URL: https://codereview.chromium.org/1521913002
Cr-Commit-Position: refs/heads/master@{#365205}
|
|
|
|
|
|
|
|
|
|
| |
Now that there is a device chooser UI this flag is unnecessary.
BUG=529950
Review URL: https://codereview.chromium.org/1514413004
Cr-Commit-Position: refs/heads/master@{#364907}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is experiment controls the behaviour of what happens when a user opens a
suggestion from the NTP. Specifically if there are previously opened tabs for
the suggestion.
We are starting this with 2 simple cases where we match the existing tabs and
the suggestion by URL or by Hostname.
This is a base change so we can understand which direction to proceed from here.
BUG=565953
Review URL: https://codereview.chromium.org/1501753002
Cr-Commit-Position: refs/heads/master@{#364319}
|
|
|
|
|
|
|
|
| |
BUG=245319
Review URL: https://codereview.chromium.org/1501543002
Cr-Commit-Position: refs/heads/master@{#364103}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome.input.ime.* APIs on windows and linux.
See the step 1 in: https://codereview.chromium.org/1403543004/
See the step 2 in: https://codereview.chromium.org/1419593002/
Main changes:
1. Update the entry in _permission_features.json and gypi file to make IME APIs accessible under chromeos, windows and linux platforms.
2. Add "platforms" attribute in input_ime.json, to reuse the ChromeOS APIs: chrome.input.ime.setComposition, .commitText, .sendKeyEvents, .keyEventHandled, .deleteSurroundingText, .onFocus, onBlur, .onKeyEvent, .onReset, .onDeactivated;
And keep other APIs ChromeOS only: chrome.input.ime.clearComposition, .hideInputView, .setCandidateWindowProperties, setCandidates, .setCursorPosition, .setMenumItems, updateMenuItems, .onActivate, .onInputContexUpdate, .onCandidateClicked, onMenuItemActivated, onSurroundingTextChanged.
3. Add flag "enable-input-ime-api" to enable chrome.input.ime API on Linux and Win.
Update input_ime_api.cc as API implementation on Linux and Win.
And add two kinds of errors: kErrorAPINotImplemented/ kErrorAPIDisabled to indicate whether this API is disabled.
4. Add new file input_ime_api_chromeos.cc for chromeos specific
implementation of the input_ime API.
BUG=517773
TEST=No compiling errors.
Review URL: https://codereview.chromium.org/1418643007
Cr-Commit-Position: refs/heads/master@{#363975}
|