| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.
BUG=436357
R=dcheng@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/1731483003
Cr-Commit-Position: refs/heads/master@{#377767}
|
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=thakis@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1548153002
Cr-Commit-Position: refs/heads/master@{#366893}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.
BUG=417463
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/653773004
Cr-Commit-Position: refs/heads/master@{#300465}
|
|
|
|
|
|
|
|
|
|
| |
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/93793010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This changes callers in chrome/common.
TBR=sky
Review URL: https://codereview.chromium.org/105473003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See bug for context. Implements a component extension
that provides speech synthesis using Google's speech
synthesis API.
Adds a "remote" flag to the TTS and TTS Engine APIs
so that it's possible for clients to distinguish
between local and remote speech engines.
Adds a new private extension API to expose Google's
API key, needed to make the request.
BUG=308250
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232242
Review URL: https://codereview.chromium.org/27034009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Failing on "Win 7 Tests (1)" http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/25765
> Implement Google network speech synthesis.
>
> See bug for context. Implements a component extension
> that provides speech synthesis using Google's speech
> synthesis API.
>
> Adds a "remote" flag to the TTS and TTS Engine APIs
> so that it's possible for clients to distinguish
> between local and remote speech engines.
>
> Adds a new private extension API to expose Google's
> API key, needed to make the request.
>
> BUG=308250
>
> Review URL: https://codereview.chromium.org/27034009
R=dmazzoni@chromium.org
TBR=dmazzoni@chromium.org
Review URL: https://codereview.chromium.org/51213003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See bug for context. Implements a component extension
that provides speech synthesis using Google's speech
synthesis API.
Adds a "remote" flag to the TTS and TTS Engine APIs
so that it's possible for clients to distinguish
between local and remote speech engines.
Adds a new private extension API to expose Google's
API key, needed to make the request.
BUG=308250
Review URL: https://codereview.chromium.org/27034009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the rest of chrome/common/extensions/extension_manifest_constants to
extensions/common/manifest_constants.
s/extension_manifest_[values|errors]/extensions::manifest_[values|errors]
Remove include of manifest constants in ~20 files that didn't use it.
Fixed small nits when I found (taking out unnecessary extensions::, etc).
TBR=davemoore@chromium.org (c/b/chromeos/)
TBR=pkotwicz@chromium.org (c/b/themes/)
TBR=thakis@chromium.org (c/b/ui/cocoa/, c/renderer/)
TBR=dimich@chromium.org (c/b/ui/panels/)
TBR=sky@chromium.org (c/b/ui/views/)
TBR=finnur@chromium.org (c/b/ui/webui/extensions/)
BUG=159265
Review URL: https://chromiumcodereview.appspot.com/23744004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=162530
Review URL: https://chromiumcodereview.appspot.com/23257005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move it to extensions/common/manifest_constants.cc.
Minorly improve packaged app + manifest version 1 error message.
BUG=162530
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22794012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=avi@chromium.org
Review URL: https://codereview.chromium.org/16923013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/common/, chrome/installer.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/16026013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes the manifest handler registration interface to (new Handler)->Register() and requires handlers to declare what keys they parse in Keys().
Also fixes const correctness in Manifest::Get* and ManifestHandler.
Based on https://codereview.chromium.org/12256031/.
BUG=159265
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12253022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
string_number_conversions in some chrome subdirectories.
Review URL: https://codereview.chromium.org/12218065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
manifest to handlers.
This makes it possible to support multi-key handlers using the same interface.
Fixes a bug with default behavior for manifest handlers; previously, HasNoKey would be called even for inappropriate extension types.
BUG=159265
Review URL: https://chromiumcodereview.appspot.com/12084034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=159265
TEST=TtsEngineManifestTest, TtsApiTest
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11745009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176016 0039d316-1c4b-4281-b951-d872f2087c98
|