| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This will mean even fewer UnusedResource checks, but that is covered by:
https://bugs.chromium.org/p/chromium/issues/detail?id=595810
BUG=597007
Review URL: https://codereview.chromium.org/1826563002
Cr-Commit-Position: refs/heads/master@{#382986}
|
|
|
|
|
|
|
|
| |
BUG=484854
Review URL: https://codereview.chromium.org/1829823002
Cr-Commit-Position: refs/heads/master@{#382905}
|
|
|
|
|
|
|
|
|
|
|
| |
explicit isDefault.
BUG=chromedriver:1339
TBR=stgao@chromium.org
Review URL: https://codereview.chromium.org/1810053004
Cr-Commit-Position: refs/heads/master@{#382205}
|
|
|
|
|
|
|
|
|
|
|
| |
Previously only desktop screenshots were retried. This works around some flakiness we've observed in recent versions of Chrome for Android. More context (for Googlers only, sorry) is available at b/27644687.
BUG=
TBR=stgao@chromium.org
Review URL: https://codereview.chromium.org/1809833002
Cr-Commit-Position: refs/heads/master@{#381808}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1813813003
Cr-Commit-Position: refs/heads/master@{#381784}
|
|
|
|
|
|
|
|
|
|
| |
present inside nested frameset.
BUG=chromedriver:107
Review URL: https://codereview.chromium.org/1799183002
Cr-Commit-Position: refs/heads/master@{#381753}
|
|
|
|
|
|
|
|
| |
BUG=505555
Review URL: https://codereview.chromium.org/1804773002
Cr-Commit-Position: refs/heads/master@{#381292}
|
|
|
|
|
|
|
|
| |
BUG=chromedriver:1331
Review URL: https://codereview.chromium.org/1766113002
Cr-Commit-Position: refs/heads/master@{#379605}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1751573002
Cr-Commit-Position: refs/heads/master@{#378295}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1745493002
Cr-Commit-Position: refs/heads/master@{#377955}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.
BUG=436357
R=dcheng@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/1731483003
Cr-Commit-Position: refs/heads/master@{#377767}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1734233002
Cr-Commit-Position: refs/heads/master@{#377736}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1725303005
Cr-Commit-Position: refs/heads/master@{#377719}
|
|
|
|
|
|
|
|
| |
BUG=chromedriver:1224
Review URL: https://codereview.chromium.org/1664043002
Cr-Commit-Position: refs/heads/master@{#377433}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch moves the last function in net_util.h into url_util.h. We are
moving it there because it also operates on a URL part (host).
BUG=488531
TEST=net_unittests --gtest_filter=UrlUtilTest.IsLocalhost
R=eroman@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/1726693002
Cr-Commit-Position: refs/heads/master@{#377115}
|
|
|
|
|
|
|
|
|
|
| |
on android waterfall bots.
BUG=chromedriver:1006 , chromedriver:1044
Review URL: https://codereview.chromium.org/1562803004
Cr-Commit-Position: refs/heads/master@{#374716}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a documentation-only change.
Disabling presubmit checks, due to "noparent" settings for the following files:
components/policy/resources/policy_templates.json
content/common/font_config_ipc_linux.h
BUG=567488
NOPRESUBMIT=true
TBR=atwilson,dcheng
Review URL: https://codereview.chromium.org/1592403002
Cr-Commit-Position: refs/heads/master@{#374213}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure ChromeDriverLogTest.testDisablingDriverLogsSuppressesChromeDriverLog
doesn't try to launch a desktop browser session when running on Android. The
logic in ChromeDriverBaseTest.CreateDriver() does the right thing for Android,
so use that instead of creating a driver directly.
Common code between tests in ChromeDriverLogTest still need to be factored out
into separate setUp and tearDown methods in a separate CL.
BUG=chromedriver:1266
TBR=stgao@chromium.org
Review URL: https://codereview.chromium.org/1672243002
Cr-Commit-Position: refs/heads/master@{#373967}
|
|
|
|
|
|
|
|
|
| |
BUG=chromedriver:1266
TBR=stgao@chromium.org
Review URL: https://codereview.chromium.org/1669343002
Cr-Commit-Position: refs/heads/master@{#373863}
|
|
|
|
|
|
|
|
|
|
| |
'OFF'.
BUG=chromedriver:1266
Review URL: https://codereview.chromium.org/1668023002
Cr-Commit-Position: refs/heads/master@{#373686}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I searched for "length() - 1]", which won't find all potential sites to use
back(), but should hit a reasonable number. These were all converted.
I don't consider str.front() to be vastly more readable than str[0], so I made
no effort to seek these out and change them. I did change code to use front()
when it would make for better parallel structure with a place I was making use
back(), e.g.:
if (str[0] == 'x' && str[str.length() - 1] == 'y') {
...was transformed to:
if (str.front() == 'x' && str.back() == 'y') {
...and not:
if (str[0] == 'x' && str.back() == 'y') {
I also added front() and back() methods to StringPiece so people wouldn't need to distinguish between string and StringPiece for these purposes.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1663253004
Cr-Commit-Position: refs/heads/master@{#373672}
|
|
|
|
|
|
|
|
|
|
| |
The test was failing about 10% of runs in mac release build.
BUG=
Review URL: https://codereview.chromium.org/1640733003
Cr-Commit-Position: refs/heads/master@{#373665}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of https://codereview.chromium.org/1653003006/
Consolidating the _run targets into the test template should make them
easier to maintain (and, eventually, remove).
BUG=583694
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1662053002
Cr-Commit-Position: refs/heads/master@{#373385}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1653003006/ )
Reason for revert:
Broke angle_unittests_run, which doesn't follow the template:
https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/builds/53646/steps/compile/logs/stdio
Original issue's description:
> Move gn _run target generation into test().
>
> TBR=brettw@chromium.org
> BUG=
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/6b1b03783b81ea27bb521c02aa84b74f06d6f71a
> Cr-Commit-Position: refs/heads/master@{#373232}
TBR=phosek@chromium.org,brettw@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1664653003
Cr-Commit-Position: refs/heads/master@{#373257}
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1653003006
Cr-Commit-Position: refs/heads/master@{#373232}
|
|
|
|
|
|
|
|
|
|
| |
on Linux & Mac.
BUG=chromedriver:1302
Review URL: https://codereview.chromium.org/1660143002
Cr-Commit-Position: refs/heads/master@{#373074}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1648703002
Cr-Commit-Position: refs/heads/master@{#372362}
|
|
|
|
|
|
|
|
| |
BUG=chromedriver:1249
Review URL: https://codereview.chromium.org/1642773002
Cr-Commit-Position: refs/heads/master@{#371916}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is part of the net::IPAddressNumber migration[1].
IPEndpoint::address() currently returns a net::IPAddressNumber but we need it to return a net::IPAddress.
BUG=496258
TBR=scheib
[1] https://code.google.com/p/chromium/issues/detail?id=496258#c10
Review URL: https://codereview.chromium.org/1565303002
Cr-Commit-Position: refs/heads/master@{#371750}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1633973002
Cr-Commit-Position: refs/heads/master@{#371451}
|
|
|
|
|
|
|
|
|
|
| |
android bot
BUG=579782
Review URL: https://codereview.chromium.org/1631093002
Cr-Commit-Position: refs/heads/master@{#371378}
|
|
|
|
|
|
|
|
| |
BUG=chromedriver:1310
Review URL: https://codereview.chromium.org/1604903003
Cr-Commit-Position: refs/heads/master@{#370590}
|
|
|
|
|
|
|
|
| |
BUG=476719
Review URL: https://codereview.chromium.org/1581203002
Cr-Commit-Position: refs/heads/master@{#369786}
|
|
|
|
|
|
|
|
| |
BUG=chromedriver:824
Review URL: https://codereview.chromium.org/1564203005
Cr-Commit-Position: refs/heads/master@{#369216}
|
|
|
|
|
|
|
|
|
|
| |
Mark tools that are only used for testing as NOT_SHIPPED. Also fix bintree's license (MIT License -> MIT) and fix the name & short name of libc++-static.
BUG=499582
Review URL: https://codereview.chromium.org/1532203002
Cr-Commit-Position: refs/heads/master@{#369150}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1562533002
Cr-Commit-Position: refs/heads/master@{#367608}
|
|
|
|
|
|
|
|
|
| |
BUG=chromedriver:1304
TBR=stgao@chromium.org
Review URL: https://codereview.chromium.org/1559623002
Cr-Commit-Position: refs/heads/master@{#367392}
|
|
|
|
|
|
|
|
| |
BUG=chromedriver:1302
Review URL: https://codereview.chromium.org/1553453002
Cr-Commit-Position: refs/heads/master@{#367005}
|
|
|
|
|
|
|
|
|
|
|
|
| |
☃
BUG=557422
R=avi@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1551503002
Cr-Commit-Position: refs/heads/master@{#366918}
|
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=thakis@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1548153002
Cr-Commit-Position: refs/heads/master@{#366893}
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1530183008/ CL fixed the issue.
BUG=chromedriver:1290
Review URL: https://codereview.chromium.org/1549593002
Cr-Commit-Position: refs/heads/master@{#366688}
|
|
|
|
|
|
|
|
| |
BUG=chromedriver:1295
Review URL: https://codereview.chromium.org/1545463002
Cr-Commit-Position: refs/heads/master@{#366498}
|
|
|
|
|
|
|
|
|
|
|
| |
Timeout issue#1278 got fixed with the release of CL https://codereview.chromium.org/1530133002
Hence, re-enabling the tests.
BUG=chromedriver:1278
Review URL: https://codereview.chromium.org/1540013002
Cr-Commit-Position: refs/heads/master@{#366496}
|
|
|
|
|
|
|
|
|
|
|
| |
subframes.
BUG=chromedriver:1276
TBR=stgao@chromium.org
Review URL: https://codereview.chromium.org/1530183008
Cr-Commit-Position: refs/heads/master@{#366186}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #3 id:40001 of https://codereview.chromium.org/1510783002/ )
Reason for revert:
this is causing some waterfall failures, as well as regressions for older browser versions
Original issue's description:
> [chromedriver] Do not wrap or unwrap functions of an object.
>
> TBR=samuong@chromium.org
> BUG=chromedriver:1276
>
> Committed: https://crrev.com/07972b514fa41867dfe7c9ad34e511702cd16987
> Cr-Commit-Position: refs/heads/master@{#363990}
TBR=gmanikpure@chromium.org,stgao@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromedriver:1276
Review URL: https://codereview.chromium.org/1538513006
Cr-Commit-Position: refs/heads/master@{#366174}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also added missing include to
chrome/test/chromedriver/net/url_request_context_getter.cc
TBR=samuong@chromium.org
BUG=554289
Review URL: https://codereview.chromium.org/1530133002
Cr-Commit-Position: refs/heads/master@{#366083}
|
|
|
|
|
|
|
|
|
|
| |
issue
BUG=chromedriver:1278,chromedriver:1290
Review URL: https://codereview.chromium.org/1515773002
Cr-Commit-Position: refs/heads/master@{#365573}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:20001 of https://codereview.chromium.org/1504383002/ )
Reason for revert:
broke compile on all cronet builders, see crbug.com/569978
Original issue's description:
> Remove ScopedVector from url_request_context_builder
>
> Also added missing include to
> chrome/test/chromedriver/net/url_request_context_getter.cc
>
> TBR=samuong@chromium.org
>
> BUG=554289
>
> Committed: https://crrev.com/346f43fc9a434c770542f6237929dabaf4c0a187
> Cr-Commit-Position: refs/heads/master@{#365221}
TBR=rsleevi@chromium.org,samuong@chromium.org,jochen@chromium.org,olli.raula@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=554289
Review URL: https://codereview.chromium.org/1525263003
Cr-Commit-Position: refs/heads/master@{#365300}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also added missing include to
chrome/test/chromedriver/net/url_request_context_getter.cc
TBR=samuong@chromium.org
BUG=554289
Review URL: https://codereview.chromium.org/1504383002
Cr-Commit-Position: refs/heads/master@{#365221}
|
|
|
|
|
|
|
|
|
| |
BUG=569561
TBR=pasko@chromium.org,samuong@chromium.org
Review URL: https://codereview.chromium.org/1528703003
Cr-Commit-Position: refs/heads/master@{#365149}
|