summaryrefslogtreecommitdiffstats
path: root/chrome/tools
Commit message (Collapse)AuthorAgeFilesLines
* Make sure the PDB path in Syzygy-optimized Chrome is absolute.siggi@chromium.org2011-12-201-5/+5
| | | | | | | | | | | R=rogerm@chromium.org,mmoss@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8989031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115209 0039d316-1c4b-4281-b951-d872f2087c98
* Go through NotificationService interface in the remaining places.tfarina@chromium.org2011-12-191-2/+3
| | | | | | | | | | BUG=98716 R=jam@chromium.org TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/8963033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114994 0039d316-1c4b-4281-b951-d872f2087c98
* Archive the chrome.dll ordering file.siggi@chromium.org2011-12-151-0/+5
| | | | | | | | | R=mmoss@chromium.org Review URL: http://codereview.chromium.org/8909011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114530 0039d316-1c4b-4281-b951-d872f2087c98
* Simple tool to populate a signature info protocol buffer from an executable.bryner@chromium.org2011-12-141-0/+57
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8931018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114512 0039d316-1c4b-4281-b951-d872f2087c98
* Breakpad: Compile Breakpad into Chromium by default on Macmseaborn@chromium.org2011-12-141-3/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is intended to make it easier to test Breakpad crash dumping on the buildbots. Crash dumping will be disabled in Chromium by default at run time unless CHROME_HEADLESS is set. The bots set CHROME_HEADLESS, but we don't really want the bots to be uploading crash dumps that are useless without symbols, so uploading is disabled except for official builds and when building with mac_breakpad_uploads=1. This should not affect stack backtraces that occur in tests (such as browser_tests) via StackDumpSignalHandler(). Although Breakpad would normally take priority over this signal handler, Breakpad does not get enabled in these test suites because is_browser is false inside InitCrashReporter(). This change leaves the Gyp option "mac_breakpad" for enabling the creation of Breakpad files. This remains off by default for Chromium builds, because the symbol dumping is slow and because it has problems in the makefile-based Mac builds. BUG=105778 TEST=run Chromium with --crash-test and CHROME_HEADLESS=1; a *.dmp file should appear in ~/Library/Application Support/Chromium/Crash Reports Review URL: http://codereview.chromium.org/8824003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114468 0039d316-1c4b-4281-b951-d872f2087c98
* Split UserMetrics into API vs. implementation. Move API to content/public.joi@chromium.org2011-12-141-5/+12
| | | | | | | | | TBR=davemoore@chromium.org BUG=98716 Review URL: http://codereview.chromium.org/8919017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114416 0039d316-1c4b-4281-b951-d872f2087c98
* Fix UserActionsMetrics calls for content settings UMA, so that they get ↵markusheintz@chromium.org2011-12-091-9/+9
| | | | | | | | | | | | | | picked up by the the chrome/tools/extract_actions.py tool. Remove wrong and unused user action metrics hash and add the correct hashes. BUG=105865 TEST=none Review URL: http://codereview.chromium.org/8873056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113798 0039d316-1c4b-4281-b951-d872f2087c98
* Add syzygy files to archives and symbol processing.mmoss@chromium.org2011-12-072-0/+24
| | | | | | Review URL: http://codereview.chromium.org/8836001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113482 0039d316-1c4b-4281-b951-d872f2087c98
* Adding ChromeOS Photo Editor user actionskaznacheev@chromium.org2011-12-072-1/+10
| | | | | | | | | | | | This is to support http://codereview.chromium.org/8819013/ BUG=chromium-os:23750 TEST= Review URL: http://codereview.chromium.org/8822013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113380 0039d316-1c4b-4281-b951-d872f2087c98
* Use `/usr/bin/env python` instead of `/usr/bin/python2.6`.thakis@chromium.org2011-12-071-1/+1
| | | | | | | | | | | | Useful on machines that don't have 2.6 but do have 2.7. BUG=none TEST=none Review URL: http://codereview.chromium.org/8825016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113334 0039d316-1c4b-4281-b951-d872f2087c98
* Add xinput1_3.dll redist to final package.scottmg@google.com2011-12-061-0/+6
| | | | | | | | | | | | | | Adds XInput redist DLL which is a new dependency of recently added gamepad code, and is required on Win XP. laforge has OK'd the size addition to the final package (~100K). BUG=79050 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112812 Review URL: http://codereview.chromium.org/8774023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113274 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 112812 - Add xinput1_3.dll redist to final package.thestig@chromium.org2011-12-031-6/+0
| | | | | | | | | | | | | | | Adds XInput redist DLL which is a new dependency of recently added gamepad code, and is required on Win XP. laforge has OK'd the size addition to the final package (~100K). BUG=79050 Review URL: http://codereview.chromium.org/8774023 TBR=scottmg@google.com Review URL: http://codereview.chromium.org/8788009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112859 0039d316-1c4b-4281-b951-d872f2087c98
* Add xinput1_3.dll redist to final package.scottmg@google.com2011-12-021-0/+6
| | | | | | | | | | | | Adds XInput redist DLL which is a new dependency of recently added gamepad code, and is required on Win XP. laforge has OK'd the size addition to the final package (~100K). BUG=79050 Review URL: http://codereview.chromium.org/8774023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112812 0039d316-1c4b-4281-b951-d872f2087c98
* A utility script to manipulate and extract resources from Windows programs.siggi@chromium.org2011-12-021-0/+320
| | | | | | | | | | | This might be considered a first step in making our release signing process a little less opaque and brittle. R=bradnelson@chromium.org,robertshield@chromium.org,grt@chromium.org BUG=36234 Review URL: http://codereview.chromium.org/8775026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112707 0039d316-1c4b-4281-b951-d872f2087c98
* Added recommended pref store on Windows.joaodasilva@chromium.org2011-12-011-26/+35
| | | | | | | | | BUG=49941 TEST=Set policies for Chromium/Chrome in a registry subkey named "Recommended". Those policies become the default values and can be overridden by the user. Review URL: http://codereview.chromium.org/8551010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112456 0039d316-1c4b-4281-b951-d872f2087c98
* Add UMA for default content settings values, and default content settings ↵markusheintz@chromium.org2011-11-301-0/+9
| | | | | | | | | | | | changed actions. BUG=TODO TEST=none Review URL: http://codereview.chromium.org/8698006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112182 0039d316-1c4b-4281-b951-d872f2087c98
* Delete some unused content settings exceptions stringsestade@chromium.org2011-11-301-2/+5
| | | | | | | | | | | these are left over from native dialogs BUG=none TEST=none Review URL: http://codereview.chromium.org/8676029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112079 0039d316-1c4b-4281-b951-d872f2087c98
* Fix resource file generation to point to output_dir instead of build_dir.siggi@chromium.org2011-11-291-7/+8
| | | | | | | | | | | | | This makes the RC script correct for the Syzygy-optimized mini_installer, which was previously turning out identical to the unoptimized one. Quench annoying progress spew from makecab. R=rogerm@chromium.org,robertshield@chromium.org Review URL: http://codereview.chromium.org/8726035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111962 0039d316-1c4b-4281-b951-d872f2087c98
* Update Breakpad to r891, to pick up r891. r891 is a speculative backout ofmark@chromium.org2011-11-282-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Breakpad r883. Along with that, a partial backout of Chrome r110931 is needed to account for an API change. Breakpad log: ------------------------------------------------------------------------ r891 | mark@chromium.org | 2011-11-28 14:17:41 -0500 (Mon, 28 Nov 2011) | 2 lines Speculative back-out of r883, which may have broken Windows crash reporting. ------------------------------------------------------------------------ r890 | jimblandy | 2011-11-23 18:03:30 -0500 (Wed, 23 Nov 2011) | 5 lines Fix some comments and parameter names. Trivial changes; committing for post-facto review. ------------------------------------------------------------------------ r889 | qsr@chromium.org | 2011-11-23 11:14:35 -0500 (Wed, 23 Nov 2011) | 4 lines Create a static library to use Breakpad on iOS. This obliged me to move BreakpadDefines.h to src/client/apple/Framework/BreakpadDefines.h Review URL: http://breakpad.appspot.com/329001 ------------------------------------------------------------------------ Review URL: http://codereview.chromium.org/8664008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111783 0039d316-1c4b-4281-b951-d872f2087c98
* Build a Syzygy-reordered mini_installer.exe.siggi@chromium.org2011-11-282-7/+133
| | | | | | | | | | | | | | This CL adds an All_syzygy target to the build/all.gyp solution, that builds a Syzygy-reordered chrome.dll and mini_installer. If there there is a chrome.dll-order.json file present in the output directory, chrome.dll will be ordered according to that, otherwise it will be randomized. Moved most of mini_installer.gyp to a common .gypi file for reuse. Review URL: http://codereview.chromium.org/8698009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111710 0039d316-1c4b-4281-b951-d872f2087c98
* Have content/ create and destroy its own threads. (Re-land)joi@chromium.org2011-11-281-2/+3
| | | | | | | | | | | | | | | | | | | Change embedding API and embedders to allow for this. Push inheritance of base::Thread down to content::BrowserThreadImpl so that content::BrowserThread is just a namespace for API functions. This change temporarily disables chrome_frame_net_tests as agreed by the CF lead, see bug 105435. TBR=ben@chromium.org (IWYU change only) BUG=98716,104578,105435 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111695 Reverted (problems on official bot): r111698 Review URL: http://codereview.chromium.org/8477004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111705 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 111695 - Have content/ create and destroy its own threads.joi@chromium.org2011-11-281-3/+2
| | | | | | | | | | | | | | | | | | | | | Reason: Problems on official builders. Change embedding API and embedders to allow for this. Push inheritance of base::Thread down to content::BrowserThreadImpl so that content::BrowserThread is just a namespace for API functions. This change temporarily disables chrome_frame_net_tests as agreed by the CF lead, see bug 105435. TBR=ben@chromium.org (IWYU change only) BUG=98716,104578,105435 Review URL: http://codereview.chromium.org/8477004 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/8718012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111698 0039d316-1c4b-4281-b951-d872f2087c98
* Have content/ create and destroy its own threads.joi@chromium.org2011-11-281-2/+3
| | | | | | | | | | | | | | | | Change embedding API and embedders to allow for this. Push inheritance of base::Thread down to content::BrowserThreadImpl so that content::BrowserThread is just a namespace for API functions. This change temporarily disables chrome_frame_net_tests as agreed by the CF lead, see bug 105435. TBR=ben@chromium.org (IWYU change only) BUG=98716,104578,105435 Review URL: http://codereview.chromium.org/8477004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111695 0039d316-1c4b-4281-b951-d872f2087c98
* Fix python scripts in src/chrome/maruel@chromium.org2011-11-2719-470/+452
| | | | | | | | | | | | | | | | | | | | Make sure that: - shebang is only present for executable files - shebang is #!/usr/bin/env python - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. Minor python style fixes. TBR=nirnimesh@chromium.org BUG=105108 TEST= Review URL: http://codereview.chromium.org/8680018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111658 0039d316-1c4b-4281-b951-d872f2087c98
* Another attempt to land http://codereview.chromium.org/8589029.siggi@chromium.org2011-11-211-117/+148
| | | | | | | | | | | | | | | | | | Start of mini_installer build config refactoring. Baby step one: - All intermediate files go into the intermediate directory. - The packed_files.txt file is gone, and instead the mini_installer is baked from a resource file output into the intermediate dir. - Cleanup use of implict global "options" in the python script. - Use subprocess.call with a list instead of os.system. R=robertshield@chromium.org,grt@chromium.org BUG=102115 Review URL: http://codereview.chromium.org/8615002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111012 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a bunch of view_messages.h includes from chrome by making the ↵jam@chromium.org2011-11-211-0/+3
| | | | | | | | | TabContentsObserver interface not use a struct from it. Instead, the interface uses a new struct, content::FrameNavigateParams, that's in the public directory. The IPC message's struct derives from it. BUG=98716 Review URL: http://codereview.chromium.org/8603015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110963 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 110934 - Retry of http://codereview.chromium.org/8589029.siggi@chromium.org2011-11-211-148/+117
| | | | | | | | | | | | | | | | | | | | | Start of mini_installer build config refactoring. Baby step one: - All intermediate files go into the intermediate directory. - The packed_files.txt file is gone, and instead the mini_installer is baked from a resource file output into the intermediate dir. - Cleanup use of implict global "options" in the python script. - Use subprocess.call with a list instead of os.system. R=robertshield@chromium.org,grt@chromium.org BUG=102115 Review URL: http://codereview.chromium.org/8600008 TBR=siggi@chromium.org Review URL: http://codereview.chromium.org/8575019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110936 0039d316-1c4b-4281-b951-d872f2087c98
* Retry of http://codereview.chromium.org/8589029.siggi@chromium.org2011-11-211-117/+148
| | | | | | | | | | | | | | | | | | Start of mini_installer build config refactoring. Baby step one: - All intermediate files go into the intermediate directory. - The packed_files.txt file is gone, and instead the mini_installer is baked from a resource file output into the intermediate dir. - Cleanup use of implict global "options" in the python script. - Use subprocess.call with a list instead of os.system. R=robertshield@chromium.org,grt@chromium.org BUG=102115 Review URL: http://codereview.chromium.org/8600008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110934 0039d316-1c4b-4281-b951-d872f2087c98
* Update breakpad to rev: 886.qsr@chromium.org2011-11-212-1/+5
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/8595014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110931 0039d316-1c4b-4281-b951-d872f2087c98
* Retry 110725 - Remove legacy FILES files.mmoss@chromium.org2011-11-193-94/+0
| | | | | | | | | These should now be replaced by FILES.cfg in all active branches and build scripts. Review URL: http://codereview.chromium.org/8603001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110800 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 110725 - Remove legacy FILES files.mmoss@chromium.org2011-11-183-0/+94
| | | | | | | | | | | | These should now be replaced by FILES.cfg in all active branches and build scripts. Review URL: http://codereview.chromium.org/8566042 TBR=mmoss@chromium.org Review URL: http://codereview.chromium.org/8596012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110729 0039d316-1c4b-4281-b951-d872f2087c98
* Remove legacy FILES files.mmoss@chromium.org2011-11-183-94/+0
| | | | | | | | | These should now be replaced by FILES.cfg in all active branches and build scripts. Review URL: http://codereview.chromium.org/8566042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110725 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 110703 - Start of mini_installer build config refactoring.siggi@chromium.org2011-11-181-148/+117
| | | | | | | | | | | | | | | | | | | | Baby step one: - All intermediate files go into the intermediate directory. - The packed_files.txt file is gone, and instead the mini_installer is baked from a resource file output into the intermediate dir. - Cleanup use of implict global "options" in the python script. - Use subprocess.call with a list instead of os.system. R=robertshield@chromium.org,grt@chromium.org BUG=102115 Review URL: http://codereview.chromium.org/8589029 TBR=siggi@chromium.org Review URL: http://codereview.chromium.org/8569012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110716 0039d316-1c4b-4281-b951-d872f2087c98
* Start of mini_installer build config refactoring.siggi@chromium.org2011-11-181-117/+148
| | | | | | | | | | | | | | | | | Baby step one: - All intermediate files go into the intermediate directory. - The packed_files.txt file is gone, and instead the mini_installer is baked from a resource file output into the intermediate dir. - Cleanup use of implict global "options" in the python script. - Use subprocess.call with a list instead of os.system. R=robertshield@chromium.org,grt@chromium.org BUG=102115 Review URL: http://codereview.chromium.org/8589029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110703 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeOS should record FileBrowser.CreateNewFolder.... eventskaznacheev@chromium.org2011-11-162-0/+16
| | | | | | | | | | | | | | | | | Added UMA user action implemented in http://codereview.chromium.org/8490014/ to extract_actions.py, updated chromeactions.txt. Note: when I ran extract_actions.py --hash I saw a number of new actions show up in chromeactions.txt. Someone has probably forgot to update it. I am only adding the one line related to my action in this patch. BUG=chromium-os:22860 TEST= Review URL: http://codereview.chromium.org/8537008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110303 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 109261 - Revert 109054 - Add artifacts for GCP virtual driver.abodenha@chromium.org2011-11-143-0/+22
| | | | | | | | | | | | | | | | BUG= TEST=No visible changes Review URL: http://codereview.chromium.org/8500001 TBR=abodenha@chromium.org Review URL: http://codereview.chromium.org/8506021 TBR=abodenha@chromium.org Review URL: http://codereview.chromium.org/8564016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109905 0039d316-1c4b-4281-b951-d872f2087c98
* Include only policy definitions that apply to the platfrom in the policy ↵mnissler@chromium.org2011-11-101-37/+34
| | | | | | | | | | | | definition list. BUG=chromium-os:19411 TEST=compiles, unit tests pass. Review URL: http://codereview.chromium.org/8467011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109405 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 109054 - Add artifacts for GCP virtual driver.abodenha@chromium.org2011-11-093-22/+0
| | | | | | | | | | | | | BUG= TEST=No visible changes Review URL: http://codereview.chromium.org/8500001 TBR=abodenha@chromium.org Review URL: http://codereview.chromium.org/8506021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109261 0039d316-1c4b-4281-b951-d872f2087c98
* Add artifacts for GCP virtual driver.abodenha@chromium.org2011-11-083-0/+22
| | | | | | | | | | BUG= TEST=No visible changes Review URL: http://codereview.chromium.org/8500001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109054 0039d316-1c4b-4281-b951-d872f2087c98
* Warn about deprecated policies on the console and about:policy.joaodasilva@chromium.org2011-11-041-14/+41
| | | | | | | | | | | | Also doing the policies->preferences translation in a single place, to reduce code duplication. TEST=Set the IncognitoEnabled policy to some value. about:policy warns that the policy is deprecated. Review URL: http://codereview.chromium.org/8443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108647 0039d316-1c4b-4281-b951-d872f2087c98
* Move BrowserThread to content namespace.joi@chromium.org2011-11-021-2/+3
| | | | | | | | | TBR=owners BUG=98716 Review URL: http://codereview.chromium.org/8437002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
* Split BrowserThread into public API and private implementation, step 1.joi@chromium.org2011-10-282-3/+4
| | | | | | | | | | | | | | | | | | | | | Only content/ now has the ability to create BrowserThread objects, with the exception that tests can create the content::TestBrowserThread subclass, and (temporarily) code in chrome/ can create the DeprecatedBrowserThread subclass. A follow-up change will make content/ take care of its own thread creation, remove DeprecatedBrowserThread, and move all state and non-trivial constructors from BrowserThread down to BrowserThreadImpl. Also moved BrowserProcessSubThread into content/ namespace. As part of follow-up cleanup, chrome/ will stop using this class. BUG=98716 TEST=existing Review URL: http://codereview.chromium.org/8392042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
* Add Remoting Host plugin to linux/SYMBOLS.lambroslambrou@google.com2011-10-261-0/+2
| | | | | | | | | BUG=87632 TEST=Check official build logs Review URL: http://codereview.chromium.org/8394064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107430 0039d316-1c4b-4281-b951-d872f2087c98
* Hand edit to add BadMessageTerminate_NC17 to the chromeactions.txt for a one ↵laforge@chromium.org2011-10-251-0/+1
| | | | | | | | off test for a branch release. Review URL: http://codereview.chromium.org/8392016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107213 0039d316-1c4b-4281-b951-d872f2087c98
* Make NotificationService an interface in the content namespace, and switch ↵jam@chromium.org2011-10-191-2/+2
| | | | | | | | | callers to use it. Move the implementation to content/browser. Stop creating it in all child processes since it's only used in the browser. BUG=98716 Review URL: http://codereview.chromium.org/8342048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106403 0039d316-1c4b-4281-b951-d872f2087c98
* Generate Chrome policy definition list from policy_templates.json.joaodasilva@chromium.org2011-10-131-17/+114
| | | | | | | | | | | | | | | | The struct and static array is now generated into policy_constants.h. Added policy::GetChromePolicyDefinitionList() and policy::GetPolicyName(). Removed ConfigurationPolicyProvider::PolicyDefinitionList. Removed PolicyStates::GetPolicyName(). Removed ConfigurationPolicyPrefStore::GetChromePolicyDefinitionList(). BUG=None TEST=Everything works as before, nothing breaks Review URL: http://codereview.chromium.org/8258018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105388 0039d316-1c4b-4281-b951-d872f2087c98
* Move PageTransition into content namespace. While I'm touching all these ↵jam@chromium.org2011-10-131-3/+3
| | | | | | | | | files, I've also updated it to use the enum naming convention in the Content API. BUG=98716 Review URL: http://codereview.chromium.org/8253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105254 0039d316-1c4b-4281-b951-d872f2087c98
* Fix check_perms failure from r105190.thestig@chromium.org2011-10-121-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105208 0039d316-1c4b-4281-b951-d872f2087c98
* x86-64 Breakpad: Append "-x64" to the pipe name for 64-bit processesmseaborn@chromium.org2011-10-121-0/+4
| | | | | | | | | | | | | | | | | | | | | | The protocol for connecting to the out-of-process Breakpad crash reporter is different for x86-32 and x86-64 (the message sizes are different because the message struct contains a pointer), so we use different pipe names for the two crash reporters. Appending "-x64" is the simplest way of doing this. It allows two crash handlers to coexist even when using the env var CHROME_BREAKPAD_PIPE_NAME for testing. Google Update (Omaha) does not yet launch an x86-64 crash handler for this to connect to -- that is a work-in-progress. BUG=89730 TEST=compile-tested; will be covered by nacl_integration later Review URL: http://codereview.chromium.org/8231036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105190 0039d316-1c4b-4281-b951-d872f2087c98
* Update Breakpad to r842, picking up:mark@chromium.org2011-10-031-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ------------------------------------------------------------------------ r842 | mark@chromium.org | 2011-10-03 15:54:28 -0400 (Mon, 03 Oct 2011) | 11 lines Use a bootstrap subset port for the inspector, tying the subset to the lifetime of the task to be monitored, the invoking task. This allows the bootstrap server (in launchd) to automatically clean up the Mach server registration when the task being monitored exits, avoiding leaks of com.Breakpad.Inspector(pid) ports in "launchctl bslist". BUG=chromium:28547 TEST=Handler should still crash catches, but inspector ports should no longer show up in "launchctl bslist". They should show up under a subset port in "launchctl bstree" instead. "launchctl bstree" must be invoked as root. Review URL: http://breakpad.appspot.com/306001 ------------------------------------------------------------------------ This gives each Breakpad instance its own bootstrap subset port as a subset of the process' bootstrap port, and places the Breakpad inspector port into the bootstrap subset port. This completely eliminates leaks of on-demand Mach services advertised via the bootstrap server. This also reverts r34318 and r34534, "temporary" (21-month) hacks to mitigate the leak. The temporary hacks were never completely effective against Breakpad ports leaking from child processes. DestructCrashReporter at process shutdown was deemed unnecessary and is being removed. As this was the last caller to that function, the implementation is removed as well. This is addressed in Breakpad rather than Chrome because a mechanism to fix it without changing the process' bootstrap port was discovered. It was determined that the rohitfork port is already immune to leaks of the sort that the Breakpad inspector port experiences. A previous attempt to fix this bug was r103089, but that caused bug 98550. This strategy is safer. The forked Breakpad module.cc is updated to match upstream r835, which allows the unforking of the CFI-disabling code. A new CFI-disabling "-c" option to dump_syms is now available and used by the dump_product_syms script. BUG=28547 TEST=1. "launchctl bslist" should no longer show on-demand com.Breakpad.Inspector ports (in Breakpad-enabled builds with Breakpad on) ports. 2. "launchctl bstree" (as root) should reveal a bootstrap subset for each process as a child of the per-user/per-session bootstrap namespace if crash reporting is on. One com.Breakpad.Inspector port should show up as a child of each bootstrap subset. As each process exits (even if mercilessly killed by "kill -9"), the associated subsets and inspector ports should disappear. 3. Breakpad reports should be generated on crashes. For example, about:crash and about:inducebrowsercrashforrealz should each cause a minidump to be written in ~/Library/Application Support/Google/Chrome/Crash Reports when Breakpad is enabled. This tests that the Breakpad ports are functioning properly. 4. The browser process should be able to access child process data. Window:Task Manager should show valid values for the Memory, CPU, and Network columns for all child processes. This tests that the rohitfork port is functioning properly. Note that this version of the change does not change the handling of rohitfork ports at all, but this test case was useful in a previous version of this patch. 5. Test case from bug 98550: Have a link in a web browser window (in a different browser) and drag it into Chrome. Expect the drag operation to operate properly in both the tab strip and in web content. See bug 98550 for details. 6. Unreported test case that failed in r103089: browser relaunch should work. Visit chrome://flags, change some flags to get the "Relaunch Now" button at the bottom (you can put the flags back to how you found them initially), and click "Relaunch Now". The browser should close and then be relaunched. Review URL: http://codereview.chromium.org/8120007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103778 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 14:35:53 +0000