| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Joi has convinced me that GRIT should generate platform specific
resources files. This is easier than parsing .rc files because
GRIT effectively has an .rc parser. To that end, we need to
convert some existing .rc files to .grd files (e.g., net_resources.rc
and webkit_resources.rc). Rather than having every grd file output
to a different place and -I all the different paths, have GRIT
generate all files into one directory. This directory is
grit_derived_sources.
Review URL: http://codereview.chromium.org/13776
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(but not all) base types.
Review URL: http://codereview.chromium.org/13726
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
believe RichEdit is sending a WM_COMMAND with an id of 35000, which
corresponds to IDC_STAR. Peter's changing of IDs resulted in IDC_STAR
getting set to 35000. I'm hoping the WM_COMMAND sent from the rich
edit has it's high bits set appropriately so that this change will
result in not trying to execute IDC_STAR when we get the command.
WARNING: this is all speculation from looking at the traces. I
couldn't repro on my machine.
BUG=5405
TEST=none
Review URL: http://codereview.chromium.org/14010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Adds a search field before the text field.
. When the search node is selected and there are no results or no
search text, a descriptive label is drawn on top of the table
telling the user what's happening.
. In the bookmark menus Edit... is now Rename... for folders.
BUG=5272 5319 5273 4165
TEST=see individual bugs
Review URL: http://codereview.chromium.org/13724
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the wrong side.
BUG=5067
TEST=see bug
Review URL: http://codereview.chromium.org/13353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
also renamed the namespace from "gfx" to "skia".
This also adds back the image_operations_unittest to a project (this had gotten lost in my move).
Review URL: http://codereview.chromium.org/13143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
We now properly handle Enter when links are focused. I also made it so that links navigate on KeyDown (when you press Enter or Space) instead of on KeyUp. This matches WebKit and native Windows behavior.
Review URL: http://codereview.chromium.org/13321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
delegate says it can be minimized.
BUG=4083
TEST=none
Review URL: http://codereview.chromium.org/13683
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in tree_node_model.
Review URL: http://codereview.chromium.org/13274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
like me.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/13267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=4065
TEST=none
Review URL: http://codereview.chromium.org/13264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Consistently use underscores between words in identifiers (IDC_NEWTAB -> IDC_NEW_TAB)
* Make some identifiers clearer or more up-to-date (IDC_DUPLICATE -> IDC_DUPLICATE_TAB, IDC_GOOFFTHERECORD -> IDC_NEW_INCOGNITO_WINDOW, IDC_NEWPROFILEWINDOW -> IDC_PROFILE_MENU)
* Try and make string identifiers (IDS_xxx) match their corresponding IDC_xxx commands. Tony tells me this will not cause any need for retranslation.
* As much as possible (without modifying automated UI test XML files), use "Bookmark Bar", not "Bookmarks Bar" (this seemed to be prevailing usage in the code)
* Fix 80-column issues
This patch touches move files than any subsequent patches, but should be the most rubber-stampable.
Review URL: http://codereview.chromium.org/13633
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
proxying for CB_GETCOMBOXINFO is wrong and will crash. Instead, call
GetComboBoxInfo.
BUG=49
Review URL: http://codereview.chromium.org/13156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary
=======
Implement a prototype of multiple profiles in Chrome by
utilizing the functionality of user-data-dir command line
flag that already exists.
A profile in this case is an umbrella for all user data
including cookies, history, bookmarks, settings, etc. Each
profile gives the user a separation of all these data
elements.
User Interface
==============
- Wrench > "New window in profile" menu item, with sub-menu items.
This new menu item has sub menu items for each existing
profile, for up to 9 profiles, and one more sub menu item
to launch a window in a new profile. The 9 sub-menu items
also have the accelerators like CTRL + SHIFT + 1, CTRL +
SHIFT + 2, etc. If there are more than 9 profiles, we
will also show an extra sub-menu item, "Other...".
- New Profile dialog box
This dialog box is shown to the use when (s)he clicks
Wrench > New window in profile > <New Profile>. It lets
the user specify a profile name, and also shows a checkbox
to create a desktop shortcut to launch Chrome in that profile.
- Choose profile dialog box
This dialog box lets the user select a profile from a drop
down to open a new window in. It also has an item <New Profile>
in the drop down, selecting which will show the new profile
dialog box mentioned above. CTRL + M shortcut also launches
this dialog box.
Code Organization
=================
chrome\browser\user_data_dir_profile_manager.h/.cc:
This class provides an abstraction of profiles on top of the user
data dir command line flag.
chrome\browser\views\user_data_dir_new_profile_dialog.h/.cc
New profile dialog box code.
chrome\browser\views\user_data_dir_profiles_dialog.h/.cc
Choose profile dialog box code.
Review URL: http://codereview.chromium.org/12895
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
In a later pass, I will separate off the cross-platform part of this file into skia/ext/skia_util (only one function).
Review URL: http://codereview.chromium.org/13101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
like my previous change except does no namespace renaming and doesn't touch
skia_utils.
Review URL: http://codereview.chromium.org/13080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12632
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12892
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in an RTL locale and right clicking on the icon some times the
scrollbar context menu would appear. I've fixed it by subclassing the
context menu handling and getting the location from the position of
the mouse.
BUG=4752
TEST=see bug, but also make sure this doesn't regress 4750
Review URL: http://codereview.chromium.org/13055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the namespace in those files from "gfx" to "skia".
I split skia_utils into two parts, the Windows specific part is now in a separate file called skia_utils_win.
There were several obsolete includes of these headers which I removed. I also removed img_resize_perftest which isn't used and has bitrotted.
Review URL: http://codereview.chromium.org/12842
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
there was close to no space between the tab control and the buttons.
The space is aligned with default Windows look for dialogs.
BUG=4402
TEST=Verify that all dialogs look good in any XP/Vista theme w.r. to space from
dialog contents to buttons.
Change by Sverrir Á. Berg <sverrir@google.com>, committing on his behalf.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Costa, r=ben, see http://codereview.chromium.org/10796 .
BUG=851
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12817
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Vista-only, but now we have cross platform goodness.
BUG=3676
Review URL: http://codereview.chromium.org/12670
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
case.
BUG=4520
TEST=bring up the keyword editor, type some text and make sure it gets
mapped to lower case.
Review URL: http://codereview.chromium.org/12452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
position of the mose. I've no idea why, but it seems when RTL the
position passed to OnContextMenu is wrong in weird inconsistent
ways. I thought it was interted, but that isn't always the case. I'm
also changing the anchor position to top_right when RTL.
BUG=4750
TEST=see bug
Review URL: http://codereview.chromium.org/12447
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=erg
review url = http://codereview.chromium.org/11348/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Vista we manage showing/hiding tooltips ourself. It would appear
when managing our own tooltips like this we need to explicitly hide
the tooltip. If you rapidly moved the mouse we wouldn't get a mouse
move and the tooltip would stick. The fix is to have ContainerWin
forward mouse leave and have the tooltip manager close the tooltip on
mouse leave.
BUG=2717
TEST=on vista do the following. Add a bookmark to the bookmark bar and
hover the mouse over it. Then hit control-b so the bookmark bar
disappears. Make sure the tooltip disappears too.
Review URL: http://codereview.chromium.org/11540
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sequence ContainerWin remains on the stack while the modal dialog is
showing. Prior to this fix we would delete the ContainerWin, so that
when the modal dialog closed control would return to a deleted
object. The fix is to effectively delay deleting of the ConatinerWins
used by menus.
BUG=4580
TEST=This is the sequence that triggered the crash: open a folder on
the bookmark bar, right child on a child folder that has more than 15
descendant URLs, click open all, a dialog should appear asking if you
really want to open all, click cancel and make sure it doesn't crash.
This is a subtle change to bookmark menus though, would be good to
thoroughly exercise the menus in as many permutations as you can
think of.
Review URL: http://codereview.chromium.org/11289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
because SetWorldTransform and a graphics mode of COMPATIBLE don't work
together. Instead we must use SetViewportOrgEx.
BUG=4515
TEST=see bug
Review URL: http://codereview.chromium.org/11253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
iterator renders it invalid. We were continuing to use this iterator.
R=darin
Review URL: http://codereview.chromium.org/10925
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
incorrectly, and clobbering the maximized state during initial sizing.
http://crbug.com/4437
Review URL: http://codereview.chromium.org/10758
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables the dynamic detection of battery status
changes so that we can turn on/off the hi-res timer.
Review URL: http://codereview.chromium.org/10264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#ifdef out windows-specific portion of chrome/common/l10n_util.h,
which allows me to port some other files.
I also extracted parts of chrome/views/tree_view.h to tree_model.h,
so that ATL/WTL-specific parts stay in tree_view.h, but tree_model.h
is platform-independent and can be included in files using it as base class.
Review URL: http://codereview.chromium.org/8618
Patch from Paweł Hajdan jr.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
correct style. I was debugging in here and this was annoying me, since there is no reason for these functions to be virtual.
Review URL: http://codereview.chromium.org/10638
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove the path from WinMain to the Browser object passing the show_command. For the Browser object, this is a problem since this value isn't portable. For the code in general it involves a lot of ugly wiring. It's completely unnecessary since the value is obtainable via GetStartupInfo.
- Remove show_command plumbing from all over the place (session restore, web app launcher, etc)
Change the way browser windows are constructed:
- The browser constructor now takes just a type and a profile, and simply initializes the object.
- Some configuration that used to be part of the constructor that was only used in one or two use cases (initial bounds, maximized state, web app name) are split into separate setters.
- Window creation is split out into a separate step to be called post configuration.
- Assorted static helper functions added to Browser to make construction of common types easy.
- Remove Browser::Show in favor of BrowserWindow::Show
- Adjust all callers to use the new helpers.
Change the way ChromeViews restores window placement:
- Split restored size determination from restored maximized determination. They are needed by the code at different times. Size restoration happens when the window is constructed and Window::SetInitialBounds is called. Maximized state restoration happens when the window is shown for the first time and SW_SHOWMAXIMIZED or SW_SHOWNORMAL is needed. Thus, replace WindowDelegate::RestoreWindowPosition with WindowDelegate::RestoreWindowBounds and WindowDelegate::RestoreMaximizedState.
- Window::SetInitialBounds calls WindowDelegate::RestoreWindowBounds
- Window::Show calls WindowDelegate::RestoreMaximizedState
- Adjusts all WindowDelegate implementations that override RestoreWindowPosition to implement these new methods instead.
- Move "playback/record" mode window size setting from browser_init to Browser::RestoreWindowBounds.
- Provide a virtual function on Window called GetShowState that determines the default show state to be used when Window::Show is called. For most windows and dialogs this is SW_SHOWNORMAL. AeroGlassFrame/OpaqueFrame (the browser window frames) override this since they're the app's main windows to return the value provided by GetStartupInfo which gives the value from the app shortcut.
http://crbug.com/3557
Review URL: http://codereview.chromium.org/10896
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. If a context menu was shown from a menu, then hidden we did not keep
mouse capture and bad things happened (menu wouldn't go away when
clicking else where, crash ...).
. We only update menu sizes on first show of a menu. That way if a
context menu doesn't have icons things don't shift around.
. If nothing was selected in the menu pressing the context menu
showed the context menu for the root. It doesn't make sense for the
root menu to have a context menu.
BUG=4364
TEST=see bug
Review URL: http://codereview.chromium.org/10706
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
added an option such that menus can be rendered in two ways, chubby or
skinny. The only places that uses the taller menus is the bookmark
bar.
I also made the menus use the right font.
BUG=1074332
TEST=none
Review URL: http://codereview.chromium.org/10865
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- make the window update locking use window visibility instead of WM_SETREDRAW. I believe WM_SETREDRAW is causing the window to become visible during tests.
- potential crashes caused by NULL TabcontentsDelegates.
TBR=sky
Review URL: http://codereview.chromium.org/10674
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
necessary since the text can be sized using the desktop DC, which should be faster. I made this function static, and moved the functions it used into file-local functions since they didn't depend on the class either.
This is trying to fix bug 49. This code is very close to the crash, and a 0x0 canvas seems like it might cause problems. However, it is unclear whether this will have any effect (other than performance).
Review URL: http://codereview.chromium.org/10409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5328 0039d316-1c4b-4281-b951-d872f2087c98
|