summaryrefslogtreecommitdiffstats
path: root/chrome/views
Commit message (Collapse)AuthorAgeFilesLines
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-08157-41612/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
* Fleshes out WidgetGTK and WindowGTK a bit more. This is still varysky@chromium.org2009-05-0715-78/+605
| | | | | | | | | | | rough, but makes things work a bit more. BUG=none TEST=none Review URL: http://codereview.chromium.org/113123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15598 0039d316-1c4b-4281-b951-d872f2087c98
* Change the ViewStorage API back to the way it was (void for StoreView) since ↵ben@chromium.org2009-05-073-15/+33
| | | | | | | | | | returning an int is just a test optimization. Expose a view_count() accessor on ViewStorage for unit tests to discern the number of views stored in it. Review URL: http://codereview.chromium.org/113091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15534 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all traces of NotificationService from views.ben@chromium.org2009-05-0713-188/+119
| | | | | | | | | | | | | | | | | | Specifically, notifies the FocusManager and ViewStorage directly when the view hierarchy is adjusted rather than using notifications. This change is based on the assumption that there is one focus manager per toplevel window. I think I remember you saying this before Jay. Removes the "window open/close" notifications since they aren't used at the Views level... the close notification is already sent manually by the BrowserView for automation so that continues to work. Moves the HWNDNotificationSource to common, since it's used by BrowserView. Rejiggers the BrowserList/Window to call a function implemented in the ViewsFE that handles closing non-app windows when the last browser window is closed. http://crbug.com/11387 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15468 Review URL: http://codereview.chromium.org/113016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15489 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15468.ben@chromium.org2009-05-0612-86/+139
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15470 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all traces of NotificationService from views.ben@chromium.org2009-05-0612-139/+86
| | | | | | | | | | | | | | | | Specifically, notifies the FocusManager and ViewStorage directly when the view hierarchy is adjusted rather than using notifications. This change is based on the assumption that there is one focus manager per toplevel window. I think I remember you saying this before Jay. Removes the "window open/close" notifications since they aren't used at the Views level... the close notification is already sent manually by the BrowserView for automation so that continues to work. Moves the HWNDNotificationSource to common, since it's used by BrowserView. Rejiggers the BrowserList/Window to call a function implemented in the ViewsFE that handles closing non-app windows when the last browser window is closed. http://crbug.com/11387 Review URL: http://codereview.chromium.org/113016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15468 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 4376 -- Press "Tab" key to navigate - Text focus is ↵xji@chromium.org2009-05-061-2/+2
| | | | | | | | | | | | | showing at wrong place in Hebrew and Arabic. (http://crbug.com/4376) When draw focus rectangle, x-axis need to be mirrored in RTL locale. BUG = http://crbug.com/4376 Review URL: http://codereview.chromium.org/109055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15425 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 11479 - RTL Regression: Ellipsis showing at the right ↵xji@chromium.org2009-05-061-1/+1
| | | | | | | | | | | | | | | side of the button on "Google Chrome Options" dialog. (http://crbug.com/11479) This is another regression caused by code refactoring. Instead of assign data member "label_" directly as the input parameter in constructor, calling SetLabel() which takes care of label layout in RTL locale. BUG=http://crbug.com/11479) Review URL: http://codereview.chromium.org/113010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15410 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some unnecessary includes.ben@chromium.org2009-05-064-4/+0
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/115016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15397 0039d316-1c4b-4281-b951-d872f2087c98
* Move: drag_drop_types, favicon_size, icon_util, insets, path, ↵ben@chromium.org2009-05-0622-45/+23
| | | | | | | | | message_box_flags, os_exchange_data to src/app http://crbug.com/11387 Review URL: http://codereview.chromium.org/115012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15371 0039d316-1c4b-4281-b951-d872f2087c98
* move chrome_font to app/gfxben@chromium.org2009-05-0615-15/+15
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/115010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15367 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome_canvas to app/gfxben@chromium.org2009-05-0631-32/+31
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15361 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to app/ben@chromium.org2009-05-0524-31/+31
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15352 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors HWNDView into two classes for reuse on GTK.sky@chromium.org2009-05-055-174/+276
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/108025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15327 0039d316-1c4b-4281-b951-d872f2087c98
* Landing the CL from Yusukes.jcampan@chromium.org2009-05-053-0/+18
| | | | | | | | | See http://codereview.chromium.org/99311 TBR=yusukes Review URL: http://codereview.chromium.org/109030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15317 0039d316-1c4b-4281-b951-d872f2087c98
* Move *Animation to app/ben@chromium.org2009-05-055-22/+4
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15275 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the ClipboardService class and header... it is nothing but a ↵ben@chromium.org2009-05-053-15/+15
| | | | | | | | | | shell around base::Clipboard now. http://crbug.com/11387 Review URL: http://codereview.chromium.org/105011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15274 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_vector.h and stl_util-inl.h to base/ben@chromium.org2009-05-055-12/+13
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/107001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15272 0039d316-1c4b-4281-b951-d872f2087c98
* Adds toplevel app/ directory and moves ResourceBundle into it.ben@chromium.org2009-05-0514-14/+14
| | | | | | | | | | | No changes to resource bundle yet, just the move to keep this CL as compact as possible. Adds new vcproj and gyp file for app dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15264 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BackSpace not working in Find box.finnur@chromium.org2009-05-041-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | This regressed with: http://codereview.chromium.org/99161 I think more work is needed, such as: 1) Figure out if more combinations need to be added. 2) Figure out if we can consolidate the code into one function, so that we don't need to keep three ShouldLookupAccelerators in sync (one in TextField, one in LocationBarView and potentially one in AutocompleteEditViewWin as well (OnKeyDownOnlyWritable). I'm not sure what all those magic keyboard constants like 0xBB do, so I think I'll leave the rest of the work to the person who created the changelist noted above. BUG=11326 TEST=Open google.com, press About link, press Ctrl+F, press e, press BackSpace. Chrome should not navigate back. Review URL: http://codereview.chromium.org/100347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15228 0039d316-1c4b-4281-b951-d872f2087c98
* Lands the fix for bug 8088 from m0 (http://codereview.chromium.org/100022).sky@chromium.org2009-05-042-16/+5
| | | | | | | | | | | | | | | | | | | | | | | | | Here's his description: Mouse hover out of context menu should un-select menu item. All Context Menu's which are implemented with ChromeMenu is not properly un-selecting the menu item when out of focus. The areas where this is affected are: * Tabs * Bookmark bar * Bookmark managerThe others uses winapi for context menus. Doesn't use ChromeMenu, uses HMENU, that explanes why the others work. For this fix, I had to make sure that the MenuPart is always NONE when the mouse is moved outside of the context menu regions, and that is always the case. Hence, we can assure to remove selection. The same way it has been done for SetSelection, I have used the same technique for this, but simpler. BUG=8088 TEST=For the above mentioned affected areas, I brought up the context menu by right clicking, and hovered over a menu item, then move the mouse horizontally outside the context menu region, it deselected the item. Review URL: http://codereview.chromium.org/102025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15220 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* roll back r15177ben@chromium.org2009-05-0484-589/+16
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15191 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15180.ben@chromium.org2009-05-049-98/+98
| | | | | | Review URL: http://codereview.chromium.org/100323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15188 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15182.ben@chromium.org2009-05-045-114/+114
| | | | | | Review URL: http://codereview.chromium.org/101024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15186 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15183.ben@chromium.org2009-05-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/99336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15185 0039d316-1c4b-4281-b951-d872f2087c98
* Only include views_resources.h on Windows, since it looks like Linux is ↵ben@chromium.org2009-05-041-1/+1
| | | | | | still building this file. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15183 0039d316-1c4b-4281-b951-d872f2087c98
* Bustage fix:ben@chromium.org2009-05-045-114/+114
| | | | | | | | | | Add back these files which I removed earlier since Linux is using them. The resources are duplicate until I collapse them into src/app/ later this week. Review URL: http://codereview.chromium.org/100320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15182 0039d316-1c4b-4281-b951-d872f2087c98
* Bustage fix for mac and linux:ben@chromium.org2009-05-049-98/+98
| | | | | | | | | | Duplicate views strings and rename them to uniquify them to get mac and linux going again. TODO(beng): move these strings into the forthcoming app/ dependency so that mac linux and windows can rely on it. Review URL: http://codereview.chromium.org/99335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15180 0039d316-1c4b-4281-b951-d872f2087c98
* Extract all views resources into:ben@chromium.org2009-05-0484-16/+589
| | | | | | | | | | | | | views_strings.[grd,vcproj] views_resources.[grd,vcproj] Moves views images (.png files) from app/theme to views/resources dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15177 0039d316-1c4b-4281-b951-d872f2087c98
* Allowing the client to handle escape and keyup events.tommi@google.com2009-05-023-10/+37
| | | | | | Review URL: http://codereview.chromium.org/99293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15142 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome/chromium icons as PNGs.ben@chromium.org2009-05-022-5/+12
| | | | | | | | | | | | Also, add support to NativeButton for rendering as default independently of behaving as default. This will be used by the default browser infobar. Adds methods to the infobar delegate interface to allow the delegate to specify that it wants its Accept button to appear as the default button. http://crbug.com/9049 Review URL: http://codereview.chromium.org/100288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15125 0039d316-1c4b-4281-b951-d872f2087c98
* People should just use GetWindow() instead of calling GetWidget()->GetWindow()ben@chromium.org2009-05-011-1/+1
| | | | | | Review URL: http://codereview.chromium.org/102020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15022 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a GetWindow method to View.ben@chromium.org2009-04-302-0/+10
| | | | | | Review URL: http://codereview.chromium.org/100221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14989 0039d316-1c4b-4281-b951-d872f2087c98
* Patch for accelerator clean-up from Hamaji.jcampan@chromium.org2009-04-303-46/+21
| | | | | | | | | | See http://codereview.chromium.org/99161 TBR=hamami Review URL: http://codereview.chromium.org/99228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14982 0039d316-1c4b-4281-b951-d872f2087c98
* Make task_manager_resource_providers.cc compile on POSIX.phajdan.jr@chromium.org2009-04-301-1/+1
| | | | | | | | TEST=Make sure that the task manager isn't obviously broken on Windows. Review URL: http://codereview.chromium.org/93067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14934 0039d316-1c4b-4281-b951-d872f2087c98
* Make "Reopen closed tab" be "Reopen closed window" when a window is the top ↵pkasting@chromium.org2009-04-292-0/+12
| | | | | | | | | | item on the closed tabs stack. Original patch by Miranda Callahan (see http://codereview.chromium.org/100054 ), r=me. BUG=11183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14910 0039d316-1c4b-4281-b951-d872f2087c98
* Patch by Shinichiro Hamaji <hamaji@google.com>:ben@chromium.org2009-04-293-1/+17
| | | | | | | | | | | | | | | | | | Allow words to be wrapped in message box. We use DT_WORDBREK|DT_EDITCONTROL as the argument of DrawText(). With this option, DrawText() try to wrap texts at word-breaks first, then wraps at non-word-breaks if one line is still too long. This change only affects for Labels in MessageBox. If we can always use this policy, please let me know and I'll fix the code. http://crbug.com/2441 Review URL: http://codereview.chromium.org/100013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14878 0039d316-1c4b-4281-b951-d872f2087c98
* Two changes:sky@chromium.org2009-04-298-32/+42
| | | | | | | | | | | | . Removes MoveToFront on Widget. . CHanges AsWindow to GetWindow. BUG=none TEST=none Review URL: http://codereview.chromium.org/99133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14868 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the use of Windows-specific types for accessibility roles and states ↵klink@chromium.org2009-04-2815-117/+119
| | | | | | | | in Views and Browser\Views. Helps with the porting effort, and makes for a cleaner implementation. Review URL: http://codereview.chromium.org/93085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14689 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this. jcampan@chromium.org2009-04-271-38/+64
| | | | | | | | | | | | | | | | | | | The Ole unitialization was failing on one of the Vista build-bot. It is not clear when the Ole initialization is balanced when a CRichEditCtrl is created/destructed. So I now turn it off explicitly. This CL makes sure we unregister our Windows window classes when shut-down. It also balances-out an OLE initialization performed by the CRichEditCTRL. This is necessary for allowing to reload chrome.dll in a process, which is what the browser tests will do. BUG=None TEST=None Review URL: http://codereview.chromium.org/101004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14649 0039d316-1c4b-4281-b951-d872f2087c98
* More linux ifdef tweaks. This reverts my earlier change (13503).sky@chromium.org2009-04-271-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/100046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14628 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow the browser window to be resized so small that layout starts ↵pkasting@chromium.org2009-04-276-1/+20
| | | | | | | | | | | breaking horribly. When it _is_ small, draw the frame correctly. This is an incomplete fix; only non-Aero main/popup/app windows are handled so far, but this was becoming hairy enough I wanted to checkpoint it. BUG=9885 Review URL: http://codereview.chromium.org/100005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14618 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14489.jcampan@chromium.org2009-04-241-67/+38
| | | | | | Review URL: http://codereview.chromium.org/99004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14492 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes sure we unregister our Windows window classes when shut-down.jcampan@chromium.org2009-04-241-38/+67
| | | | | | | | | | | | It also balances-out an OLE initialization performed by the CRichEditCTRL. This is necessary for allowing to reload chrome.dll in a process, which is what the browser tests will do. BUG=None TEST=None Review URL: http://codereview.chromium.org/93026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14489 0039d316-1c4b-4281-b951-d872f2087c98
* Checkbox/RadioButton labels have to reserve space for the focus rects, even ↵ben@chromium.org2009-04-243-1/+10
| | | | | | | | | if they're not actively being painted as focused, otherwise layout breaks badly. http://crbug.com/10958 Review URL: http://codereview.chromium.org/93142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14464 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where radio buttons would become unselected when clicked (more ↵jcampan@chromium.org2009-04-242-1/+6
| | | | | | | | | | specifically, when clicked on the button, not the label). BUG=10834 TEST=Open the option dialog, click on the button (not the label) of a selected radio-button. The button should stay selected. Make sure checkboxes and radio buttons still behave as expected. Review URL: http://codereview.chromium.org/97012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14447 0039d316-1c4b-4281-b951-d872f2087c98
* Make messages in javascript's alert copyable.tc@google.com2009-04-242-0/+20
| | | | | | | | | | | | | | Now, we can copy the message by Ctrl-C. BUG=5879 Patch by hamaji@google.com via http://codereview.chromium.org/93112 Review URL: http://codereview.chromium.org/92133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14441 0039d316-1c4b-4281-b951-d872f2087c98
* The previous behavior of not focusing the HWND when focusing a ↵jcampan@chromium.org2009-04-242-6/+0
| | | | | | | | | | checkbox/radio-button was preventing focus to work as expected on these controls. It would leave the previous HWND focused, causing problems. BUG=10856 TEST=Open the Option dialog. Click the "Show home button..." checkbox. The close button should lose focus, the checkbox should get focus. Press space, the checkbox state should change. Click on a radio-button, it should become selected and get focused. Press the up/down arrow. The next/previous radio-button should get selected and focused. Review URL: http://codereview.chromium.org/93114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14417 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r14276 (http://codereview.chromium.org/88069) which causes unit ↵robertshield@google.com2009-04-235-20/+0
| | | | | | | | | | | | | test breakage. Example: http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(2)/builds/1268/steps/unit_tests/logs/stdio TBR=http://codereview.chromium.org/95010 Review URL: http://codereview.chromium.org/95010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14314 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 22:14:59 +0000