| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed by: jcampan@chromium.org
Changed at: Fri 19 Jun 2009 21:22:47
Branch: src
Revision: 18889
Comments:
Relanding focus manager refactoring with build fix, see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben
Review URL: http://codereview.chromium.org/141013
Because it creates hundreds of new reliability crashes.
TBR:jcampan
Review URL: http://codereview.chromium.org/140064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
extensions that are loaded after EXTENSIONS_READY.
Review URL: http://codereview.chromium.org/140065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I noticed a Font dialog used the system locale (not the application locale) to display the localzed font name of a CJK font, i.e. we can retrieve this localized font name with a GetTextFace() call. This change just retrieves the localized font name of the given font with a GetTextFace() call before initializing a CHOOSEFONT object.
BUG=3803 <http://crbug.com/3803>
TEST=run Chrome on Simplified Chinese XP; open the "Fonts and Languages" dialog;click the "Change" for "Sans-Serif Font", and; verify its "font" editbox shows the localized font-name of "simsun".
Review URL: http://codereview.chromium.org/119416
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rearranged the windows and mac ports to use the cross platform interfaces. Updated windows fonts and languages to use those interfaces. As well, created stubs for mac platform.
BUG=13524 (http://crbug.com/13524)
TEST=Open a webpage with a textfield, right click and choose Spell checker options > Language Settings. Tested this on windows as well.
Review URL: http://codereview.chromium.org/140043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none, just re-enabling some disabled tests.
Review URL: http://codereview.chromium.org/113789
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Corrected a typo in generating the stat, and evolved to a new histogram
name to avoid confusion.
Note that the time between start and finish still needs to be
fixed, as that part of the regression is not handled.
BUG=14678
r=davemoore
Review URL: http://codereview.chromium.org/132072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14763
TEST=Enable themes; status bubble color should reflect changed theme. Otherwise, status bubble color should not change.
Review URL: http://codereview.chromium.org/140016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/141024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Following the same approach as the general tab page..
BUG=11507
TEST=The Personal stuff tab is fully functioning, the prefs save correctly.
Review URL: http://codereview.chromium.org/125105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=14783
TEST=Download more than one thing. Shelf shouldn't get bigger everytime an item is added.
Review URL: http://codereview.chromium.org/140041
Review URL: http://codereview.chromium.org/140041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben
Review URL: http://codereview.chromium.org/141013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[retry, fix windows compile failure]
* use a new ChannelHandle type when passing IPC channels over IPC
The current POSIX code assumes that one end of a channel is always a new
child process (a renderer). For plugins we need to be able to construct
channels between each of the browser, plugin, and renderer.
This change augments the messages related to creating channels to allow
passing in a base::FileDescriptor containing the socket. The intent is
that the browser process, as the initial interchange between plugin and
renderer, creates the socketpair() on their behalf and hands each their
respective end of the connection.
* register channel endpoint names in the global pipe map
The plugin code assumes it can map from a string to a channel endpoint
at basically any time. So whenever we get a channel endpoint over IPC,
we install it in a global map of channel endpoints.
Review URL: http://codereview.chromium.org/113157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Don't like that GTK only does app-modal rather than window modal, but otherwise you can just close the parent window and crash when you then click okay on the dialog.
BUG=11507
Review URL: http://codereview.chromium.org/141020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Dependency on gtest.
* Add intel\mt_lib\{P4_,}memset.obj as AdditionalDependencies.
* Update library directories.
* Make sure BasicRuntimeChecks=0 for both Debug and Release.
* The manifest now comes from the sources list,
not in AdditionalManifestFiles.
* AdditionalOptions to override the build/common.gypi defaults.
* GenerateMapFile
* Fix spelling errors.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/141015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14774
TEST=no
Review URL: http://codereview.chromium.org/140032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Resuscitate the TOOLKIT_VIEWS build by disabling stuff we don't build yet.
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/141012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke the Windows build.
BUG=None
TEST=None
TBR=ben
Review URL: http://codereview.chromium.org/140023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
not subclassed anymore.The FocusManager is now created and owned by top-level WidgetWins.BUG=NoneTEST=Run the unit tests, UI tests, interactive UI tests. Fully test the focus behavior in the browser: activate/deactivate the browser windows, make sure focus is remembered. Switch tabs, make sure focus is remembered for each tab. make sure accelerators work as expected. Test focus traversal in a web page, in the option dialog.
Review URL: http://codereview.chromium.org/125148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds read-write to the client key of google_update
- Adds the logic to track experiment outcome
- Some new geric exitc codes (non error codes)
BUG= b/1484308
TEST= see the bug
Review URL: http://codereview.chromium.org/132058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/140020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/141006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the tab correctly.
BUG=14126
TEST=Use the "Create application shortcut..." menu to bring up the Gears dialog. Press tab, the focus should move around. Press ESC, the dialog should close.
Review URL: http://codereview.chromium.org/140001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Implements a ConstrainedWindowGtk which positions itself in the center of its corresponding TabContentsViewGtk.
- Implements LoginPromptGtk. HTTP Auth now works under Linux.
- Renames ConstrainedWindowImpl to ConstrainedWindowWin
http://crbug.com/11512
Review URL: http://codereview.chromium.org/132047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Supress UMR in RSAPrivateKey::ExportPrivateKey(). From
what I can see, this really is a false positive. The
byte is 0xCD, at the exact place the error is reported
n Purify. Other supporting evidence is that it doesn't
always occur in the same place. Since we are generating
random keys, you'd expect to see the error show up
every so often wherever we are reading that memory.
* Remove supression of MOZ_Z_Deflate. Purify says this no
longer occurs. Not sure why.
Review URL: http://codereview.chromium.org/131097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the LASTCHANGE file (which doesn't actually use the value), which
was causing unnecessary rebuilds of resources and chrome.exe.
Change the output intermediate directory to
<(SHARED_INTERMEDIATE_DIR)/chrome so the on-disk location matches
the name of the changed target (app => chrome).
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/139007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
more input and calling parent class forall.
http://crbug.com/14485
Review URL: http://codereview.chromium.org/141004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
two descriptions in hopes of helping the translators.
BUG=12442
TEST=none
Review URL: http://codereview.chromium.org/141001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- SavePageTest.SaveHTMLOnly
- SavePageTest.SaveCompleteHTML
- DownloadTest.UnknownSize
- DownloadTest.IncognitoDownload
BUG=14746,14755
TEST=no
Review URL: http://codereview.chromium.org/139006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit f2f30e9d0108f4a776672c6b29d25ed3a8ad19ad.
Review URL: http://codereview.chromium.org/140013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic for when to prepend a null byte to integers was
reversed. Fortunately, this had no impact on anything, because:
a) We ignore the null byte on the parse side because we know the
integers we're interested in are always unsigned.
b) It appears openssl does the same thing (I tried it both ways
and it always came up with the same private key data).
Still, better to be correct.
Also, re-enable previously disabled unit tests.
BUG=14640
Review URL: http://codereview.chromium.org/131095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=scherkus
Need to delay load FFmpeg dlls.
Review URL: http://codereview.chromium.org/131088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes us a better citizen in OSX text-editing land and is a first step in getting our text entry story to work more natively on OSX.
The selectors are added at runtime to the Cocoa class and invoking them causes the appropriate WebKit core command to be invoked on the currently focused WebFrame.
As a side-effect bug 10862 is fixed.
BUG=10862
TEST=Open a new tab and type some text into an input element, change to a Hebrew keyboard layout and hit command-a, all text should be selected.
Review URL: http://codereview.chromium.org/114070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
friendly when running in purify.
Review URL: http://codereview.chromium.org/139004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r18850, as it had a compile failure.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* use a new ChannelHandle type when passing IPC channels over IPC
The current POSIX code assumes that one end of a channel is always a new
child process (a renderer). For plugins we need to be able to construct
channels between each of the browser, plugin, and renderer.
This change augments the messages related to creating channels to allow
passing in a base::FileDescriptor containing the socket. The intent is
that the browser process, as the initial interchange between plugin and
renderer, creates the socketpair() on their behalf and hands each their
respective end of the connection.
* register channel endpoint names in the global pipe map
The plugin code assumes it can map from a string to a channel endpoint
at basically any time. So whenever we get a channel endpoint over IPC,
we install it in a global map of channel endpoints.
Review URL: http://codereview.chromium.org/113157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
valgrind is very slow on the Mac.
BUG=none
TEST=Most/all of the UI tests should pass on the Mac when run under valgrind.
Review URL: http://codereview.chromium.org/140008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=This is a UI test.
Review URL: http://codereview.chromium.org/131012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also notify other browser windows of changes to the order.
BUG=http://code.google.com/p/chromium/issues/detail?id=12123
TEST=browser_tests.exe --gtest_filter=ExtensionShelfModelTest.*
Review URL: http://codereview.chromium.org/131114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Hood panel to be more like on windows and remove stuff that's not needed. Disable all prefs that aren't currently hooked up.
BUG=none
TEST=Prefs on first two panels haven't stopped working.
Review URL: http://codereview.chromium.org/140004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
catch the case when the user closes the last tab in a tabstrip. In this case, we add ourselves as a message loop observer and never get a chance to remove ourselves before the tabstrip is destroyed.
BUG=14648
TEST=Open a new window and press the close button on the tab. The browser should not crash.
Review URL: http://codereview.chromium.org/140006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and stores it in user prefs, where it can be used by the new tab page.
BUG = http://crbug.com/13363
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18766
Review URL: http://codereview.chromium.org/125052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DownloadRequestManager is the object that manages the number of downloads
that can occur in a given tab. It throttles non-user initiated downloads
to prevent carpet-bombing download attacks.
Enabling this object for Mac fixes the issue where we can only download
one file in a given tab.
BUG=None (mac work).
TEST=Can now download more than one item in a tab.
Review URL: http://codereview.chromium.org/132039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
setting turned on to prevent their dependencies from assuming they emit an
import libary. This implies that these two targets should be loadable_module,
rather than manually setting IgnoreImportLibrary.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/132080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
app_locale_settings.
Removing duplicate IDS_UI_FONT_ from locale_settings (already present in app_locale_settings).
There are no code changes.
BUG=http://crbug.com/7319
TEST=No test case, since we are removing dupes. The only check is to make sure code compiles (and it does).
Review URL: http://codereview.chromium.org/131060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
See: http://codereview.chromium.org/126098
Patch from Jerry Tang <tangjie@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=14731
Review URL: http://codereview.chromium.org/138001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18836 0039d316-1c4b-4281-b951-d872f2087c98
|